Title: fs: remove duplicate fd validation in sync functions by mertcanaltin · Pull Request #61361 · nodejs/node · GitHub
Open Graph Title: fs: remove duplicate fd validation in sync functions by mertcanaltin · Pull Request #61361 · nodejs/node
X Title: fs: remove duplicate fd validation in sync functions by mertcanaltin · Pull Request #61361 · nodejs/node
Description: I removed the repeated fd validation in synchronization functions; C++ already validates this via GetValidatedFd. Asynchronous functions keep JS validation for error ordering. readSync: 1,793K → 1,923K ops/sec passed all fs tests test-fs-read.js test-fs-write.js test-fs-readv-sync.js test-fs-writev-sync.js
Open Graph Description: I removed the repeated fd validation in synchronization functions; C++ already validates this via GetValidatedFd. Asynchronous functions keep JS validation for error ordering. readSync: 1,793K → 1,...
X Description: I removed the repeated fd validation in synchronization functions; C++ already validates this via GetValidatedFd. Asynchronous functions keep JS validation for error ordering. readSync: 1,793K → 1,...
Opengraph URL: https://github.com/nodejs/node/pull/61361
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:37163e37-9c02-ef5c-7601-a15bbae16dad |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E562:18D9A8:51C9A6:6FB913:6A4C770A |
| html-safe-nonce | fea5c35083bab197bf18a9ce6ccb4d057a2556847a3713503212d202b30e649c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNTYyOjE4RDlBODo1MUM5QTY6NkZCOTEzOjZBNEM3NzBBIiwidmlzaXRvcl9pZCI6IjI4OTYxNzAyMTAxMTUyMzMzOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 3f48e861478f8af89627ba2e2041e305104725c3423d73ab779de95001af07bc |
| hovercard-subject-tag | pull_request:3167467065 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodejs/node/pull/61361/files |
| twitter:image | https://avatars.githubusercontent.com/u/37827216?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/37827216?s=400&v=4 |
| og:image:alt | I removed the repeated fd validation in synchronization functions; C++ already validates this via GetValidatedFd. Asynchronous functions keep JS validation for error ordering. readSync: 1,793K → 1,... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3d11bb817438277de2a940854450e83a7d32b6aeb5014e9e6b00a6423900251c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 56ac743bebb13694b888673bb7257f4b97a4b7fd |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width