René's URL Explorer Experiment


Title: fs: fix ENOTDIR in globSync when file is treated as dir by Han5991 · Pull Request #61259 · nodejs/node · GitHub

Open Graph Title: fs: fix ENOTDIR in globSync when file is treated as dir by Han5991 · Pull Request #61259 · nodejs/node

X Title: fs: fix ENOTDIR in globSync when file is treated as dir by Han5991 · Pull Request #61259 · nodejs/node

Description: fs.globSync failed with ENOTDIR when a path component in a glob pattern was a file but used as a directory (e.g., 'foo{,/bar}' when 'foo' is a file). This change aligns getDirentSync with the async...

Open Graph Description: fs.globSync failed with ENOTDIR when a path component in a glob pattern was a file but used as a directory (e.g., 'foo{,/bar}' when 'foo' is a file). This change aligns getDirentSyn...

X Description: fs.globSync failed with ENOTDIR when a path component in a glob pattern was a file but used as a directory (e.g., 'foo{,/bar}' when 'foo' is a file). This change ali...

Opengraph URL: https://github.com/nodejs/node/pull/61259

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f2b1bbac-aab7-5d47-7779-bbd3cc6a2a81
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id91E2:9D4F4:1190ADB:1830B8B:6969F83C
html-safe-noncef10ed64c21226540944e0fab5c4f28b951e5423e3c29f0c3e1a0898668be14cd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MUUyOjlENEY0OjExOTBBREI6MTgzMEI4Qjo2OTY5RjgzQyIsInZpc2l0b3JfaWQiOiIzNTY3NDE5NzcwNzY5MzczMjQ0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacb160c2f45e62a4dd755ab06e6b60284fab0bc6eb503443bb9e7804aaec4d9dae
hovercard-subject-tagpull_request:3143384185
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/61259/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/fa39056004138bbc7aa0a46517edb110a8091a54f4d2cb9afb2f3ee8db4485a8/nodejs/node/pull/61259
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/fa39056004138bbc7aa0a46517edb110a8091a54f4d2cb9afb2f3ee8db4485a8/nodejs/node/pull/61259
og:image:altfs.globSync failed with ENOTDIR when a path component in a glob pattern was a file but used as a directory (e.g., 'foo{,/bar}' when 'foo' is a file). This change aligns getDirentSyn...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameHan5991
hostnamegithub.com
expected-hostnamegithub.com
None7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebdde15ad1b403e23b08bbd89b53fbe6bdf688cad
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/61259#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F61259
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F61259
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/61259
Reloadhttps://github.com/nodejs/node/pull/61259
Reloadhttps://github.com/nodejs/node/pull/61259
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/61259
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 697 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/61259
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/61259#issue-comment-box
Han5991https://github.com/Han5991
nodejs:mainhttps://github.com/nodejs/node/tree/main
Han5991:fix/fs-glob-sync-enotdirhttps://github.com/Han5991/node/tree/fix/fs-glob-sync-enotdir
fs: fix ENOTDIR in globSync when file is treated as dir https://github.com/nodejs/node/pull/61259#top
Han5991https://github.com/Han5991
nodejs:mainhttps://github.com/nodejs/node/tree/main
Han5991:fix/fs-glob-sync-enotdirhttps://github.com/Han5991/node/tree/fix/fs-glob-sync-enotdir
Conversation 7 https://github.com/nodejs/node/pull/61259
Commits 3 https://github.com/nodejs/node/pull/61259/commits
Checks 34 https://github.com/nodejs/node/pull/61259/checks
Files changed https://github.com/nodejs/node/pull/61259/files
Please reload this pagehttps://github.com/nodejs/node/pull/61259
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/Han5991
Han5991https://github.com/Han5991
Jan 3, 2026https://github.com/nodejs/node/pull/61259#issue-3777879312
https://private-user-images.githubusercontent.com/73056306/531609662-6dd21c15-d611-4d95-8aae-0b30d87930ae.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Njg1NTI4MDgsIm5iZiI6MTc2ODU1MjUwOCwicGF0aCI6Ii83MzA1NjMwNi81MzE2MDk2NjItNmRkMjFjMTUtZDYxMS00ZDk1LThhYWUtMGIzMGQ4NzkzMGFlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjAxMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYwMTE2VDA4MzUwOFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTRiZjIyOWVhZDBmN2EyNzgxNzhhZDgwZTY5Y2M3M2U1NmU4YmVmMGJhZTIxODg1M2M0MTBiNDYzOWFjNmI1OGQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.jVR8Q13s69iBKgWHe7iAjx0mkhvkNoXU-OAUmcu6kio
#61257https://github.com/nodejs/node/issues/61257
Please reload this pagehttps://github.com/nodejs/node/pull/61259
https://github.com/Han5991
fs: fix ENOTDIR in globSync when file is treated as dirhttps://github.com/nodejs/node/pull/61259/commits/61bfdb338e65f2c47f59f535b7306c31e2151437
61bfdb3https://github.com/nodejs/node/pull/61259/commits/61bfdb338e65f2c47f59f535b7306c31e2151437
nodejs#61257https://github.com/nodejs/node/issues/61257
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Jan 3, 2026https://github.com/nodejs/node/pull/61259#event-21835242010
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Jan 3, 2026https://github.com/nodejs/node/pull/61259#issuecomment-3706940501
Please reload this pagehttps://github.com/nodejs/node/pull/61259
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/61259?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
842448bhttps://app.codecov.io/gh/nodejs/node/commit/842448b1ee8c0a7b428c4550b2e9eac6f8659944?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
d2e58e3https://app.codecov.io/gh/nodejs/node/commit/d2e58e34df54931f02ff285e75d7db0572dd347c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/61259?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/fs/glob.jshttps://app.codecov.io/gh/nodejs/node/pull/61259?src=pr&el=tree&filepath=lib%2Finternal%2Ffs%2Fglob.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL2ZzL2dsb2IuanM=
103 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/61259/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/61259
https://github.com/Han5991
Merge branch 'nodejs:main' into fix/fs-glob-sync-enotdirhttps://github.com/nodejs/node/pull/61259/commits/1d288a6411f9cfe9eca016109602fdc49ab25425
1d288a6https://github.com/nodejs/node/pull/61259/commits/1d288a6411f9cfe9eca016109602fdc49ab25425
https://github.com/Renegade334
Renegade334https://github.com/Renegade334
Jan 9, 2026 https://github.com/nodejs/node/pull/61259#pullrequestreview-3642219161
View reviewed changes https://github.com/nodejs/node/pull/61259/files/1d288a6411f9cfe9eca016109602fdc49ab25425
lib/internal/fs/glob.jshttps://github.com/nodejs/node/pull/61259/files/1d288a6411f9cfe9eca016109602fdc49ab25425#diff-926520e174d4e59a716c7367049fed207249e3732631177be409b34634a896af
Please reload this pagehttps://github.com/nodejs/node/pull/61259
https://github.com/Han5991
Han5991https://github.com/Han5991
Renegade334https://github.com/Renegade334
January 9, 2026 04:39https://github.com/nodejs/node/pull/61259#event-21938957689
https://github.com/Han5991
https://github.com/Renegade334
fs: simplify getDirentSync lstatSync handlinghttps://github.com/nodejs/node/pull/61259/commits/d2e58e34df54931f02ff285e75d7db0572dd347c
d2e58e3https://github.com/nodejs/node/pull/61259/commits/d2e58e34df54931f02ff285e75d7db0572dd347c
https://github.com/Han5991
Han5991https://github.com/Han5991
force-pushedhttps://github.com/nodejs/node/compare/285ded7bb80d9d8d04441b576bd84e0f981bc7b2..d2e58e34df54931f02ff285e75d7db0572dd347c
285ded7https://github.com/nodejs/node/commit/285ded7bb80d9d8d04441b576bd84e0f981bc7b2
d2e58e3https://github.com/nodejs/node/commit/d2e58e34df54931f02ff285e75d7db0572dd347c
Compare https://github.com/nodejs/node/compare/285ded7bb80d9d8d04441b576bd84e0f981bc7b2..d2e58e34df54931f02ff285e75d7db0572dd347c
January 9, 2026 04:59https://github.com/nodejs/node/pull/61259#event-21939146481
https://github.com/Renegade334
Renegade334https://github.com/Renegade334
Jan 9, 2026 https://github.com/nodejs/node/pull/61259#pullrequestreview-3642642882
View reviewed changes https://github.com/nodejs/node/pull/61259/files/d2e58e34df54931f02ff285e75d7db0572dd347c
https://github.com/Renegade334
Renegade334https://github.com/Renegade334
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
commit-queue-squash https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash
Jan 9, 2026https://github.com/nodejs/node/pull/61259#event-21940552947
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jan 9, 2026https://github.com/nodejs/node/pull/61259#event-21951845077
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 9, 2026https://github.com/nodejs/node/pull/61259#issuecomment-3729807886
https://ci.nodejs.org/job/node-test-pull-request/70741/https://ci.nodejs.org/job/node-test-pull-request/70741/
Please reload this pagehttps://github.com/nodejs/node/pull/61259
https://github.com/Han5991
Han5991https://github.com/Han5991
Jan 11, 2026https://github.com/nodejs/node/pull/61259#issuecomment-3733881886
@Renegade334https://github.com/Renegade334
Please reload this pagehttps://github.com/nodejs/node/pull/61259
https://github.com/Renegade334
Renegade334https://github.com/Renegade334
Jan 11, 2026https://github.com/nodejs/node/pull/61259#issuecomment-3734419324
Please reload this pagehttps://github.com/nodejs/node/pull/61259
https://github.com/Han5991
Han5991https://github.com/Han5991
Jan 11, 2026https://github.com/nodejs/node/pull/61259#issuecomment-3734447717
Please reload this pagehttps://github.com/nodejs/node/pull/61259
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F61259
https://github.com/Renegade334
Renegade334 https://github.com/Renegade334
https://github.com/nodejs/node/pull/61259/files/d2e58e34df54931f02ff285e75d7db0572dd347c
commit-queue-squash https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
fs.globSync fails when fs.glob does not https://github.com/nodejs/node/issues/61257
Please reload this pagehttps://github.com/nodejs/node/pull/61259
https://github.com/Han5991
https://github.com/nodejs-github-bot
https://github.com/Renegade334
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.