René's URL Explorer Experiment


Title: module: throw error for ESM syntax in explicit commonjs entry by heathdutton · Pull Request #61171 · nodejs/node · GitHub

Open Graph Title: module: throw error for ESM syntax in explicit commonjs entry by heathdutton · Pull Request #61171 · nodejs/node

X Title: module: throw error for ESM syntax in explicit commonjs entry by heathdutton · Pull Request #61171 · nodejs/node

Description: When a main entry point contains ESM syntax but is in a package with "type": "commonjs" in package.json, the module would silently exit with code 0 without executing or showing any error. This happened because the CJS loader detected ESM syntax, attempted to defer to ESM loading, but the async execution never completed before the process exited. This change throws ERR_REQUIRE_ESM for main modules with ESM syntax in explicitly CommonJS-typed packages, providing a clear error message instead of silent failure. Fixes: #61104

Open Graph Description: When a main entry point contains ESM syntax but is in a package with "type": "commonjs" in package.json, the module would silently exit with code 0 without executing or showing ...

X Description: When a main entry point contains ESM syntax but is in a package with "type": "commonjs" in package.json, the module would silently exit with code 0 without execu...

Opengraph URL: https://github.com/nodejs/node/pull/61171

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:bf7cf1fb-30f0-ee03-de40-af1e0a4b83f0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEB72:345F55:12855DB:18E5B3F:6A4C6FBF
html-safe-nonce8cfe8d8172abe17f85dc0a41b76d2123bb5869dcba240762fdfc89ef87c03037
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQjcyOjM0NUY1NToxMjg1NURCOjE4RTVCM0Y6NkE0QzZGQkYiLCJ2aXNpdG9yX2lkIjoiMjE5NzQ5NzU0MzIxNzkzNDI3MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac95bf426fd849127d6301fcb9188a7aae2b579733ac32e495c845325a6cd94151
hovercard-subject-tagpull_request:3129503149
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/61171/files
twitter:imagehttps://avatars.githubusercontent.com/u/302215?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/302215?s=400&v=4
og:image:altWhen a main entry point contains ESM syntax but is in a package with "type": "commonjs" in package.json, the module would silently exit with code 0 without executing or showing ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None3d11bb817438277de2a940854450e83a7d32b6aeb5014e9e6b00a6423900251c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release14099438da5379150f15a2892474c7c7e6c0e55e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/61171/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F61171%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F61171%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/61171/files
Reloadhttps://github.com/nodejs/node/pull/61171/files
Reloadhttps://github.com/nodejs/node/pull/61171/files
Please reload this pagehttps://github.com/nodejs/node/pull/61171/files
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/61171/files
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 964 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
heathduttonhttps://github.com/heathdutton
nodejs:mainhttps://github.com/nodejs/node/tree/main
heathdutton:fix/module-esm-silent-failure-61104https://github.com/heathdutton/node/tree/fix/module-esm-silent-failure-61104
Conversation 16 https://github.com/nodejs/node/pull/61171
Commits 1 https://github.com/nodejs/node/pull/61171/commits
Checks 0 https://github.com/nodejs/node/pull/61171/checks
Files changed https://github.com/nodejs/node/pull/61171/files
Please reload this pagehttps://github.com/nodejs/node/pull/61171/files
module: throw error for ESM syntax in explicit commonjs entry https://github.com/nodejs/node/pull/61171/files#top
Show all changes 1 commit https://github.com/nodejs/node/pull/61171/files
19e940d module: fix silent failure for ESM syntax in explicit commonjs entry heathdutton Dec 25, 2025 https://github.com/nodejs/node/pull/61171/commits/19e940d17c578ed30ea988bf6f8d2941cdd30214
Clear filters https://github.com/nodejs/node/pull/61171/files
Please reload this pagehttps://github.com/nodejs/node/pull/61171/files
Please reload this pagehttps://github.com/nodejs/node/pull/61171/files
loader.js https://github.com/nodejs/node/pull/61171/files#diff-5b5902273122e094ff474fda358605ffa45a4a58b51cd0bf4c1acb93779df142
test-esm-syntax-in-cjs-main.js https://github.com/nodejs/node/pull/61171/files#diff-5f383875f7ac43c6832c74d70ab0bc29312e099f1771b1d094adab77cd1c7743
esm-script.js https://github.com/nodejs/node/pull/61171/files#diff-1040b625467bf2c0305ea3f4f59283866060cfafecbd431d356f1875064d275e
package.json https://github.com/nodejs/node/pull/61171/files#diff-2c5275e5ba28166f9f27c2bb09ed6b826a2c3cc5f789e0727b4ab5b0decef7ac
lib/internal/modules/cjs/loader.jshttps://github.com/nodejs/node/pull/61171/files#diff-5b5902273122e094ff474fda358605ffa45a4a58b51cd0bf4c1acb93779df142
View file https://github.com/heathdutton/node/blob/19e940d17c578ed30ea988bf6f8d2941cdd30214/lib/internal/modules/cjs/loader.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/61171/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/61171/files#diff-5b5902273122e094ff474fda358605ffa45a4a58b51cd0bf4c1acb93779df142
joyeecheunghttps://github.com/joyeecheung
Jan 5, 2026https://github.com/nodejs/node/pull/61171/files#r2662412231
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/61171/files
https://github.com/nodejs/node/pull/61171/files#diff-5b5902273122e094ff474fda358605ffa45a4a58b51cd0bf4c1acb93779df142
test/es-module/test-esm-syntax-in-cjs-main.jshttps://github.com/nodejs/node/pull/61171/files#diff-5f383875f7ac43c6832c74d70ab0bc29312e099f1771b1d094adab77cd1c7743
View file https://github.com/heathdutton/node/blob/19e940d17c578ed30ea988bf6f8d2941cdd30214/test/es-module/test-esm-syntax-in-cjs-main.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/61171/{{ revealButtonHref }}
test/fixtures/es-modules/package-type-commonjs-esm-syntax/esm-script.jshttps://github.com/nodejs/node/pull/61171/files#diff-1040b625467bf2c0305ea3f4f59283866060cfafecbd431d356f1875064d275e
View file https://github.com/heathdutton/node/blob/19e940d17c578ed30ea988bf6f8d2941cdd30214/test/fixtures/es-modules/package-type-commonjs-esm-syntax/esm-script.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/61171/{{ revealButtonHref }}
joyeecheunghttps://github.com/joyeecheung
Jan 5, 2026https://github.com/nodejs/node/pull/61171/files#r2662383527
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#61104https://github.com/nodejs/node/issues/61104
Please reload this pagehttps://github.com/nodejs/node/pull/61171/files
test/fixtures/es-modules/package-type-commonjs-esm-syntax/package.jsonhttps://github.com/nodejs/node/pull/61171/files#diff-2c5275e5ba28166f9f27c2bb09ed6b826a2c3cc5f789e0727b4ab5b0decef7ac
View file https://github.com/heathdutton/node/blob/19e940d17c578ed30ea988bf6f8d2941cdd30214/test/fixtures/es-modules/package-type-commonjs-esm-syntax/package.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/61171/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.