René's URL Explorer Experiment


Title: fix: custom inspect should not throw when called with wrong this by efekrskl · Pull Request #61128 · nodejs/node · GitHub

Open Graph Title: fix: custom inspect should not throw when called with wrong this by efekrskl · Pull Request #61128 · nodejs/node

X Title: fix: custom inspect should not throw when called with wrong this by efekrskl · Pull Request #61128 · nodejs/node

Description: Fixes #46323 I see Event has a similar brand check (lib/internal/event_target.js:152) Should we also remove that one?

Open Graph Description: Fixes #46323 I see Event has a similar brand check (lib/internal/event_target.js:152) Should we also remove that one?

X Description: Fixes #46323 I see Event has a similar brand check (lib/internal/event_target.js:152) Should we also remove that one?

Opengraph URL: https://github.com/nodejs/node/pull/61128

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:87b99bee-5009-a22e-2507-c6f9633133c0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9B06:356725:9F0433:D6A776:6A4C472A
html-safe-nonce7d2691165e751f3de4532562f61c477def184defdc37aef67ab4d4c4e72568b8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QjA2OjM1NjcyNTo5RjA0MzM6RDZBNzc2OjZBNEM0NzJBIiwidmlzaXRvcl9pZCI6IjQxMjE3Njg3MDg1OTc4OTI5MDYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac7b08b7d78f03a053effc7105815812b607c687f19c47ca181bce889d8230c2b4
hovercard-subject-tagpull_request:3118135880
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/61128/files
twitter:imagehttps://avatars.githubusercontent.com/u/8130264?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/8130264?s=400&v=4
og:image:altFixes #46323 I see Event has a similar brand check (lib/internal/event_target.js:152) Should we also remove that one?
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None3d11bb817438277de2a940854450e83a7d32b6aeb5014e9e6b00a6423900251c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3996b3b83990e134be6c099ab9a7f48f140ae80f
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/61128/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F61128%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F61128%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/61128/files
Reloadhttps://github.com/nodejs/node/pull/61128/files
Reloadhttps://github.com/nodejs/node/pull/61128/files
Please reload this pagehttps://github.com/nodejs/node/pull/61128/files
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/61128/files
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 967 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
efekrskl:fix/remove-eventtarget-custom-inspect-brandinghttps://github.com/efekrskl/node/tree/fix/remove-eventtarget-custom-inspect-branding
Conversation 5 https://github.com/nodejs/node/pull/61128
Commits 4 https://github.com/nodejs/node/pull/61128/commits
Checks 46 https://github.com/nodejs/node/pull/61128/checks
Files changed 2 https://github.com/nodejs/node/pull/61128/files
fix: custom inspect should not throw when called with wrong this https://github.com/nodejs/node/pull/61128/files#top
Show all changes 4 commits https://github.com/nodejs/node/pull/61128/files
d3edbd1 events: remove eventtarget custom inspect branding efekrskl Dec 19, 2025 https://github.com/nodejs/node/pull/61128/commits/d3edbd13644fe3f6a24cc36baec69e47823a8a89
830ace5 test: test eventtarget custom inspect w/o branding efekrskl Dec 19, 2025 https://github.com/nodejs/node/pull/61128/commits/830ace596fb96b1b3d6fbba7ca54c78a6357a61c
bf43b8a test: use check output type instead of using doesNotThrow efekrskl Dec 21, 2025 https://github.com/nodejs/node/pull/61128/commits/bf43b8acc4b1922d7aa494b09522b3766f2ca32a
d8e55f9 test: fix lint errors efekrskl Dec 21, 2025 https://github.com/nodejs/node/pull/61128/commits/d8e55f9efea47e5d6344b11a4248e9aefa880ba1
Clear filters https://github.com/nodejs/node/pull/61128/files
Please reload this pagehttps://github.com/nodejs/node/pull/61128/files
Please reload this pagehttps://github.com/nodejs/node/pull/61128/files
event_target.js https://github.com/nodejs/node/pull/61128/files#diff-3a58267211ca7ef81843af880c461058fba2dc32379702b246a2d8aaec23c77e
test-eventtarget-custom-inspect-does-not-throw.js https://github.com/nodejs/node/pull/61128/files#diff-a3a4ba23b52f0c936f6da258bba5e622fc78c668c92bf9cc98a1d27efaa337d0
lib/internal/event_target.jshttps://github.com/nodejs/node/pull/61128/files#diff-3a58267211ca7ef81843af880c461058fba2dc32379702b246a2d8aaec23c77e
View file https://github.com/efekrskl/node/blob/d8e55f9efea47e5d6344b11a4248e9aefa880ba1/lib/internal/event_target.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/61128/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/61128/files#diff-3a58267211ca7ef81843af880c461058fba2dc32379702b246a2d8aaec23c77e
https://github.com/nodejs/node/pull/61128/files#diff-3a58267211ca7ef81843af880c461058fba2dc32379702b246a2d8aaec23c77e
test/parallel/test-eventtarget-custom-inspect-does-not-throw.jshttps://github.com/nodejs/node/pull/61128/files#diff-a3a4ba23b52f0c936f6da258bba5e622fc78c668c92bf9cc98a1d27efaa337d0
View file https://github.com/efekrskl/node/blob/d8e55f9efea47e5d6344b11a4248e9aefa880ba1/test/parallel/test-eventtarget-custom-inspect-does-not-throw.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/61128/{{ revealButtonHref }}
Please reload this pagehttps://github.com/nodejs/node/pull/61128/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.