Title: test_runner: fix lazy `test.assert` accessor by Renegade334 · Pull Request #61097 · nodejs/node · GitHub
Open Graph Title: test_runner: fix lazy `test.assert` accessor by Renegade334 · Pull Request #61097 · nodejs/node
X Title: test_runner: fix lazy `test.assert` accessor by Renegade334 · Pull Request #61097 · nodejs/node
Description: The intention was for this to be a define-on-access lazy property, but the object passed to Object.defineProperty isn't a descriptor, so this never happens. As a result, the assert object is currently reconstructed on every access; test.assert === test.assert is false at present. Changed to a conventional lazy getter, in alignment with the other node:test property accessors.
Open Graph Description: The intention was for this to be a define-on-access lazy property, but the object passed to Object.defineProperty isn't a descriptor, so this never happens. As a result, the assert object is cu...
X Description: The intention was for this to be a define-on-access lazy property, but the object passed to Object.defineProperty isn't a descriptor, so this never happens. As a result, the assert object i...
Opengraph URL: https://github.com/nodejs/node/pull/61097
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:840c8f4e-24b3-f003-09d8-8fd51fb72b40 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C0E8:163A10:70763B:93C904:6A4C3217 |
| html-safe-nonce | 31b0075e52b314300cf267f6493d716cc458d7187e19e0b67a9c356c2fd8a416 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMEU4OjE2M0ExMDo3MDc2M0I6OTNDOTA0OjZBNEMzMjE3IiwidmlzaXRvcl9pZCI6IjM3OTE3NDkxNDI0Njk2ODU3ODMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 8b8dfc41bbf0efef7394a79c98c8ad7db61db38fd14eb645972d4fb2dd9b81b0 |
| hovercard-subject-tag | pull_request:3110538940 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodejs/node/pull/61097/files |
| twitter:image | https://avatars.githubusercontent.com/u/9092381?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/9092381?s=400&v=4 |
| og:image:alt | The intention was for this to be a define-on-access lazy property, but the object passed to Object.defineProperty isn't a descriptor, so this never happens. As a result, the assert object is cu... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 1b6b16d04026f131a36d57e3b01d0f4d26a51800edf48bf5ed0256e0ac905511 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9ee13484b32cf23e15fde191da4c9aa47d41201c |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width