René's URL Explorer Experiment


Title: test: enforce better never-settling-promise detection by aduh95 · Pull Request #60976 · nodejs/node · GitHub

Open Graph Title: test: enforce better never-settling-promise detection by aduh95 · Pull Request #60976 · nodejs/node

X Title: test: enforce better never-settling-promise detection by aduh95 · Pull Request #60976 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Tests should be explicit regarding whether a promise is expected to settle, and the test should fail when the behavior does not meet expectations.

X Description: Tests should be explicit regarding whether a promise is expected to settle, and the test should fail when the behavior does not meet expectations.

Opengraph URL: https://github.com/nodejs/node/pull/60976

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/checks(.:format)
route-controllerpull_requests
route-actionchecks
fetch-noncev2:f9298834-208b-e049-886d-c1088aef93af
current-catalog-service-hash87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a
request-idB4C8:3841FE:89853:C21ED:6A4C9384
html-safe-nonce85b72f025ca5a9e482c41fd14eb24c30670c286743f9ecd81a57af8baa195954
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNEM4OjM4NDFGRTo4OTg1MzpDMjFFRDo2QTRDOTM4NCIsInZpc2l0b3JfaWQiOiIzNzQzNjk2NDY0MjQ2NTEwNDY4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacdb70a3e92bcfde878d7ab22b81b1a136dcd580b7ec85eff45cde54523ad86ad5
hovercard-subject-tagpull_request:3077725731
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/checks
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/60976/checks
twitter:imagehttps://opengraph.githubassets.com/76a33e3499bce6e158708c13cca62b68b7d6e67150b29bd745cda8f9bfa2be07/nodejs/node/pull/60976
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/76a33e3499bce6e158708c13cca62b68b7d6e67150b29bd745cda8f9bfa2be07/nodejs/node/pull/60976
og:image:altTests should be explicit regarding whether a promise is expected to settle, and the test should fail when the behavior does not meet expectations.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaduh95
hostnamegithub.com
expected-hostnamegithub.com
None3d11bb817438277de2a940854450e83a7d32b6aeb5014e9e6b00a6423900251c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7a2dede45637df6b92ddcfe2a557e67d4b5854ae
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/60976/checks#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F60976%2Fchecks
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F60976%2Fchecks
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fchecks&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/60976/checks
Reloadhttps://github.com/nodejs/node/pull/60976/checks
Reloadhttps://github.com/nodejs/node/pull/60976/checks
Please reload this pagehttps://github.com/nodejs/node/pull/60976/checks
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/60976/checks
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 964 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
aduh95:never-settling-thenhttps://github.com/aduh95/node/tree/never-settling-then
Conversationhttps://github.com/nodejs/node/pull/60976
Commits1 (1)https://github.com/nodejs/node/pull/60976/commits
Checkshttps://github.com/nodejs/node/pull/60976/checks
Files changedhttps://github.com/nodejs/node/pull/60976/files
test: enforce better never-settling-promise detectionhttps://github.com/nodejs/node/pull/60976/checks#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
aduh95:never-settling-thenhttps://github.com/aduh95/node/tree/never-settling-then
Please reload this pagehttps://github.com/nodejs/node/pull/60976/checks
Sign in for the full log viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F60976%2Fchecks
Label PRs on: pull_request_target https://github.com/nodejs/node/actions/runs/19990256052
label https://github.com/nodejs/node/actions/runs/19990256052/job/57329933354?pr=60976
Test Linux on: pull_request https://github.com/nodejs/node/actions/runs/19990256380
test-linux (ubuntu-24.04) https://github.com/nodejs/node/actions/runs/19990256380/job/57329933940?pr=60976
test-linux (ubuntu-24.04-arm) https://github.com/nodejs/node/actions/runs/19990256380/job/57329933929?pr=60976
Test Shared libraries on: pull_request https://github.com/nodejs/node/actions/runs/19990256386
Build slim tarball https://github.com/nodejs/node/actions/runs/19990256386/job/57329933994?pr=60976
x86_64-linux: with shared libraries https://github.com/nodejs/node/actions/runs/19990256386/job/57329983080?pr=60976
aarch64-linux: with shared libraries https://github.com/nodejs/node/actions/runs/19990256386/job/57329983075?pr=60976
x86_64-darwin: with shared libraries https://github.com/nodejs/node/actions/runs/19990256386/job/57329983079?pr=60976
aarch64-darwin: with shared libraries https://github.com/nodejs/node/actions/runs/19990256386/job/57329983078?pr=60976
Coverage Linux (without intl) on: pull_request https://github.com/nodejs/node/actions/runs/19990256385
coverage-linux-without-intl https://github.com/nodejs/node/actions/runs/19990256385/job/57329933976?pr=60976
Test macOS on: pull_request https://github.com/nodejs/node/actions/runs/19990256387
test-macOS https://github.com/nodejs/node/actions/runs/19990256387/job/57329934026?pr=60976
Coverage Windows on: pull_request https://github.com/nodejs/node/actions/runs/19990256396
coverage-windows https://github.com/nodejs/node/actions/runs/19990256396/job/57329933959?pr=60976
Build from tarball on: pull_request https://github.com/nodejs/node/actions/runs/19990256398
build-tarball https://github.com/nodejs/node/actions/runs/19990256398/job/57329934011?pr=60976
test-tarball-linux https://github.com/nodejs/node/actions/runs/19990256398/job/57330016593?pr=60976
Test and upload documentation to artifacts on: pull_request https://github.com/nodejs/node/actions/runs/19990256400
build-docs https://github.com/nodejs/node/actions/runs/19990256400/job/57329934057?pr=60976
Coverage Linux on: pull_request https://github.com/nodejs/node/actions/runs/19990256402
coverage-linux https://github.com/nodejs/node/actions/runs/19990256402/job/57329934046?pr=60976
First commit message adheres to guidelines on: pull_request https://github.com/nodejs/node/actions/runs/19990256413
lint-commit-message https://github.com/nodejs/node/actions/runs/19990256413/job/57329933948?pr=60976
Linters on: pull_request https://github.com/nodejs/node/actions/runs/19990256428
lint-addon-docs https://github.com/nodejs/node/actions/runs/19990256428/job/57329934024?pr=60976
lint-cpp https://github.com/nodejs/node/actions/runs/19990256428/job/57329934014?pr=60976
format-cpp https://github.com/nodejs/node/actions/runs/19990256428/job/57329933993?pr=60976
lint-js-and-md https://github.com/nodejs/node/actions/runs/19990256428/job/57329934053?pr=60976
lint-nix https://github.com/nodejs/node/actions/runs/19990256428/job/57329934040?pr=60976
lint-py https://github.com/nodejs/node/actions/runs/19990256428/job/57329934035?pr=60976
lint-yaml https://github.com/nodejs/node/actions/runs/19990256428/job/57329934049?pr=60976
lint-sh https://github.com/nodejs/node/actions/runs/19990256428/job/57329934071?pr=60976
lint-codeowners https://github.com/nodejs/node/actions/runs/19990256428/job/57329934051?pr=60976
lint-pr-url https://github.com/nodejs/node/actions/runs/19990256428/job/57329934061?pr=60976
lint-readme https://github.com/nodejs/node/actions/runs/19990256428/job/57329934028?pr=60976
Test internet on: pull_request https://github.com/nodejs/node/actions/runs/19990256435
test-internet https://github.com/nodejs/node/actions/runs/19990256435/job/57360125859?pr=60976
Notify on Review Wanted on: pull_request_target https://github.com/nodejs/node/actions/runs/19990258072
Notify on Review Wanted https://github.com/nodejs/node/actions/runs/19990258072/job/57329937978?pr=60976
Comment on issues and PRs when labeled on: pull_request_target https://github.com/nodejs/node/actions/runs/19990258087
stale-comment https://github.com/nodejs/node/actions/runs/19990258087/job/57329938041?pr=60976
fast-track https://github.com/nodejs/node/actions/runs/19990258087/job/57329937973?pr=60976
notable-change https://github.com/nodejs/node/actions/runs/19990258087/job/57329938057?pr=60976
Comment on issues and PRs when labeled on: pull_request_target https://github.com/nodejs/node/actions/runs/19990258126
stale-comment https://github.com/nodejs/node/actions/runs/19990258126/job/57329938158?pr=60976
fast-track https://github.com/nodejs/node/actions/runs/19990258126/job/57329938164?pr=60976
notable-change https://github.com/nodejs/node/actions/runs/19990258126/job/57329938048?pr=60976
Notify on Review Wanted on: pull_request_target https://github.com/nodejs/node/actions/runs/19990258127
Notify on Review Wanted https://github.com/nodejs/node/actions/runs/19990258127/job/57329938141?pr=60976
Notify on Review Wanted on: pull_request_target https://github.com/nodejs/node/actions/runs/19990258160
Notify on Review Wanted https://github.com/nodejs/node/actions/runs/19990258160/job/57329938161?pr=60976
Comment on issues and PRs when labeled on: pull_request_target https://github.com/nodejs/node/actions/runs/19990258162
stale-comment https://github.com/nodejs/node/actions/runs/19990258162/job/57329938143?pr=60976
fast-track https://github.com/nodejs/node/actions/runs/19990258162/job/57329938151?pr=60976
notable-change https://github.com/nodejs/node/actions/runs/19990258162/job/57329938228?pr=60976
Notify on Review Wanted on: pull_request_target https://github.com/nodejs/node/actions/runs/19990258173
Notify on Review Wanted https://github.com/nodejs/node/actions/runs/19990258173/job/57329938247?pr=60976
Comment on issues and PRs when labeled on: pull_request_target https://github.com/nodejs/node/actions/runs/19990258178
stale-comment https://github.com/nodejs/node/actions/runs/19990258178/job/57329938256?pr=60976
fast-track https://github.com/nodejs/node/actions/runs/19990258178/job/57329938272?pr=60976
notable-change https://github.com/nodejs/node/actions/runs/19990258178/job/57329938238?pr=60976
Notify on Review Wanted on: pull_request_target https://github.com/nodejs/node/actions/runs/19990258208
Notify on Review Wanted https://github.com/nodejs/node/actions/runs/19990258208/job/57329938347?pr=60976
Comment on issues and PRs when labeled on: pull_request_target https://github.com/nodejs/node/actions/runs/19990258207
stale-comment https://github.com/nodejs/node/actions/runs/19990258207/job/57329943484?pr=60976
fast-track https://github.com/nodejs/node/actions/runs/19990258207/job/57329938365?pr=60976
notable-change https://github.com/nodejs/node/actions/runs/19990258207/job/57329941495?pr=60976
Comment on issues and PRs when labeled on: pull_request_target https://github.com/nodejs/node/actions/runs/19990258596
stale-comment https://github.com/nodejs/node/actions/runs/19990258596/job/57329939276?pr=60976
fast-track https://github.com/nodejs/node/actions/runs/19990258596/job/57329939228?pr=60976
notable-change https://github.com/nodejs/node/actions/runs/19990258596/job/57329939257?pr=60976
Notify on Review Wanted on: pull_request_target https://github.com/nodejs/node/actions/runs/19990258598
Notify on Review Wanted https://github.com/nodejs/node/actions/runs/19990258598/job/57329939211?pr=60976
Notify on Review Wanted on: pull_request_target https://github.com/nodejs/node/actions/runs/19991823370
Notify on Review Wanted https://github.com/nodejs/node/actions/runs/19991823370/job/57333642067?pr=60976
Comment on issues and PRs when labeled on: pull_request_target https://github.com/nodejs/node/actions/runs/19991823380
stale-comment https://github.com/nodejs/node/actions/runs/19991823380/job/57333642031?pr=60976
fast-track https://github.com/nodejs/node/actions/runs/19991823380/job/57333642006?pr=60976
notable-change https://github.com/nodejs/node/actions/runs/19991823380/job/57333642010?pr=60976
Notify on Review Wanted on: pull_request_target https://github.com/nodejs/node/actions/runs/19991823416
Notify on Review Wanted https://github.com/nodejs/node/actions/runs/19991823416/job/57333645335?pr=60976
Comment on issues and PRs when labeled on: pull_request_target https://github.com/nodejs/node/actions/runs/19991823427
stale-comment https://github.com/nodejs/node/actions/runs/19991823427/job/57333642098?pr=60976
fast-track https://github.com/nodejs/node/actions/runs/19991823427/job/57333642081?pr=60976
notable-change https://github.com/nodejs/node/actions/runs/19991823427/job/57333642056?pr=60976
Comment on issues and PRs when labeled on: pull_request_target https://github.com/nodejs/node/actions/runs/20117051860
stale-comment https://github.com/nodejs/node/actions/runs/20117051860/job/57728868938?pr=60976
fast-track https://github.com/nodejs/node/actions/runs/20117051860/job/57728868838?pr=60976
notable-change https://github.com/nodejs/node/actions/runs/20117051860/job/57728868846?pr=60976
Notify on Review Wanted on: pull_request_target https://github.com/nodejs/node/actions/runs/20117051861
Notify on Review Wanted https://github.com/nodejs/node/actions/runs/20117051861/job/57728868849?pr=60976
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.