| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:fa9300a6-6224-6f37-9041-059a2995df86 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BDFA:341934:4EA4DE:6BA89E:6A4C856A |
| html-safe-nonce | 6ba374155b027b9d602a3240d0c4fcbaa4a30b2304b47dc0871aa4564e2a827f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCREZBOjM0MTkzNDo0RUE0REU6NkJBODlFOjZBNEM4NTZBIiwidmlzaXRvcl9pZCI6Ijg5MzU1Njg4ODE3NTQxMjU4NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | fa40499cd684cb7a8f38ce611624c408cdea178c1ee3f7c7fd3e158f4cd9bec3 |
| hovercard-subject-tag | pull_request:3055687614 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/60893/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/8960c4add61b91229b350d4e125ede5e939ab4d1096ea87d6e35b419fcbfe3dd/nodejs/node/pull/60893 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/8960c4add61b91229b350d4e125ede5e939ab4d1096ea87d6e35b419fcbfe3dd/nodejs/node/pull/60893 |
| og:image:alt | Alternative for this pr: #60889
this pr deleted decodeLatin1, and added Windows-1252 encoding support
problem: #60888
Thanks for repair & info detail 🙏 @ChALkeR
cc @mcollina
Fixes: #60888
Fixe... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mertcanaltin |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3d11bb817438277de2a940854450e83a7d32b6aeb5014e9e6b00a6423900251c |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7a2dede45637df6b92ddcfe2a557e67d4b5854ae |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/60893#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F60893 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F60893 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/60893 |
| Reload | https://github.com/nodejs/node/pull/60893 |
| Reload | https://github.com/nodejs/node/pull/60893 |
| Please reload this page | https://github.com/nodejs/node/pull/60893 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/60893 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.4k
| https://github.com/nodejs/node/issues |
|
Pull requests
964
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| mertcanaltin:mert/fix/windows-1252-decoding | https://github.com/mertcanaltin/node/tree/mert/fix/windows-1252-decoding |
| Conversation | https://github.com/nodejs/node/pull/60893 |
| Commits1 (1) | https://github.com/nodejs/node/pull/60893/commits |
| Checks | https://github.com/nodejs/node/pull/60893/checks |
| Files changed | https://github.com/nodejs/node/pull/60893/files |
| src: implement Windows-1252 encoding support and update related tests | https://github.com/nodejs/node/pull/60893#top |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| mertcanaltin:mert/fix/windows-1252-decoding | https://github.com/mertcanaltin/node/tree/mert/fix/windows-1252-decoding |
|
| https://github.com/mertcanaltin |
| mertcanaltin | https://github.com/mertcanaltin |
| Nov 29, 2025 | https://github.com/nodejs/node/pull/60893#issue-3676839326 |
| Please reload this page | https://github.com/nodejs/node/pull/60893 |
| #60889 | https://github.com/nodejs/node/pull/60889 |
| #60888 | https://github.com/nodejs/node/issues/60888 |
| @ChALkeR | https://github.com/ChALkeR |
| @mcollina | https://github.com/mcollina |
| #60888 | https://github.com/nodejs/node/issues/60888 |
| #59515 | https://github.com/nodejs/node/issues/59515 |
| #56542 | https://github.com/nodejs/node/issues/56542 |
| Please reload this page | https://github.com/nodejs/node/pull/60893 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
encoding
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aencoding |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
typings
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atypings |
| Nov 29, 2025 | https://github.com/nodejs/node/pull/60893#event-21252201093 |
| https://github.com/mertcanaltin |
| mertcanaltin | https://github.com/mertcanaltin |
|
Nov 29, 2025
| https://github.com/nodejs/node/pull/60893#ref-pullrequest-3676445420 |
|
Revert "util: add fast path for Latin1 decoding"
#60889
| https://github.com/nodejs/node/pull/60889 |
| https://github.com/mertcanaltin |
| mertcanaltin | https://github.com/mertcanaltin |
| Nov 29, 2025 | https://github.com/nodejs/node/pull/60893#issuecomment-3591811450 |
| https://github.com/nodejs/node/actions/runs/19785758751/job/56691976357?pr=60893 | https://github.com/nodejs/node/actions/runs/19785758751/job/56691976357?pr=60893 |
| Please reload this page | https://github.com/nodejs/node/pull/60893 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Nov 29, 2025
| https://github.com/nodejs/node/pull/60893#pullrequestreview-3520769908 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/60893/files |
| mcollina | https://github.com/mcollina |
| https://github.com/nodejs/node/pull/60893#pullrequestreview-3520769908 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/60893 |
| https://github.com/ChALkeR |
| ChALkeR | https://github.com/ChALkeR |
|
Nov 29, 2025
| https://github.com/nodejs/node/pull/60893#pullrequestreview-3520774107 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/60893/files |
| ChALkeR | https://github.com/ChALkeR |
| https://github.com/nodejs/node/pull/60893#pullrequestreview-3520774107 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/60893 |
| https://github.com/mertcanaltin |
| mertcanaltin | https://github.com/mertcanaltin |
| force-pushed | https://github.com/nodejs/node/compare/709e9cef009aa0a0daac4abf79ab856b1b0faf74..25319d530e2f65e17b0fdb17f2adc97c03a63415 |
| 709e9ce | https://github.com/nodejs/node/commit/709e9cef009aa0a0daac4abf79ab856b1b0faf74 |
| 25319d5 | https://github.com/nodejs/node/commit/25319d530e2f65e17b0fdb17f2adc97c03a63415 |
|
Compare
| https://github.com/nodejs/node/compare/709e9cef009aa0a0daac4abf79ab856b1b0faf74..25319d530e2f65e17b0fdb17f2adc97c03a63415 |
| November 29, 2025 18:11 | https://github.com/nodejs/node/pull/60893#event-21252814911 |
| https://github.com/mertcanaltin |
| mertcanaltin | https://github.com/mertcanaltin |
| Nov 29, 2025 | https://github.com/nodejs/node/pull/60893#issuecomment-3591845998 |
| Please reload this page | https://github.com/nodejs/node/pull/60893 |
|
| https://github.com/mertcanaltin |
| src: implement Windows-1252 encoding support and update related tests | https://github.com/nodejs/node/pull/60893/commits/59fd7cb44df7278742691f9175fec6ea95e88f97 |
| 59fd7cb | https://github.com/nodejs/node/pull/60893/commits/59fd7cb44df7278742691f9175fec6ea95e88f97 |
| https://github.com/mertcanaltin |
| mertcanaltin | https://github.com/mertcanaltin |
| force-pushed | https://github.com/nodejs/node/compare/848e4808de5587127b80537261da375fc0500e0e..59fd7cb44df7278742691f9175fec6ea95e88f97 |
| 848e480 | https://github.com/nodejs/node/commit/848e4808de5587127b80537261da375fc0500e0e |
| 59fd7cb | https://github.com/nodejs/node/commit/59fd7cb44df7278742691f9175fec6ea95e88f97 |
|
Compare
| https://github.com/nodejs/node/compare/848e4808de5587127b80537261da375fc0500e0e..59fd7cb44df7278742691f9175fec6ea95e88f97 |
| November 29, 2025 18:28 | https://github.com/nodejs/node/pull/60893#event-21252871058 |
| https://github.com/apps/codecov |
| codecov | https://github.com/apps/codecov |
| Nov 29, 2025 | https://github.com/nodejs/node/pull/60893#issuecomment-3591922299 |
| Please reload this page | https://github.com/nodejs/node/pull/60893 |
| Codecov | https://app.codecov.io/gh/nodejs/node/pull/60893?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| 6c22420 | https://app.codecov.io/gh/nodejs/node/commit/6c224203723e901db7518c35f679409a9f9a76af?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| 59fd7cb | https://app.codecov.io/gh/nodejs/node/commit/59fd7cb44df7278742691f9175fec6ea95e88f97?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| Files with missing lines | https://app.codecov.io/gh/nodejs/node/pull/60893?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| src/encoding_binding.cc | https://app.codecov.io/gh/nodejs/node/pull/60893?src=pr&el=tree&filepath=src%2Fencoding_binding.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL2VuY29kaW5nX2JpbmRpbmcuY2M= |
| 1 Missing and 3 partials ⚠️ | https://app.codecov.io/gh/nodejs/node/pull/60893?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| Files with missing lines | https://app.codecov.io/gh/nodejs/node/pull/60893?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| lib/internal/encoding.js | https://app.codecov.io/gh/nodejs/node/pull/60893?src=pr&el=tree&filepath=lib%2Finternal%2Fencoding.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL2VuY29kaW5nLmpz |
| src/encoding_binding.h | https://app.codecov.io/gh/nodejs/node/pull/60893?src=pr&el=tree&filepath=src%2Fencoding_binding.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL2VuY29kaW5nX2JpbmRpbmcuaA== |
| src/encoding_binding.cc | https://app.codecov.io/gh/nodejs/node/pull/60893?src=pr&el=tree&filepath=src%2Fencoding_binding.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL2VuY29kaW5nX2JpbmRpbmcuY2M= |
| 31 files with indirect coverage changes | https://app.codecov.io/gh/nodejs/node/pull/60893/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| Test Analytics | https://docs.codecov.com/docs/test-analytics |
| JS Bundle Analysis | https://docs.codecov.com/docs/javascript-bundle-analysis |
| Please reload this page | https://github.com/nodejs/node/pull/60893 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
lts-watch-v20.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v20.x |
|
lts-watch-v22.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v22.x |
| Nov 30, 2025 | https://github.com/nodejs/node/pull/60893#event-21255275054 |
| https://github.com/RafaelGSS |
| RafaelGSS | https://github.com/RafaelGSS |
|
Nov 30, 2025
| https://github.com/nodejs/node/pull/60893#pullrequestreview-3521377763 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/60893/files/59fd7cb44df7278742691f9175fec6ea95e88f97 |
| https://github.com/RafaelGSS |
| RafaelGSS | https://github.com/RafaelGSS |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Nov 30, 2025 | https://github.com/nodejs/node/pull/60893#event-21256840080 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Nov 30, 2025 | https://github.com/nodejs/node/pull/60893#event-21256879358 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 30, 2025 | https://github.com/nodejs/node/pull/60893#issuecomment-3592614003 |
| https://ci.nodejs.org/job/node-test-pull-request/70354/ | https://ci.nodejs.org/job/node-test-pull-request/70354/ |
| Please reload this page | https://github.com/nodejs/node/pull/60893 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Dec 4, 2025 | https://github.com/nodejs/node/pull/60893#issuecomment-3609436599 |
| https://ci.nodejs.org/job/node-test-pull-request/70383/ | https://ci.nodejs.org/job/node-test-pull-request/70383/ |
| Please reload this page | https://github.com/nodejs/node/pull/60893 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Dec 4, 2025 | https://github.com/nodejs/node/pull/60893#event-21361037869 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Dec 4, 2025 | https://github.com/nodejs/node/pull/60893#event-21361067640 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| f65b0bc | https://github.com/nodejs/node/commit/f65b0bc81a79a6068e594d1179c4c51680bfaa89 |
| Dec 4, 2025 | https://github.com/nodejs/node/pull/60893#event-21361109012 |
| Please reload this page | https://github.com/nodejs/node/pull/60893 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Dec 4, 2025 | https://github.com/nodejs/node/pull/60893#issuecomment-3612505736 |
| f65b0bc | https://github.com/nodejs/node/commit/f65b0bc81a79a6068e594d1179c4c51680bfaa89 |
| Please reload this page | https://github.com/nodejs/node/pull/60893 |
| targos | https://github.com/targos |
|
Dec 5, 2025
| https://github.com/nodejs/node/pull/60893#ref-commit-abdccc0 |
|
| https://github.com/mertcanaltin |
|
| https://github.com/targos |
| src: implement Windows-1252 encoding support and update related tests | https://github.com/nodejs/node/commit/abdccc0770d24dd10d011929ca632041fbeaecda |
| abdccc0 | https://github.com/nodejs/node/commit/abdccc0770d24dd10d011929ca632041fbeaecda |
| #60893 | https://github.com/nodejs/node/pull/60893 |
| #60888 | https://github.com/nodejs/node/issues/60888 |
| #59515 | https://github.com/nodejs/node/issues/59515 |
| #56542 | https://github.com/nodejs/node/issues/56542 |
| https://github.com/ChALkeR |
| ChALkeR | https://github.com/ChALkeR |
| Dec 17, 2025 | https://github.com/nodejs/node/pull/60893#issuecomment-3664840688 |
| Please reload this page | https://github.com/nodejs/node/pull/60893 |
| #60889 | https://github.com/nodejs/node/pull/60889 |
| Please reload this page | https://github.com/nodejs/node/pull/60893 |
| https://github.com/ChALkeR |
| ChALkeR | https://github.com/ChALkeR |
|
Dec 17, 2025
| https://github.com/nodejs/node/pull/60893#pullrequestreview-3587213742 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/60893/files/59fd7cb44df7278742691f9175fec6ea95e88f97 |
| src/encoding_binding.cc | https://github.com/nodejs/node/pull/60893/files/59fd7cb44df7278742691f9175fec6ea95e88f97#diff-ae2f36d44cbc7f412b2dacfc1ccc7d741068d10372843a31e3deee89bf09ff6e |
| ChALkeR | https://github.com/ChALkeR |
| Dec 17, 2025 | https://github.com/nodejs/node/pull/60893#discussion_r2626623255 |
| Please reload this page | https://github.com/nodejs/node/pull/60893 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/60893 |
| https://github.com/ChALkeR |
| ChALkeR | https://github.com/ChALkeR |
|
Dec 17, 2025
| https://github.com/nodejs/node/pull/60893#ref-issue-3725526416 |
|
TextDecoder is wrong and very slow
#61041
| https://github.com/nodejs/node/issues/61041 |
| https://github.com/ChALkeR |
| ChALkeR | https://github.com/ChALkeR |
| Dec 17, 2025 | https://github.com/nodejs/node/pull/60893#issuecomment-3664867862 |
| Please reload this page | https://github.com/nodejs/node/pull/60893 |
| #55275 | https://github.com/nodejs/node/pull/55275 |
| #55275 | https://github.com/nodejs/node/pull/55275 |
| Please reload this page | https://github.com/nodejs/node/pull/60893 |
| https://github.com/mertcanaltin |
| mertcanaltin | https://github.com/mertcanaltin |
| Dec 17, 2025 | https://github.com/nodejs/node/pull/60893#issuecomment-3664942974 |
| #55275 | https://github.com/nodejs/node/pull/55275 |
| #55275 | https://github.com/nodejs/node/pull/55275 |
| Please reload this page | https://github.com/nodejs/node/pull/60893 |
| https://github.com/ChALkeR |
| ChALkeR | https://github.com/ChALkeR |
|
Dec 17, 2025
| https://github.com/nodejs/node/pull/60893#ref-pullrequest-3738564127 |
|
lib: implement all 1-byte encodings in js
#61093
| https://github.com/nodejs/node/pull/61093 |
| https://github.com/ChALkeR |
| ChALkeR | https://github.com/ChALkeR |
| Dec 18, 2025 | https://github.com/nodejs/node/pull/60893#issuecomment-3671789608 |
| Please reload this page | https://github.com/nodejs/node/pull/60893 |
| Please reload this page | https://github.com/nodejs/node/pull/60893 |
| https://github.com/mertcanaltin |
| mertcanaltin | https://github.com/mertcanaltin |
| Dec 18, 2025 | https://github.com/nodejs/node/pull/60893#issuecomment-3671823665 |
| Please reload this page | https://github.com/nodejs/node/pull/60893 |
| #61107 | https://github.com/nodejs/node/pull/61107 |
| Please reload this page | https://github.com/nodejs/node/pull/60893 |
| https://github.com/ChALkeR |
| ChALkeR | https://github.com/ChALkeR |
| Dec 18, 2025 | https://github.com/nodejs/node/pull/60893#issuecomment-3671836303 |
| Please reload this page | https://github.com/nodejs/node/pull/60893 |
| #61093 | https://github.com/nodejs/node/pull/61093 |
| Please reload this page | https://github.com/nodejs/node/pull/60893 |
| https://github.com/mertcanaltin |
| mertcanaltin | https://github.com/mertcanaltin |
| Dec 18, 2025 | https://github.com/nodejs/node/pull/60893#issuecomment-3671845343 |
| Please reload this page | https://github.com/nodejs/node/pull/60893 |
| #61093 | https://github.com/nodejs/node/pull/61093 |
| Please reload this page | https://github.com/nodejs/node/pull/60893 |
| aduh95 | https://github.com/aduh95 |
|
Jan 9, 2026
| https://github.com/nodejs/node/pull/60893#ref-commit-42276ae |
|
| https://github.com/mertcanaltin |
|
| https://github.com/aduh95 |
| src: implement Windows-1252 encoding support and update related tests | https://github.com/nodejs/node/commit/42276ae523c2a1f98ec53142d0feeac387f826c6 |
| 42276ae | https://github.com/nodejs/node/commit/42276ae523c2a1f98ec53142d0feeac387f826c6 |
| #60893 | https://github.com/nodejs/node/pull/60893 |
| #60888 | https://github.com/nodejs/node/issues/60888 |
| #59515 | https://github.com/nodejs/node/issues/59515 |
| #56542 | https://github.com/nodejs/node/issues/56542 |
| RafaelGSS | https://github.com/RafaelGSS |
|
Jan 13, 2026
| https://github.com/nodejs/node/pull/60893#ref-commit-550e8a7 |
|
| https://github.com/mertcanaltin |
|
| https://github.com/RafaelGSS |
| src: implement Windows-1252 encoding support and update related tests | https://github.com/nodejs/node/commit/550e8a7a69576f29edbcf966d5f11846b7bbc5ad |
| 550e8a7 | https://github.com/nodejs/node/commit/550e8a7a69576f29edbcf966d5f11846b7bbc5ad |
| #60893 | https://github.com/nodejs/node/pull/60893 |
| #60888 | https://github.com/nodejs/node/issues/60888 |
| #59515 | https://github.com/nodejs/node/issues/59515 |
| #56542 | https://github.com/nodejs/node/issues/56542 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
Jan 16, 2026
| https://github.com/nodejs/node/pull/60893#ref-pullrequest-3822224144 |
|
2026-01-19, Version 25.4.0 (Current)
#61400
| https://github.com/nodejs/node/pull/61400 |
| aduh95 | https://github.com/aduh95 |
|
Jan 19, 2026
| https://github.com/nodejs/node/pull/60893#ref-commit-7484a34 |
|
| https://github.com/mertcanaltin |
|
| https://github.com/aduh95 |
| src: implement Windows-1252 encoding support and update related tests | https://github.com/nodejs/node/commit/7484a34a7d0d461440a15b6dcf664d1d1afc3b71 |
| 7484a34 | https://github.com/nodejs/node/commit/7484a34a7d0d461440a15b6dcf664d1d1afc3b71 |
| #60893 | https://github.com/nodejs/node/pull/60893 |
| #60888 | https://github.com/nodejs/node/issues/60888 |
| #59515 | https://github.com/nodejs/node/issues/59515 |
| #56542 | https://github.com/nodejs/node/issues/56542 |
| tmeijn | https://github.com/tmeijn |
|
Jan 22, 2026
| https://github.com/nodejs/node/pull/60893#ref-commit-d3d819e |
|
| https://github.com/tmeijn |
| build(deps): update node to v25.4.0 | https://github.com/tmeijn/dotfiles/commit/d3d819e37760131eb0853233a474780d24051202 |
| d3d819e | https://github.com/tmeijn/dotfiles/commit/d3d819e37760131eb0853233a474780d24051202 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
Feb 3, 2026
| https://github.com/nodejs/node/pull/60893#ref-pullrequest-3892697171 |
|
2026-02-10, Version 24.13.1 'Krypton' (LTS)
#61661
| https://github.com/nodejs/node/pull/61661 |
| aduh95 | https://github.com/aduh95 |
|
Feb 17, 2026
| https://github.com/nodejs/node/pull/60893#ref-commit-7f0ffdd |
|
| https://github.com/mertcanaltin |
|
| https://github.com/aduh95 |
| src: implement Windows-1252 encoding support and update related tests | https://github.com/nodejs/node/commit/7f0ffddc149d70337d629c136c1f9fffe720f9fa |
| 7f0ffdd | https://github.com/nodejs/node/commit/7f0ffddc149d70337d629c136c1f9fffe720f9fa |
| #60893 | https://github.com/nodejs/node/pull/60893 |
| #60888 | https://github.com/nodejs/node/issues/60888 |
| #59515 | https://github.com/nodejs/node/issues/59515 |
| #56542 | https://github.com/nodejs/node/issues/56542 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Feb 22, 2026
| https://github.com/nodejs/node/pull/60893#ref-pullrequest-3975660233 |
|
V22.22.1 proposal
#61947
| https://github.com/nodejs/node/pull/61947 |
| mhalikosen | https://github.com/mhalikosen |
|
Feb 24, 2026
| https://github.com/nodejs/node/pull/60893#ref-commit-788982f |
|
| https://github.com/mhalikosen |
| fix(headers): correct windows-1252 test assertion for Node 24.13.1 | https://github.com/mhalikosen/remix/commit/788982f33b367ad76aefcad678e1cdd783b26dc7 |
| 788982f | https://github.com/mhalikosen/remix/commit/788982f33b367ad76aefcad678e1cdd783b26dc7 |
| nodejs/node#60893 | https://github.com/nodejs/node/pull/60893 |
| nodejs/node#61093 | https://github.com/nodejs/node/pull/61093 |
| fa226ba | https://github.com/mhalikosen/remix/commit/fa226ba7572a09224b0d4b85bb1be3c76977b713 |
| https://github.com/mhalikosen |
| mhalikosen | https://github.com/mhalikosen |
|
Feb 24, 2026
| https://github.com/nodejs/node/pull/60893#ref-pullrequest-3985549032 |
|
fix(headers): correct windows-1252 test assertion for Node 24.13.1
remix-run/remix#11085
| https://github.com/remix-run/remix/pull/11085 |
| https://github.com/marco-ippolito |
| marco-ippolito | https://github.com/marco-ippolito |
|
lts-watch-v20.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v20.x |
| Mar 2, 2026 | https://github.com/nodejs/node/pull/60893#event-23194093531 |
| https://github.com/marco-ippolito |
| marco-ippolito | https://github.com/marco-ippolito |
|
lts-watch-v22.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v22.x |
| Apr 27, 2026 | https://github.com/nodejs/node/pull/60893#event-24913854413 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F60893 |
|
| https://github.com/ChALkeR |
|
ChALkeR
| https://github.com/ChALkeR |
|
| https://github.com/nodejs/node/pull/60893/files/59fd7cb44df7278742691f9175fec6ea95e88f97 |
|
| https://github.com/mcollina |
|
mcollina
| https://github.com/mcollina |
|
| https://github.com/nodejs/node/pull/60893/files/6a6c3c8197558eee5f40602e31b5a1de99783533 |
|
| https://github.com/RafaelGSS |
|
RafaelGSS
| https://github.com/RafaelGSS |
|
| https://github.com/nodejs/node/pull/60893/files/59fd7cb44df7278742691f9175fec6ea95e88f97 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
encoding
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aencoding |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
typings
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atypings |
|
TextDecoder behavior is wrong since 20.18.3/22.13.0
| https://github.com/nodejs/node/issues/60888 |
|
error for "Windows-1252" encoding for char "\u2013"
| https://github.com/nodejs/node/issues/59515 |
|
TextDecoder incorrectly decodes 0x92 and several other characters for Windows-1252
| https://github.com/nodejs/node/issues/56542 |
| Please reload this page | https://github.com/nodejs/node/pull/60893 |
|
| https://github.com/mertcanaltin |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/ChALkeR |
|
| https://github.com/mcollina |
|
| https://github.com/RafaelGSS |
|
| https://github.com/aduh95 |
|
| https://github.com/marco-ippolito |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |