Title: tools: don't fetch V8 deps in the source tree by richardlau · Pull Request #60883 · nodejs/node · GitHub
Open Graph Title: tools: don't fetch V8 deps in the source tree by richardlau · Pull Request #60883 · nodejs/node
X Title: tools: don't fetch V8 deps in the source tree by richardlau · Pull Request #60883 · nodejs/node
Description: The Node.js source tree already includes several V8 DEPS under deps/v8/third_party that are needed to build Node.js. Exclude these in tools/v8/fetch_deps.py to prevent "Conflicting directory" warnings when running the V8 CI.
e.g. https://ci.nodejs.org/job/node-test-commit-v8-linux/6886/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/consoleFull
10:35:32 Warnings:
10:35:32 Conflicting directory ./v8/third_party/jinja2 moved to ./_bad_scm/v8/third_party/jinja2ev06og_3.
10:35:32 Conflicting directory ./v8/third_party/fp16/src moved to ./_bad_scm/v8/third_party/fp16/srcofo97bgs.
10:35:32 Conflicting directory ./v8/third_party/fast_float/src moved to ./_bad_scm/v8/third_party/fast_float/src9v1zqv71.
10:35:32 Conflicting directory ./v8/third_party/abseil-cpp moved to ./_bad_scm/v8/third_party/abseil-cppki9can6x.
10:35:32 Conflicting directory ./v8/third_party/markupsafe moved to ./_bad_scm/v8/third_party/markupsafechfk151u.
10:35:32 Conflicting directory ./v8/third_party/googletest/src moved to ./_bad_scm/v8/third_party/googletest/srcnct99h20.
10:35:32 Conflicting directory ./v8/third_party/simdutf moved to ./_bad_scm/v8/third_party/simdutfu_7og22d.
10:35:32 Conflicting directory ./v8/third_party/zlib moved to ./_bad_scm/v8/third_party/zlib7aw3bhfj.
10:35:32 Conflicting directory ./v8/third_party/dragonbox/src moved to ./_bad_scm/v8/third_party/dragonbox/src_awrr_e7.
10:35:32 Conflicting directory ./v8/third_party/highway/src moved to ./_bad_scm/v8/third_party/highway/srcfch45l4t.
10:35:32 git update is recommended.
I initially added all of the above to the overrides in tools/v8/fetch_deps.py but the V8 CI failed when some of them were skipped which suggests the V8 build requires things that have been removed from/not copied into the Node.js source tree:
v8/third_party/googletest/src
Details
iojs@test-hetzner-ubuntu2204-x64-2:~/build/workspace/node-test-commit-v8-linux/deps/v8$ PATH=/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/depot_tools:/home/iojs/build/workspace/node-test-commit-v8-linux/depot_tools:/home/iojs/venv/bin:/home/iojs/nghttp2/src:/home/iojs/wrk:/usr/lib/ccache:/usr/lib64/ccache:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin tools/dev/v8gen.py -vv x64.release
################################################################################
/usr/bin/python3 -u tools/mb/mb.py gen -f infra/mb/mb_config.pyl -m developer_default -b x64.release out.gn/x64.release
Writing """\
dcheck_always_on = false
is_debug = false
target_cpu = "x64"
""" to /home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/out.gn/x64.release/args.gn.
/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/buildtools/linux64/gn gen out.gn/x64.release --check
-> returned 1
ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
target(_target_type, target_name) {
^----------------------------------
The target:
//third_party/googletest:gmock
has a source file:
//third_party/googletest/src/googlemock/include/gmock/gmock-cardinalities.h
which was not found.
___________________
ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
target(_target_type, target_name) {
^----------------------------------
The target:
//third_party/googletest:gmock
has a source file:
//third_party/googletest/src/googlemock/include/gmock/gmock-actions.h
which was not found.
___________________
ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
target(_target_type, target_name) {
^----------------------------------
The target:
//third_party/googletest:gmock
has a source file:
//third_party/googletest/src/googlemock/include/gmock/gmock-matchers.h
which was not found.
___________________
ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
target(_target_type, target_name) {
^----------------------------------
The target:
//third_party/googletest:gmock
has a source file:
//third_party/googletest/src/googlemock/include/gmock/gmock-function-mocker.h
which was not found.
___________________
ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
target(_target_type, target_name) {
^----------------------------------
The target:
//third_party/googletest:gmock
has a source file:
//third_party/googletest/src/googlemock/include/gmock/gmock-more-matchers.h
which was not found.
___________________
ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
target(_target_type, target_name) {
^----------------------------------
The target:
//third_party/googletest:gmock
has a source file:
//third_party/googletest/src/googlemock/include/gmock/gmock-more-actions.h
which was not found.
___________________
ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
target(_target_type, target_name) {
^----------------------------------
The target:
//third_party/googletest:gmock
has a source file:
//third_party/googletest/src/googlemock/include/gmock/gmock-spec-builders.h
which was not found.
___________________
ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
target(_target_type, target_name) {
^----------------------------------
The target:
//third_party/googletest:gmock
has a source file:
//third_party/googletest/src/googlemock/include/gmock/internal/gmock-port.h
which was not found.
___________________
ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
target(_target_type, target_name) {
^----------------------------------
The target:
//third_party/googletest:gmock
has a source file:
//third_party/googletest/src/googlemock/include/gmock/internal/gmock-internal-utils.h
which was not found.
___________________
ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
target(_target_type, target_name) {
^----------------------------------
The target:
//third_party/googletest:gmock
has a source file:
//third_party/googletest/src/googlemock/include/gmock/gmock-nice-strict.h
which was not found.
___________________
ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
target(_target_type, target_name) {
^----------------------------------
The target:
//third_party/googletest:gmock
has a source file:
//third_party/googletest/src/googlemock/include/gmock/gmock.h
which was not found.
___________________
ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
target(_target_type, target_name) {
^----------------------------------
The target:
//third_party/googletest:gmock
has a source file:
//third_party/googletest/src/googlemock/src/gmock-cardinalities.cc
which was not found.
___________________
ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
target(_target_type, target_name) {
^----------------------------------
The target:
//third_party/googletest:gmock
has a source file:
//third_party/googletest/src/googlemock/src/gmock-internal-utils.cc
which was not found.
___________________
ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
target(_target_type, target_name) {
^----------------------------------
The target:
//third_party/googletest:gmock
has a source file:
//third_party/googletest/src/googlemock/src/gmock.cc
which was not found.
___________________
ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
target(_target_type, target_name) {
^----------------------------------
The target:
//third_party/googletest:gmock_main
has a source file:
//third_party/googletest/src/googlemock/src/gmock_main.cc
which was not found.
___________________
ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
target(_target_type, target_name) {
^----------------------------------
The target:
//third_party/googletest:gmock
has a source file:
//third_party/googletest/src/googlemock/include/gmock/internal/gmock-pp.h
which was not found.
___________________
ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
target(_target_type, target_name) {
^----------------------------------
The target:
//third_party/googletest:gmock
has a source file:
//third_party/googletest/src/googlemock/src/gmock-matchers.cc
which was not found.
___________________
ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
target(_target_type, target_name) {
^----------------------------------
The target:
//third_party/googletest:gtest
has a source file:
//third_party/googletest/src/googletest/include/gtest/gtest-assertion-result.h
which was not found.
___________________
ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
target(_target_type, target_name) {
^----------------------------------
The target:
//third_party/googletest:gmock
has a source file:
//third_party/googletest/src/googlemock/src/gmock-spec-builders.cc
which was not found.
___________________
ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
target(_target_type, target_name) {
^----------------------------------
The target:
//third_party/googletest:gtest
has a source file:
//third_party/googletest/src/googletest/include/gtest/gtest-death-test.h
which was not found.
___________________
ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
target(_target_type, target_name) {
^----------------------------------
The target:
//third_party/googletest:gtest
has a source file:
//third_party/googletest/src/googletest/include/gtest/gtest-matchers.h
which was not found.
___________________
ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
target(_target_type, target_name) {
^----------------------------------
The target:
//third_party/googletest:gtest
has a source file:
//third_party/googletest/src/googletest/include/gtest/gtest-param-test.h
which was not found.
___________________
ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
target(_target_type, target_name) {
^----------------------------------
The target:
//third_party/googletest:gtest
has a source file:
//third_party/googletest/src/googletest/include/gtest/gtest-printers.h
which was not found.
___________________
ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
target(_target_type, target_name) {
^----------------------------------
The target:
//third_party/googletest:gtest
has a source file:
//third_party/googletest/src/googletest/include/gtest/gtest-test-part.h
which was not found.
___________________
ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
target(_target_type, target_name) {
^----------------------------------
The target:
//third_party/googletest:gtest
has a source file:
//third_party/googletest/src/googletest/include/gtest/gtest-message.h
which was not found.
___________________
ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
target(_target_type, target_name) {
^----------------------------------
The target:
//third_party/googletest:gtest
has a source file:
//third_party/googletest/src/googletest/include/gtest/gtest-typed-test.h
which was not found.
___________________
ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
target(_target_type, target_name) {
^----------------------------------
The target:
//third_party/googletest:gtest
has a source file:
//third_party/googletest/src/googletest/include/gtest/gtest-spi.h
which was not found.
___________________
ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
target(_target_type, target_name) {
^----------------------------------
The target:
//third_party/googletest:gtest
has a source file:
//third_party/googletest/src/googletest/include/gtest/gtest.h
which was not found.
___________________
ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
target(_target_type, target_name) {
^----------------------------------
The target:
//third_party/googletest:gtest
has a source file:
//third_party/googletest/src/googletest/include/gtest/internal/gtest-filepath.h
which was not found.
___________________
ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
target(_target_type, target_name) {
^----------------------------------
The target:
//third_party/googletest:gtest
has a source file:
//third_party/googletest/src/googletest/include/gtest/gtest_pred_impl.h
which was not found.
___________________
ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
target(_target_type, target_name) {
^----------------------------------
The target:
//third_party/googletest:gtest
has a source file:
//third_party/googletest/src/googletest/include/gtest/internal/gtest-internal.h
which was not found.
___________________
ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
target(_target_type, target_name) {
^----------------------------------
The target:
//third_party/googletest:gtest
has a source file:
//third_party/googletest/src/googletest/include/gtest/internal/gtest-param-util.h
which was not found.
___________________
ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
target(_target_type, target_name) {
^----------------------------------
The target:
//third_party/googletest:gtest
has a source file:
//third_party/googletest/src/googletest/include/gtest/internal/gtest-port.h
which was not found.
___________________
ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
target(_target_type, target_name) {
^----------------------------------
The target:
//third_party/googletest:gtest
has a source file:
//third_party/googletest/src/googletest/include/gtest/internal/gtest-string.h
which was not found.
___________________
ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
target(_target_type, target_name) {
^----------------------------------
The target:
//third_party/googletest:gtest
has a source file:
//third_party/googletest/src/googletest/src/gtest-death-test.cc
which was not found.
___________________
ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
target(_target_type, target_name) {
^----------------------------------
The target:
//third_party/googletest:gtest
has a source file:
//third_party/googletest/src/googletest/include/gtest/internal/gtest-death-test-internal.h
which was not found.
___________________
ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
target(_target_type, target_name) {
^----------------------------------
The target:
//third_party/googletest:gtest
has a source file:
//third_party/googletest/src/googletest/include/gtest/internal/gtest-type-util.h
which was not found.
___________________
ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
target(_target_type, target_name) {
^----------------------------------
The target:
//third_party/googletest:gtest
has a source file:
//third_party/googletest/src/googletest/src/gtest-port.cc
which was not found.
___________________
ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
target(_target_type, target_name) {
^----------------------------------
The target:
//third_party/googletest:gtest
has a source file:
//third_party/googletest/src/googletest/src/gtest-matchers.cc
which was not found.
___________________
ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
target(_target_type, target_name) {
^----------------------------------
The target:
//third_party/googletest:gtest
has a source file:
//third_party/googletest/src/googletest/src/gtest-printers.cc
which was not found.
___________________
ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
target(_target_type, target_name) {
^----------------------------------
The target:
//third_party/googletest:gtest
has a source file:
//third_party/googletest/src/googletest/src/gtest-typed-test.cc
which was not found.
___________________
ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
target(_target_type, target_name) {
^----------------------------------
The target:
//third_party/googletest:gtest
has a source file:
//third_party/googletest/src/googletest/src/gtest-internal-inl.h
which was not found.
___________________
ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
target(_target_type, target_name) {
^----------------------------------
The target:
//third_party/googletest:gtest
has a source file:
//third_party/googletest/src/googletest/src/gtest-test-part.cc
which was not found.
___________________
ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
target(_target_type, target_name) {
^----------------------------------
The target:
//third_party/googletest:gtest
has a source file:
//third_party/googletest/src/googletest/src/gtest-assertion-result.cc
which was not found.
___________________
ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
target(_target_type, target_name) {
^----------------------------------
The target:
//third_party/googletest:gtest
has a source file:
//third_party/googletest/src/googletest/src/gtest.cc
which was not found.
___________________
ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
target(_target_type, target_name) {
^----------------------------------
The target:
//third_party/googletest:gtest_main
has a source file:
//third_party/googletest/src/googletest/src/gtest_main.cc
which was not found.
___________________
ERROR at //build/config/BUILDCONFIG.gn:558:5: Source file not found.
target(_target_type, target_name) {
^----------------------------------
The target:
//third_party/googletest:gtest
has a source file:
//third_party/googletest/src/googletest/src/gtest-filepath.cc
which was not found.
___________________
ERROR at //build/config/BUILDCONFIG.gn:648:5: Source file not found.
target(_target_type, _target_name) {
^-----------------------------------
The target:
//third_party/zlib:zlib_bench
has a source file:
//third_party/zlib/contrib/bench/zlib_bench.cc
which was not found.
GN gen failed: 1
Traceback (most recent call last):
File "/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/tools/dev/v8gen.py", line 256, in
Open Graph Description: The Node.js source tree already includes several V8 DEPS under deps/v8/third_party that are needed to build Node.js. Exclude these in tools/v8/fetch_deps.py to prevent "Conflicting directory&q...
X Description: The Node.js source tree already includes several V8 DEPS under deps/v8/third_party that are needed to build Node.js. Exclude these in tools/v8/fetch_deps.py to prevent "Conflicting directo...
Opengraph URL: https://github.com/nodejs/node/pull/60883
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:d56d0122-49ae-9d8f-a0b6-28a69766f987 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A2F2:321C49:3B49D:4E6F7:6A4C1147 |
| html-safe-nonce | be7f3cf67cefd888bbbcf72d5b19a35c9d6616f97b184cbd5a9de7dc6eb200dd |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMkYyOjMyMUM0OTozQjQ5RDo0RTZGNzo2QTRDMTE0NyIsInZpc2l0b3JfaWQiOiIxMjI3NzQ0MzAzNDUyNTI0ODcxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | b55cd3ef414f5f07f7141f740988e79d7d90b47a58493b81994f5a823e06a083 |
| hovercard-subject-tag | pull_request:3054571807 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodejs/node/pull/60883/files |
| twitter:image | https://avatars.githubusercontent.com/u/5445507?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/5445507?s=400&v=4 |
| og:image:alt | The Node.js source tree already includes several V8 DEPS under deps/v8/third_party that are needed to build Node.js. Exclude these in tools/v8/fetch_deps.py to prevent "Conflicting directory&q... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 0ccfc9e5281bfe12e38a4d632dc422843e4d5b6757917f7efda2f6567d72fea9 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 18812876666a23a0912556e224383baa4c84cf8e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width