| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:7a45e701-8193-a194-7ee1-72eab99eddb8 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 832E:312530:8A7207:BCA64B:6A4C861B |
| html-safe-nonce | 18f3b95e3e7951b7ea9ae244a5458609683f7b1bd1e748cb609cf8558c4582a7 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MzJFOjMxMjUzMDo4QTcyMDc6QkNBNjRCOjZBNEM4NjFCIiwidmlzaXRvcl9pZCI6IjU4ODAyOTE1MjQwNDI1ODk3MjMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 206caa625c9bd13e017acf1a7635cf71bd660415bf623d429cc876fb42697722 |
| hovercard-subject-tag | pull_request:3036508692 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/60815/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/b04466a173214e9ae5bece03646cf9ed4280f693e45c78066aeb2d710c59cd4d/nodejs/node/pull/60815 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b04466a173214e9ae5bece03646cf9ed4280f693e45c78066aeb2d710c59cd4d/nodejs/node/pull/60815 |
| og:image:alt | Summary
This PR is to address #60640 . When compiled without amaro, some tests fail. This is because --strip-types option should default to false when compiled without amaro, but it is set to true ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | y-okt |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3d11bb817438277de2a940854450e83a7d32b6aeb5014e9e6b00a6423900251c |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7a2dede45637df6b92ddcfe2a557e67d4b5854ae |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/60815#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F60815 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F60815 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/60815 |
| Reload | https://github.com/nodejs/node/pull/60815 |
| Reload | https://github.com/nodejs/node/pull/60815 |
| Please reload this page | https://github.com/nodejs/node/pull/60815 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/60815 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.4k
| https://github.com/nodejs/node/issues |
|
Pull requests
964
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| y-okt:strip-types-default-amaro | https://github.com/y-okt/node/tree/strip-types-default-amaro |
| Conversation | https://github.com/nodejs/node/pull/60815 |
| Commits9 (9) | https://github.com/nodejs/node/pull/60815/commits |
| Checks | https://github.com/nodejs/node/pull/60815/checks |
| Files changed | https://github.com/nodejs/node/pull/60815/files |
| test: skip failing tests and set the default value of strip-types to false when compiled without amaro | https://github.com/nodejs/node/pull/60815#top |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| y-okt:strip-types-default-amaro | https://github.com/y-okt/node/tree/strip-types-default-amaro |
|
| https://github.com/y-okt |
| y-okt | https://github.com/y-okt |
| Nov 22, 2025 | https://github.com/nodejs/node/pull/60815#issue-3654800821 |
| Please reload this page | https://github.com/nodejs/node/pull/60815 |
| #60640 | https://github.com/nodejs/node/issues/60640 |
| @marco-ippolito | https://github.com/marco-ippolito |
| Amaro | https://github.com/nodejs/amaro |
| code | https://github.com/nodejs/node/blob/fb6b83c9eface51acad916cff365b98aa826f56a/test/parallel/test-runner-global-setup-teardown.mjs#L265 |
| code | https://sourcegraph.com/github.com/nodejs/node/-/blob/test/parallel/test-worker-syntax-error.js?L6 |
| code | https://sourcegraph.com/github.com/nodejs/node/-/blob/lib/internal/main/worker_thread.js?L169 |
| Please reload this page | https://github.com/nodejs/node/pull/60815 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 22, 2025 | https://github.com/nodejs/node/pull/60815#issuecomment-3566817336 |
| Please reload this page | https://github.com/nodejs/node/pull/60815 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
config
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aconfig |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
| Nov 22, 2025 | https://github.com/nodejs/node/pull/60815#event-21115744804 |
| https://github.com/y-okt |
| y-okt | https://github.com/y-okt |
|
Nov 22, 2025
| https://github.com/nodejs/node/pull/60815#ref-issue-3603823716 |
|
--experimental-strip-types default value should depend on --without-amaro configure flag
#60640
| https://github.com/nodejs/node/issues/60640 |
| https://github.com/marco-ippolito |
| marco-ippolito | https://github.com/marco-ippolito |
| Nov 22, 2025 | https://github.com/nodejs/node/pull/60815#issuecomment-3566892670 |
| Please reload this page | https://github.com/nodejs/node/pull/60815 |
| Please reload this page | https://github.com/nodejs/node/pull/60815 |
| https://github.com/apps/codecov |
| codecov | https://github.com/apps/codecov |
| Nov 22, 2025 | https://github.com/nodejs/node/pull/60815#issuecomment-3566944479 |
| Please reload this page | https://github.com/nodejs/node/pull/60815 |
| Codecov | https://app.codecov.io/gh/nodejs/node/pull/60815?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| 08d966c | https://app.codecov.io/gh/nodejs/node/commit/08d966cb657d114db5b939a13f064f4517f35b42?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| c334402 | https://app.codecov.io/gh/nodejs/node/commit/c33440288b9c397d01b4b601d822493f50edd0dd?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| Files with missing lines | https://app.codecov.io/gh/nodejs/node/pull/60815?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| src/node_options.cc | https://app.codecov.io/gh/nodejs/node/pull/60815?src=pr&el=tree&filepath=src%2Fnode_options.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfb3B0aW9ucy5jYw== |
| src/node_options.h | https://app.codecov.io/gh/nodejs/node/pull/60815?src=pr&el=tree&filepath=src%2Fnode_options.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfb3B0aW9ucy5o |
| 32 files with indirect coverage changes | https://app.codecov.io/gh/nodejs/node/pull/60815/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| Test Analytics | https://docs.codecov.com/docs/test-analytics |
| JS Bundle Analysis | https://docs.codecov.com/docs/javascript-bundle-analysis |
| Please reload this page | https://github.com/nodejs/node/pull/60815 |
| https://github.com/kapouer |
| kapouer | https://github.com/kapouer |
| Nov 22, 2025 | https://github.com/nodejs/node/pull/60815#issuecomment-3566989263 |
| Please reload this page | https://github.com/nodejs/node/pull/60815 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Nov 22, 2025
| https://github.com/nodejs/node/pull/60815#pullrequestreview-3496960340 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/60815/files |
| src/node_options.cc | https://github.com/nodejs/node/pull/60815/files#diff-d0b7433f8ca620eba56fc39f79429c73e2b3f061ca6d27583132a37b788b8aa8 |
| Please reload this page | https://github.com/nodejs/node/pull/60815 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
|
Nov 23, 2025
| https://github.com/nodejs/node/pull/60815#pullrequestreview-3497328501 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/60815/files |
| test/es-module/test-esm-import-meta-main-eval.mjs | https://github.com/nodejs/node/pull/60815/files#diff-72224643a1c8ca5378fa6f4d7319ad25bfbd239f89c946d47d690bd1bc336c4b |
| Please reload this page | https://github.com/nodejs/node/pull/60815 |
| test/es-module/test-esm-tla-syntax-errors-not-recognized-as-tla-error.mjs | https://github.com/nodejs/node/pull/60815/files#diff-aba2bcc45fa516d0999b236e26a89855214fd595385a241139abe4b6c6f8cd0b |
| Please reload this page | https://github.com/nodejs/node/pull/60815 |
| https://github.com/piyush-pk |
| piyush-pk | https://github.com/piyush-pk |
|
Nov 23, 2025
| https://github.com/nodejs/node/pull/60815#pullrequestreview-3497503625 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/60815/files |
| src/node_options.cc | https://github.com/nodejs/node/pull/60815/files#diff-d0b7433f8ca620eba56fc39f79429c73e2b3f061ca6d27583132a37b788b8aa8 |
| Please reload this page | https://github.com/nodejs/node/pull/60815 |
| https://github.com/y-okt |
| y-okt | https://github.com/y-okt |
| force-pushed | https://github.com/nodejs/node/compare/a450ee58fd32014e1073e71e88edbc542daf2ec0..3dc852d46647778f92b5afe866d984c234b2789e |
| a450ee5 | https://github.com/nodejs/node/commit/a450ee58fd32014e1073e71e88edbc542daf2ec0 |
| 3dc852d | https://github.com/nodejs/node/commit/3dc852d46647778f92b5afe866d984c234b2789e |
|
Compare
| https://github.com/nodejs/node/compare/a450ee58fd32014e1073e71e88edbc542daf2ec0..3dc852d46647778f92b5afe866d984c234b2789e |
| November 23, 2025 14:32 | https://github.com/nodejs/node/pull/60815#event-21122394416 |
| y-okt | https://github.com/y-okt |
|
Nov 23, 2025
| https://github.com/nodejs/node/pull/60815#ref-commit-e8f2aa5 |
|
| https://github.com/y-okt |
| test: move amaro checks after common import | https://github.com/y-okt/node/commit/e8f2aa5d8f06686680254f415f1a4c15ffa113c9 |
| e8f2aa5 | https://github.com/y-okt/node/commit/e8f2aa5d8f06686680254f415f1a4c15ffa113c9 |
| nodejs#60815 | https://github.com/nodejs/node/pull/60815 |
| https://github.com/y-okt |
| y-okt | https://github.com/y-okt |
| Nov 23, 2025 | https://github.com/nodejs/node/pull/60815#issuecomment-3568020233 |
| Please reload this page | https://github.com/nodejs/node/pull/60815 |
| https://github.com/y-okt |
| y-okt | https://github.com/y-okt |
|
Nov 23, 2025
| https://github.com/nodejs/node/pull/60815#pullrequestreview-3497811550 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/60815/files |
| test/parallel/test-cli-node-options-docs.js | https://github.com/nodejs/node/pull/60815/files#diff-dd340f895a4228c3a69834e804a0e2f4715eda3b1ef9e2f1a7ff94b5bd7c01ae |
| Please reload this page | https://github.com/nodejs/node/pull/60815 |
| https://github.com/y-okt |
| y-okt | https://github.com/y-okt |
| aduh95 | https://github.com/aduh95 |
| anonrig | https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
| November 23, 2025 14:37 | https://github.com/nodejs/node/pull/60815#event-21122414901 |
| https://github.com/marco-ippolito |
| marco-ippolito | https://github.com/marco-ippolito |
|
Nov 23, 2025
| https://github.com/nodejs/node/pull/60815#pullrequestreview-3497822311 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/60815/files |
| test/es-module/test-esm-detect-ambiguous.mjs | https://github.com/nodejs/node/pull/60815/files#diff-967cad211217cd21d040e0f8df6fe04e0d916f03c8d724d04751a1351f5d4da0 |
| Please reload this page | https://github.com/nodejs/node/pull/60815 |
| https://github.com/y-okt |
| y-okt | https://github.com/y-okt |
| marco-ippolito | https://github.com/marco-ippolito |
| November 23, 2025 15:52 | https://github.com/nodejs/node/pull/60815#event-21122824503 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Nov 23, 2025
| https://github.com/nodejs/node/pull/60815#pullrequestreview-3497895075 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/60815/files |
| test/parallel/test-worker-eval-typescript.js | https://github.com/nodejs/node/pull/60815/files#diff-4d7e9c947688920ed2be7f5614c1480fd5e38084bbde622e61210758fb1e3b93 |
| Please reload this page | https://github.com/nodejs/node/pull/60815 |
| https://github.com/marco-ippolito |
| marco-ippolito | https://github.com/marco-ippolito |
| Nov 23, 2025 | https://github.com/nodejs/node/pull/60815#issuecomment-3568168540 |
| #60815 (comment) | https://github.com/nodejs/node/pull/60815#discussion_r2554209239 |
| Please reload this page | https://github.com/nodejs/node/pull/60815 |
| https://github.com/y-okt |
| y-okt | https://github.com/y-okt |
| force-pushed | https://github.com/nodejs/node/compare/3dc852d46647778f92b5afe866d984c234b2789e..332027b9a741573016fa50074e3c6157398036da |
| 3dc852d | https://github.com/nodejs/node/commit/3dc852d46647778f92b5afe866d984c234b2789e |
| 332027b | https://github.com/nodejs/node/commit/332027b9a741573016fa50074e3c6157398036da |
|
Compare
| https://github.com/nodejs/node/compare/3dc852d46647778f92b5afe866d984c234b2789e..332027b9a741573016fa50074e3c6157398036da |
| November 25, 2025 15:23 | https://github.com/nodejs/node/pull/60815#event-21167537422 |
| y-okt | https://github.com/y-okt |
|
Nov 25, 2025
| https://github.com/nodejs/node/pull/60815#ref-commit-c89949a |
|
| https://github.com/y-okt |
| test: move amaro checks after common import | https://github.com/y-okt/node/commit/c89949a270af1043401d56ab99e55f3a45cdc56f |
| c89949a | https://github.com/y-okt/node/commit/c89949a270af1043401d56ab99e55f3a45cdc56f |
| nodejs#60815 | https://github.com/nodejs/node/pull/60815 |
| y-okt | https://github.com/y-okt |
|
Nov 25, 2025
| https://github.com/nodejs/node/pull/60815#ref-commit-5e30dbf |
|
| https://github.com/y-okt |
| src: make the default value of strip_types AMARO | https://github.com/y-okt/node/commit/5e30dbfed8919020e6d359c4fb73ced330665350 |
| 5e30dbf | https://github.com/y-okt/node/commit/5e30dbfed8919020e6d359c4fb73ced330665350 |
| nodejs#60815 | https://github.com/nodejs/node/pull/60815 |
| y-okt | https://github.com/y-okt |
|
Nov 25, 2025
| https://github.com/nodejs/node/pull/60815#ref-commit-332027b |
|
| https://github.com/y-okt |
| test: include passing tests from skip list | https://github.com/y-okt/node/commit/332027b9a741573016fa50074e3c6157398036da |
| 332027b | https://github.com/y-okt/node/commit/332027b9a741573016fa50074e3c6157398036da |
| nodejs#60815 | https://github.com/nodejs/node/pull/60815 |
| https://github.com/y-okt |
| y-okt | https://github.com/y-okt |
| Nov 25, 2025 | https://github.com/nodejs/node/pull/60815#issuecomment-3576230439 |
| @marco-ippolito | https://github.com/marco-ippolito |
| @aduh95 | https://github.com/aduh95 |
| Please reload this page | https://github.com/nodejs/node/pull/60815 |
| https://github.com/y-okt |
| y-okt | https://github.com/y-okt |
| aduh95 | https://github.com/aduh95 |
| November 25, 2025 15:25 | https://github.com/nodejs/node/pull/60815#event-21167585163 |
| https://github.com/marco-ippolito |
| marco-ippolito | https://github.com/marco-ippolito |
|
Nov 25, 2025
| https://github.com/nodejs/node/pull/60815#pullrequestreview-3505633991 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/60815/files |
| test/es-module/test-esm-detect-ambiguous.mjs | https://github.com/nodejs/node/pull/60815/files#diff-967cad211217cd21d040e0f8df6fe04e0d916f03c8d724d04751a1351f5d4da0 |
| Please reload this page | https://github.com/nodejs/node/pull/60815 |
| y-okt | https://github.com/y-okt |
| November 28, 2025 21:48 | https://github.com/nodejs/node/pull/60815#commits-pushed-2d43230 |
|
| https://github.com/y-okt |
| test: move amaro checks after common import | https://github.com/nodejs/node/pull/60815/commits/2d43230c4e6fc5546ff8fc356e347ed82e9149af |
| 2d43230 | https://github.com/nodejs/node/pull/60815/commits/2d43230c4e6fc5546ff8fc356e347ed82e9149af |
| nodejs#60815 | https://github.com/nodejs/node/pull/60815 |
|
| https://github.com/y-okt |
| test: add workaround for the node-options-doc test to make the pipeli… | https://github.com/nodejs/node/pull/60815/commits/b192c6b93332563ab5b86494e9e52f509ac8ba8b |
| b192c6b | https://github.com/nodejs/node/pull/60815/commits/b192c6b93332563ab5b86494e9e52f509ac8ba8b |
| nodejs#60640 | https://github.com/nodejs/node/issues/60640 |
|
| https://github.com/y-okt |
| src: make the default value of strip_types AMARO | https://github.com/nodejs/node/pull/60815/commits/339fc203063590d7d307f4b6e7e0c838542f14b1 |
| 339fc20 | https://github.com/nodejs/node/pull/60815/commits/339fc203063590d7d307f4b6e7e0c838542f14b1 |
| nodejs#60815 | https://github.com/nodejs/node/pull/60815 |
|
| https://github.com/y-okt |
| test: include passing tests from skip list | https://github.com/nodejs/node/pull/60815/commits/a290baffb14d321aa41a5f20d80629088720e189 |
| a290baf | https://github.com/nodejs/node/pull/60815/commits/a290baffb14d321aa41a5f20d80629088720e189 |
| nodejs#60815 | https://github.com/nodejs/node/pull/60815 |
|
| https://github.com/y-okt |
| test: fix linting and remove unnecessary space changes | https://github.com/nodejs/node/pull/60815/commits/138865010b4cd32b81c8a67f08d1c8f504ea1685 |
| 1388650 | https://github.com/nodejs/node/pull/60815/commits/138865010b4cd32b81c8a67f08d1c8f504ea1685 |
| nodejs#60815 | https://github.com/nodejs/node/pull/60815 |
|
| https://github.com/y-okt |
| test: fix spacing issue | https://github.com/nodejs/node/pull/60815/commits/5a746fd997e118e8a467223f1edf6b0284f064e2 |
| 5a746fd | https://github.com/nodejs/node/pull/60815/commits/5a746fd997e118e8a467223f1edf6b0284f064e2 |
| nodejs#60815 | https://github.com/nodejs/node/pull/60815 |
|
| https://github.com/y-okt |
| test: skip test-compile-cache-typescript tests | https://github.com/nodejs/node/pull/60815/commits/c33440288b9c397d01b4b601d822493f50edd0dd |
| c334402 | https://github.com/nodejs/node/pull/60815/commits/c33440288b9c397d01b4b601d822493f50edd0dd |
| nodejs#60815 | https://github.com/nodejs/node/pull/60815 |
| https://github.com/y-okt |
| y-okt | https://github.com/y-okt |
| force-pushed | https://github.com/nodejs/node/compare/a004bf5670329fb4660061ac40ce5012c7258c6a..c33440288b9c397d01b4b601d822493f50edd0dd |
| a004bf5 | https://github.com/nodejs/node/commit/a004bf5670329fb4660061ac40ce5012c7258c6a |
| c334402 | https://github.com/nodejs/node/commit/c33440288b9c397d01b4b601d822493f50edd0dd |
|
Compare
| https://github.com/nodejs/node/compare/a004bf5670329fb4660061ac40ce5012c7258c6a..c33440288b9c397d01b4b601d822493f50edd0dd |
| November 28, 2025 12:48 | https://github.com/nodejs/node/pull/60815#event-21242081640 |
| https://github.com/y-okt |
| y-okt | https://github.com/y-okt |
| Nov 28, 2025 | https://github.com/nodejs/node/pull/60815#issuecomment-3589229053 |
| @aduh95 | https://github.com/aduh95 |
| Please reload this page | https://github.com/nodejs/node/pull/60815 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Nov 28, 2025
| https://github.com/nodejs/node/pull/60815#pullrequestreview-3519050810 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/60815/files/c33440288b9c397d01b4b601d822493f50edd0dd |
| aduh95 | https://github.com/aduh95 |
| https://github.com/nodejs/node/pull/60815#pullrequestreview-3519050810 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/60815 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
|
commit-queue-squash
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash |
| Nov 28, 2025 | https://github.com/nodejs/node/pull/60815#event-21242955050 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Nov 28, 2025 | https://github.com/nodejs/node/pull/60815#event-21243030467 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 28, 2025 | https://github.com/nodejs/node/pull/60815#issuecomment-3589401914 |
| https://ci.nodejs.org/job/node-test-pull-request/70336/ | https://ci.nodejs.org/job/node-test-pull-request/70336/ |
| Please reload this page | https://github.com/nodejs/node/pull/60815 |
| https://github.com/marco-ippolito |
| marco-ippolito | https://github.com/marco-ippolito |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Nov 28, 2025 | https://github.com/nodejs/node/pull/60815#event-21244754979 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Nov 28, 2025 | https://github.com/nodejs/node/pull/60815#event-21244778452 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| d09c3ff | https://github.com/nodejs/node/commit/d09c3ffb7ca85606d491e51ff15b11416a4f85a6 |
| Nov 28, 2025 | https://github.com/nodejs/node/pull/60815#event-21244800921 |
| Please reload this page | https://github.com/nodejs/node/pull/60815 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 28, 2025 | https://github.com/nodejs/node/pull/60815#issuecomment-3589747663 |
| d09c3ff | https://github.com/nodejs/node/commit/d09c3ffb7ca85606d491e51ff15b11416a4f85a6 |
| Please reload this page | https://github.com/nodejs/node/pull/60815 |
| targos | https://github.com/targos |
|
Nov 29, 2025
| https://github.com/nodejs/node/pull/60815#ref-commit-52f73c2 |
|
| https://github.com/y-okt |
|
| https://github.com/targos |
| test: skip failing tests when compiled without amaro | https://github.com/nodejs/node/commit/52f73c23df52ff40fe60ef8b02b204a36af513d4 |
| 52f73c2 | https://github.com/nodejs/node/commit/52f73c23df52ff40fe60ef8b02b204a36af513d4 |
| #60640 | https://github.com/nodejs/node/issues/60640 |
| #60815 | https://github.com/nodejs/node/pull/60815 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
lts-watch-v22.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v22.x |
| Nov 30, 2025 | https://github.com/nodejs/node/pull/60815#event-21255290962 |
| aduh95 | https://github.com/aduh95 |
|
Jan 9, 2026
| https://github.com/nodejs/node/pull/60815#ref-commit-3cef24c |
|
| https://github.com/y-okt |
|
| https://github.com/aduh95 |
| test: skip failing tests when compiled without amaro | https://github.com/nodejs/node/commit/3cef24ca55baa016fa6bab86fad47b6da209a7a9 |
| 3cef24c | https://github.com/nodejs/node/commit/3cef24ca55baa016fa6bab86fad47b6da209a7a9 |
| #60640 | https://github.com/nodejs/node/issues/60640 |
| #60815 | https://github.com/nodejs/node/pull/60815 |
| RafaelGSS | https://github.com/RafaelGSS |
|
Jan 13, 2026
| https://github.com/nodejs/node/pull/60815#ref-commit-8caeb03 |
|
| https://github.com/y-okt |
|
| https://github.com/RafaelGSS |
| test: skip failing tests when compiled without amaro | https://github.com/nodejs/node/commit/8caeb03a52842774291d666d8ad0a1660a62b24a |
| 8caeb03 | https://github.com/nodejs/node/commit/8caeb03a52842774291d666d8ad0a1660a62b24a |
| #60640 | https://github.com/nodejs/node/issues/60640 |
| #60815 | https://github.com/nodejs/node/pull/60815 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
Jan 16, 2026
| https://github.com/nodejs/node/pull/60815#ref-pullrequest-3822224144 |
|
2026-01-19, Version 25.4.0 (Current)
#61400
| https://github.com/nodejs/node/pull/61400 |
| aduh95 | https://github.com/aduh95 |
|
Jan 19, 2026
| https://github.com/nodejs/node/pull/60815#ref-commit-163c17d |
|
| https://github.com/y-okt |
|
| https://github.com/aduh95 |
| test: skip failing tests when compiled without amaro | https://github.com/nodejs/node/commit/163c17de51d65cc6f84a0bd8c62022320564bb89 |
| 163c17d | https://github.com/nodejs/node/commit/163c17de51d65cc6f84a0bd8c62022320564bb89 |
| #60640 | https://github.com/nodejs/node/issues/60640 |
| #60815 | https://github.com/nodejs/node/pull/60815 |
| tmeijn | https://github.com/tmeijn |
|
Jan 22, 2026
| https://github.com/nodejs/node/pull/60815#ref-commit-d3d819e |
|
| https://github.com/tmeijn |
| build(deps): update node to v25.4.0 | https://github.com/tmeijn/dotfiles/commit/d3d819e37760131eb0853233a474780d24051202 |
| d3d819e | https://github.com/tmeijn/dotfiles/commit/d3d819e37760131eb0853233a474780d24051202 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
Feb 3, 2026
| https://github.com/nodejs/node/pull/60815#ref-pullrequest-3892697171 |
|
2026-02-10, Version 24.13.1 'Krypton' (LTS)
#61661
| https://github.com/nodejs/node/pull/61661 |
| aduh95 | https://github.com/aduh95 |
|
Feb 17, 2026
| https://github.com/nodejs/node/pull/60815#ref-commit-d4a2d8a |
|
| https://github.com/y-okt |
|
| https://github.com/aduh95 |
| test: skip failing tests when compiled without amaro | https://github.com/nodejs/node/commit/d4a2d8aa8a2c95cdac1cce2b63e36ba035c56683 |
| d4a2d8a | https://github.com/nodejs/node/commit/d4a2d8aa8a2c95cdac1cce2b63e36ba035c56683 |
| #60640 | https://github.com/nodejs/node/issues/60640 |
| #60815 | https://github.com/nodejs/node/pull/60815 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Feb 22, 2026
| https://github.com/nodejs/node/pull/60815#ref-pullrequest-3975660233 |
|
V22.22.1 proposal
#61947
| https://github.com/nodejs/node/pull/61947 |
| https://github.com/marco-ippolito |
| marco-ippolito | https://github.com/marco-ippolito |
|
lts-watch-v22.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v22.x |
| Apr 27, 2026 | https://github.com/nodejs/node/pull/60815#event-24913838233 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F60815 |
|
| https://github.com/aduh95 |
|
aduh95
| https://github.com/aduh95 |
|
| https://github.com/nodejs/node/pull/60815/files/c33440288b9c397d01b4b601d822493f50edd0dd |
|
| https://github.com/marco-ippolito |
|
marco-ippolito
| https://github.com/marco-ippolito |
|
| https://github.com/nodejs/node/pull/60815/files/a004bf5670329fb4660061ac40ce5012c7258c6a |
|
| https://github.com/anonrig |
|
anonrig
| https://github.com/anonrig |
|
| https://github.com/piyush-pk |
|
piyush-pk
| https://github.com/piyush-pk |
|
| https://github.com/nodejs/node/pull/60815/files/a450ee58fd32014e1073e71e88edbc542daf2ec0 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
commit-queue-squash
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash |
|
config
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aconfig |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
| Please reload this page | https://github.com/nodejs/node/pull/60815 |
|
| https://github.com/y-okt |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/marco-ippolito |
|
| https://github.com/kapouer |
|
| https://github.com/aduh95 |
|
| https://github.com/anonrig |
|
| https://github.com/piyush-pk |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |