René's URL Explorer Experiment


Title: src: fix off-thread cert loading in bundled cert mode by joyeecheung · Pull Request #60764 · nodejs/node · GitHub

Open Graph Title: src: fix off-thread cert loading in bundled cert mode by joyeecheung · Pull Request #60764 · nodejs/node

X Title: src: fix off-thread cert loading in bundled cert mode by joyeecheung · Pull Request #60764 · nodejs/node

Description: https://redirect.github.com/nodejs/node/pull/59856 had an typo/mistake in the skip conditions so that it is skipping when --use-openssl-ca or --openssl-system-ca-path (configure time) are NOT used, even though they should be skipped only when those ARE used (which is not the default for default builds). This change fixes that so that the perf numbers in that PR is true for the default build. Thanks @deepak1556 for catching it!

Open Graph Description: https://redirect.github.com/nodejs/node/pull/59856 had an typo/mistake in the skip conditions so that it is skipping when --use-openssl-ca or --openssl-system-ca-path (configure time) are NOT used,...

X Description: https://redirect.github.com/nodejs/node/pull/59856 had an typo/mistake in the skip conditions so that it is skipping when --use-openssl-ca or --openssl-system-ca-path (configure time) are NOT used,...

Opengraph URL: https://github.com/nodejs/node/pull/60764

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:e040d465-c5fb-69bf-8864-e9aefe996a71
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAA08:3B09FF:A9FBE:F7302:6A4D0236
html-safe-nonceb6a5a390513ce2f5644b98ee86dccd642079b779912d81acc9d27d3e8e8ac94a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQTA4OjNCMDlGRjpBOUZCRTpGNzMwMjo2QTREMDIzNiIsInZpc2l0b3JfaWQiOiI4ODg3OTMzMDEyOTI3NDUyNzAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacadab3d3601082db52f787007f9328d34a6d80c17d08ca531a2c40d5ba11eba09
hovercard-subject-tagpull_request:3019911630
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/60764/files
twitter:imagehttps://avatars.githubusercontent.com/u/4299420?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4299420?s=400&v=4
og:image:althttps://redirect.github.com/nodejs/node/pull/59856 had an typo/mistake in the skip conditions so that it is skipping when --use-openssl-ca or --openssl-system-ca-path (configure time) are NOT used,...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None31e4db13a9e20081f2fac78f441659a6576e582bbb15e153f9c7fb6473aa29f5
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasefb70bd3c4b2bec429781b65419e912c66e2d5581
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/60764/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F60764%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F60764%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/60764/files
Reloadhttps://github.com/nodejs/node/pull/60764/files
Reloadhttps://github.com/nodejs/node/pull/60764/files
Please reload this pagehttps://github.com/nodejs/node/pull/60764/files
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/60764/files
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 957 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
joyeecheung:fix-off-thread-cryptohttps://github.com/joyeecheung/node/tree/fix-off-thread-crypto
Conversation 10 https://github.com/nodejs/node/pull/60764
Commits 1 https://github.com/nodejs/node/pull/60764/commits
Checks 38 https://github.com/nodejs/node/pull/60764/checks
Files changed https://github.com/nodejs/node/pull/60764/files
Please reload this pagehttps://github.com/nodejs/node/pull/60764/files
src: fix off-thread cert loading in bundled cert mode https://github.com/nodejs/node/pull/60764/files#top
Show all changes 1 commit https://github.com/nodejs/node/pull/60764/files
cae0df4 src: fix off-thread cert loading in bundled cert mode joyeecheung Nov 18, 2025 https://github.com/nodejs/node/pull/60764/commits/cae0df46e84532a51cc949e2c7da277ac981840a
Clear filters https://github.com/nodejs/node/pull/60764/files
Please reload this pagehttps://github.com/nodejs/node/pull/60764/files
Please reload this pagehttps://github.com/nodejs/node/pull/60764/files
crypto_context.cc https://github.com/nodejs/node/pull/60764/files#diff-3a010f7fadf05b30c9e223628e2bacd54df3404fa83a8d280158fe639494bb5a
tls.js https://github.com/nodejs/node/pull/60764/files#diff-64ae68ab367a11d4bf74d6142d959a94f5976373499a3668f683fce9b4a9cb40
list-certs.js https://github.com/nodejs/node/pull/60764/files#diff-7b083c41fb590775c621a0410b6ff87207560cfef634bd312d140f913a5d6da0
test-tls-off-thread-cert-loading-disabled.js https://github.com/nodejs/node/pull/60764/files#diff-7279fcd753288782c9cd322e38a5477762913b5c29e2f6e35728d685fe703411
test-tls-off-thread-cert-loading-system.js https://github.com/nodejs/node/pull/60764/files#diff-9cdb68c64dfae2c71b796ed8d48cae83b846a6523ef70c075415ac0271f741a0
test-tls-off-thread-cert-loading.js https://github.com/nodejs/node/pull/60764/files#diff-ae98b8b64496870400246442b3520ff17e27a86551b6106a347d99a47bcb29ca
src/crypto/crypto_context.cchttps://github.com/nodejs/node/pull/60764/files#diff-3a010f7fadf05b30c9e223628e2bacd54df3404fa83a8d280158fe639494bb5a
View file https://github.com/joyeecheung/node/blob/cae0df46e84532a51cc949e2c7da277ac981840a/src/crypto/crypto_context.cc
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/60764/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/60764/files#diff-3a010f7fadf05b30c9e223628e2bacd54df3404fa83a8d280158fe639494bb5a
anonrighttps://github.com/anonrig
Nov 23, 2025https://github.com/nodejs/node/pull/60764/files#r2553716223
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/60764/files
joyeecheunghttps://github.com/joyeecheung
Nov 25, 2025https://github.com/nodejs/node/pull/60764/files#r2558126193
Please reload this pagehttps://github.com/nodejs/node/pull/60764/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/60764/files
https://github.com/nodejs/node/pull/60764/files#diff-3a010f7fadf05b30c9e223628e2bacd54df3404fa83a8d280158fe639494bb5a
test/common/tls.jshttps://github.com/nodejs/node/pull/60764/files#diff-64ae68ab367a11d4bf74d6142d959a94f5976373499a3668f683fce9b4a9cb40
View file https://github.com/joyeecheung/node/blob/cae0df46e84532a51cc949e2c7da277ac981840a/test/common/tls.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/60764/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/60764/files#diff-64ae68ab367a11d4bf74d6142d959a94f5976373499a3668f683fce9b4a9cb40
https://github.com/nodejs/node/pull/60764/files#diff-64ae68ab367a11d4bf74d6142d959a94f5976373499a3668f683fce9b4a9cb40
test/fixtures/list-certs.jshttps://github.com/nodejs/node/pull/60764/files#diff-7b083c41fb590775c621a0410b6ff87207560cfef634bd312d140f913a5d6da0
View file https://github.com/joyeecheung/node/blob/cae0df46e84532a51cc949e2c7da277ac981840a/test/fixtures/list-certs.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/60764/{{ revealButtonHref }}
test/parallel/test-tls-off-thread-cert-loading-disabled.jshttps://github.com/nodejs/node/pull/60764/files#diff-7279fcd753288782c9cd322e38a5477762913b5c29e2f6e35728d685fe703411
View file https://github.com/joyeecheung/node/blob/cae0df46e84532a51cc949e2c7da277ac981840a/test/parallel/test-tls-off-thread-cert-loading-disabled.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/60764/{{ revealButtonHref }}
test/parallel/test-tls-off-thread-cert-loading-system.jshttps://github.com/nodejs/node/pull/60764/files#diff-9cdb68c64dfae2c71b796ed8d48cae83b846a6523ef70c075415ac0271f741a0
View file https://github.com/joyeecheung/node/blob/cae0df46e84532a51cc949e2c7da277ac981840a/test/parallel/test-tls-off-thread-cert-loading-system.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/60764/{{ revealButtonHref }}
test/parallel/test-tls-off-thread-cert-loading.jshttps://github.com/nodejs/node/pull/60764/files#diff-ae98b8b64496870400246442b3520ff17e27a86551b6106a347d99a47bcb29ca
View file https://github.com/joyeecheung/node/blob/cae0df46e84532a51cc949e2c7da277ac981840a/test/parallel/test-tls-off-thread-cert-loading.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/60764/{{ revealButtonHref }}
Please reload this pagehttps://github.com/nodejs/node/pull/60764/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.