Title: url: remove array.reduce usage to make inspect faster by gurgunday · Pull Request #60748 · nodejs/node · GitHub
Open Graph Title: url: remove array.reduce usage to make inspect faster by gurgunday · Pull Request #60748 · nodejs/node
X Title: url: remove array.reduce usage to make inspect faster by gurgunday · Pull Request #60748 · nodejs/node
Description: branch: url/url-searchparams-inspect.js url/url-searchparams-inspect.js n=100000 kind="params" variant="empty": 4,532,381.098194127 url/url-searchparams-inspect.js n=100000 kind="iterator-keys" variant="empty": 1,515,353.3785894632 url/url-searchparams-inspect.js n=100000 kind="iterator-values" variant="empty": 1,492,998.7614679476 url/url-searchparams-inspect.js n=100000 kind="iterator-entries" variant="empty": 1,450,254.4522195323 url/url-searchparams-inspect.js n=100000 kind="params" variant="small": 403,675.9409357187 url/url-searchparams-inspect.js n=100000 kind="iterator-keys" variant="small": 427,352.2536421096 url/url-searchparams-inspect.js n=100000 kind="iterator-values" variant="small": 420,388.7130120308 url/url-searchparams-inspect.js n=100000 kind="iterator-entries" variant="small": 207,149.16684729385 url/url-searchparams-inspect.js n=100000 kind="params" variant="medium": 78,324.92739345282 url/url-searchparams-inspect.js n=100000 kind="iterator-keys" variant="medium": 103,255.19317270137 url/url-searchparams-inspect.js n=100000 kind="iterator-values" variant="medium": 105,868.77834677565 url/url-searchparams-inspect.js n=100000 kind="iterator-entries" variant="medium": 42,676.903041653466 url/url-searchparams-inspect.js n=100000 kind="params" variant="large": 10,407.476332765786 url/url-searchparams-inspect.js n=100000 kind="iterator-keys" variant="large": 15,924.216229468899 url/url-searchparams-inspect.js n=100000 kind="iterator-values" variant="large": 15,842.239285517238 url/url-searchparams-inspect.js n=100000 kind="iterator-entries" variant="large": 6,287.244407894947 main: url/url-searchparams-inspect.js url/url-searchparams-inspect.js n=100000 kind="params" variant="empty": 4,141,001.0870127855 url/url-searchparams-inspect.js n=100000 kind="iterator-keys" variant="empty": 1,456,942.7876779065 url/url-searchparams-inspect.js n=100000 kind="iterator-values" variant="empty": 975,149.1432105592 url/url-searchparams-inspect.js n=100000 kind="iterator-entries" variant="empty": 1,385,660.492394456 url/url-searchparams-inspect.js n=100000 kind="params" variant="small": 382,729.5216981326 url/url-searchparams-inspect.js n=100000 kind="iterator-keys" variant="small": 402,301.29698277207 url/url-searchparams-inspect.js n=100000 kind="iterator-values" variant="small": 403,590.5432681854 url/url-searchparams-inspect.js n=100000 kind="iterator-entries" variant="small": 197,061.3393303881 url/url-searchparams-inspect.js n=100000 kind="params" variant="medium": 78,651.96299050128 url/url-searchparams-inspect.js n=100000 kind="iterator-keys" variant="medium": 101,996.0845906241 url/url-searchparams-inspect.js n=100000 kind="iterator-values" variant="medium": 101,739.53835371115 url/url-searchparams-inspect.js n=100000 kind="iterator-entries" variant="medium": 41,671.14631489552 url/url-searchparams-inspect.js n=100000 kind="params" variant="large": 9,892.61944926823 url/url-searchparams-inspect.js n=100000 kind="iterator-keys" variant="large": 15,148.689404508617 url/url-searchparams-inspect.js n=100000 kind="iterator-values" variant="large": 15,377.710695515232 url/url-searchparams-inspect.js n=100000 kind="iterator-entries" variant="large": 5,952.288479327792 Reduce is slow, we should prefer iteration
Open Graph Description: branch: url/url-searchparams-inspect.js url/url-searchparams-inspect.js n=100000 kind="params" variant="empty": 4,532,381.098194127 url/url-searchparams-inspect.js n=100000 kind...
X Description: branch: url/url-searchparams-inspect.js url/url-searchparams-inspect.js n=100000 kind="params" variant="empty": 4,532,381.098194127 url/url-searchparams-inspect....
Opengraph URL: https://github.com/nodejs/node/pull/60748
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:7ab158cb-cdea-2933-e173-979fc445bd55 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | EB36:6E493:CDC753:11434DE:6A4C593F |
| html-safe-nonce | 244c6b9caa5dedc337def51d2dad4b22abfa7210b6e68af3b038e80779077fbe |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQjM2OjZFNDkzOkNEQzc1MzoxMTQzNERFOjZBNEM1OTNGIiwidmlzaXRvcl9pZCI6IjY2NTMwNTczNDYwNzI5NjgzMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 0603dd8af2ae2a03e77243009f939d6f906c153a3c3d845587a83851f5d9df84 |
| hovercard-subject-tag | pull_request:3015076002 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodejs/node/pull/60748/files |
| twitter:image | https://avatars.githubusercontent.com/u/74139498?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/74139498?s=400&v=4 |
| og:image:alt | branch: url/url-searchparams-inspect.js url/url-searchparams-inspect.js n=100000 kind="params" variant="empty": 4,532,381.098194127 url/url-searchparams-inspect.js n=100000 kind... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3d11bb817438277de2a940854450e83a7d32b6aeb5014e9e6b00a6423900251c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 14099438da5379150f15a2892474c7c7e6c0e55e |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width