Title: http,https: fix double ERR_PROXY_TUNNEL emission by islandryu · Pull Request #60699 · nodejs/node · GitHub
Open Graph Title: http,https: fix double ERR_PROXY_TUNNEL emission by islandryu · Pull Request #60699 · nodejs/node
X Title: http,https: fix double ERR_PROXY_TUNNEL emission by islandryu · Pull Request #60699 · nodejs/node
Description: Fixes: #60697 Like the issue reporter, I think proxy-related errors should be handled only by the proxy logic. Otherwise, the same root cause can lead to duplicate errors. However, there may be cases where an error should also be emitted from within onSocket that I might be overlooking.
Open Graph Description: Fixes: #60697 Like the issue reporter, I think proxy-related errors should be handled only by the proxy logic. Otherwise, the same root cause can lead to duplicate errors. However, there may be cas...
X Description: Fixes: #60697 Like the issue reporter, I think proxy-related errors should be handled only by the proxy logic. Otherwise, the same root cause can lead to duplicate errors. However, there may be cas...
Opengraph URL: https://github.com/nodejs/node/pull/60699
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:d0efedfc-c841-1c63-7b5f-3498a4f91c77 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 97E6:374E1E:708B95:9C4539:6A4C905C |
| html-safe-nonce | 769e13a7e0519a99e91eea5b3ea99bea4103430c5c2b3b7de704307b39569268 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5N0U2OjM3NEUxRTo3MDhCOTU6OUM0NTM5OjZBNEM5MDVDIiwidmlzaXRvcl9pZCI6IjIyMDc2NDcxMDA2OTQyMDQ1MDgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 8c16174defd39c9db75e6ce12f4afc1a0122014ff228144630df84c35a5057c0 |
| hovercard-subject-tag | pull_request:3006141353 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodejs/node/pull/60699/files |
| twitter:image | https://avatars.githubusercontent.com/u/65934663?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/65934663?s=400&v=4 |
| og:image:alt | Fixes: #60697 Like the issue reporter, I think proxy-related errors should be handled only by the proxy logic. Otherwise, the same root cause can lead to duplicate errors. However, there may be cas... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3d11bb817438277de2a940854450e83a7d32b6aeb5014e9e6b00a6423900251c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7a2dede45637df6b92ddcfe2a557e67d4b5854ae |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width