Title: esm: use wasm version of cjs-module-lexer by joyeecheung · Pull Request #60663 · nodejs/node · GitHub
Open Graph Title: esm: use wasm version of cjs-module-lexer by joyeecheung · Pull Request #60663 · nodejs/node
X Title: esm: use wasm version of cjs-module-lexer by joyeecheung · Pull Request #60663 · nodejs/node
Description: benchmark: use typescript for import cjs benchmark The original benchmark uses a not very realistic fixture (it has a huge try-catch block that would throw on the first line and then export at the end, hardly representative of real-world code). Also, it measures the entire import including evaluation, not just parsing. This updates the name to import-cjs to be more accurate, and use the typescript.js as the fixture which has been reported to be slow to import, leading users to use require() to work around the peformance impact. It splits the measurement into two different types: parsing CJS for the first time (where the overhead of loading the lexer makes a difference) and parsing CJS after the lexer has been loaded. esm: use wasm version of cjs-module-lexer The synchronous version has been available since 1.4.0. Refs: #59913 confidence improvement accuracy (*) (**) (***) esm/import-cjs.js type='cold' *** 22.09 % ±3.65% ±5.00% ±6.81% esm/import-cjs.js type='warm' *** -3.93 % ±1.69% ±2.29% ±3.06%
Open Graph Description: benchmark: use typescript for import cjs benchmark The original benchmark uses a not very realistic fixture (it has a huge try-catch block that would throw on the first line and then export at the ...
X Description: benchmark: use typescript for import cjs benchmark The original benchmark uses a not very realistic fixture (it has a huge try-catch block that would throw on the first line and then export at the ...
Opengraph URL: https://github.com/nodejs/node/pull/60663
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:8baba256-e56f-dc45-c65f-d4a834f914d8 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A906:1E79:4FCCB0:735D66:6A4CE6A8 |
| html-safe-nonce | c452a8ae537ca344875fef51364280a9db1c85586ba035109e87102862cbfe77 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOTA2OjFFNzk6NEZDQ0IwOjczNUQ2Njo2QTRDRTZBOCIsInZpc2l0b3JfaWQiOiI1OTAxNzMwNTI3NjEwNDYzOTEyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 2fcffb861f01591b4adc38b9c1b03cfc557aed266eec47a7b12360f4cc59cce1 |
| hovercard-subject-tag | pull_request:2995155746 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodejs/node/pull/60663/files |
| twitter:image | https://avatars.githubusercontent.com/u/4299420?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/4299420?s=400&v=4 |
| og:image:alt | benchmark: use typescript for import cjs benchmark The original benchmark uses a not very realistic fixture (it has a huge try-catch block that would throw on the first line and then export at the ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 299b43bca6e02ad35197ffeba30d2466846d5fb02ab96fbced5b5e6cec589fb8 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | c5a57f04eeb310f57c73fd6d751d957e2ca27ed2 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width