René's URL Explorer Experiment


Title: http: fix drain event with cork/uncork in ServerResponse by ThierryMT · Pull Request #60437 · nodejs/node · GitHub

Open Graph Title: http: fix drain event with cork/uncork in ServerResponse by ThierryMT · Pull Request #60437 · nodejs/node

X Title: http: fix drain event with cork/uncork in ServerResponse by ThierryMT · Pull Request #60437 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes #60432 When using cork() and uncork() with ServerResponse, the drain event was not reliably emitted after uncorking. This occurred because the uncork() method did not check if a drain was pen...

X Description: Fixes #60432 When using cork() and uncork() with ServerResponse, the drain event was not reliably emitted after uncorking. This occurred because the uncork() method did not check if a drain was pen...

Opengraph URL: https://github.com/nodejs/node/pull/60437

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:00ed631d-20b6-2a5b-c739-732b6faf413c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCD9C:1CB5C6:EB8226:1402AEB:6A4D5F97
html-safe-nonceb7becf063e084ff18d1569431e6cc340260e82d9f83c25c5d3334b1480b8ea9f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRDlDOjFDQjVDNjpFQjgyMjY6MTQwMkFFQjo2QTRENUY5NyIsInZpc2l0b3JfaWQiOiIzOTMwOTc5NzExNDg0NTE4Mjk2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac901404b1f5ab5770c4096ecf5732c9d2e9114d8f147e177931a75c8bd5414c12
hovercard-subject-tagpull_request:2951544601
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/60437/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/19508f0829e0728273149a92f130ac35ee17faf16d6d1caa3d440fbc8ef97dcb/nodejs/node/pull/60437
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/19508f0829e0728273149a92f130ac35ee17faf16d6d1caa3d440fbc8ef97dcb/nodejs/node/pull/60437
og:image:altFixes #60432 When using cork() and uncork() with ServerResponse, the drain event was not reliably emitted after uncorking. This occurred because the uncork() method did not check if a drain was pen...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameThierryMT
hostnamegithub.com
expected-hostnamegithub.com
Nonee6658d7c7808aeed776f841e0839b885fce343c9b96244be612c779298e7661e
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasea438513d3a22ffcd713795ed948c3e5525007665
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/60437#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F60437
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F60437
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/60437
Reloadhttps://github.com/nodejs/node/pull/60437
Reloadhttps://github.com/nodejs/node/pull/60437
Please reload this pagehttps://github.com/nodejs/node/pull/60437
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/60437
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 960 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
ThierryMThttps://github.com/ThierryMT
nodejs:mainhttps://github.com/nodejs/node/tree/main
ThierryMT:fix-drain-event-cork-uncorkhttps://github.com/ThierryMT/node/tree/fix-drain-event-cork-uncork
Conversationhttps://github.com/nodejs/node/pull/60437
Commits2 (2)https://github.com/nodejs/node/pull/60437/commits
Checkshttps://github.com/nodejs/node/pull/60437/checks
Files changedhttps://github.com/nodejs/node/pull/60437/files
http: fix drain event with cork/uncork in ServerResponsehttps://github.com/nodejs/node/pull/60437#top
ThierryMThttps://github.com/ThierryMT
nodejs:mainhttps://github.com/nodejs/node/tree/main
ThierryMT:fix-drain-event-cork-uncorkhttps://github.com/ThierryMT/node/tree/fix-drain-event-cork-uncork
https://github.com/ThierryMT
ThierryMThttps://github.com/ThierryMT
Oct 27, 2025https://github.com/nodejs/node/pull/60437#issue-3557397529
#60432https://github.com/nodejs/node/issues/60432
Please reload this pagehttps://github.com/nodejs/node/pull/60437
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 27, 2025https://github.com/nodejs/node/pull/60437#issuecomment-3451956577
Please reload this pagehttps://github.com/nodejs/node/pull/60437
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Oct 27, 2025https://github.com/nodejs/node/pull/60437#event-20529140882
https://github.com/mcollina
mcollinahttps://github.com/mcollina
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Oct 27, 2025https://github.com/nodejs/node/pull/60437#event-20530731947
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Oct 27, 2025 https://github.com/nodejs/node/pull/60437#pullrequestreview-3384465693
View reviewed changes https://github.com/nodejs/node/pull/60437/files/972f7330d38da9469ac36a013c6128e39c6f612f
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/60437#pullrequestreview-3384465693
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/60437
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Oct 27, 2025https://github.com/nodejs/node/pull/60437#issuecomment-3452294316
@ThierryMThttps://github.com/ThierryMT
Please reload this pagehttps://github.com/nodejs/node/pull/60437
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Oct 27, 2025https://github.com/nodejs/node/pull/60437#event-20530928190
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 27, 2025https://github.com/nodejs/node/pull/60437#issuecomment-3452330097
https://ci.nodejs.org/job/node-test-pull-request/69906/https://ci.nodejs.org/job/node-test-pull-request/69906/
Please reload this pagehttps://github.com/nodejs/node/pull/60437
https://github.com/ThierryMT
http: fix drain event with cork/uncorkhttps://github.com/nodejs/node/pull/60437/commits/972f7330d38da9469ac36a013c6128e39c6f612f
972f733https://github.com/nodejs/node/pull/60437/commits/972f7330d38da9469ac36a013c6128e39c6f612f
nodejs#60432https://github.com/nodejs/node/issues/60432
https://github.com/ThierryMT
ThierryMThttps://github.com/ThierryMT
force-pushedhttps://github.com/nodejs/node/compare/63b516bb504fd85c8430350de5566a0ec8627b9c..972f7330d38da9469ac36a013c6128e39c6f612f
63b516bhttps://github.com/nodejs/node/commit/63b516bb504fd85c8430350de5566a0ec8627b9c
972f733https://github.com/nodejs/node/commit/972f7330d38da9469ac36a013c6128e39c6f612f
Compare https://github.com/nodejs/node/compare/63b516bb504fd85c8430350de5566a0ec8627b9c..972f7330d38da9469ac36a013c6128e39c6f612f
October 27, 2025 17:26https://github.com/nodejs/node/pull/60437#event-20531800596
https://github.com/ronag
ronaghttps://github.com/ronag
Oct 27, 2025 https://github.com/nodejs/node/pull/60437#pullrequestreview-3384701182
View reviewed changes https://github.com/nodejs/node/pull/60437/files/972f7330d38da9469ac36a013c6128e39c6f612f
https://github.com/pimterry
pimterryhttps://github.com/pimterry
Oct 28, 2025 https://github.com/nodejs/node/pull/60437#ref-pullrequest-3557475630
module: fix EISDIR error with Windows drive-letter-only paths #60438 https://github.com/nodejs/node/pull/60438
https://github.com/ThierryMT
test: add test for drain event with cork/uncorkhttps://github.com/nodejs/node/pull/60437/commits/9ab4cc4b6a610ac5374f76f36029073aa93523d5
9ab4cc4https://github.com/nodejs/node/pull/60437/commits/9ab4cc4b6a610ac5374f76f36029073aa93523d5
https://github.com/pimterry
pimterryhttps://github.com/pimterry
Oct 31, 2025 https://github.com/nodejs/node/pull/60437#pullrequestreview-3403754502
View reviewed changes https://github.com/nodejs/node/pull/60437/files/9ab4cc4b6a610ac5374f76f36029073aa93523d5
pimterryhttps://github.com/pimterry
https://github.com/nodejs/node/pull/60437#pullrequestreview-3403754502
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/60437
test/parallel/test-http-response-drain-cork.jshttps://github.com/nodejs/node/pull/60437/files/9ab4cc4b6a610ac5374f76f36029073aa93523d5#diff-3e1266c9549853cfe119391191045bac281e8f284f1eae12ba474b69b9c5fc49
pimterryhttps://github.com/pimterry
Oct 31, 2025https://github.com/nodejs/node/pull/60437#discussion_r2481063704
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/60437
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Oct 31, 2025https://github.com/nodejs/node/pull/60437#issuecomment-3472859201
Please reload this pagehttps://github.com/nodejs/node/pull/60437
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/60437?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
d9cf867https://app.codecov.io/gh/nodejs/node/commit/d9cf867a9dad11b5aca34b4dd59a061efa3667f0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
9ab4cc4https://app.codecov.io/gh/nodejs/node/commit/9ab4cc4b6a610ac5374f76f36029073aa93523d5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/60437?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/_http_outgoing.jshttps://app.codecov.io/gh/nodejs/node/pull/60437?src=pr&el=tree&filepath=lib%2F_http_outgoing.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL19odHRwX291dGdvaW5nLmpz
31 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/60437/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/60437
https://github.com/Ethan-Arrowood
Ethan-Arrowoodhttps://github.com/Ethan-Arrowood
Nov 3, 2025 https://github.com/nodejs/node/pull/60437#pullrequestreview-3412073830
View reviewed changes https://github.com/nodejs/node/pull/60437/files/9ab4cc4b6a610ac5374f76f36029073aa93523d5
Ethan-Arrowoodhttps://github.com/Ethan-Arrowood
https://github.com/nodejs/node/pull/60437#pullrequestreview-3412073830
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/60437
https://github.com/ThierryMT
ThierryMThttps://github.com/ThierryMT
Nov 3, 2025https://github.com/nodejs/node/pull/60437#event-20680500620
https://github.com/davidje13
davidje13https://github.com/davidje13
May 26, 2026 https://github.com/nodejs/node/pull/60437#ref-issue-3556721047
drain event is unreliable when using cork/uncork with ServerResponse #60432 https://github.com/nodejs/node/issues/60432
davidje13https://github.com/davidje13
Jun 21, 2026 https://github.com/nodejs/node/pull/60437#ref-commit-fda2f07
https://github.com/davidje13
http: fix drain event with cork/uncorkhttps://github.com/davidje13/node/commit/fda2f0709fd09d4f5bff05a10754b8b3ecd127ee
fda2f07https://github.com/davidje13/node/commit/fda2f0709fd09d4f5bff05a10754b8b3ecd127ee
nodejs#60437https://github.com/nodejs/node/pull/60437
nodejs#60432https://github.com/nodejs/node/issues/60432
https://github.com/davidje13
davidje13https://github.com/davidje13
Jun 21, 2026 https://github.com/nodejs/node/pull/60437#ref-pullrequest-4708897525
http: fix drain event with cork/uncork #64038 https://github.com/nodejs/node/pull/64038
davidje13https://github.com/davidje13
Jun 21, 2026 https://github.com/nodejs/node/pull/60437#ref-commit-3dd6cb4
https://github.com/davidje13
http: fix drain event with cork/uncorkhttps://github.com/davidje13/node/commit/3dd6cb4dc107cc9ba5e12ebedeec17b60bcb6f0d
3dd6cb4https://github.com/davidje13/node/commit/3dd6cb4dc107cc9ba5e12ebedeec17b60bcb6f0d
nodejs#60437https://github.com/nodejs/node/pull/60437
nodejs#60432https://github.com/nodejs/node/issues/60432
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 2, 2026 https://github.com/nodejs/node/pull/60437#ref-commit-615749b
https://github.com/davidje13
http: fix drain event with cork/uncorkhttps://github.com/nodejs/node/commit/615749b9b5fa2b4c1c5ac672e8651ca44150d3b8
615749bhttps://github.com/nodejs/node/commit/615749b9b5fa2b4c1c5ac672e8651ca44150d3b8
#60437https://github.com/nodejs/node/pull/60437
#60432https://github.com/nodejs/node/issues/60432
#64038https://github.com/nodejs/node/pull/64038
richardlauhttps://github.com/richardlau
Jul 3, 2026 https://github.com/nodejs/node/pull/60437#ref-commit-aeb539a
https://github.com/davidje13
https://github.com/richardlau
http: fix drain event with cork/uncorkhttps://github.com/nodejs/node/commit/aeb539a383c1a40e9bc7ca3971be552393f95460
aeb539ahttps://github.com/nodejs/node/commit/aeb539a383c1a40e9bc7ca3971be552393f95460
#60437https://github.com/nodejs/node/pull/60437
#60432https://github.com/nodejs/node/issues/60432
#64038https://github.com/nodejs/node/pull/64038
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F60437
https://github.com/pimterry
pimterry https://github.com/pimterry
https://github.com/nodejs/node/pull/60437/files/9ab4cc4b6a610ac5374f76f36029073aa93523d5
https://github.com/Ethan-Arrowood
Ethan-Arrowood https://github.com/Ethan-Arrowood
https://github.com/nodejs/node/pull/60437/files/9ab4cc4b6a610ac5374f76f36029073aa93523d5
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/60437/files/972f7330d38da9469ac36a013c6128e39c6f612f
https://github.com/ronag
ronag https://github.com/ronag
https://github.com/nodejs/node/pull/60437/files/972f7330d38da9469ac36a013c6128e39c6f612f
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
drain event is unreliable when using cork/uncork with ServerResponse https://github.com/nodejs/node/issues/60432
Please reload this pagehttps://github.com/nodejs/node/pull/60437
https://github.com/ThierryMT
https://github.com/nodejs-github-bot
https://github.com/mcollina
https://github.com/pimterry
https://github.com/ronag
https://github.com/Ethan-Arrowood
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.