René's URL Explorer Experiment


Title: test: be explicit about polluting of `global` by Trott · Pull Request #6017 · nodejs/node · GitHub

Open Graph Title: test: be explicit about polluting of `global` by Trott · Pull Request #6017 · nodejs/node

X Title: test: be explicit about polluting of `global` by Trott · Pull Request #6017 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Pull Request check-list Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with this change (including linting)? Is the commit message formatted according to [CONTRIBUTING.md][0]? ...

X Description: Pull Request check-list Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with this change (including linting)? Is the commit message formatted according to [CONTRIBUTING.md][0]? ...

Opengraph URL: https://github.com/nodejs/node/pull/6017

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f0fa9d5f-138e-86da-92c4-892580abbe9f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB82E:34AAF2:13E4783:1B37817:6A4D762C
html-safe-nonceb7b03c3818a73b2cb0032060179fb249627863ad81f37286651b0140e6096f74
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCODJFOjM0QUFGMjoxM0U0NzgzOjFCMzc4MTc6NkE0RDc2MkMiLCJ2aXNpdG9yX2lkIjoiMzAxOTIyODkyNzAxNDgyNzU2NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac77b3d477513dbba299e218e6f89d9b809395d365781bae83a52aa3ea60c4c764
hovercard-subject-tagpull_request:65029059
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/6017/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c044548380306b03481416661603fe885f99af71463b9cada73eb5233c94029f/nodejs/node/pull/6017
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c044548380306b03481416661603fe885f99af71463b9cada73eb5233c94029f/nodejs/node/pull/6017
og:image:altPull Request check-list Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with this change (including linting)? Is the commit message formatted according to [CONTRIBUTING.md][0]? ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameTrott
hostnamegithub.com
expected-hostnamegithub.com
Nonec78260c7b3f4ac4b0356c8208537f05406a3a2d46a9ec3f735b372dcc519c39e
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release399fff412f48461d435721c009efc17ea44be72f
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/6017#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F6017
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F6017
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/6017
Reloadhttps://github.com/nodejs/node/pull/6017
Reloadhttps://github.com/nodejs/node/pull/6017
Please reload this pagehttps://github.com/nodejs/node/pull/6017
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/6017
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 962 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Trotthttps://github.com/Trott
nodejs:masterhttps://github.com/nodejs/node/tree/master
Trott:doctorhttps://github.com/Trott/io.js/tree/doctor
Conversationhttps://github.com/nodejs/node/pull/6017
Commits1 (1)https://github.com/nodejs/node/pull/6017/commits
Checkshttps://github.com/nodejs/node/pull/6017/checks
Files changedhttps://github.com/nodejs/node/pull/6017/files
test: be explicit about polluting of globalhttps://github.com/nodejs/node/pull/6017#top
Trotthttps://github.com/Trott
nodejs:masterhttps://github.com/nodejs/node/tree/master
Trott:doctorhttps://github.com/Trott/io.js/tree/doctor
https://github.com/Trott
Trotthttps://github.com/Trott
Apr 2, 2016https://github.com/nodejs/node/pull/6017#issue-145339202
Please reload this pagehttps://github.com/nodejs/node/pull/6017
https://github.com/Trott
test: be explicit about polluting of globalhttps://github.com/nodejs/node/pull/6017/commits/c48ed8d66f5153a167e81bf588acc05f1b284d12
c48ed8dhttps://github.com/nodejs/node/pull/6017/commits/c48ed8d66f5153a167e81bf588acc05f1b284d12
https://github.com/Trott
Trotthttps://github.com/Trott
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
domain https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adomain
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
lts-watch-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x
Apr 2, 2016https://github.com/nodejs/node/pull/6017#event-612062617
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Apr 2, 2016https://github.com/nodejs/node/pull/6017#issuecomment-204656235
Please reload this pagehttps://github.com/nodejs/node/pull/6017
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Apr 2, 2016https://github.com/nodejs/node/pull/6017#issuecomment-204656401
Please reload this pagehttps://github.com/nodejs/node/pull/6017
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Apr 2, 2016https://github.com/nodejs/node/pull/6017#issuecomment-204707369
Please reload this pagehttps://github.com/nodejs/node/pull/6017
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Apr 4, 2016https://github.com/nodejs/node/pull/6017#issuecomment-205512029
https://ci.nodejs.org/job/node-test-pull-request/2154/https://ci.nodejs.org/job/node-test-pull-request/2154/
Please reload this pagehttps://github.com/nodejs/node/pull/6017
jasnellhttps://github.com/jasnell
Apr 4, 2016 https://github.com/nodejs/node/pull/6017#ref-commit-ae2be27
https://github.com/Trott
https://github.com/jasnell
test: be explicit about polluting of globalhttps://github.com/nodejs/node/commit/ae2be27add3c0597a2555efab3cd9370199c945a
ae2be27https://github.com/nodejs/node/commit/ae2be27add3c0597a2555efab3cd9370199c945a
#6017https://github.com/nodejs/node/pull/6017
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Apr 4, 2016https://github.com/nodejs/node/pull/6017#issuecomment-205533614
ae2be27https://github.com/nodejs/node/commit/ae2be27add3c0597a2555efab3cd9370199c945a
Please reload this pagehttps://github.com/nodejs/node/pull/6017
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Apr 4, 2016https://github.com/nodejs/node/pull/6017#event-614384224
Trotthttps://github.com/Trott
Apr 4, 2016 https://github.com/nodejs/node/pull/6017#ref-commit-c15a6be
https://github.com/Trott
test: enforce strict mode for test-domain-cryptohttps://github.com/Trott/io.js/commit/c15a6bef70004c4b6bd9bbd801da6169e1d77bc4
c15a6behttps://github.com/Trott/io.js/commit/c15a6bef70004c4b6bd9bbd801da6169e1d77bc4
nodejs#6017https://github.com/nodejs/node/pull/6017
https://github.com/Trott
Trotthttps://github.com/Trott
Apr 4, 2016 https://github.com/nodejs/node/pull/6017#ref-pullrequest-145836952
test: enforce strict mode for test-domain-crypto #6047 https://github.com/nodejs/node/pull/6047
MylesBorinshttps://github.com/MylesBorins
Apr 5, 2016 https://github.com/nodejs/node/pull/6017#ref-commit-cc8fcc5
https://github.com/Trott
test: be explicit about polluting of globalhttps://github.com/nodejs/node/commit/cc8fcc5a0704bf3fca7dcd5cb81e9775fc0e4a0f
cc8fcc5https://github.com/nodejs/node/commit/cc8fcc5a0704bf3fca7dcd5cb81e9775fc0e4a0f
#6017https://github.com/nodejs/node/pull/6017
V5.10.1 proposal #6059 https://github.com/nodejs/node/pull/6059
V5.10.1 proposal #6060 https://github.com/nodejs/node/pull/6060
Trotthttps://github.com/Trott
Apr 6, 2016 https://github.com/nodejs/node/pull/6017#ref-commit-d4eafd0
https://github.com/Trott
test: enforce strict mode for test-domain-cryptohttps://github.com/Trott/io.js/commit/d4eafd0c114b6765983c5524759656f335675835
d4eafd0https://github.com/Trott/io.js/commit/d4eafd0c114b6765983c5524759656f335675835
nodejs#6047https://github.com/nodejs/node/pull/6047
nodejs#6017https://github.com/nodejs/node/pull/6017
MylesBorinshttps://github.com/MylesBorins
Apr 11, 2016 https://github.com/nodejs/node/pull/6017#ref-commit-a7b3a75
https://github.com/Trott
test: be explicit about polluting of globalhttps://github.com/nodejs/node/commit/a7b3a7533ae5e60e1c4f4c47867c758b3020aa74
a7b3a75https://github.com/nodejs/node/commit/a7b3a7533ae5e60e1c4f4c47867c758b3020aa74
#6017https://github.com/nodejs/node/pull/6017
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v4.x
lts-watch-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x
Apr 11, 2016https://github.com/nodejs/node/pull/6017#event-622791013
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Apr 11, 2016 https://github.com/nodejs/node/pull/6017#ref-pullrequest-147505251
V4.4.3 proposal #6149 https://github.com/nodejs/node/pull/6149
MylesBorinshttps://github.com/MylesBorins
Apr 19, 2016 https://github.com/nodejs/node/pull/6017#ref-commit-473ffdc
https://github.com/Trott
test: enforce strict mode for test-domain-cryptohttps://github.com/nodejs/node/commit/473ffdc9c3c56bc853397edde99d17e8a2e75618
473ffdchttps://github.com/nodejs/node/commit/473ffdc9c3c56bc853397edde99d17e8a2e75618
#6047https://github.com/nodejs/node/pull/6047
#6017https://github.com/nodejs/node/pull/6017
MylesBorinshttps://github.com/MylesBorins
Apr 20, 2016 https://github.com/nodejs/node/pull/6017#ref-commit-8ab2d73
https://github.com/Trott
test: enforce strict mode for test-domain-cryptohttps://github.com/nodejs/node/commit/8ab2d73b39649abb5fa9539bdd2eff668d99355f
8ab2d73https://github.com/nodejs/node/commit/8ab2d73b39649abb5fa9539bdd2eff668d99355f
#6047https://github.com/nodejs/node/pull/6047
#6017https://github.com/nodejs/node/pull/6017
MylesBorinshttps://github.com/MylesBorins
Apr 20, 2016 https://github.com/nodejs/node/pull/6017#ref-commit-a27e952
https://github.com/Trott
test: enforce strict mode for test-domain-cryptohttps://github.com/nodejs/node/commit/a27e95231eb2df6d96084bd2d214176fd7a75aa6
a27e952https://github.com/nodejs/node/commit/a27e95231eb2df6d96084bd2d214176fd7a75aa6
#6047https://github.com/nodejs/node/pull/6047
#6017https://github.com/nodejs/node/pull/6017
MylesBorinshttps://github.com/MylesBorins
May 17, 2016 https://github.com/nodejs/node/pull/6017#ref-commit-fb6bd9e
https://github.com/Trott
test: enforce strict mode for test-domain-cryptohttps://github.com/nodejs/node/commit/fb6bd9eaeab6cc51dd762b843ce9567d58309926
fb6bd9ehttps://github.com/nodejs/node/commit/fb6bd9eaeab6cc51dd762b843ce9567d58309926
#6047https://github.com/nodejs/node/pull/6047
#6017https://github.com/nodejs/node/pull/6017
MylesBorinshttps://github.com/MylesBorins
May 18, 2016 https://github.com/nodejs/node/pull/6017#ref-commit-3a67a05
https://github.com/Trott
test: enforce strict mode for test-domain-cryptohttps://github.com/nodejs/node/commit/3a67a05ed457faa2f7e7fd8e8941767a3ae90231
3a67a05https://github.com/nodejs/node/commit/3a67a05ed457faa2f7e7fd8e8941767a3ae90231
#6047https://github.com/nodejs/node/pull/6047
#6017https://github.com/nodejs/node/pull/6017
https://github.com/Trott
Trotthttps://github.com/Trott
January 13, 2022 22:42https://github.com/nodejs/node/pull/6017#event-5890936252
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F6017
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
domain https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adomain
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/6017
https://github.com/Trott
https://github.com/bnoordhuis
https://github.com/jasnell
https://github.com/cjihrig
https://github.com/MylesBorins
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.