René's URL Explorer Experiment


Title: Fix events remove listener emission by Han5991 · Pull Request #60137 · nodejs/node · GitHub

Open Graph Title: Fix events remove listener emission by Han5991 · Pull Request #60137 · nodejs/node

X Title: Fix events remove listener emission by Han5991 · Pull Request #60137 · nodejs/node

Description: Description This PR fixes a bug where the removeListener event was not being emitted when the last listener was removed from an EventEmitter. Background When removeListener() is called and the last...

Open Graph Description: Description This PR fixes a bug where the removeListener event was not being emitted when the last listener was removed from an EventEmitter. Background When removeListener() is called and the last...

X Description: Description This PR fixes a bug where the removeListener event was not being emitted when the last listener was removed from an EventEmitter. Background When removeListener() is called and the last...

Opengraph URL: https://github.com/nodejs/node/pull/60137

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:84fbf4cf-d7d9-c7fc-508c-b67de388bc51
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9018:C18A5:E24C5:142C2A:696A3DFB
html-safe-nonceea06b597527e29755892f906b0c4b2b95d71bd93d9966a43635b95aae3b8e16f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MDE4OkMxOEE1OkUyNEM1OjE0MkMyQTo2OTZBM0RGQiIsInZpc2l0b3JfaWQiOiIyNjg5NDA1NDY5MDc4NDcwMTM5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacb1564a3d3764a5965f29d34dc2ee05c850e0b9929b13429d70c39cad791ee901
hovercard-subject-tagpull_request:2892725020
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/60137/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b1d86549d8edff5a2fb8ec37158cf8420fb9ffaab7d6d857606592193c8c02d8/nodejs/node/pull/60137
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b1d86549d8edff5a2fb8ec37158cf8420fb9ffaab7d6d857606592193c8c02d8/nodejs/node/pull/60137
og:image:altDescription This PR fixes a bug where the removeListener event was not being emitted when the last listener was removed from an EventEmitter. Background When removeListener() is called and the last...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameHan5991
hostnamegithub.com
expected-hostnamegithub.com
None321736bfdb3f591415ae895a0459bec204b26a76caf47ba5c980634cfacc4538
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release13581a31d51edf4a3aca179e10890a4d4f9b6d76
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/60137#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F60137
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F60137
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/60137
Reloadhttps://github.com/nodejs/node/pull/60137
Reloadhttps://github.com/nodejs/node/pull/60137
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/60137
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 694 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/60137
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/60137#issue-comment-box
Han5991https://github.com/Han5991
nodejs:mainhttps://github.com/nodejs/node/tree/main
Han5991:fix-events-remove-listener-emissionhttps://github.com/Han5991/node/tree/fix-events-remove-listener-emission
Fix events remove listener emission https://github.com/nodejs/node/pull/60137#top
Han5991https://github.com/Han5991
nodejs:mainhttps://github.com/nodejs/node/tree/main
Han5991:fix-events-remove-listener-emissionhttps://github.com/Han5991/node/tree/fix-events-remove-listener-emission
Conversation 7 https://github.com/nodejs/node/pull/60137
Commits 2 https://github.com/nodejs/node/pull/60137/commits
Checks 28 https://github.com/nodejs/node/pull/60137/checks
Files changed 2 https://github.com/nodejs/node/pull/60137/files
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/Han5991
Han5991https://github.com/Han5991
Oct 7, 2025https://github.com/nodejs/node/pull/60137#issue-3490053418
https://private-user-images.githubusercontent.com/73056306/498133153-d6529a49-c105-4976-b631-a34a3d8ed322.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Njg1NzA2NjMsIm5iZiI6MTc2ODU3MDM2MywicGF0aCI6Ii83MzA1NjMwNi80OTgxMzMxNTMtZDY1MjlhNDktYzEwNS00OTc2LWI2MzEtYTM0YTNkOGVkMzIyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjAxMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYwMTE2VDEzMzI0M1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTBhYmMxYTU4NDNlMjE0NmEzMTFkYmQ0MGZhYzBmNWQyZTU1YmVmZmFhMjk1NjdkODJiYjRlZDRiNGE0YWM2N2EmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.BcU75G4ju9DB7rWIuDAalfNs59mPNH3FKSjDmg0TOZY
#59977https://github.com/nodejs/node/issues/59977
Please reload this pagehttps://github.com/nodejs/node/pull/60137
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
events https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aevents
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Oct 7, 2025https://github.com/nodejs/node/pull/60137#event-20132505065
https://github.com/Han5991
Han5991https://github.com/Han5991
October 7, 2025 05:54https://github.com/nodejs/node/pull/60137#event-20132510823
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Oct 7, 2025https://github.com/nodejs/node/pull/60137#issuecomment-3375463905
Please reload this pagehttps://github.com/nodejs/node/pull/60137
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/60137?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
bfc81cahttps://app.codecov.io/gh/nodejs/node/commit/bfc81ca2284e7d596a140d6b93735a1914816561?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
d322e4dhttps://app.codecov.io/gh/nodejs/node/commit/d322e4de739c3930ccfe05fde0c17849db7ad65c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/60137?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/events.jshttps://app.codecov.io/gh/nodejs/node/pull/60137?src=pr&el=tree&filepath=lib%2Fevents.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2V2ZW50cy5qcw==
25 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/60137/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/60137
Han5991https://github.com/Han5991
October 10, 2025 08:24https://github.com/nodejs/node/pull/60137#commits-pushed-e04ddfc
https://github.com/Han5991
test: ensure removeListener event fires for once() listenershttps://github.com/nodejs/node/pull/60137/commits/e04ddfc92a8fffa79d91ddeb5eaf338a3f73054d
e04ddfchttps://github.com/nodejs/node/pull/60137/commits/e04ddfc92a8fffa79d91ddeb5eaf338a3f73054d
https://github.com/Han5991
fix: emit removeListener event when last listener is removedhttps://github.com/nodejs/node/pull/60137/commits/d322e4de739c3930ccfe05fde0c17849db7ad65c
d322e4dhttps://github.com/nodejs/node/pull/60137/commits/d322e4de739c3930ccfe05fde0c17849db7ad65c
https://github.com/Han5991
Han5991https://github.com/Han5991
force-pushedhttps://github.com/nodejs/node/compare/074f626a347527fa0a80c0e9102be448e64e0ff1..d322e4de739c3930ccfe05fde0c17849db7ad65c
074f626https://github.com/nodejs/node/commit/074f626a347527fa0a80c0e9102be448e64e0ff1
d322e4dhttps://github.com/nodejs/node/commit/d322e4de739c3930ccfe05fde0c17849db7ad65c
Compare https://github.com/nodejs/node/compare/074f626a347527fa0a80c0e9102be448e64e0ff1..d322e4de739c3930ccfe05fde0c17849db7ad65c
October 9, 2025 23:24https://github.com/nodejs/node/pull/60137#event-20195598392
https://github.com/simonkcleung
simonkcleunghttps://github.com/simonkcleung
Oct 18, 2025 https://github.com/nodejs/node/pull/60137#pullrequestreview-3353748875
View reviewed changes https://github.com/nodejs/node/pull/60137/files/d322e4de739c3930ccfe05fde0c17849db7ad65c
simonkcleunghttps://github.com/simonkcleung
Please reload this pagehttps://github.com/nodejs/node/pull/60137
https://github.com/nodejs/node/pull/60137#pullrequestreview-3353748875
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/60137
https://github.com/Han5991
Han5991https://github.com/Han5991
Oct 22, 2025https://github.com/nodejs/node/pull/60137#issuecomment-3434349142
Please reload this pagehttps://github.com/nodejs/node/pull/60137
https://github.com/simonkcleung
simonkcleunghttps://github.com/simonkcleung
Oct 23, 2025https://github.com/nodejs/node/pull/60137#issuecomment-3437012558
Please reload this pagehttps://github.com/nodejs/node/pull/60137
https://github.com/Han5991
Han5991https://github.com/Han5991
Oct 23, 2025https://github.com/nodejs/node/pull/60137#issuecomment-3439531349
@simonkcleunghttps://github.com/simonkcleung
Please reload this pagehttps://github.com/nodejs/node/pull/60137
https://github.com/simonkcleung
simonkcleunghttps://github.com/simonkcleung
Oct 24, 2025https://github.com/nodejs/node/pull/60137#issuecomment-3443223805
Please reload this pagehttps://github.com/nodejs/node/pull/60137
@simonkcleunghttps://github.com/simonkcleung
Please reload this pagehttps://github.com/nodejs/node/pull/60137
https://github.com/avivkeller
avivkellerhttps://github.com/avivkeller
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jan 16, 2026https://github.com/nodejs/node/pull/60137#event-22083340967
https://github.com/avivkeller
avivkellerhttps://github.com/avivkeller
Jan 16, 2026 https://github.com/nodejs/node/pull/60137#pullrequestreview-3668276886
View reviewed changes https://github.com/nodejs/node/pull/60137/files/d322e4de739c3930ccfe05fde0c17849db7ad65c
https://github.com/avivkeller
avivkellerhttps://github.com/avivkeller
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jan 16, 2026https://github.com/nodejs/node/pull/60137#event-22083343341
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jan 16, 2026https://github.com/nodejs/node/pull/60137#event-22083493464
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 16, 2026https://github.com/nodejs/node/pull/60137#issuecomment-3757624232
https://ci.nodejs.org/job/node-test-pull-request/70824/https://ci.nodejs.org/job/node-test-pull-request/70824/
Please reload this pagehttps://github.com/nodejs/node/pull/60137
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F60137
https://github.com/avivkeller
avivkeller https://github.com/avivkeller
https://github.com/nodejs/node/pull/60137/files/d322e4de739c3930ccfe05fde0c17849db7ad65c
https://github.com/simonkcleung
simonkcleung https://github.com/simonkcleung
https://github.com/nodejs/node/pull/60137/files/d322e4de739c3930ccfe05fde0c17849db7ad65c
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
events https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aevents
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
sockets no longer emit removeListener events in v20.11.0 https://github.com/nodejs/node/issues/59977
Please reload this pagehttps://github.com/nodejs/node/pull/60137
https://github.com/Han5991
https://github.com/simonkcleung
https://github.com/nodejs-github-bot
https://github.com/avivkeller
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.