| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:84fbf4cf-d7d9-c7fc-508c-b67de388bc51 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9018:C18A5:E24C5:142C2A:696A3DFB |
| html-safe-nonce | ea06b597527e29755892f906b0c4b2b95d71bd93d9966a43635b95aae3b8e16f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MDE4OkMxOEE1OkUyNEM1OjE0MkMyQTo2OTZBM0RGQiIsInZpc2l0b3JfaWQiOiIyNjg5NDA1NDY5MDc4NDcwMTM5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | b1564a3d3764a5965f29d34dc2ee05c850e0b9929b13429d70c39cad791ee901 |
| hovercard-subject-tag | pull_request:2892725020 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/60137/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/b1d86549d8edff5a2fb8ec37158cf8420fb9ffaab7d6d857606592193c8c02d8/nodejs/node/pull/60137 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b1d86549d8edff5a2fb8ec37158cf8420fb9ffaab7d6d857606592193c8c02d8/nodejs/node/pull/60137 |
| og:image:alt | Description
This PR fixes a bug where the removeListener event was not being emitted when the last listener was removed from an EventEmitter.
Background
When removeListener() is called and the last... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Han5991 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 321736bfdb3f591415ae895a0459bec204b26a76caf47ba5c980634cfacc4538 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 13581a31d51edf4a3aca179e10890a4d4f9b6d76 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/60137#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F60137 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F60137 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/60137 |
| Reload | https://github.com/nodejs/node/pull/60137 |
| Reload | https://github.com/nodejs/node/pull/60137 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/60137 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
694
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/60137 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/60137#issue-comment-box |
| Han5991 | https://github.com/Han5991 |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| Han5991:fix-events-remove-listener-emission | https://github.com/Han5991/node/tree/fix-events-remove-listener-emission |
|
Fix events remove listener emission
| https://github.com/nodejs/node/pull/60137#top |
| Han5991 | https://github.com/Han5991 |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| Han5991:fix-events-remove-listener-emission | https://github.com/Han5991/node/tree/fix-events-remove-listener-emission |
|
Conversation
7
| https://github.com/nodejs/node/pull/60137 |
|
Commits
2
| https://github.com/nodejs/node/pull/60137/commits |
|
Checks
28
| https://github.com/nodejs/node/pull/60137/checks |
|
Files changed
2
| https://github.com/nodejs/node/pull/60137/files |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/Han5991 |
| Han5991 | https://github.com/Han5991 |
| Oct 7, 2025 | https://github.com/nodejs/node/pull/60137#issue-3490053418 |
| https://private-user-images.githubusercontent.com/73056306/498133153-d6529a49-c105-4976-b631-a34a3d8ed322.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Njg1NzA2NjMsIm5iZiI6MTc2ODU3MDM2MywicGF0aCI6Ii83MzA1NjMwNi80OTgxMzMxNTMtZDY1MjlhNDktYzEwNS00OTc2LWI2MzEtYTM0YTNkOGVkMzIyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjAxMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYwMTE2VDEzMzI0M1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTBhYmMxYTU4NDNlMjE0NmEzMTFkYmQ0MGZhYzBmNWQyZTU1YmVmZmFhMjk1NjdkODJiYjRlZDRiNGE0YWM2N2EmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.BcU75G4ju9DB7rWIuDAalfNs59mPNH3FKSjDmg0TOZY |
| #59977 | https://github.com/nodejs/node/issues/59977 |
| Please reload this page | https://github.com/nodejs/node/pull/60137 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
events
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aevents |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
| Oct 7, 2025 | https://github.com/nodejs/node/pull/60137#event-20132505065 |
| https://github.com/Han5991 |
| Han5991 | https://github.com/Han5991 |
| October 7, 2025 05:54 | https://github.com/nodejs/node/pull/60137#event-20132510823 |
| https://github.com/apps/codecov |
| codecov | https://github.com/apps/codecov |
| Oct 7, 2025 | https://github.com/nodejs/node/pull/60137#issuecomment-3375463905 |
| Please reload this page | https://github.com/nodejs/node/pull/60137 |
| Codecov | https://app.codecov.io/gh/nodejs/node/pull/60137?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| bfc81ca | https://app.codecov.io/gh/nodejs/node/commit/bfc81ca2284e7d596a140d6b93735a1914816561?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| d322e4d | https://app.codecov.io/gh/nodejs/node/commit/d322e4de739c3930ccfe05fde0c17849db7ad65c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| Files with missing lines | https://app.codecov.io/gh/nodejs/node/pull/60137?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| lib/events.js | https://app.codecov.io/gh/nodejs/node/pull/60137?src=pr&el=tree&filepath=lib%2Fevents.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2V2ZW50cy5qcw== |
| 25 files with indirect coverage changes | https://app.codecov.io/gh/nodejs/node/pull/60137/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| Test Analytics | https://docs.codecov.com/docs/test-analytics |
| JS Bundle Analysis | https://docs.codecov.com/docs/javascript-bundle-analysis |
| Please reload this page | https://github.com/nodejs/node/pull/60137 |
| Han5991 | https://github.com/Han5991 |
| October 10, 2025 08:24 | https://github.com/nodejs/node/pull/60137#commits-pushed-e04ddfc |
|
| https://github.com/Han5991 |
| test: ensure removeListener event fires for once() listeners | https://github.com/nodejs/node/pull/60137/commits/e04ddfc92a8fffa79d91ddeb5eaf338a3f73054d |
| e04ddfc | https://github.com/nodejs/node/pull/60137/commits/e04ddfc92a8fffa79d91ddeb5eaf338a3f73054d |
|
| https://github.com/Han5991 |
| fix: emit removeListener event when last listener is removed | https://github.com/nodejs/node/pull/60137/commits/d322e4de739c3930ccfe05fde0c17849db7ad65c |
| d322e4d | https://github.com/nodejs/node/pull/60137/commits/d322e4de739c3930ccfe05fde0c17849db7ad65c |
| https://github.com/Han5991 |
| Han5991 | https://github.com/Han5991 |
| force-pushed | https://github.com/nodejs/node/compare/074f626a347527fa0a80c0e9102be448e64e0ff1..d322e4de739c3930ccfe05fde0c17849db7ad65c |
| 074f626 | https://github.com/nodejs/node/commit/074f626a347527fa0a80c0e9102be448e64e0ff1 |
| d322e4d | https://github.com/nodejs/node/commit/d322e4de739c3930ccfe05fde0c17849db7ad65c |
|
Compare
| https://github.com/nodejs/node/compare/074f626a347527fa0a80c0e9102be448e64e0ff1..d322e4de739c3930ccfe05fde0c17849db7ad65c |
| October 9, 2025 23:24 | https://github.com/nodejs/node/pull/60137#event-20195598392 |
| https://github.com/simonkcleung |
| simonkcleung | https://github.com/simonkcleung |
|
Oct 18, 2025
| https://github.com/nodejs/node/pull/60137#pullrequestreview-3353748875 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/60137/files/d322e4de739c3930ccfe05fde0c17849db7ad65c |
| simonkcleung | https://github.com/simonkcleung |
| Please reload this page | https://github.com/nodejs/node/pull/60137 |
| https://github.com/nodejs/node/pull/60137#pullrequestreview-3353748875 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/60137 |
| https://github.com/Han5991 |
| Han5991 | https://github.com/Han5991 |
| Oct 22, 2025 | https://github.com/nodejs/node/pull/60137#issuecomment-3434349142 |
| Please reload this page | https://github.com/nodejs/node/pull/60137 |
| https://github.com/simonkcleung |
| simonkcleung | https://github.com/simonkcleung |
| Oct 23, 2025 | https://github.com/nodejs/node/pull/60137#issuecomment-3437012558 |
| Please reload this page | https://github.com/nodejs/node/pull/60137 |
| https://github.com/Han5991 |
| Han5991 | https://github.com/Han5991 |
| Oct 23, 2025 | https://github.com/nodejs/node/pull/60137#issuecomment-3439531349 |
| @simonkcleung | https://github.com/simonkcleung |
| Please reload this page | https://github.com/nodejs/node/pull/60137 |
| https://github.com/simonkcleung |
| simonkcleung | https://github.com/simonkcleung |
| Oct 24, 2025 | https://github.com/nodejs/node/pull/60137#issuecomment-3443223805 |
| Please reload this page | https://github.com/nodejs/node/pull/60137 |
| @simonkcleung | https://github.com/simonkcleung |
| Please reload this page | https://github.com/nodejs/node/pull/60137 |
| https://github.com/avivkeller |
| avivkeller | https://github.com/avivkeller |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Jan 16, 2026 | https://github.com/nodejs/node/pull/60137#event-22083340967 |
| https://github.com/avivkeller |
| avivkeller | https://github.com/avivkeller |
|
Jan 16, 2026
| https://github.com/nodejs/node/pull/60137#pullrequestreview-3668276886 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/60137/files/d322e4de739c3930ccfe05fde0c17849db7ad65c |
| https://github.com/avivkeller |
| avivkeller | https://github.com/avivkeller |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Jan 16, 2026 | https://github.com/nodejs/node/pull/60137#event-22083343341 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Jan 16, 2026 | https://github.com/nodejs/node/pull/60137#event-22083493464 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jan 16, 2026 | https://github.com/nodejs/node/pull/60137#issuecomment-3757624232 |
| https://ci.nodejs.org/job/node-test-pull-request/70824/ | https://ci.nodejs.org/job/node-test-pull-request/70824/ |
| Please reload this page | https://github.com/nodejs/node/pull/60137 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F60137 |
|
| https://github.com/avivkeller |
|
avivkeller
| https://github.com/avivkeller |
|
| https://github.com/nodejs/node/pull/60137/files/d322e4de739c3930ccfe05fde0c17849db7ad65c |
|
| https://github.com/simonkcleung |
|
simonkcleung
| https://github.com/simonkcleung |
|
| https://github.com/nodejs/node/pull/60137/files/d322e4de739c3930ccfe05fde0c17849db7ad65c |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
events
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aevents |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
sockets no longer emit removeListener events in v20.11.0
| https://github.com/nodejs/node/issues/59977 |
| Please reload this page | https://github.com/nodejs/node/pull/60137 |
|
| https://github.com/Han5991 |
|
| https://github.com/simonkcleung |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/avivkeller |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |