Title: net: support DNS hints in createConnection() by cjihrig · Pull Request #6000 · nodejs/node · GitHub
Open Graph Title: net: support DNS hints in createConnection() by cjihrig · Pull Request #6000 · nodejs/node
X Title: net: support DNS hints in createConnection() by cjihrig · Pull Request #6000 · nodejs/node
Description: Pull Request check-list Please make sure to review and check all of these items: Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with this change (including linting)? Is the commit message formatted according to CONTRIBUTING.md? Is a documentation update included (if this change modifies existing APIs, or introduces new ones)? Affected core subsystem(s) net Description of change This commit adds support for passing DNS lookup hints to createConnection(). This PR is semver minor, but I'd like to toss out the idea of a semver major change where no DNS hints are implicitly set. Instead, users could specify hints if necessary. My motivation is a number of issues related to varying support of V4MAPPED. Thoughts @bnoordhuis / @indutny?
Open Graph Description: Pull Request check-list Please make sure to review and check all of these items: Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with this change (including linting)? Is the comm...
X Description: Pull Request check-list Please make sure to review and check all of these items: Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with this change (including linting)? Is the comm...
Opengraph URL: https://github.com/nodejs/node/pull/6000
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:5634fc61-e962-963d-bcbd-52e191d9bf33 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | ECE6:3092B8:E7BEBA:ECDA9D:6A4DC2C5 |
| html-safe-nonce | 3cd27a0c920fbdff791a0e1b59e9f61a3b3d74e7e86f992e926f67ebdadb280a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQ0U2OjMwOTJCODpFN0JFQkE6RUNEQTlEOjZBNERDMkM1IiwidmlzaXRvcl9pZCI6Ijc5NTE4OTg3MzM2MDMzMDgyMjkiLCJyZWdpb25fZWRnZSI6InNlYSIsInJlZ2lvbl9yZW5kZXIiOiJzZWEifQ== |
| visitor-hmac | b27171ef52d0fc9fe51b4c1121e9c93f4cff627aafc560e0c3e28e8fd9ce14b7 |
| hovercard-subject-tag | pull_request:64963194 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodejs/node/pull/6000/files |
| twitter:image | https://avatars.githubusercontent.com/u/2512748?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/2512748?s=400&v=4 |
| og:image:alt | Pull Request check-list Please make sure to review and check all of these items: Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with this change (including linting)? Is the comm... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 1d344bdb7547fe6bca17a59bb2b8aac3dc9532a0 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width