René's URL Explorer Experiment


Title: stream: improve performance of finished() by avcribl · Pull Request #59873 · nodejs/node · GitHub

Open Graph Title: stream: improve performance of finished() by avcribl · Pull Request #59873 · nodejs/node

X Title: stream: improve performance of finished() by avcribl · Pull Request #59873 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: The changes optimize the end-of-stream.js module to only preserve AsyncLocalStorage context when it's actually needed, improving performance by avoiding ALS overhead in the common case where no...

X Description: The changes optimize the end-of-stream.js module to only preserve AsyncLocalStorage context when it's actually needed, improving performance by avoiding ALS overhead in the common case wher...

Opengraph URL: https://github.com/nodejs/node/pull/59873

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:027ef100-060b-21be-56dd-50ea9aae1905
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id85E2:DFFE4:7DF2CC:AEE83E:6A4C940E
html-safe-nonce7b27de13f0933b722027503191e9a4f621f4c931c7460bc4cd9540a523202d61
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NUUyOkRGRkU0OjdERjJDQzpBRUU4M0U6NkE0Qzk0MEUiLCJ2aXNpdG9yX2lkIjoiNzY1NzM0NDk4MDE4MDgzMzI5NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac72dd0452f8dcf82b1b88ba64f1bb3a0738aba32bca69141709f753bdff0e0592
hovercard-subject-tagpull_request:2823960568
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/59873/commits
twitter:imagehttps://opengraph.githubassets.com/773ea512ff3479a3f0a3f6864a851ddeabb1a9883438e8ec199770c850b7c6c8/nodejs/node/pull/59873
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/773ea512ff3479a3f0a3f6864a851ddeabb1a9883438e8ec199770c850b7c6c8/nodejs/node/pull/59873
og:image:altThe changes optimize the end-of-stream.js module to only preserve AsyncLocalStorage context when it's actually needed, improving performance by avoiding ALS overhead in the common case where no...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameavcribl
hostnamegithub.com
expected-hostnamegithub.com
None3d11bb817438277de2a940854450e83a7d32b6aeb5014e9e6b00a6423900251c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7a2dede45637df6b92ddcfe2a557e67d4b5854ae
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/59873/commits#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F59873%2Fcommits
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F59873%2Fcommits
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/59873/commits
Reloadhttps://github.com/nodejs/node/pull/59873/commits
Reloadhttps://github.com/nodejs/node/pull/59873/commits
Please reload this pagehttps://github.com/nodejs/node/pull/59873/commits
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/59873/commits
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 964 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
avcribl:improve-stream-finished-perfhttps://github.com/avcribl/node/tree/improve-stream-finished-perf
Conversationhttps://github.com/nodejs/node/pull/59873
Commits9 (9)https://github.com/nodejs/node/pull/59873/commits
Checkshttps://github.com/nodejs/node/pull/59873/checks
Files changedhttps://github.com/nodejs/node/pull/59873/files
stream: improve performance of finished()https://github.com/nodejs/node/pull/59873/commits#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
avcribl:improve-stream-finished-perfhttps://github.com/avcribl/node/tree/improve-stream-finished-perf
stream: preserve AsyncLocalStorage on finished only when neededhttps://github.com/nodejs/node/pull/59873/commits/765dd80f46959f2674added04ba7a520d8709ec4
https://github.com/avcribl
avcriblhttps://github.com/nodejs/node/commits?author=avcribl
765dd80https://github.com/nodejs/node/pull/59873/commits/765dd80f46959f2674added04ba7a520d8709ec4
https://github.com/nodejs/node/tree/765dd80f46959f2674added04ba7a520d8709ec4
benchmark: added finished benchmarkhttps://github.com/nodejs/node/pull/59873/commits/f5595c6809bb2900fb376f1431ac8963c081466b
https://github.com/avcribl
avcriblhttps://github.com/nodejs/node/commits?author=avcribl
f5595c6https://github.com/nodejs/node/pull/59873/commits/f5595c6809bb2900fb376f1431ac8963c081466b
https://github.com/nodejs/node/tree/f5595c6809bb2900fb376f1431ac8963c081466b
removed async_hookshttps://github.com/nodejs/node/pull/59873/commits/66dd3f670d0a18461a0a06c7ddffccbb332a510a
https://github.com/avcribl
avcriblhttps://github.com/nodejs/node/commits?author=avcribl
66dd3f6https://github.com/nodejs/node/pull/59873/commits/66dd3f670d0a18461a0a06c7ddffccbb332a510a
https://github.com/nodejs/node/tree/66dd3f670d0a18461a0a06c7ddffccbb332a510a
modified the benchmark testhttps://github.com/nodejs/node/pull/59873/commits/48db583d3f3271e0a1e5d8d56471e36d937d18e8
https://github.com/avcribl
avcriblhttps://github.com/nodejs/node/commits?author=avcribl
48db583https://github.com/nodejs/node/pull/59873/commits/48db583d3f3271e0a1e5d8d56471e36d937d18e8
https://github.com/nodejs/node/tree/48db583d3f3271e0a1e5d8d56471e36d937d18e8
added check if no-async-context-frame is enabled or nothttps://github.com/nodejs/node/pull/59873/commits/8e5b4a23869b6569dd7ea2e473c3573f11f365e4
https://github.com/avcribl
avcriblhttps://github.com/nodejs/node/commits?author=avcribl
8e5b4a2https://github.com/nodejs/node/pull/59873/commits/8e5b4a23869b6569dd7ea2e473c3573f11f365e4
https://github.com/nodejs/node/tree/8e5b4a23869b6569dd7ea2e473c3573f11f365e4
added unit testshttps://github.com/nodejs/node/pull/59873/commits/2d55f081bbb5a562d64c2b5e4b26350e6a824269
https://github.com/avcribl
avcriblhttps://github.com/nodejs/node/commits?author=avcribl
2d55f08https://github.com/nodejs/node/pull/59873/commits/2d55f081bbb5a562d64c2b5e4b26350e6a824269
https://github.com/nodejs/node/tree/2d55f081bbb5a562d64c2b5e4b26350e6a824269
bumped the number of iterationshttps://github.com/nodejs/node/pull/59873/commits/a7f49d3b5b299ece908f67d256fd3cea064924a6
https://github.com/avcribl
avcriblhttps://github.com/nodejs/node/commits?author=avcribl
a7f49d3https://github.com/nodejs/node/pull/59873/commits/a7f49d3b5b299ece908f67d256fd3cea064924a6
https://github.com/nodejs/node/tree/a7f49d3b5b299ece908f67d256fd3cea064924a6
fixed lint issueshttps://github.com/nodejs/node/pull/59873/commits/c49b350cd08a71f43e68c10499f07188d8334953
https://github.com/avcribl
avcriblhttps://github.com/nodejs/node/commits?author=avcribl
c49b350https://github.com/nodejs/node/pull/59873/commits/c49b350cd08a71f43e68c10499f07188d8334953
https://github.com/nodejs/node/tree/c49b350cd08a71f43e68c10499f07188d8334953
expanded on the unit testhttps://github.com/nodejs/node/pull/59873/commits/d51ca0dcb2a117a2e00b3a17eb985a9d37bf429f
https://github.com/avcribl
avcriblhttps://github.com/nodejs/node/commits?author=avcribl
d51ca0dhttps://github.com/nodejs/node/pull/59873/commits/d51ca0dcb2a117a2e00b3a17eb985a9d37bf429f
https://github.com/nodejs/node/tree/d51ca0dcb2a117a2e00b3a17eb985a9d37bf429f
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.