| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:d0913c59-1d08-012c-76ad-8fc8a9e98edf |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8A92:264976:CD605:105321:696AFDAF |
| html-safe-nonce | dda20ad729b8ba32057188bc545fe08e2a219029d6c44bd3ffdb1e4907387159 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QTkyOjI2NDk3NjpDRDYwNToxMDUzMjE6Njk2QUZEQUYiLCJ2aXNpdG9yX2lkIjoiNTc1MjczNjIzMDkwMTc0MzAyMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | e932262e0c70995e5ca4bf4b54e47b2227c18d7eb7b66d35603cd7d37b315e08 |
| hovercard-subject-tag | pull_request:64250988 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/5916/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/de576c22a300ed1498c1355c6d47a95b8b94c658b54a198d0124a54ddc90bd65/nodejs/node/pull/5916 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/de576c22a300ed1498c1355c6d47a95b8b94c658b54a198d0124a54ddc90bd65/nodejs/node/pull/5916 |
| og:image:alt | Pull Request check-list
Please make sure to review and check all of these items:
Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
this change (including linting)?
Is the comm... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Trott |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/5916#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F5916 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F5916 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/5916 |
| Reload | https://github.com/nodejs/node/pull/5916 |
| Reload | https://github.com/nodejs/node/pull/5916 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/5916 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
692
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/5916 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/5916#issue-comment-box |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:bengie | https://github.com/Trott/io.js/tree/bengie |
|
test: ensure existence of _handle property
| https://github.com/nodejs/node/pull/5916#top |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:bengie | https://github.com/Trott/io.js/tree/bengie |
|
Conversation
30
| https://github.com/nodejs/node/pull/5916 |
|
Commits
1
| https://github.com/nodejs/node/pull/5916/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/5916/checks |
|
Files changed
| https://github.com/nodejs/node/pull/5916/files |
| Please reload this page | https://github.com/nodejs/node/pull/5916 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Mar 26, 2016 | https://github.com/nodejs/node/pull/5916#issue-143755388 |
| @bengl | https://github.com/bengl |
| @drewfish | https://github.com/drewfish |
| Please reload this page | https://github.com/nodejs/node/pull/5916 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
|
process
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aprocess |
| Mar 26, 2016 | https://github.com/nodejs/node/pull/5916#event-604253628 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/23074bf70df3158e96e56b40a150850653c03804..45acadefedfb4bad14188b67730450b294508140 |
| 23074bf | https://github.com/nodejs/node/commit/23074bf70df3158e96e56b40a150850653c03804 |
| 45acade | https://github.com/nodejs/node/commit/45acadefedfb4bad14188b67730450b294508140 |
|
Compare
| https://github.com/nodejs/node/compare/23074bf70df3158e96e56b40a150850653c03804..45acadefedfb4bad14188b67730450b294508140 |
| March 26, 2016 22:38 | https://github.com/nodejs/node/pull/5916#event-604256845 |
| https://github.com/drewfish |
| drewfish | https://github.com/drewfish |
| Mar 26, 2016 | https://github.com/nodejs/node/pull/5916#issuecomment-201945264 |
| Please reload this page | https://github.com/nodejs/node/pull/5916 |
| https://github.com/santigimeno |
| santigimeno | https://github.com/santigimeno |
| Mar 26, 2016 | https://github.com/nodejs/node/pull/5916#issuecomment-201946475 |
| @Trott | https://github.com/Trott |
| Please reload this page | https://github.com/nodejs/node/pull/5916 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Mar 26, 2016 | https://github.com/nodejs/node/pull/5916#issuecomment-201948098 |
| @santigimeno | https://github.com/santigimeno |
| @bengl | https://github.com/bengl |
| Please reload this page | https://github.com/nodejs/node/pull/5916 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Mar 26, 2016 | https://github.com/nodejs/node/pull/5916#issuecomment-201948153 |
| Please reload this page | https://github.com/nodejs/node/pull/5916 |
| https://github.com/jbergstroem |
| jbergstroem | https://github.com/jbergstroem |
| Mar 27, 2016 | https://github.com/nodejs/node/pull/5916#issuecomment-201961337 |
| https://github.com/gentoo/gentoo/blob/master/net-libs/nodejs/nodejs-5.9.0.ebuild#L71..L76 | https://github.com/gentoo/gentoo/blob/master/net-libs/nodejs/nodejs-5.9.0.ebuild#L71..L76 |
| Please reload this page | https://github.com/nodejs/node/pull/5916 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Mar 27, 2016 | https://github.com/nodejs/node/pull/5916#issuecomment-201965766 |
| Please reload this page | https://github.com/nodejs/node/pull/5916 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Mar 27, 2016 | https://github.com/nodejs/node/pull/5916#issuecomment-202126418 |
| fs.ReadStream | https://github.com/nodejs/node/blob/293fd0453591ef0d87437a265ff515916d35d715/lib/fs.js#L1791 |
| inherit from net.Socket | https://github.com/nodejs/node/blob/293fd0453591ef0d87437a265ff515916d35d715/lib/tty.js#L29 |
| node/lib/internal/process/stdio.js | https://github.com/nodejs/node/blob/293fd0453591ef0d87437a265ff515916d35d715/lib/internal/process/stdio.js#L54-L57 |
| 293fd04 | https://github.com/nodejs/node/commit/293fd0453591ef0d87437a265ff515916d35d715 |
| Please reload this page | https://github.com/nodejs/node/pull/5916 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Mar 27, 2016
| https://github.com/nodejs/node/pull/5916#ref-issue-143828433 |
|
Piping from stdin is broken
#5927
| https://github.com/nodejs/node/issues/5927 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/45acadefedfb4bad14188b67730450b294508140..0b7bfdd52d883bf4b6a779620a0c18e198cc3298 |
| 45acade | https://github.com/nodejs/node/commit/45acadefedfb4bad14188b67730450b294508140 |
| 0b7bfdd | https://github.com/nodejs/node/commit/0b7bfdd52d883bf4b6a779620a0c18e198cc3298 |
|
Compare
| https://github.com/nodejs/node/compare/45acadefedfb4bad14188b67730450b294508140..0b7bfdd52d883bf4b6a779620a0c18e198cc3298 |
| March 27, 2016 21:17 | https://github.com/nodejs/node/pull/5916#event-604628422 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Mar 27, 2016 | https://github.com/nodejs/node/pull/5916#issuecomment-202148446 |
| @Fishrock123 | https://github.com/Fishrock123 |
| Please reload this page | https://github.com/nodejs/node/pull/5916 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Mar 28, 2016 | https://github.com/nodejs/node/pull/5916#issuecomment-202430199 |
| https://ci.nodejs.org/job/node-test-pull-request/2080/ | https://ci.nodejs.org/job/node-test-pull-request/2080/ |
| Please reload this page | https://github.com/nodejs/node/pull/5916 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Mar 28, 2016
| https://github.com/nodejs/node/pull/5916#ref-pullrequest-144003261 |
|
test: stdin is not always a net.Socket
#5935
| https://github.com/nodejs/node/pull/5935 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Mar 28, 2016 | https://github.com/nodejs/node/pull/5916#issuecomment-202439351 |
| #5935 | https://github.com/nodejs/node/pull/5935 |
| Please reload this page | https://github.com/nodejs/node/pull/5916 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Mar 28, 2016 | https://github.com/nodejs/node/pull/5916#issuecomment-202524317 |
| Please reload this page | https://github.com/nodejs/node/pull/5916 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Mar 28, 2016 | https://github.com/nodejs/node/pull/5916#issuecomment-202589027 |
| Please reload this page | https://github.com/nodejs/node/pull/5916 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Mar 28, 2016 | https://github.com/nodejs/node/pull/5916#issuecomment-202592337 |
| @drewfish | https://github.com/drewfish |
| @bengl | https://github.com/bengl |
| Please reload this page | https://github.com/nodejs/node/pull/5916 |
| https://github.com/bengl |
| bengl | https://github.com/bengl |
| Mar 28, 2016 | https://github.com/nodejs/node/pull/5916#issuecomment-202596385 |
| Please reload this page | https://github.com/nodejs/node/pull/5916 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Mar 28, 2016 | https://github.com/nodejs/node/pull/5916#issuecomment-202599948 |
| Please reload this page | https://github.com/nodejs/node/pull/5916 |
| https://github.com/bengl |
| bengl | https://github.com/bengl |
| Mar 28, 2016 | https://github.com/nodejs/node/pull/5916#issuecomment-202613436 |
| Please reload this page | https://github.com/nodejs/node/pull/5916 |
| https://github.com/drewfish |
| drewfish | https://github.com/drewfish |
| Mar 28, 2016 | https://github.com/nodejs/node/pull/5916#issuecomment-202619416 |
| @jbergstroem | https://github.com/jbergstroem |
| Please reload this page | https://github.com/nodejs/node/pull/5916 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Mar 30, 2016
| https://github.com/nodejs/node/pull/5916#discussion-diff-57923972 |
| View reviewed changes
| https://github.com/nodejs/node/pull/5916/files#diff-2590c335fc3d7d8dce3a314e6edcb76fa0fe2e286f0cb10808a6dae7ee061c8c |
| test/parallel/test-stdout-close-unref.js | https://github.com/nodejs/node/pull/5916/files#diff-2590c335fc3d7d8dce3a314e6edcb76fa0fe2e286f0cb10808a6dae7ee061c8c |
| Fishrock123 | https://github.com/Fishrock123 |
| Mar 30, 2016 | https://github.com/nodejs/node/pull/5916#discussion_r57923972 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #5834 | https://github.com/nodejs/node/pull/5834 |
| Please reload this page | https://github.com/nodejs/node/pull/5916 |
| Trott | https://github.com/Trott |
| Mar 30, 2016 | https://github.com/nodejs/node/pull/5916#discussion_r57977718 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @Fishrock123 | https://github.com/Fishrock123 |
| Please reload this page | https://github.com/nodejs/node/pull/5916 |
| https://github.com/jbergstroem |
| jbergstroem | https://github.com/jbergstroem |
| Mar 30, 2016 | https://github.com/nodejs/node/pull/5916#issuecomment-203661796 |
| @drewfish | https://github.com/drewfish |
| gentoo sandbox | https://wiki.gentoo.org/wiki/Project:Sandbox |
| Please reload this page | https://github.com/nodejs/node/pull/5916 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/bc85d4650cbb94beacc32befa47d90931c0d7497..b808952ce824d73f06c44d72cd9163275563b221 |
| bc85d46 | https://github.com/nodejs/node/commit/bc85d4650cbb94beacc32befa47d90931c0d7497 |
| b808952 | https://github.com/nodejs/node/commit/b808952ce824d73f06c44d72cd9163275563b221 |
|
Compare
| https://github.com/nodejs/node/compare/bc85d4650cbb94beacc32befa47d90931c0d7497..b808952ce824d73f06c44d72cd9163275563b221 |
| March 30, 2016 23:11 | https://github.com/nodejs/node/pull/5916#event-609043824 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Mar 30, 2016 | https://github.com/nodejs/node/pull/5916#issuecomment-203677487 |
| https://ci.nodejs.org/job/node-test-pull-request/2103/ | https://ci.nodejs.org/job/node-test-pull-request/2103/ |
| Please reload this page | https://github.com/nodejs/node/pull/5916 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Mar 30, 2016 | https://github.com/nodejs/node/pull/5916#event-609045024 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Mar 31, 2016 | https://github.com/nodejs/node/pull/5916#issuecomment-203727325 |
| https://ci.nodejs.org/job/node-test-pull-request/2105/ | https://ci.nodejs.org/job/node-test-pull-request/2105/ |
| Please reload this page | https://github.com/nodejs/node/pull/5916 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Mar 31, 2016 | https://github.com/nodejs/node/pull/5916#issuecomment-204011481 |
| https://ci.nodejs.org/job/node-test-pull-request/2112/ | https://ci.nodejs.org/job/node-test-pull-request/2112/ |
| Please reload this page | https://github.com/nodejs/node/pull/5916 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Mar 31, 2016 | https://github.com/nodejs/node/pull/5916#issuecomment-204011809 |
| @Fishrock123 | https://github.com/Fishrock123 |
| Please reload this page | https://github.com/nodejs/node/pull/5916 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Mar 31, 2016
| https://github.com/nodejs/node/pull/5916#discussion-diff-58085878 |
| View reviewed changes
| https://github.com/nodejs/node/pull/5916/files#diff-2590c335fc3d7d8dce3a314e6edcb76fa0fe2e286f0cb10808a6dae7ee061c8c |
| test/parallel/test-stdout-close-unref.js | https://github.com/nodejs/node/pull/5916/files#diff-2590c335fc3d7d8dce3a314e6edcb76fa0fe2e286f0cb10808a6dae7ee061c8c |
| Fishrock123 | https://github.com/Fishrock123 |
| Mar 31, 2016 | https://github.com/nodejs/node/pull/5916#discussion_r58085878 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/5916 |
| Trott | https://github.com/Trott |
| Mar 31, 2016 | https://github.com/nodejs/node/pull/5916#discussion_r58144428 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @Fishrock123 | https://github.com/Fishrock123 |
| Please reload this page | https://github.com/nodejs/node/pull/5916 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Mar 31, 2016 | https://github.com/nodejs/node/pull/5916#issuecomment-204012418 |
| Please reload this page | https://github.com/nodejs/node/pull/5916 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Mar 31, 2016
| https://github.com/nodejs/node/pull/5916#ref-commit-d6c9f64 |
|
| https://github.com/Fishrock123 |
| test: stdin is not always a net.Socket | https://github.com/Fishrock123/node/commit/d6c9f64e98092bbca41209bb1babe22bee64be42 |
| d6c9f64 | https://github.com/Fishrock123/node/commit/d6c9f64e98092bbca41209bb1babe22bee64be42 |
| nodejs#5916 | https://github.com/nodejs/node/pull/5916 |
| nodejs#5935 | https://github.com/nodejs/node/pull/5935 |
|
| https://github.com/Trott |
| test: ensure _handle property existence | https://github.com/nodejs/node/pull/5916/commits/fa8f31f6f4782b88711abd2b3fcf47d5118ae886 |
| fa8f31f | https://github.com/nodejs/node/pull/5916/commits/fa8f31f6f4782b88711abd2b3fcf47d5118ae886 |
| @bengl | https://github.com/bengl |
| @drewfish | https://github.com/drewfish |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/b808952ce824d73f06c44d72cd9163275563b221..fa8f31f6f4782b88711abd2b3fcf47d5118ae886 |
| b808952 | https://github.com/nodejs/node/commit/b808952ce824d73f06c44d72cd9163275563b221 |
| fa8f31f | https://github.com/nodejs/node/commit/fa8f31f6f4782b88711abd2b3fcf47d5118ae886 |
|
Compare
| https://github.com/nodejs/node/compare/b808952ce824d73f06c44d72cd9163275563b221..fa8f31f6f4782b88711abd2b3fcf47d5118ae886 |
| March 31, 2016 23:34 | https://github.com/nodejs/node/pull/5916#event-610580467 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Mar 31, 2016 | https://github.com/nodejs/node/pull/5916#issuecomment-204175241 |
| Please reload this page | https://github.com/nodejs/node/pull/5916 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Mar 31, 2016 | https://github.com/nodejs/node/pull/5916#issuecomment-204175360 |
| https://ci.nodejs.org/job/node-test-pull-request/2116/ | https://ci.nodejs.org/job/node-test-pull-request/2116/ |
| Please reload this page | https://github.com/nodejs/node/pull/5916 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
lts-watch-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x |
| Apr 1, 2016 | https://github.com/nodejs/node/pull/5916#event-610608908 |
| Trott | https://github.com/Trott |
|
Apr 1, 2016
| https://github.com/nodejs/node/pull/5916#ref-commit-a20c700 |
|
| https://github.com/Trott |
| test: ensure _handle property existence | https://github.com/Trott/io.js/commit/a20c70029075cab18e4ff4d27dfd95b7eda2b268 |
| a20c700 | https://github.com/Trott/io.js/commit/a20c70029075cab18e4ff4d27dfd95b7eda2b268 |
| @bengl | https://github.com/bengl |
| @drewfish | https://github.com/drewfish |
| nodejs#5916 | https://github.com/nodejs/node/pull/5916 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Apr 1, 2016 | https://github.com/nodejs/node/pull/5916#issuecomment-204226526 |
| a20c700 | https://github.com/nodejs/node/commit/a20c70029075cab18e4ff4d27dfd95b7eda2b268 |
| Please reload this page | https://github.com/nodejs/node/pull/5916 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Apr 1, 2016 | https://github.com/nodejs/node/pull/5916#event-610728079 |
| MylesBorins | https://github.com/MylesBorins |
|
Apr 5, 2016
| https://github.com/nodejs/node/pull/5916#ref-commit-f14d71c |
|
| https://github.com/Fishrock123 |
| test: stdin is not always a net.Socket | https://github.com/nodejs/node/commit/f14d71ccea6b9bfb63e2ac2fc2004a904e511466 |
| f14d71c | https://github.com/nodejs/node/commit/f14d71ccea6b9bfb63e2ac2fc2004a904e511466 |
| #5916 | https://github.com/nodejs/node/pull/5916 |
| #5935 | https://github.com/nodejs/node/pull/5935 |
| MylesBorins | https://github.com/MylesBorins |
|
Apr 5, 2016
| https://github.com/nodejs/node/pull/5916#ref-commit-96bb315 |
|
| https://github.com/Trott |
| test: ensure _handle property existence | https://github.com/nodejs/node/commit/96bb3152629c56f1a158e9fdf586c294ff2991ba |
| 96bb315 | https://github.com/nodejs/node/commit/96bb3152629c56f1a158e9fdf586c294ff2991ba |
| @bengl | https://github.com/bengl |
| @drewfish | https://github.com/drewfish |
| #5916 | https://github.com/nodejs/node/pull/5916 |
|
V5.10.1 proposal
#6059
| https://github.com/nodejs/node/pull/6059 |
|
V5.10.1 proposal
#6060
| https://github.com/nodejs/node/pull/6060 |
| MylesBorins | https://github.com/MylesBorins |
|
Apr 11, 2016
| https://github.com/nodejs/node/pull/5916#ref-commit-d59be4d |
|
| https://github.com/Trott |
| test: ensure _handle property existence | https://github.com/nodejs/node/commit/d59be4d2484fde2285ffe202a9b0acbd7fcb90e2 |
| d59be4d | https://github.com/nodejs/node/commit/d59be4d2484fde2285ffe202a9b0acbd7fcb90e2 |
| @bengl | https://github.com/bengl |
| @drewfish | https://github.com/drewfish |
| #5916 | https://github.com/nodejs/node/pull/5916 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v4.x |
|
lts-watch-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x |
| Apr 11, 2016 | https://github.com/nodejs/node/pull/5916#event-622641047 |
| MylesBorins | https://github.com/MylesBorins |
|
Apr 11, 2016
| https://github.com/nodejs/node/pull/5916#ref-commit-63d8296 |
|
| https://github.com/Fishrock123 |
| test: stdin is not always a net.Socket | https://github.com/nodejs/node/commit/63d82960fd542827cc5e402ba71e29a5aa67b006 |
| 63d8296 | https://github.com/nodejs/node/commit/63d82960fd542827cc5e402ba71e29a5aa67b006 |
| #5916 | https://github.com/nodejs/node/pull/5916 |
| #5935 | https://github.com/nodejs/node/pull/5935 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Apr 11, 2016
| https://github.com/nodejs/node/pull/5916#ref-pullrequest-147505251 |
|
V4.4.3 proposal
#6149
| https://github.com/nodejs/node/pull/6149 |
| https://github.com/STRML |
| STRML | https://github.com/STRML |
|
Jan 9, 2017
| https://github.com/nodejs/node/pull/5916#ref-issue-199574800 |
|
uws: Cannot read property 'fd' of null
primus/primus#530
| https://github.com/primus/primus/issues/530 |
| https://github.com/danbev |
| danbev | https://github.com/danbev |
|
Oct 22, 2017
| https://github.com/nodejs/node/pull/5916#ref-pullrequest-267465683 |
|
test: make test-v8-serdes work without stdin
#16382
| https://github.com/nodejs/node/pull/16382 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| January 13, 2022 22:42 | https://github.com/nodejs/node/pull/5916#event-5890936218 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F5916 |
|
process
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aprocess |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/5916 |
|
| https://github.com/Trott |
|
| https://github.com/drewfish |
|
| https://github.com/santigimeno |
|
| https://github.com/jbergstroem |
|
| https://github.com/Fishrock123 |
|
| https://github.com/bengl |
|
| https://github.com/mhdawson |
|
| https://github.com/MylesBorins |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |