Title: src: simplify adding fast APIs to ExternalReferenceRegistry by Renegade334 · Pull Request #58896 · nodejs/node · GitHub
Open Graph Title: src: simplify adding fast APIs to ExternalReferenceRegistry by Renegade334 · Pull Request #58896 · nodejs/node
X Title: src: simplify adding fast APIs to ExternalReferenceRegistry by Renegade334 · Pull Request #58896 · nodejs/node
Description: The process for adding a fast API to the external registry is currently rather cumbersome, and involves: adding the fast callback typedef to the long and ugly list of "allowed" CFunction signatures in node_external_reference.h registering the fast callback registering the v8::CFunctionInfo object obtained from the corresponding CFunction This PR adds a new registry overload which simply takes a reference to the CFunction and registers both the callback pointer and the info pointer, without requiring any additional typedefs.
Open Graph Description: The process for adding a fast API to the external registry is currently rather cumbersome, and involves: adding the fast callback typedef to the long and ugly list of "allowed" CFunction...
X Description: The process for adding a fast API to the external registry is currently rather cumbersome, and involves: adding the fast callback typedef to the long and ugly list of "allowed" C...
Opengraph URL: https://github.com/nodejs/node/pull/58896
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:d54033f4-24e3-1133-6365-441242a03d77 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 921C:228A12:EBB73D:144C0CD:6A4C9FAE |
| html-safe-nonce | 20801ac4b45cc0f9cb2cf4534fa30a93c1aa0e6f33987c5ace8f23841f044614 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MjFDOjIyOEExMjpFQkI3M0Q6MTQ0QzBDRDo2QTRDOUZBRSIsInZpc2l0b3JfaWQiOiI3MTU1Nzk3ODU0OTA4MDk2NDMwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 476548c4a1724a0a7affaf90baac0f3ae3f9a879f34605f6897b139116c68704 |
| hovercard-subject-tag | pull_request:2627319772 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodejs/node/pull/58896/files |
| twitter:image | https://avatars.githubusercontent.com/u/9092381?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/9092381?s=400&v=4 |
| og:image:alt | The process for adding a fast API to the external registry is currently rather cumbersome, and involves: adding the fast callback typedef to the long and ugly list of "allowed" CFunction... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3d11bb817438277de2a940854450e83a7d32b6aeb5014e9e6b00a6423900251c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | ae90d426644ca15e89bacceb72e51f4e9dbf85f7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width