René's URL Explorer Experiment


Title: tools: Compile maglev files into v8_compiler if maglev is disabled by ziyao233 · Pull Request #58861 · nodejs/node · GitHub

Open Graph Title: tools: Compile maglev files into v8_compiler if maglev is disabled by ziyao233 · Pull Request #58861 · nodejs/node

X Title: tools: Compile maglev files into v8_compiler if maglev is disabled by ziyao233 · Pull Request #58861 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: v8_compiler needs maglev graph builder even if maglev is disabled. But the required files shouldn't be compiled into v8_internal_headers, which both v8_base_without_compiler and v8_compiler dep...

X Description: v8_compiler needs maglev graph builder even if maglev is disabled. But the required files shouldn't be compiled into v8_internal_headers, which both v8_base_without_compiler and v8_compiler...

Opengraph URL: https://github.com/nodejs/node/pull/58861

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c0743fef-db02-1963-f9ba-88d5b30243ad
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9ABE:E4373:5CC8D:7D354:6A4D8042
html-safe-nonce3994191ed1855393ca89e3cea524984addf636fde6f6213082516956f533a7e6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QUJFOkU0MzczOjVDQzhEOjdEMzU0OjZBNEQ4MDQyIiwidmlzaXRvcl9pZCI6IjYwMDQ2NzE2ODA5OTA3NzMzMTQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac931f7f2646b801334668e6a173e6d1c7364abc0f4f0fda9fae30fb0f093ae32f
hovercard-subject-tagpull_request:2623989917
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/58861/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8c51f051b1031befd68762280e1e4e2b78232d6058bd931276450ae197f2e8f9/nodejs/node/pull/58861
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8c51f051b1031befd68762280e1e4e2b78232d6058bd931276450ae197f2e8f9/nodejs/node/pull/58861
og:image:altv8_compiler needs maglev graph builder even if maglev is disabled. But the required files shouldn't be compiled into v8_internal_headers, which both v8_base_without_compiler and v8_compiler dep...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameziyao233
hostnamegithub.com
expected-hostnamegithub.com
Nonec6bf61c909482ec3072ef5d7a5a28f2a9d214788c9a44793eca1960048cb05ae
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release6702a58b419a792226bd21ef0fb1bcb318bbcaa3
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/58861#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F58861
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F58861
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/58861
Reloadhttps://github.com/nodejs/node/pull/58861
Reloadhttps://github.com/nodejs/node/pull/58861
Please reload this pagehttps://github.com/nodejs/node/pull/58861
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/58861
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 963 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
ziyao233https://github.com/ziyao233
nodejs:mainhttps://github.com/nodejs/node/tree/main
ziyao233:v8/fix-maglev-compilationhttps://github.com/ziyao233/node/tree/v8/fix-maglev-compilation
Conversationhttps://github.com/nodejs/node/pull/58861
Commits1 (1)https://github.com/nodejs/node/pull/58861/commits
Checkshttps://github.com/nodejs/node/pull/58861/checks
Files changedhttps://github.com/nodejs/node/pull/58861/files
tools: Compile maglev files into v8_compiler if maglev is disabledhttps://github.com/nodejs/node/pull/58861#top
ziyao233https://github.com/ziyao233
nodejs:mainhttps://github.com/nodejs/node/tree/main
ziyao233:v8/fix-maglev-compilationhttps://github.com/ziyao233/node/tree/v8/fix-maglev-compilation
https://github.com/ziyao233
ziyao233https://github.com/ziyao233
Jun 27, 2025https://github.com/nodejs/node/pull/58861#issue-3182361092
Please reload this pagehttps://github.com/nodejs/node/pull/58861
https://github.com/ziyao233
tools: Compile maglev files into v8_compiler if maglev is disabledhttps://github.com/nodejs/node/pull/58861/commits/886aa1d5c352114658fc39b38d7d45798a4ad17d
886aa1dhttps://github.com/nodejs/node/pull/58861/commits/886aa1d5c352114658fc39b38d7d45798a4ad17d
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 27, 2025https://github.com/nodejs/node/pull/58861#issuecomment-3012578134
Please reload this pagehttps://github.com/nodejs/node/pull/58861
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
tools https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools
v8 engine https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22
Jun 27, 2025https://github.com/nodejs/node/pull/58861#event-18355001218
https://github.com/ziyao233
ziyao233https://github.com/ziyao233
Jun 27, 2025https://github.com/nodejs/node/pull/58861#issuecomment-3012611588
Please reload this pagehttps://github.com/nodejs/node/pull/58861
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Jun 30, 2025 https://github.com/nodejs/node/pull/58861#pullrequestreview-2972705110
View reviewed changes https://github.com/nodejs/node/pull/58861/files/886aa1d5c352114658fc39b38d7d45798a4ad17d
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jun 30, 2025https://github.com/nodejs/node/pull/58861#event-18394783863
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jun 30, 2025https://github.com/nodejs/node/pull/58861#event-18394861323
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 30, 2025https://github.com/nodejs/node/pull/58861#issuecomment-3020733370
https://ci.nodejs.org/job/node-test-pull-request/67756/https://ci.nodejs.org/job/node-test-pull-request/67756/
Please reload this pagehttps://github.com/nodejs/node/pull/58861
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 30, 2025https://github.com/nodejs/node/pull/58861#issuecomment-3020734928
https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6636/https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6636/
Please reload this pagehttps://github.com/nodejs/node/pull/58861
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 30, 2025https://github.com/nodejs/node/pull/58861#issuecomment-3020737293
https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6636/https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6636/
Please reload this pagehttps://github.com/nodejs/node/pull/58861
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 30, 2025https://github.com/nodejs/node/pull/58861#issuecomment-3020746409
https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6636/https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6636/
Please reload this pagehttps://github.com/nodejs/node/pull/58861
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 30, 2025https://github.com/nodejs/node/pull/58861#issuecomment-3020970871
https://ci.nodejs.org/job/node-test-pull-request/67758/https://ci.nodejs.org/job/node-test-pull-request/67758/
Please reload this pagehttps://github.com/nodejs/node/pull/58861
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Jul 4, 2025 https://github.com/nodejs/node/pull/58861#ref-issue-3202394884
nodejs 24.0.1 tries and fails to link v8's maglev on s390x #58954 https://github.com/nodejs/node/issues/58954
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Jul 4, 2025 https://github.com/nodejs/node/pull/58861#pullrequestreview-2988295768
View reviewed changes https://github.com/nodejs/node/pull/58861/files/886aa1d5c352114658fc39b38d7d45798a4ad17d
https://github.com/richardlau
richardlauhttps://github.com/richardlau
dont-land-on-v20.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v20.x
dont-land-on-v22.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v22.x
Jul 4, 2025https://github.com/nodejs/node/pull/58861#event-18477835157
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
Jul 5, 2025 https://github.com/nodejs/node/pull/58861#pullrequestreview-2990799611
View reviewed changes https://github.com/nodejs/node/pull/58861/files/886aa1d5c352114658fc39b38d7d45798a4ad17d
richardlauhttps://github.com/richardlau
Jul 7, 2025 https://github.com/nodejs/node/pull/58861#ref-commit-7be2528
https://github.com/ziyao233
https://github.com/richardlau
tools: compile maglev files into v8_compiler if maglev is disabledhttps://github.com/nodejs/node/commit/7be2528e05448a9a291ec679aa823d119c997141
7be2528https://github.com/nodejs/node/commit/7be2528e05448a9a291ec679aa823d119c997141
#58954https://github.com/nodejs/node/issues/58954
#58861https://github.com/nodejs/node/pull/58861
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Jul 7, 2025https://github.com/nodejs/node/pull/58861#issuecomment-3045290054
7be2528https://github.com/nodejs/node/commit/7be2528e05448a9a291ec679aa823d119c997141
Please reload this pagehttps://github.com/nodejs/node/pull/58861
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Jul 7, 2025https://github.com/nodejs/node/pull/58861#event-18506158370
RafaelGSShttps://github.com/RafaelGSS
Jul 8, 2025 https://github.com/nodejs/node/pull/58861#ref-commit-e8dd189
https://github.com/ziyao233
https://github.com/RafaelGSS
tools: compile maglev files into v8_compiler if maglev is disabledhttps://github.com/nodejs/node/commit/e8dd1897d58b4c48e54154e8ee1de85b6edf5bcb
e8dd189https://github.com/nodejs/node/commit/e8dd1897d58b4c48e54154e8ee1de85b6edf5bcb
#58954https://github.com/nodejs/node/issues/58954
#58861https://github.com/nodejs/node/pull/58861
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jul 8, 2025 https://github.com/nodejs/node/pull/58861#ref-pullrequest-3212840261
2025-07-09, Version 24.4.0 (Current) #58993 https://github.com/nodejs/node/pull/58993
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F58861
https://github.com/joyeecheung
joyeecheung https://github.com/joyeecheung
https://github.com/nodejs/node/pull/58861/files/886aa1d5c352114658fc39b38d7d45798a4ad17d
https://github.com/richardlau
richardlau https://github.com/richardlau
https://github.com/nodejs/node/pull/58861/files/886aa1d5c352114658fc39b38d7d45798a4ad17d
https://github.com/RafaelGSS
RafaelGSS https://github.com/RafaelGSS
https://github.com/nodejs/node/pull/58861/files/886aa1d5c352114658fc39b38d7d45798a4ad17d
dont-land-on-v22.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v22.x
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
tools https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools
v8 engine https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22
Please reload this pagehttps://github.com/nodejs/node/pull/58861
https://github.com/ziyao233
https://github.com/nodejs-github-bot
https://github.com/richardlau
https://github.com/joyeecheung
https://github.com/RafaelGSS
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.