René's URL Explorer Experiment


Title: fs: close dir before throwing if `options.bufferSize` is invalid by LiviaMedeiros · Pull Request #58856 · nodejs/node · GitHub

Open Graph Title: fs: close dir before throwing if `options.bufferSize` is invalid by LiviaMedeiros · Pull Request #58856 · nodejs/node

X Title: fs: close dir before throwing if `options.bufferSize` is invalid by LiviaMedeiros · Pull Request #58856 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes: #58854 Test blocked on: #58855

X Description: Fixes: #58854 Test blocked on: #58855

Opengraph URL: https://github.com/nodejs/node/pull/58856

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:386fad5c-7249-4f72-3eed-cdcc0e19256a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8D30:3415D:F266A6:1488A0F:6A4D6199
html-safe-noncec4a7797a2e9467299a522218858111df97898387f585cbe70587adb3c8f51750
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RDMwOjM0MTVEOkYyNjZBNjoxNDg4QTBGOjZBNEQ2MTk5IiwidmlzaXRvcl9pZCI6IjQ0OTQxNTU2NDQ2MTAxMDk4NDkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac529a3cff237d93f901778c50d1d7915f6c5c05c8ea2e98a2d138975a0e3d7bae
hovercard-subject-tagpull_request:2622400283
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/58856/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/20d94c9ad22222a668231b91a0765878ffad02cd85dcbdbbd9debc3005a53602/nodejs/node/pull/58856
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/20d94c9ad22222a668231b91a0765878ffad02cd85dcbdbbd9debc3005a53602/nodejs/node/pull/58856
og:image:altFixes: #58854 Test blocked on: #58855
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameLiviaMedeiros
hostnamegithub.com
expected-hostnamegithub.com
Nonee6658d7c7808aeed776f841e0839b885fce343c9b96244be612c779298e7661e
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasea438513d3a22ffcd713795ed948c3e5525007665
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/58856#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F58856
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F58856
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/58856
Reloadhttps://github.com/nodejs/node/pull/58856
Reloadhttps://github.com/nodejs/node/pull/58856
Please reload this pagehttps://github.com/nodejs/node/pull/58856
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/58856
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 961 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
LiviaMedeiros:fs-dir-close-on-invalid-bufferhttps://github.com/LiviaMedeiros/node/tree/fs-dir-close-on-invalid-buffer
Conversationhttps://github.com/nodejs/node/pull/58856
Commits1 (1)https://github.com/nodejs/node/pull/58856/commits
Checkshttps://github.com/nodejs/node/pull/58856/checks
Files changedhttps://github.com/nodejs/node/pull/58856/files
fs: close dir before throwing if options.bufferSize is invalidhttps://github.com/nodejs/node/pull/58856#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
LiviaMedeiros:fs-dir-close-on-invalid-bufferhttps://github.com/LiviaMedeiros/node/tree/fs-dir-close-on-invalid-buffer
https://github.com/LiviaMedeiros
LiviaMedeiroshttps://github.com/LiviaMedeiros
Jun 26, 2025https://github.com/nodejs/node/pull/58856#issue-3180507263
Please reload this pagehttps://github.com/nodejs/node/pull/58856
#58854https://github.com/nodejs/node/issues/58854
#58855https://github.com/nodejs/node/pull/58855
Please reload this pagehttps://github.com/nodejs/node/pull/58856
https://github.com/LiviaMedeiros
LiviaMedeiroshttps://github.com/LiviaMedeiros
blocked https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ablocked
Jun 26, 2025https://github.com/nodejs/node/pull/58856#event-18344493799
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Jun 26, 2025https://github.com/nodejs/node/pull/58856#event-18344496726
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Jun 26, 2025https://github.com/nodejs/node/pull/58856#issuecomment-3010353125
Please reload this pagehttps://github.com/nodejs/node/pull/58856
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/58856?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
(4d5ee24)https://app.codecov.io/gh/nodejs/node/commit/4d5ee2491b9c31b142ff48b648ec535b2c5aad13?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
(eadbae5)https://app.codecov.io/gh/nodejs/node/commit/eadbae56bb701769473930af8fdfe928eef2e4ba?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/58856?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/fs/dir.jshttps://app.codecov.io/gh/nodejs/node/pull/58856?src=pr&el=tree&filepath=lib%2Finternal%2Ffs%2Fdir.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL2ZzL2Rpci5qcw==
29 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/58856/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/58856
https://github.com/LiviaMedeiros
LiviaMedeiroshttps://github.com/LiviaMedeiros
force-pushedhttps://github.com/nodejs/node/compare/2155c48d91a19a00b021c6d33343f582c64e44f3..67ea5695cb94a4e223c90eeb16a211f30f5fae5d
2155c48https://github.com/nodejs/node/commit/2155c48d91a19a00b021c6d33343f582c64e44f3
67ea569https://github.com/nodejs/node/commit/67ea5695cb94a4e223c90eeb16a211f30f5fae5d
Compare https://github.com/nodejs/node/compare/2155c48d91a19a00b021c6d33343f582c64e44f3..67ea5695cb94a4e223c90eeb16a211f30f5fae5d
June 29, 2025 05:53https://github.com/nodejs/node/pull/58856#event-18372676465
https://github.com/LiviaMedeiros
LiviaMedeiroshttps://github.com/LiviaMedeiros
blocked https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ablocked
Jun 29, 2025https://github.com/nodejs/node/pull/58856#event-18372676533
https://github.com/LiviaMedeiros
fs: close dir before throwing if options.bufferSize is invalidhttps://github.com/nodejs/node/pull/58856/commits/eadbae56bb701769473930af8fdfe928eef2e4ba
eadbae5https://github.com/nodejs/node/pull/58856/commits/eadbae56bb701769473930af8fdfe928eef2e4ba
https://github.com/LiviaMedeiros
LiviaMedeiroshttps://github.com/LiviaMedeiros
force-pushedhttps://github.com/nodejs/node/compare/67ea5695cb94a4e223c90eeb16a211f30f5fae5d..eadbae56bb701769473930af8fdfe928eef2e4ba
67ea569https://github.com/nodejs/node/commit/67ea5695cb94a4e223c90eeb16a211f30f5fae5d
eadbae5https://github.com/nodejs/node/commit/eadbae56bb701769473930af8fdfe928eef2e4ba
Compare https://github.com/nodejs/node/compare/67ea5695cb94a4e223c90eeb16a211f30f5fae5d..eadbae56bb701769473930af8fdfe928eef2e4ba
June 29, 2025 05:57https://github.com/nodejs/node/pull/58856#event-18372685278
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 29, 2025https://github.com/nodejs/node/pull/58856#issuecomment-3016778640
https://ci.nodejs.org/job/node-test-pull-request/67717/https://ci.nodejs.org/job/node-test-pull-request/67717/
Please reload this pagehttps://github.com/nodejs/node/pull/58856
https://github.com/lpinca
lpincahttps://github.com/lpinca
Jul 5, 2025 https://github.com/nodejs/node/pull/58856#pullrequestreview-2990549024
View reviewed changes https://github.com/nodejs/node/pull/58856/files/eadbae56bb701769473930af8fdfe928eef2e4ba
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jul 5, 2025 https://github.com/nodejs/node/pull/58856#pullrequestreview-2990561605
View reviewed changes https://github.com/nodejs/node/pull/58856/files/eadbae56bb701769473930af8fdfe928eef2e4ba
https://github.com/juanarbol
juanarbolhttps://github.com/juanarbol
Jul 6, 2025 https://github.com/nodejs/node/pull/58856#pullrequestreview-2991010334
View reviewed changes https://github.com/nodejs/node/pull/58856/files/eadbae56bb701769473930af8fdfe928eef2e4ba
https://github.com/juanarbol
juanarbolhttps://github.com/juanarbol
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Jul 6, 2025https://github.com/nodejs/node/pull/58856#event-18489861450
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Jul 6, 2025https://github.com/nodejs/node/pull/58856#event-18489912011
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
9ab9763https://github.com/nodejs/node/commit/9ab976397da80e84ebf9ed12c3e7bd308aab6de1
Jul 6, 2025https://github.com/nodejs/node/pull/58856#event-18489914664
Please reload this pagehttps://github.com/nodejs/node/pull/58856
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 6, 2025https://github.com/nodejs/node/pull/58856#issuecomment-3040955461
9ab9763https://github.com/nodejs/node/commit/9ab976397da80e84ebf9ed12c3e7bd308aab6de1
Please reload this pagehttps://github.com/nodejs/node/pull/58856
RafaelGSShttps://github.com/RafaelGSS
Jul 8, 2025 https://github.com/nodejs/node/pull/58856#ref-commit-b378fc3
https://github.com/LiviaMedeiros
https://github.com/RafaelGSS
fs: close dir before throwing if options.bufferSize is invalidhttps://github.com/nodejs/node/commit/b378fc3ac08f2102eb3107254dd4591dbe3940bb
b378fc3https://github.com/nodejs/node/commit/b378fc3ac08f2102eb3107254dd4591dbe3940bb
#58856https://github.com/nodejs/node/pull/58856
#58854https://github.com/nodejs/node/issues/58854
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jul 8, 2025 https://github.com/nodejs/node/pull/58856#ref-pullrequest-3212840261
2025-07-09, Version 24.4.0 (Current) #58993 https://github.com/nodejs/node/pull/58993
aduh95https://github.com/aduh95
Jul 21, 2025 https://github.com/nodejs/node/pull/58856#ref-commit-fb8b85a
https://github.com/LiviaMedeiros
https://github.com/aduh95
fs: close dir before throwing if options.bufferSize is invalidhttps://github.com/nodejs/node/commit/fb8b85adb2505dac77edc7f0ff95fafa06009e29
fb8b85ahttps://github.com/nodejs/node/commit/fb8b85adb2505dac77edc7f0ff95fafa06009e29
#58856https://github.com/nodejs/node/pull/58856
#58854https://github.com/nodejs/node/issues/58854
aduh95https://github.com/aduh95
Jul 24, 2025 https://github.com/nodejs/node/pull/58856#ref-commit-c7ebf2e
https://github.com/LiviaMedeiros
https://github.com/aduh95
fs: close dir before throwing if options.bufferSize is invalidhttps://github.com/nodejs/node/commit/c7ebf2e24579d2867d38735582bd343a1a12363f
c7ebf2ehttps://github.com/nodejs/node/commit/c7ebf2e24579d2867d38735582bd343a1a12363f
#58856https://github.com/nodejs/node/pull/58856
#58854https://github.com/nodejs/node/issues/58854
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jul 28, 2025 https://github.com/nodejs/node/pull/58856#ref-pullrequest-3268981161
2025-07-29, Version 22.18.0 'Jod' (LTS) #59256 https://github.com/nodejs/node/pull/59256
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F58856
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/58856/files/eadbae56bb701769473930af8fdfe928eef2e4ba
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/58856/files/eadbae56bb701769473930af8fdfe928eef2e4ba
https://github.com/juanarbol
juanarbol https://github.com/juanarbol
https://github.com/nodejs/node/pull/58856/files/eadbae56bb701769473930af8fdfe928eef2e4ba
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
fs: opendirSync() leaks directory handle on error https://github.com/nodejs/node/issues/58854
Please reload this pagehttps://github.com/nodejs/node/pull/58856
https://github.com/LiviaMedeiros
https://github.com/nodejs-github-bot
https://github.com/jasnell
https://github.com/lpinca
https://github.com/juanarbol
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.