René's URL Explorer Experiment


Title: test: close dirs in `fs-opendir` test by LiviaMedeiros · Pull Request #58855 · nodejs/node · GitHub

Open Graph Title: test: close dirs in `fs-opendir` test by LiviaMedeiros · Pull Request #58855 · nodejs/node

X Title: test: close dirs in `fs-opendir` test by LiviaMedeiros · Pull Request #58855 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Two subtests in test-fs-opendir.js are not closing dir. Let's fix it.

X Description: Two subtests in test-fs-opendir.js are not closing dir. Let's fix it.

Mail addresses
luigipinca@gmail.com
duhamelantoine1995@gmail.com
livia@cirno.name
luigipinca@gmail.com
duhamelantoine1995@gmail.com
livia@cirno.name

Opengraph URL: https://github.com/nodejs/node/pull/58855

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:8d4547e2-bca3-ebfd-bb13-4a1ffc2b77a5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8750:55779:128F4D3:19BD194:6A4EA171
html-safe-noncec0bc8af2172b04b68599089dc6166381ad3fbdf468dfb3c16cf56f16b1b2ead6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NzUwOjU1Nzc5OjEyOEY0RDM6MTlCRDE5NDo2QTRFQTE3MSIsInZpc2l0b3JfaWQiOiI4NDg4NTI1ODYzMjU5NjQ0MjczIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac637f0e67a1ec914c9219c2b1ee85a699fcf7f57a796cd76e32f78369631ca651
hovercard-subject-tagpull_request:2622351092
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/58855/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/3c4033154f93771714bea1658a7d1dfe55ba8e30c56f5e644ab3bff7b7d386eb/nodejs/node/pull/58855
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3c4033154f93771714bea1658a7d1dfe55ba8e30c56f5e644ab3bff7b7d386eb/nodejs/node/pull/58855
og:image:altTwo subtests in test-fs-opendir.js are not closing dir. Let's fix it.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameLiviaMedeiros
hostnamegithub.com
expected-hostnamegithub.com
None41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee6a744804e8e70f97b4d5a18a94dcc63db22f97a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/58855#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F58855
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F58855
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/58855
Reloadhttps://github.com/nodejs/node/pull/58855
Reloadhttps://github.com/nodejs/node/pull/58855
Please reload this pagehttps://github.com/nodejs/node/pull/58855
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/58855
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 963 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
LiviaMedeiros:test-fs-opendir-close-handleshttps://github.com/LiviaMedeiros/node/tree/test-fs-opendir-close-handles
Conversationhttps://github.com/nodejs/node/pull/58855
Commits2 (2)https://github.com/nodejs/node/pull/58855/commits
Checkshttps://github.com/nodejs/node/pull/58855/checks
Files changedhttps://github.com/nodejs/node/pull/58855/files
test: close dirs in fs-opendir testhttps://github.com/nodejs/node/pull/58855#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
LiviaMedeiros:test-fs-opendir-close-handleshttps://github.com/LiviaMedeiros/node/tree/test-fs-opendir-close-handles
https://github.com/LiviaMedeiros
LiviaMedeiroshttps://github.com/LiviaMedeiros
Jun 26, 2025https://github.com/nodejs/node/pull/58855#issue-3180451053
Please reload this pagehttps://github.com/nodejs/node/pull/58855
https://github.com/LiviaMedeiros
test: close dirs in fs-opendir testhttps://github.com/nodejs/node/pull/58855/commits/014e8dc3cca5ae6ad09bcea5af0f172293d610ca
014e8dchttps://github.com/nodejs/node/pull/58855/commits/014e8dc3cca5ae6ad09bcea5af0f172293d610ca
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Jun 26, 2025https://github.com/nodejs/node/pull/58855#event-18344183023
https://github.com/LiviaMedeiros
LiviaMedeiroshttps://github.com/LiviaMedeiros
Jun 26, 2025 https://github.com/nodejs/node/pull/58855#pullrequestreview-2963679755
View reviewed changes https://github.com/nodejs/node/pull/58855/files/014e8dc3cca5ae6ad09bcea5af0f172293d610ca
test/parallel/test-fs-opendir.jshttps://github.com/nodejs/node/pull/58855/files/014e8dc3cca5ae6ad09bcea5af0f172293d610ca#diff-686aca8889b55f0afbba155ebd90257331b35b996e6d3fff090e11b56579c70d
Please reload this pagehttps://github.com/nodejs/node/pull/58855
https://github.com/LiviaMedeiros
squash: linthttps://github.com/nodejs/node/pull/58855/commits/49591bc17abbd17c6ac5e557943fb20511d6eac2
49591bchttps://github.com/nodejs/node/pull/58855/commits/49591bc17abbd17c6ac5e557943fb20511d6eac2
https://github.com/LiviaMedeiros
LiviaMedeiroshttps://github.com/LiviaMedeiros
Jun 26, 2025 https://github.com/nodejs/node/pull/58855#ref-pullrequest-3180507263
fs: close dir before throwing if options.bufferSize is invalid #58856 https://github.com/nodejs/node/pull/58856
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Jun 26, 2025https://github.com/nodejs/node/pull/58855#issuecomment-3010291309
Please reload this pagehttps://github.com/nodejs/node/pull/58855
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/58855?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
(b4c5fb4)https://app.codecov.io/gh/nodejs/node/commit/b4c5fb4ffbec9f27ba5799070c2e0588b7c7ff0e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
(49591bc)https://app.codecov.io/gh/nodejs/node/commit/49591bc17abbd17c6ac5e557943fb20511d6eac2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
see 26 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/58855/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/58855
https://github.com/lpinca
lpincahttps://github.com/lpinca
Jun 27, 2025 https://github.com/nodejs/node/pull/58855#pullrequestreview-2967628139
View reviewed changes https://github.com/nodejs/node/pull/58855/files/49591bc17abbd17c6ac5e557943fb20511d6eac2
https://github.com/LiviaMedeiros
LiviaMedeiroshttps://github.com/LiviaMedeiros
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jun 28, 2025https://github.com/nodejs/node/pull/58855#event-18367503958
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jun 28, 2025https://github.com/nodejs/node/pull/58855#event-18367546039
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 28, 2025https://github.com/nodejs/node/pull/58855#issuecomment-3015024742
https://ci.nodejs.org/job/node-test-pull-request/67695/https://ci.nodejs.org/job/node-test-pull-request/67695/
Please reload this pagehttps://github.com/nodejs/node/pull/58855
https://github.com/aduh95
aduh95https://github.com/aduh95
Jun 28, 2025 https://github.com/nodejs/node/pull/58855#pullrequestreview-2968449945
View reviewed changes https://github.com/nodejs/node/pull/58855/files/49591bc17abbd17c6ac5e557943fb20511d6eac2
aduh95https://github.com/aduh95
https://github.com/nodejs/node/pull/58855#pullrequestreview-2968449945
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/58855
https://github.com/LiviaMedeiros
LiviaMedeiroshttps://github.com/LiviaMedeiros
Jun 28, 2025https://github.com/nodejs/node/pull/58855#issuecomment-3015108247
Please reload this pagehttps://github.com/nodejs/node/pull/58855
https://github.com/aduh95
aduh95https://github.com/aduh95
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Jun 28, 2025https://github.com/nodejs/node/pull/58855#event-18367887090
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue-failed https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-failed
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Jun 28, 2025https://github.com/nodejs/node/pull/58855#event-18371402207
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 28, 2025https://github.com/nodejs/node/pull/58855#issuecomment-3016042493
#58855https://github.com/nodejs/node/pull/58855
#58855https://github.com/nodejs/node/pull/58855
https://github.com/nodejs/node/actions/runs/15948276759
https://github.com/nodejs/node/actions/runs/15948276759https://github.com/nodejs/node/actions/runs/15948276759
Please reload this pagehttps://github.com/nodejs/node/pull/58855
https://github.com/LiviaMedeiros
LiviaMedeiroshttps://github.com/LiviaMedeiros
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
commit-queue-squash https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash
commit-queue-failed https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-failed
Jun 28, 2025https://github.com/nodejs/node/pull/58855#event-18371416538
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Jun 28, 2025https://github.com/nodejs/node/pull/58855#event-18371433889
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
f0a9478https://github.com/nodejs/node/commit/f0a947865f0c69de2ac77dc72f2024cf18caa893
Jun 28, 2025https://github.com/nodejs/node/pull/58855#event-18371437758
Please reload this pagehttps://github.com/nodejs/node/pull/58855
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 28, 2025https://github.com/nodejs/node/pull/58855#issuecomment-3016058436
f0a9478https://github.com/nodejs/node/commit/f0a947865f0c69de2ac77dc72f2024cf18caa893
Please reload this pagehttps://github.com/nodejs/node/pull/58855
targoshttps://github.com/targos
Jul 3, 2025 https://github.com/nodejs/node/pull/58855#ref-commit-df85b02
https://github.com/LiviaMedeiros
https://github.com/targos
test: close dirs in fs-opendir testhttps://github.com/nodejs/node/commit/df85b02a00152bb20b0b1550c3db1d8555b6eed9
df85b02https://github.com/nodejs/node/commit/df85b02a00152bb20b0b1550c3db1d8555b6eed9
#58855https://github.com/nodejs/node/pull/58855
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jul 8, 2025 https://github.com/nodejs/node/pull/58855#ref-pullrequest-3212840261
2025-07-09, Version 24.4.0 (Current) #58993 https://github.com/nodejs/node/pull/58993
aduh95https://github.com/aduh95
Jul 21, 2025 https://github.com/nodejs/node/pull/58855#ref-commit-b1fb252
https://github.com/LiviaMedeiros
https://github.com/aduh95
test: close dirs in fs-opendir testhttps://github.com/nodejs/node/commit/b1fb252b1c1a579f890bf901df06b56f169cdf56
b1fb252https://github.com/nodejs/node/commit/b1fb252b1c1a579f890bf901df06b56f169cdf56
#58855https://github.com/nodejs/node/pull/58855
aduh95https://github.com/aduh95
Jul 24, 2025 https://github.com/nodejs/node/pull/58855#ref-commit-e24dede
https://github.com/LiviaMedeiros
https://github.com/aduh95
test: close dirs in fs-opendir testhttps://github.com/nodejs/node/commit/e24dede403e964103da014d9ef83cf2fa5c9246b
e24dedehttps://github.com/nodejs/node/commit/e24dede403e964103da014d9ef83cf2fa5c9246b
#58855https://github.com/nodejs/node/pull/58855
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jul 28, 2025 https://github.com/nodejs/node/pull/58855#ref-pullrequest-3268981161
2025-07-29, Version 22.18.0 'Jod' (LTS) #59256 https://github.com/nodejs/node/pull/59256
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F58855
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/58855/files/49591bc17abbd17c6ac5e557943fb20511d6eac2
https://github.com/aduh95
aduh95 https://github.com/aduh95
https://github.com/nodejs/node/pull/58855/files/49591bc17abbd17c6ac5e557943fb20511d6eac2
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
commit-queue-squash https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/58855
https://github.com/LiviaMedeiros
https://github.com/nodejs-github-bot
https://github.com/lpinca
https://github.com/aduh95
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.