René's URL Explorer Experiment


Title: fs: runtime deprecate closing `fs.Dir` on garbage collection by LiviaMedeiros · Pull Request #58850 · nodejs/node · GitHub

Open Graph Title: fs: runtime deprecate closing `fs.Dir` on garbage collection by LiviaMedeiros · Pull Request #58850 · nodejs/node

X Title: fs: runtime deprecate closing `fs.Dir` on garbage collection by LiviaMedeiros · Pull Request #58850 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: The DEP0137 is going to be End-of-Life in the next major release. I think we should align closing fs.Dir on GC and deprecate it as well. Now that explicit resource management is available, closing ...

X Description: The DEP0137 is going to be End-of-Life in the next major release. I think we should align closing fs.Dir on GC and deprecate it as well. Now that explicit resource management is available, closing ...

Opengraph URL: https://github.com/nodejs/node/pull/58850

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:6216b988-d14c-a952-acec-e323c36cd5de
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9760:3B6971:5F278:83E92:6A4D1ABF
html-safe-nonce4394b39c59420c18dd5715e2e1e57be1902b7b20e11265dd69f28c01aeb9455c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NzYwOjNCNjk3MTo1RjI3ODo4M0U5Mjo2QTREMUFCRiIsInZpc2l0b3JfaWQiOiIxNTQ0NjIxMjI1NTc2NDM0NTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacb3280db83694e452c6123167ce518b4d20cb9dab33d3543386618ed06592955f
hovercard-subject-tagpull_request:2621934580
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/58850/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/086ef2f613ba8a5c3a64ae374ba34e19be47d77dea52da7ab81cbe76efb8e852/nodejs/node/pull/58850
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/086ef2f613ba8a5c3a64ae374ba34e19be47d77dea52da7ab81cbe76efb8e852/nodejs/node/pull/58850
og:image:altThe DEP0137 is going to be End-of-Life in the next major release. I think we should align closing fs.Dir on GC and deprecate it as well. Now that explicit resource management is available, closing ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameLiviaMedeiros
hostnamegithub.com
expected-hostnamegithub.com
Nonebcb4661e6fb4fe8b394c51ea02ccdb2236d40dc59afc75a3bbba50bf6517134c
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasefb70bd3c4b2bec429781b65419e912c66e2d5581
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/58850#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F58850
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F58850
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/58850
Reloadhttps://github.com/nodejs/node/pull/58850
Reloadhttps://github.com/nodejs/node/pull/58850
Please reload this pagehttps://github.com/nodejs/node/pull/58850
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/58850
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 958 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
LiviaMedeiroshttps://github.com/LiviaMedeiros
nodejs:mainhttps://github.com/nodejs/node/tree/main
LiviaMedeiros:fs-deprecate-dir-close-gchttps://github.com/LiviaMedeiros/node/tree/fs-deprecate-dir-close-gc
Conversationhttps://github.com/nodejs/node/pull/58850
Commits1 (1)https://github.com/nodejs/node/pull/58850/commits
Checkshttps://github.com/nodejs/node/pull/58850/checks
Files changedhttps://github.com/nodejs/node/pull/58850/files
fs: runtime deprecate closing fs.Dir on garbage collectionhttps://github.com/nodejs/node/pull/58850#top
LiviaMedeiroshttps://github.com/LiviaMedeiros
nodejs:mainhttps://github.com/nodejs/node/tree/main
LiviaMedeiros:fs-deprecate-dir-close-gchttps://github.com/LiviaMedeiros/node/tree/fs-deprecate-dir-close-gc
https://github.com/LiviaMedeiros
LiviaMedeiroshttps://github.com/LiviaMedeiros
Jun 26, 2025https://github.com/nodejs/node/pull/58850#issue-3179970381
Please reload this pagehttps://github.com/nodejs/node/pull/58850
DEP0137https://nodejs.org/api/deprecations.html#dep0137-closing-fsfilehandle-on-garbage-collection
Please reload this pagehttps://github.com/nodejs/node/pull/58850
https://github.com/LiviaMedeiros
LiviaMedeiroshttps://github.com/LiviaMedeiros
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
deprecations https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adeprecations
Jun 26, 2025https://github.com/nodejs/node/pull/58850#event-18341493889
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Jun 26, 2025https://github.com/nodejs/node/pull/58850#event-18341498566
https://github.com/LiviaMedeiros
LiviaMedeiroshttps://github.com/LiviaMedeiros
force-pushedhttps://github.com/nodejs/node/compare/719ebb4f929e3515c63cf0feb686555bb232b10f..39e8ae5f6f59fc053678dd8472c5f71ec41160d8
719ebb4https://github.com/nodejs/node/commit/719ebb4f929e3515c63cf0feb686555bb232b10f
39e8ae5https://github.com/nodejs/node/commit/39e8ae5f6f59fc053678dd8472c5f71ec41160d8
Compare https://github.com/nodejs/node/compare/719ebb4f929e3515c63cf0feb686555bb232b10f..39e8ae5f6f59fc053678dd8472c5f71ec41160d8
June 26, 2025 18:31https://github.com/nodejs/node/pull/58850#event-18341637983
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Jun 26, 2025https://github.com/nodejs/node/pull/58850#issuecomment-3009677247
Please reload this pagehttps://github.com/nodejs/node/pull/58850
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/58850?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
94422e8https://app.codecov.io/gh/nodejs/node/commit/94422e8a40bcb380d7f2633c4dde19839ba71d5e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
8ff0b20https://app.codecov.io/gh/nodejs/node/commit/8ff0b20842c7b660b0fba005b6d96f2d6b2a75b9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/58850?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
src/node_dir.cchttps://app.codecov.io/gh/nodejs/node/pull/58850?src=pr&el=tree&filepath=src%2Fnode_dir.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfZGlyLmNj
0 Missing and 1 partial ⚠️ https://app.codecov.io/gh/nodejs/node/pull/58850?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/58850?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
src/env-inl.hhttps://app.codecov.io/gh/nodejs/node/pull/58850?src=pr&el=tree&filepath=src%2Fenv-inl.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL2Vudi1pbmwuaA==
src/env.hhttps://app.codecov.io/gh/nodejs/node/pull/58850?src=pr&el=tree&filepath=src%2Fenv.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL2Vudi5o
src/node_dir.cchttps://app.codecov.io/gh/nodejs/node/pull/58850?src=pr&el=tree&filepath=src%2Fnode_dir.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfZGlyLmNj
36 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/58850/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/58850
https://github.com/aduh95
aduh95https://github.com/aduh95
Sep 6, 2025 https://github.com/nodejs/node/pull/58850#pullrequestreview-3191820309
View reviewed changes https://github.com/nodejs/node/pull/58850/files
doc/api/deprecations.mdhttps://github.com/nodejs/node/pull/58850/files#diff-b7c42d4dc97df183538f07f68a1f6ee54068ee8860cfa053ab141e64f290af87
aduh95https://github.com/aduh95
Sep 6, 2025https://github.com/nodejs/node/pull/58850#discussion_r2326656061
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/58850
aduh95https://github.com/aduh95
Sep 10, 2025https://github.com/nodejs/node/pull/58850#discussion_r2336283383
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/58850
LiviaMedeiroshttps://github.com/LiviaMedeiros
Sep 10, 2025https://github.com/nodejs/node/pull/58850#discussion_r2336360965
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/58850
https://github.com/LiviaMedeiros
LiviaMedeiroshttps://github.com/LiviaMedeiros
force-pushedhttps://github.com/nodejs/node/compare/39e8ae5f6f59fc053678dd8472c5f71ec41160d8..c60424bd6ddadc3d04b6047e9dc360afba5a7da4
39e8ae5https://github.com/nodejs/node/commit/39e8ae5f6f59fc053678dd8472c5f71ec41160d8
c60424bhttps://github.com/nodejs/node/commit/c60424bd6ddadc3d04b6047e9dc360afba5a7da4
Compare https://github.com/nodejs/node/compare/39e8ae5f6f59fc053678dd8472c5f71ec41160d8..c60424bd6ddadc3d04b6047e9dc360afba5a7da4
September 10, 2025 10:05https://github.com/nodejs/node/pull/58850#event-19609488493
https://github.com/aduh95
aduh95https://github.com/aduh95
Sep 10, 2025 https://github.com/nodejs/node/pull/58850#pullrequestreview-3205613900
View reviewed changes https://github.com/nodejs/node/pull/58850/files
aduh95https://github.com/aduh95
https://github.com/nodejs/node/pull/58850#pullrequestreview-3205613900
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/58850
https://github.com/LiviaMedeiros
LiviaMedeiroshttps://github.com/LiviaMedeiros
Sep 10, 2025https://github.com/nodejs/node/pull/58850#issuecomment-3274483195
Please reload this pagehttps://github.com/nodejs/node/pull/58850
https://github.com/LiviaMedeiros
LiviaMedeiroshttps://github.com/LiviaMedeiros
Sep 10, 2025 https://github.com/nodejs/node/pull/58850#ref-pullrequest-3402076854
doc: deprecate closing fs.Dir on garbage collection #59839 https://github.com/nodejs/node/pull/59839
https://github.com/LiviaMedeiros
fs: runtime deprecate closing fs.Dir on garbage collectionhttps://github.com/nodejs/node/pull/58850/commits/8ff0b20842c7b660b0fba005b6d96f2d6b2a75b9
8ff0b20https://github.com/nodejs/node/pull/58850/commits/8ff0b20842c7b660b0fba005b6d96f2d6b2a75b9
https://github.com/LiviaMedeiros
LiviaMedeiroshttps://github.com/LiviaMedeiros
force-pushedhttps://github.com/nodejs/node/compare/741088bde812868173e039328298d58420db9cc4..8ff0b20842c7b660b0fba005b6d96f2d6b2a75b9
741088bhttps://github.com/nodejs/node/commit/741088bde812868173e039328298d58420db9cc4
8ff0b20https://github.com/nodejs/node/commit/8ff0b20842c7b660b0fba005b6d96f2d6b2a75b9
Compare https://github.com/nodejs/node/compare/741088bde812868173e039328298d58420db9cc4..8ff0b20842c7b660b0fba005b6d96f2d6b2a75b9
September 12, 2025 12:17https://github.com/nodejs/node/pull/58850#event-19659701593
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 12, 2025https://github.com/nodejs/node/pull/58850#issuecomment-3285076551
https://ci.nodejs.org/job/node-test-pull-request/69207/https://ci.nodejs.org/job/node-test-pull-request/69207/
Please reload this pagehttps://github.com/nodejs/node/pull/58850
https://github.com/aduh95
aduh95https://github.com/aduh95
Sep 12, 2025https://github.com/nodejs/node/pull/58850#issuecomment-3285285426
Please reload this pagehttps://github.com/nodejs/node/pull/58850
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F58850
https://github.com/aduh95
aduh95 https://github.com/aduh95
https://github.com/nodejs/node/pull/58850/files/741088bde812868173e039328298d58420db9cc4
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
deprecations https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adeprecations
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
Please reload this pagehttps://github.com/nodejs/node/pull/58850
https://github.com/LiviaMedeiros
https://github.com/nodejs-github-bot
https://github.com/aduh95
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.