René's URL Explorer Experiment


Title: test_runner: fix timeout not propagated to the child process in run by jakecastelli · Pull Request #58831 · nodejs/node · GitHub

Open Graph Title: test_runner: fix timeout not propagated to the child process in run by jakecastelli · Pull Request #58831 · nodejs/node

X Title: test_runner: fix timeout not propagated to the child process in run by jakecastelli · Pull Request #58831 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: We do have test coverage for this case, however, the test failed due to an incorrect file path, not due to the intended testTimeoutFailure. The key takeaway is that we should make the assertion mor...

X Description: We do have test coverage for this case, however, the test failed due to an incorrect file path, not due to the intended testTimeoutFailure. The key takeaway is that we should make the assertion mor...

Opengraph URL: https://github.com/nodejs/node/pull/58831

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0af0286d-db24-aa2e-acfd-2b03d89e6ecb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBFC2:3E4802:84AE6E:B28E67:6A4D3C5C
html-safe-nonce336435960646b073ce69e5b8d3fe3ae7dfa66679da438227629a8471a8c90ff1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRkMyOjNFNDgwMjo4NEFFNkU6QjI4RTY3OjZBNEQzQzVDIiwidmlzaXRvcl9pZCI6IjE2ODIzOTMwNTczMjI2NzkzODgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac4f0440d3efbb5b143154fdcfb9ede6135a420461a9327affb2cf2842449d6902
hovercard-subject-tagpull_request:2617931848
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/58831/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b2516180755315490c6e57ceda1c0b9ad1fe3c575a8f323f5ada2aa269b0d7ca/nodejs/node/pull/58831
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b2516180755315490c6e57ceda1c0b9ad1fe3c575a8f323f5ada2aa269b0d7ca/nodejs/node/pull/58831
og:image:altWe do have test coverage for this case, however, the test failed due to an incorrect file path, not due to the intended testTimeoutFailure. The key takeaway is that we should make the assertion mor...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejakecastelli
hostnamegithub.com
expected-hostnamegithub.com
None92571a8944142227b7e19cd10918b1ddd06e5066c1ad5bc7e4769cf6140a87e6
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release56fc8347865a14e2ec811533d68f929cf4e0ec19
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/58831#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F58831
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F58831
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/58831
Reloadhttps://github.com/nodejs/node/pull/58831
Reloadhttps://github.com/nodejs/node/pull/58831
Please reload this pagehttps://github.com/nodejs/node/pull/58831
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/58831
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 959 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
jakecastelli:fix-58802https://github.com/jakecastelli/node/tree/fix-58802
Conversationhttps://github.com/nodejs/node/pull/58831
Commits2 (2)https://github.com/nodejs/node/pull/58831/commits
Checkshttps://github.com/nodejs/node/pull/58831/checks
Files changedhttps://github.com/nodejs/node/pull/58831/files
test_runner: fix timeout not propagated to the child process in runhttps://github.com/nodejs/node/pull/58831#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
jakecastelli:fix-58802https://github.com/jakecastelli/node/tree/fix-58802
https://github.com/jakecastelli
jakecastellihttps://github.com/jakecastelli
Jun 25, 2025https://github.com/nodejs/node/pull/58831#issue-3175321397
#58802https://github.com/nodejs/node/issues/58802
Please reload this pagehttps://github.com/nodejs/node/pull/58831
https://github.com/jakecastelli
test_runner: fix timeout not propagated to the child process in runhttps://github.com/nodejs/node/pull/58831/commits/a11e81689395a7e3d6366272f67f02786913783a
a11e816https://github.com/nodejs/node/pull/58831/commits/a11e81689395a7e3d6366272f67f02786913783a
https://github.com/jakecastelli
jakecastellihttps://github.com/jakecastelli
pmarchinihttps://github.com/pmarchini
June 25, 2025 11:39https://github.com/nodejs/node/pull/58831#event-18314938972
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 25, 2025https://github.com/nodejs/node/pull/58831#issuecomment-3004458467
Please reload this pagehttps://github.com/nodejs/node/pull/58831
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
test_runner https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest_runner
Jun 25, 2025https://github.com/nodejs/node/pull/58831#event-18314941613
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Jun 25, 2025https://github.com/nodejs/node/pull/58831#issuecomment-3004596809
Please reload this pagehttps://github.com/nodejs/node/pull/58831
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/58831?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
6ce6fdbhttps://app.codecov.io/gh/nodejs/node/commit/6ce6fdbf219a72ecdbe5e65d0259f1072304b1d9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
7720b96https://app.codecov.io/gh/nodejs/node/commit/7720b96b1b44f0d3d027aad89267bee1dd23e375?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/58831?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/test_runner/runner.jshttps://app.codecov.io/gh/nodejs/node/pull/58831?src=pr&el=tree&filepath=lib%2Finternal%2Ftest_runner%2Frunner.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3Rlc3RfcnVubmVyL3J1bm5lci5qcw==
40 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/58831/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/58831
https://github.com/pmarchini
pmarchinihttps://github.com/pmarchini
Jun 25, 2025https://github.com/nodejs/node/pull/58831#issuecomment-3004657805
Please reload this pagehttps://github.com/nodejs/node/pull/58831
@jakecastellihttps://github.com/jakecastelli
Please reload this pagehttps://github.com/nodejs/node/pull/58831
https://github.com/jakecastelli
fixup! testhttps://github.com/nodejs/node/pull/58831/commits/7720b96b1b44f0d3d027aad89267bee1dd23e375
7720b96https://github.com/nodejs/node/pull/58831/commits/7720b96b1b44f0d3d027aad89267bee1dd23e375
https://github.com/jakecastelli
jakecastellihttps://github.com/jakecastelli
Jun 25, 2025https://github.com/nodejs/node/pull/58831#issuecomment-3004823893
Please reload this pagehttps://github.com/nodejs/node/pull/58831
https://github.com/JakobJingleheimer
JakobJingleheimerhttps://github.com/JakobJingleheimer
Jun 26, 2025 https://github.com/nodejs/node/pull/58831#pullrequestreview-2961627497
View reviewed changes https://github.com/nodejs/node/pull/58831/files/7720b96b1b44f0d3d027aad89267bee1dd23e375
https://github.com/JakobJingleheimer
JakobJingleheimerhttps://github.com/JakobJingleheimer
commit-queue-squash https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jun 26, 2025https://github.com/nodejs/node/pull/58831#event-18333870527
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jun 26, 2025https://github.com/nodejs/node/pull/58831#event-18333918825
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 26, 2025https://github.com/nodejs/node/pull/58831#issuecomment-3008046609
https://ci.nodejs.org/job/node-test-pull-request/67664/https://ci.nodejs.org/job/node-test-pull-request/67664/
Please reload this pagehttps://github.com/nodejs/node/pull/58831
https://github.com/JakobJingleheimer
JakobJingleheimerhttps://github.com/JakobJingleheimer
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jun 26, 2025https://github.com/nodejs/node/pull/58831#event-18337354195
https://github.com/edsadr
edsadrhttps://github.com/edsadr
June 26, 2025 18:44https://github.com/nodejs/node/pull/58831#event-18341853904
https://github.com/edsadr
edsadrhttps://github.com/edsadr
Jun 26, 2025 https://github.com/nodejs/node/pull/58831#pullrequestreview-2963174992
View reviewed changes https://github.com/nodejs/node/pull/58831/files/7720b96b1b44f0d3d027aad89267bee1dd23e375
edsadrhttps://github.com/edsadr
https://github.com/nodejs/node/pull/58831#pullrequestreview-2963174992
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/58831
https://github.com/JakobJingleheimer
JakobJingleheimerhttps://github.com/JakobJingleheimer
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Jun 27, 2025https://github.com/nodejs/node/pull/58831#event-18355969282
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Jun 27, 2025https://github.com/nodejs/node/pull/58831#event-18355991762
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
94f7568https://github.com/nodejs/node/commit/94f7568e5c105a1a26958eb07000a00182328598
Jun 27, 2025https://github.com/nodejs/node/pull/58831#event-18356020868
Please reload this pagehttps://github.com/nodejs/node/pull/58831
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jun 27, 2025https://github.com/nodejs/node/pull/58831#issuecomment-3012739007
94f7568https://github.com/nodejs/node/commit/94f7568e5c105a1a26958eb07000a00182328598
Please reload this pagehttps://github.com/nodejs/node/pull/58831
targoshttps://github.com/targos
Jul 3, 2025 https://github.com/nodejs/node/pull/58831#ref-commit-d0faf72
https://github.com/jakecastelli
https://github.com/targos
test_runner: fix timeout not propagated to the child process in runhttps://github.com/nodejs/node/commit/d0faf723c7938c72875e2d77d5522ed6bfccdcc6
d0faf72https://github.com/nodejs/node/commit/d0faf723c7938c72875e2d77d5522ed6bfccdcc6
#58831https://github.com/nodejs/node/pull/58831
#58802https://github.com/nodejs/node/issues/58802
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jul 8, 2025 https://github.com/nodejs/node/pull/58831#ref-pullrequest-3212840261
2025-07-09, Version 24.4.0 (Current) #58993 https://github.com/nodejs/node/pull/58993
https://github.com/richardlau
richardlauhttps://github.com/richardlau
backport-requested-v22.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v22.x
Sep 19, 2025https://github.com/nodejs/node/pull/58831#event-19803435247
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Sep 19, 2025https://github.com/nodejs/node/pull/58831#issuecomment-3312843710
Please reload this pagehttps://github.com/nodejs/node/pull/58831
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F58831
https://github.com/edsadr
edsadr https://github.com/edsadr
https://github.com/nodejs/node/pull/58831/files/7720b96b1b44f0d3d027aad89267bee1dd23e375
https://github.com/JakobJingleheimer
JakobJingleheimer https://github.com/JakobJingleheimer
https://github.com/nodejs/node/pull/58831/files/7720b96b1b44f0d3d027aad89267bee1dd23e375
https://github.com/pmarchini
pmarchini https://github.com/pmarchini
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
backport-requested-v22.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v22.x
commit-queue-squash https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-squash
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
test_runner https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest_runner
testrunner: run() ignores timeout option https://github.com/nodejs/node/issues/58802
Please reload this pagehttps://github.com/nodejs/node/pull/58831
https://github.com/jakecastelli
https://github.com/nodejs-github-bot
https://github.com/pmarchini
https://github.com/richardlau
https://github.com/edsadr
https://github.com/JakobJingleheimer
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.