René's URL Explorer Experiment


Title: fs: runtime deprecate mistakenly exposed `fs.Dir` methods by jasnell · Pull Request #58679 · nodejs/node · GitHub

Open Graph Title: fs: runtime deprecate mistakenly exposed `fs.Dir` methods by jasnell · Pull Request #58679 · nodejs/node

X Title: fs: runtime deprecate mistakenly exposed `fs.Dir` methods by jasnell · Pull Request #58679 · nodejs/node

Description: The processReadResult and readSyncRecursive methods on the fs.Dir class were mistakenly exposed as public APIs. These methods are intended only for internal use. They are now runtime deprecated and...

Open Graph Description: The processReadResult and readSyncRecursive methods on the fs.Dir class were mistakenly exposed as public APIs. These methods are intended only for internal use. They are now runtime deprecated and...

X Description: The processReadResult and readSyncRecursive methods on the fs.Dir class were mistakenly exposed as public APIs. These methods are intended only for internal use. They are now runtime deprecated and...

Opengraph URL: https://github.com/nodejs/node/pull/58679

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:aac8d145-8753-d5f1-55cc-5123186ccc06
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC002:31BD8E:FC8EB:165F1A:696A0410
html-safe-nonce552d923b8ec047935c902176849b5addf2a1657c6e856738e2a9d8c0116a23c1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMDAyOjMxQkQ4RTpGQzhFQjoxNjVGMUE6Njk2QTA0MTAiLCJ2aXNpdG9yX2lkIjoiMTcyMzM1ODE3MTkwOTE5NDc2OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac352e6c5ea365cdc39af14b89ba4a5d157acb66e47b7b958928a6370382f70d76
hovercard-subject-tagpull_request:2584626525
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/58679/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/9614fc21c654a477642eaffe78f6a1d2fbab7f9e0e03e741fcf7992d1c1a2a49/nodejs/node/pull/58679
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9614fc21c654a477642eaffe78f6a1d2fbab7f9e0e03e741fcf7992d1c1a2a49/nodejs/node/pull/58679
og:image:altThe processReadResult and readSyncRecursive methods on the fs.Dir class were mistakenly exposed as public APIs. These methods are intended only for internal use. They are now runtime deprecated and...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejasnell
hostnamegithub.com
expected-hostnamegithub.com
None578c119ff0247c8b2f2491fbf4fc0395cdf909d4df66598cebdc96ddfc4418dc
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release671c2f67171dbced24284331f3133a613d08c366
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/58679#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F58679
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F58679
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/58679
Reloadhttps://github.com/nodejs/node/pull/58679
Reloadhttps://github.com/nodejs/node/pull/58679
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/58679
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 697 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/58679
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/58679#issue-comment-box
jasnellhttps://github.com/jasnell
nodejs:mainhttps://github.com/nodejs/node/tree/main
jasnell:jasnell/fs-dir-deprecationshttps://github.com/jasnell/node/tree/jasnell/fs-dir-deprecations
fs: runtime deprecate mistakenly exposed fs.Dir methods https://github.com/nodejs/node/pull/58679#top
jasnellhttps://github.com/jasnell
nodejs:mainhttps://github.com/nodejs/node/tree/main
jasnell:jasnell/fs-dir-deprecationshttps://github.com/jasnell/node/tree/jasnell/fs-dir-deprecations
Conversation 12 https://github.com/nodejs/node/pull/58679
Commits 1 https://github.com/nodejs/node/pull/58679/commits
Checks 41 https://github.com/nodejs/node/pull/58679/checks
Files changed https://github.com/nodejs/node/pull/58679/files
Please reload this pagehttps://github.com/nodejs/node/pull/58679
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jun 11, 2025https://github.com/nodejs/node/pull/58679#issue-3137239640
Please reload this pagehttps://github.com/nodejs/node/pull/58679
https://github.com/jasnell
fs: runtime deprecate mistakenly exposed fs.Dir methodshttps://github.com/nodejs/node/pull/58679/commits/ce1bce7e14fbef9c0d22dca659f0f693ce1975fd
ce1bce7https://github.com/nodejs/node/pull/58679/commits/ce1bce7e14fbef9c0d22dca659f0f693ce1975fd
https://github.com/jasnell
jasnellhttps://github.com/jasnell
aduh95https://github.com/aduh95
anonrighttps://github.com/anonrig
mcollinahttps://github.com/mcollina
targoshttps://github.com/targos
June 11, 2025 15:20https://github.com/nodejs/node/pull/58679#event-18096829899
https://github.com/jasnell
jasnellhttps://github.com/jasnell
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
deprecations https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adeprecations
Jun 11, 2025https://github.com/nodejs/node/pull/58679#event-18096830302
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Jun 11, 2025https://github.com/nodejs/node/pull/58679#event-18096833576
https://github.com/jasnell
jasnellhttps://github.com/jasnell
LiviaMedeiroshttps://github.com/LiviaMedeiros
June 11, 2025 15:49https://github.com/nodejs/node/pull/58679#event-18097355450
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jun 11, 2025https://github.com/nodejs/node/pull/58679#issuecomment-2963346971
#58672https://github.com/nodejs/node/pull/58672
Please reload this pagehttps://github.com/nodejs/node/pull/58679
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jun 11, 2025 https://github.com/nodejs/node/pull/58679#ref-pullrequest-3135993972
fs: make processReadResult() and readSyncRecursive() private #58672 https://github.com/nodejs/node/pull/58672
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Jun 11, 2025https://github.com/nodejs/node/pull/58679#issuecomment-2963408969
Please reload this pagehttps://github.com/nodejs/node/pull/58679
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/58679?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
(977b5ac)https://app.codecov.io/gh/nodejs/node/commit/977b5ac7ddc7ab0f866c39056f3e28e4b2e82645?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
(ce1bce7)https://app.codecov.io/gh/nodejs/node/commit/ce1bce7e14fbef9c0d22dca659f0f693ce1975fd?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/58679?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/fs/dir.jshttps://app.codecov.io/gh/nodejs/node/pull/58679?src=pr&el=tree&filepath=lib%2Finternal%2Ffs%2Fdir.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL2ZzL2Rpci5qcw==
27 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/58679/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/58679
https://github.com/LiviaMedeiros
LiviaMedeiroshttps://github.com/LiviaMedeiros
Jun 11, 2025 https://github.com/nodejs/node/pull/58679#pullrequestreview-2917812915
View reviewed changes https://github.com/nodejs/node/pull/58679/files/ce1bce7e14fbef9c0d22dca659f0f693ce1975fd
LiviaMedeiroshttps://github.com/LiviaMedeiros
https://github.com/nodejs/node/pull/58679#pullrequestreview-2917812915
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#58672https://github.com/nodejs/node/pull/58672
#58672https://github.com/nodejs/node/pull/58672
Please reload this pagehttps://github.com/nodejs/node/pull/58679
doc/api/deprecations.mdhttps://github.com/nodejs/node/pull/58679/files/ce1bce7e14fbef9c0d22dca659f0f693ce1975fd#diff-b7c42d4dc97df183538f07f68a1f6ee54068ee8860cfa053ab141e64f290af87
LiviaMedeiroshttps://github.com/LiviaMedeiros
Jun 11, 2025https://github.com/nodejs/node/pull/58679#discussion_r2140545099
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/58679
doc/api/deprecations.mdhttps://github.com/nodejs/node/pull/58679/files/ce1bce7e14fbef9c0d22dca659f0f693ce1975fd#diff-b7c42d4dc97df183538f07f68a1f6ee54068ee8860cfa053ab141e64f290af87
LiviaMedeiroshttps://github.com/LiviaMedeiros
Jun 11, 2025https://github.com/nodejs/node/pull/58679#discussion_r2140545428
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/58679
doc/api/deprecations.mdhttps://github.com/nodejs/node/pull/58679/files/ce1bce7e14fbef9c0d22dca659f0f693ce1975fd#diff-b7c42d4dc97df183538f07f68a1f6ee54068ee8860cfa053ab141e64f290af87
LiviaMedeiroshttps://github.com/LiviaMedeiros
Jun 11, 2025https://github.com/nodejs/node/pull/58679#discussion_r2140551759
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/58679
doc/api/deprecations.mdhttps://github.com/nodejs/node/pull/58679/files/ce1bce7e14fbef9c0d22dca659f0f693ce1975fd#diff-b7c42d4dc97df183538f07f68a1f6ee54068ee8860cfa053ab141e64f290af87
LiviaMedeiroshttps://github.com/LiviaMedeiros
Jun 11, 2025https://github.com/nodejs/node/pull/58679#discussion_r2140553953
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/58679
https://github.com/anonrig
anonrighttps://github.com/anonrig
Jun 11, 2025 https://github.com/nodejs/node/pull/58679#pullrequestreview-2918195744
View reviewed changes https://github.com/nodejs/node/pull/58679/files/ce1bce7e14fbef9c0d22dca659f0f693ce1975fd
https://github.com/aduh95
aduh95https://github.com/aduh95
Jun 11, 2025https://github.com/nodejs/node/pull/58679#issuecomment-2964427537
Please reload this pagehttps://github.com/nodejs/node/pull/58679
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jun 12, 2025https://github.com/nodejs/node/pull/58679#issuecomment-2968420247
Please reload this pagehttps://github.com/nodejs/node/pull/58679
https://github.com/jasnell
jasnellhttps://github.com/jasnell
tsc-agenda https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atsc-agenda
Jun 12, 2025https://github.com/nodejs/node/pull/58679#event-18124041995
https://github.com/anonrig
anonrighttps://github.com/anonrig
Jun 12, 2025https://github.com/nodejs/node/pull/58679#issuecomment-2968452699
Please reload this pagehttps://github.com/nodejs/node/pull/58679
https://github.com/panva
panvahttps://github.com/panva
Jun 13, 2025https://github.com/nodejs/node/pull/58679#issuecomment-2969222464
#58672https://github.com/nodejs/node/pull/58672
semver-majorhttps://github.com/nodejs/node/labels/semver-major
Please reload this pagehttps://github.com/nodejs/node/pull/58679
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jun 14, 2025https://github.com/nodejs/node/pull/58679#issuecomment-2972876099
#58672https://github.com/nodejs/node/pull/58672
Please reload this pagehttps://github.com/nodejs/node/pull/58679
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jun 14, 2025https://github.com/nodejs/node/pull/58679#event-18150439986
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F58679
https://github.com/anonrig
anonrig https://github.com/anonrig
https://github.com/nodejs/node/pull/58679/files/ce1bce7e14fbef9c0d22dca659f0f693ce1975fd
https://github.com/LiviaMedeiros
LiviaMedeiros https://github.com/LiviaMedeiros
https://github.com/nodejs/node/pull/58679/files/ce1bce7e14fbef9c0d22dca659f0f693ce1975fd
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/targos
targos https://github.com/targos
https://github.com/aduh95
aduh95 https://github.com/aduh95
deprecations https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adeprecations
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
tsc-agenda https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atsc-agenda
Please reload this pagehttps://github.com/nodejs/node/pull/58679
https://github.com/jasnell
https://github.com/aduh95
https://github.com/anonrig
https://github.com/panva
https://github.com/LiviaMedeiros
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.