| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:54d78f8e-e521-f7cb-aea8-e1f0d0b3ba87 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8658:1D81B0:2A87992:3965670:696AE80C |
| html-safe-nonce | f291f098bc97f35747749fe007df419814793e679555b4f985ecdf692104fbe4 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NjU4OjFEODFCMDoyQTg3OTkyOjM5NjU2NzA6Njk2QUU4MEMiLCJ2aXNpdG9yX2lkIjoiMTI2OTkyODU0ODgwMTExMjA3NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | a90defc940191002e08fed5fdccdb21aec80791be278356ef6ea4afd5529a9ad |
| hovercard-subject-tag | pull_request:2557105382 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/58535/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/95596d1f9040aafa9c70f07afe8dcbfdb20aeb8fda7c503f49f834ede2e0248b/nodejs/node/pull/58535 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/95596d1f9040aafa9c70f07afe8dcbfdb20aeb8fda7c503f49f834ede2e0248b/nodejs/node/pull/58535 |
| og:image:alt | close #58534 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | bjohansebas |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3d84d50b3c75fa36755c3cf392edbc09e626f979 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/58535#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F58535 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F58535 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/58535 |
| Reload | https://github.com/nodejs/node/pull/58535 |
| Reload | https://github.com/nodejs/node/pull/58535 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/58535 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
692
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/58535 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/58535#issue-comment-box |
| bjohansebas | https://github.com/bjohansebas |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| bjohansebas:http_internals | https://github.com/bjohansebas/node/tree/http_internals |
|
lib: deprecate _http_*
| https://github.com/nodejs/node/pull/58535#top |
| bjohansebas | https://github.com/bjohansebas |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| bjohansebas:http_internals | https://github.com/bjohansebas/node/tree/http_internals |
|
Conversation
21
| https://github.com/nodejs/node/pull/58535 |
|
Commits
6
| https://github.com/nodejs/node/pull/58535/commits |
|
Checks
20
| https://github.com/nodejs/node/pull/58535/checks |
|
Files changed
| https://github.com/nodejs/node/pull/58535/files |
| Please reload this page | https://github.com/nodejs/node/pull/58535 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/bjohansebas |
| bjohansebas | https://github.com/bjohansebas |
| May 31, 2025 | https://github.com/nodejs/node/pull/58535#issue-3105933926 |
| #58534 | https://github.com/nodejs/node/issues/58534 |
| Please reload this page | https://github.com/nodejs/node/pull/58535 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| May 31, 2025 | https://github.com/nodejs/node/pull/58535#issuecomment-2925621789 |
| Please reload this page | https://github.com/nodejs/node/pull/58535 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
http
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
| May 31, 2025 | https://github.com/nodejs/node/pull/58535#event-17904199363 |
| https://github.com/bjohansebas |
| bjohansebas | https://github.com/bjohansebas |
|
wip
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip |
| May 31, 2025 | https://github.com/nodejs/node/pull/58535#event-17904284884 |
| https://github.com/bjohansebas |
| bjohansebas | https://github.com/bjohansebas |
| force-pushed | https://github.com/nodejs/node/compare/11b68783fc4863827af1b500e61c327d8c7ff9c3..329d0a05a34fe1b8347199b1148df728b2aa5a53 |
| 11b6878 | https://github.com/nodejs/node/commit/11b68783fc4863827af1b500e61c327d8c7ff9c3 |
| 329d0a0 | https://github.com/nodejs/node/commit/329d0a05a34fe1b8347199b1148df728b2aa5a53 |
|
Compare
| https://github.com/nodejs/node/compare/11b68783fc4863827af1b500e61c327d8c7ff9c3..329d0a05a34fe1b8347199b1148df728b2aa5a53 |
| May 31, 2025 20:17 | https://github.com/nodejs/node/pull/58535#event-17904649027 |
| https://github.com/bjohansebas |
| bjohansebas | https://github.com/bjohansebas |
|
semver-major
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major |
|
deprecations
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adeprecations |
| May 31, 2025 | https://github.com/nodejs/node/pull/58535#event-17904661400 |
| https://github.com/bjohansebas |
| bjohansebas | https://github.com/bjohansebas |
| May 31, 2025 21:29 | https://github.com/nodejs/node/pull/58535#event-17905127851 |
| https://github.com/bjohansebas |
| bjohansebas | https://github.com/bjohansebas |
| dario-piotrowicz | https://github.com/dario-piotrowicz |
| jasnell | https://github.com/jasnell |
| mcollina | https://github.com/mcollina |
| May 31, 2025 21:29 | https://github.com/nodejs/node/pull/58535#event-17905132565 |
| https://github.com/bjohansebas |
| bjohansebas | https://github.com/bjohansebas |
|
wip
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip |
| May 31, 2025 | https://github.com/nodejs/node/pull/58535#event-17905133577 |
| bjohansebas | https://github.com/bjohansebas |
| May 31, 2025 22:32 | https://github.com/nodejs/node/pull/58535#commits-pushed-e6335e0 |
|
| https://github.com/bjohansebas |
| lib: deprecate _http_* | https://github.com/nodejs/node/pull/58535/commits/e6335e04e21abcb44fe57334a905dae3bc1c26cb |
| e6335e0 | https://github.com/nodejs/node/pull/58535/commits/e6335e04e21abcb44fe57334a905dae3bc1c26cb |
|
| https://github.com/bjohansebas |
| test: update internal module references and add flags for tests | https://github.com/nodejs/node/pull/58535/commits/e6a21930a7a4574f3641a526daaadfee69c3f721 |
| e6a2193 | https://github.com/nodejs/node/pull/58535/commits/e6a21930a7a4574f3641a526daaadfee69c3f721 |
|
| https://github.com/bjohansebas |
| http,http2,https: use http internals | https://github.com/nodejs/node/pull/58535/commits/cdce87366f03d4563c8742c75a2b4679be768a18 |
| cdce873 | https://github.com/nodejs/node/pull/58535/commits/cdce87366f03d4563c8742c75a2b4679be768a18 |
| https://github.com/bjohansebas |
| bjohansebas | https://github.com/bjohansebas |
| force-pushed | https://github.com/nodejs/node/compare/674ca6f3348265c04a7e1c63afbf207d30169a8b..0ec4cccbb708014fed678b1a3c523d376d6fb458 |
| 674ca6f | https://github.com/nodejs/node/commit/674ca6f3348265c04a7e1c63afbf207d30169a8b |
| 0ec4ccc | https://github.com/nodejs/node/commit/0ec4cccbb708014fed678b1a3c523d376d6fb458 |
|
Compare
| https://github.com/nodejs/node/compare/674ca6f3348265c04a7e1c63afbf207d30169a8b..0ec4cccbb708014fed678b1a3c523d376d6fb458 |
| May 31, 2025 22:36 | https://github.com/nodejs/node/pull/58535#event-17905830654 |
| bjohansebas | https://github.com/bjohansebas |
| May 31, 2025 23:16 | https://github.com/nodejs/node/pull/58535#commits-pushed-5b223df |
|
| https://github.com/bjohansebas |
| test: add test for warnings | https://github.com/nodejs/node/pull/58535/commits/5b223dffe1d21babd0ecf6e0e3eebf384ce6cdd3 |
| 5b223df | https://github.com/nodejs/node/pull/58535/commits/5b223dffe1d21babd0ecf6e0e3eebf384ce6cdd3 |
|
| https://github.com/bjohansebas |
| benchmack: no use internals | https://github.com/nodejs/node/pull/58535/commits/bd305a8caf85e954bb6c69d6ec7010db6d3800b8 |
| bd305a8 | https://github.com/nodejs/node/pull/58535/commits/bd305a8caf85e954bb6c69d6ec7010db6d3800b8 |
| https://github.com/bjohansebas |
| bjohansebas | https://github.com/bjohansebas |
| force-pushed | https://github.com/nodejs/node/compare/0ec4cccbb708014fed678b1a3c523d376d6fb458..bd305a8caf85e954bb6c69d6ec7010db6d3800b8 |
| 0ec4ccc | https://github.com/nodejs/node/commit/0ec4cccbb708014fed678b1a3c523d376d6fb458 |
| bd305a8 | https://github.com/nodejs/node/commit/bd305a8caf85e954bb6c69d6ec7010db6d3800b8 |
|
Compare
| https://github.com/nodejs/node/compare/0ec4cccbb708014fed678b1a3c523d376d6fb458..bd305a8caf85e954bb6c69d6ec7010db6d3800b8 |
| May 31, 2025 23:17 | https://github.com/nodejs/node/pull/58535#event-17906169387 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
May 31, 2025
| https://github.com/nodejs/node/pull/58535#pullrequestreview-2884715279 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/58535/files/bd305a8caf85e954bb6c69d6ec7010db6d3800b8 |
| benchmark/http/check_is_http_token.js | https://github.com/nodejs/node/pull/58535/files/bd305a8caf85e954bb6c69d6ec7010db6d3800b8#diff-f8d96d0d7a0117ac7da85e6bea1d02b507e1507a330eab97c6966be9f1dca198 |
| jasnell | https://github.com/jasnell |
| May 31, 2025 | https://github.com/nodejs/node/pull/58535#discussion_r2118373028 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/58535 |
| bjohansebas | https://github.com/bjohansebas |
| May 31, 2025 | https://github.com/nodejs/node/pull/58535#discussion_r2118381331 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/58535 |
| dario-piotrowicz | https://github.com/dario-piotrowicz |
| May 31, 2025 | https://github.com/nodejs/node/pull/58535#discussion_r2118385470 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/58535 |
| jasnell | https://github.com/jasnell |
| Jun 2, 2025 | https://github.com/nodejs/node/pull/58535#discussion_r2119758235 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/58535 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| May 31, 2025 | https://github.com/nodejs/node/pull/58535#issuecomment-2925956937 |
| @mcollina | https://github.com/mcollina |
| Please reload this page | https://github.com/nodejs/node/pull/58535 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| May 31, 2025 | https://github.com/nodejs/node/pull/58535#issuecomment-2925960594 |
| https://github.com/search?type=code&q=%22require%28%27_http%22 | https://github.com/search?type=code&q=%22require%28%27_http%22 |
| Please reload this page | https://github.com/nodejs/node/pull/58535 |
| https://github.com/dario-piotrowicz |
| dario-piotrowicz | https://github.com/dario-piotrowicz |
|
May 31, 2025
| https://github.com/nodejs/node/pull/58535#pullrequestreview-2884718875 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/58535/files/bd305a8caf85e954bb6c69d6ec7010db6d3800b8 |
| dario-piotrowicz | https://github.com/dario-piotrowicz |
| https://github.com/nodejs/node/pull/58535#pullrequestreview-2884718875 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/58535 |
| test/parallel/test-warn-http-server-deprecation.js | https://github.com/nodejs/node/pull/58535/files/bd305a8caf85e954bb6c69d6ec7010db6d3800b8#diff-f8394f536ab82ee1d0bc5274b3af7d08a7582325810f41305a0a1452cac8a558 |
| Please reload this page | https://github.com/nodejs/node/pull/58535 |
| test/parallel/test-https-server-close-destroy-timeout.js | https://github.com/nodejs/node/pull/58535/files/bd305a8caf85e954bb6c69d6ec7010db6d3800b8#diff-6be7c57e2462b8df959757644979f9753ff0b22f6b42e0a7f2f3a8a731b5095d |
| dario-piotrowicz | https://github.com/dario-piotrowicz |
| May 31, 2025 | https://github.com/nodejs/node/pull/58535#discussion_r2118379026 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/58535 |
| bjohansebas | https://github.com/bjohansebas |
| May 31, 2025 | https://github.com/nodejs/node/pull/58535#discussion_r2118397617 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/58535 |
| dario-piotrowicz | https://github.com/dario-piotrowicz |
| Jun 1, 2025 | https://github.com/nodejs/node/pull/58535#discussion_r2119658612 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/58535 |
| benchmark/http/check_is_http_token.js | https://github.com/nodejs/node/pull/58535/files/bd305a8caf85e954bb6c69d6ec7010db6d3800b8#diff-f8d96d0d7a0117ac7da85e6bea1d02b507e1507a330eab97c6966be9f1dca198 |
| dario-piotrowicz | https://github.com/dario-piotrowicz |
| May 31, 2025 | https://github.com/nodejs/node/pull/58535#discussion_r2118385470 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/58535 |
| benchmark/http/check_invalid_header_char.js | https://github.com/nodejs/node/pull/58535/files/bd305a8caf85e954bb6c69d6ec7010db6d3800b8#diff-6e0c5da178236cdc4e4f2e55882345880beac9cf5e33d910494dbf1eeadf8257 |
| dario-piotrowicz | https://github.com/dario-piotrowicz |
| May 31, 2025 | https://github.com/nodejs/node/pull/58535#discussion_r2118386926 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/58535 |
| bjohansebas | https://github.com/bjohansebas |
| May 31, 2025 | https://github.com/nodejs/node/pull/58535#discussion_r2118397708 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/58535 |
| dario-piotrowicz | https://github.com/dario-piotrowicz |
| Jun 1, 2025 | https://github.com/nodejs/node/pull/58535#discussion_r2119628829 |
| Please reload this page | https://github.com/nodejs/node/pull/58535 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/58535 |
| https://github.com/bjohansebas |
| bjohansebas | https://github.com/bjohansebas |
| May 31, 2025 | https://github.com/nodejs/node/pull/58535#issuecomment-2925975754 |
| https://github.com/search?type=code&q=%22require%28%27_http%22 | https://github.com/search?type=code&q=%22require%28%27_http%22 |
| Please reload this page | https://github.com/nodejs/node/pull/58535 |
|
| https://github.com/bjohansebas |
|
| https://github.com/dario-piotrowicz |
| Update test/parallel/test-warn-http-server-deprecation.js | https://github.com/nodejs/node/pull/58535/commits/2103d6f19f5b44505c4bd02a8d6199115a75358f |
| 2103d6f | https://github.com/nodejs/node/pull/58535/commits/2103d6f19f5b44505c4bd02a8d6199115a75358f |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| May 31, 2025 | https://github.com/nodejs/node/pull/58535#issuecomment-2926009562 |
| Please reload this page | https://github.com/nodejs/node/pull/58535 |
| https://github.com/apps/codecov |
| codecov | https://github.com/apps/codecov |
| Jun 1, 2025 | https://github.com/nodejs/node/pull/58535#issuecomment-2926109665 |
| Please reload this page | https://github.com/nodejs/node/pull/58535 |
| Codecov | https://app.codecov.io/gh/nodejs/node/pull/58535?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| (f497881) | https://app.codecov.io/gh/nodejs/node/commit/f4978814d49b25fb7dadb43124ed9f43d22c3a4c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| (2103d6f) | https://app.codecov.io/gh/nodejs/node/commit/2103d6f19f5b44505c4bd02a8d6199115a75358f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| Files with missing lines | https://app.codecov.io/gh/nodejs/node/pull/58535?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| lib/internal/http/outgoing.js | https://app.codecov.io/gh/nodejs/node/pull/58535?src=pr&el=tree&filepath=lib%2Finternal%2Fhttp%2Foutgoing.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL2h0dHAvb3V0Z29pbmcuanM= |
| 48 Missing and 3 partials ⚠️ | https://app.codecov.io/gh/nodejs/node/pull/58535?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| lib/internal/http/server.js | https://app.codecov.io/gh/nodejs/node/pull/58535?src=pr&el=tree&filepath=lib%2Finternal%2Fhttp%2Fserver.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL2h0dHAvc2VydmVyLmpz |
| 33 Missing and 3 partials ⚠️ | https://app.codecov.io/gh/nodejs/node/pull/58535?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| lib/internal/http/client.js | https://app.codecov.io/gh/nodejs/node/pull/58535?src=pr&el=tree&filepath=lib%2Finternal%2Fhttp%2Fclient.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL2h0dHAvY2xpZW50Lmpz |
| 20 Missing ⚠️ | https://app.codecov.io/gh/nodejs/node/pull/58535?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| lib/internal/http/agent.js | https://app.codecov.io/gh/nodejs/node/pull/58535?src=pr&el=tree&filepath=lib%2Finternal%2Fhttp%2Fagent.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL2h0dHAvYWdlbnQuanM= |
| 10 Missing ⚠️ | https://app.codecov.io/gh/nodejs/node/pull/58535?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| lib/internal/http/incoming.js | https://app.codecov.io/gh/nodejs/node/pull/58535?src=pr&el=tree&filepath=lib%2Finternal%2Fhttp%2Fincoming.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL2h0dHAvaW5jb21pbmcuanM= |
| 3 Missing ⚠️ | https://app.codecov.io/gh/nodejs/node/pull/58535?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| Files with missing lines | https://app.codecov.io/gh/nodejs/node/pull/58535?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| lib/_http_agent.js | https://app.codecov.io/gh/nodejs/node/pull/58535?src=pr&el=tree&filepath=lib%2F_http_agent.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL19odHRwX2FnZW50Lmpz |
| lib/_http_client.js | https://app.codecov.io/gh/nodejs/node/pull/58535?src=pr&el=tree&filepath=lib%2F_http_client.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL19odHRwX2NsaWVudC5qcw== |
| lib/_http_common.js | https://app.codecov.io/gh/nodejs/node/pull/58535?src=pr&el=tree&filepath=lib%2F_http_common.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL19odHRwX2NvbW1vbi5qcw== |
| lib/_http_incoming.js | https://app.codecov.io/gh/nodejs/node/pull/58535?src=pr&el=tree&filepath=lib%2F_http_incoming.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL19odHRwX2luY29taW5nLmpz |
| lib/_http_outgoing.js | https://app.codecov.io/gh/nodejs/node/pull/58535?src=pr&el=tree&filepath=lib%2F_http_outgoing.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL19odHRwX291dGdvaW5nLmpz |
| lib/_http_server.js | https://app.codecov.io/gh/nodejs/node/pull/58535?src=pr&el=tree&filepath=lib%2F_http_server.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL19odHRwX3NlcnZlci5qcw== |
| lib/http.js | https://app.codecov.io/gh/nodejs/node/pull/58535?src=pr&el=tree&filepath=lib%2Fhttp.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2h0dHAuanM= |
| lib/https.js | https://app.codecov.io/gh/nodejs/node/pull/58535?src=pr&el=tree&filepath=lib%2Fhttps.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2h0dHBzLmpz |
| lib/internal/child_process.js | https://app.codecov.io/gh/nodejs/node/pull/58535?src=pr&el=tree&filepath=lib%2Finternal%2Fchild_process.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL2NoaWxkX3Byb2Nlc3MuanM= |
| lib/internal/http/common.js | https://app.codecov.io/gh/nodejs/node/pull/58535?src=pr&el=tree&filepath=lib%2Finternal%2Fhttp%2Fcommon.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL2h0dHAvY29tbW9uLmpz |
| 8 more | https://app.codecov.io/gh/nodejs/node/pull/58535?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| 25 files with indirect coverage changes | https://app.codecov.io/gh/nodejs/node/pull/58535/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| Test Analytics | https://docs.codecov.com/docs/test-analytics |
| JS Bundle Analysis | https://docs.codecov.com/docs/javascript-bundle-analysis |
| Please reload this page | https://github.com/nodejs/node/pull/58535 |
| https://github.com/dario-piotrowicz |
| dario-piotrowicz | https://github.com/dario-piotrowicz |
|
Jun 1, 2025
| https://github.com/nodejs/node/pull/58535#pullrequestreview-2886155471 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/58535/files/2103d6f19f5b44505c4bd02a8d6199115a75358f |
| benchmark/http/check_invalid_header_char.js | https://github.com/nodejs/node/pull/58535/files/bd305a8caf85e954bb6c69d6ec7010db6d3800b8#diff-6e0c5da178236cdc4e4f2e55882345880beac9cf5e33d910494dbf1eeadf8257 |
| dario-piotrowicz | https://github.com/dario-piotrowicz |
| Jun 1, 2025 | https://github.com/nodejs/node/pull/58535#discussion_r2119628829 |
| Please reload this page | https://github.com/nodejs/node/pull/58535 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/58535 |
| lib/_http_common.js | https://github.com/nodejs/node/pull/58535/files/2103d6f19f5b44505c4bd02a8d6199115a75358f#diff-c53157e76b3e2712347a8cadde9d676026c82b00c3c1569e4932ec3ff3c9fa9b |
| dario-piotrowicz | https://github.com/dario-piotrowicz |
| Jun 1, 2025 | https://github.com/nodejs/node/pull/58535#discussion_r2119629425 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/58535 |
| dario-piotrowicz | https://github.com/dario-piotrowicz |
| Jun 1, 2025 | https://github.com/nodejs/node/pull/58535#discussion_r2119629943 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/58535 |
| test/parallel/test-https-server-close-destroy-timeout.js | https://github.com/nodejs/node/pull/58535/files/bd305a8caf85e954bb6c69d6ec7010db6d3800b8#diff-6be7c57e2462b8df959757644979f9753ff0b22f6b42e0a7f2f3a8a731b5095d |
| dario-piotrowicz | https://github.com/dario-piotrowicz |
| Jun 1, 2025 | https://github.com/nodejs/node/pull/58535#discussion_r2119658612 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/58535 |
| https://github.com/bjohansebas |
| bjohansebas | https://github.com/bjohansebas |
| Jun 14, 2025 | https://github.com/nodejs/node/pull/58535#issuecomment-2972933014 |
| Please reload this page | https://github.com/nodejs/node/pull/58535 |
| bjohansebas | https://github.com/bjohansebas |
|
Jul 30, 2025
| https://github.com/nodejs/node/pull/58535#ref-commit-d8d2df0 |
|
| https://github.com/bjohansebas |
| lib: docs deprecate _http_* | https://github.com/bjohansebas/node/commit/d8d2df09978183dbc50862e28f5b60de0f49d49a |
| d8d2df0 | https://github.com/bjohansebas/node/commit/d8d2df09978183dbc50862e28f5b60de0f49d49a |
| nodejs#58535 | https://github.com/nodejs/node/pull/58535 |
| bjohansebas | https://github.com/bjohansebas |
|
Jul 31, 2025
| https://github.com/nodejs/node/pull/58535#ref-commit-df48e6f |
|
| https://github.com/bjohansebas |
| lib: docs deprecate _http_* | https://github.com/bjohansebas/node/commit/df48e6feb3c2962afddc6a3dd1bad66259207c95 |
| df48e6f | https://github.com/bjohansebas/node/commit/df48e6feb3c2962afddc6a3dd1bad66259207c95 |
| nodejs#58535 | https://github.com/nodejs/node/pull/58535 |
| https://github.com/bjohansebas |
| bjohansebas | https://github.com/bjohansebas |
|
Jul 31, 2025
| https://github.com/nodejs/node/pull/58535#ref-pullrequest-3278812369 |
|
lib: docs deprecate _http_*
#59293
| https://github.com/nodejs/node/pull/59293 |
| bjohansebas | https://github.com/bjohansebas |
|
Jul 31, 2025
| https://github.com/nodejs/node/pull/58535#ref-commit-70c3173 |
|
| https://github.com/bjohansebas |
| lib: docs deprecate _http_* | https://github.com/bjohansebas/node/commit/70c31732bc4b0e17f4112b0dd18500ba05632e33 |
| 70c3173 | https://github.com/bjohansebas/node/commit/70c31732bc4b0e17f4112b0dd18500ba05632e33 |
| nodejs#58535 | https://github.com/nodejs/node/pull/58535 |
| bjohansebas | https://github.com/bjohansebas |
|
Jul 31, 2025
| https://github.com/nodejs/node/pull/58535#ref-commit-e947fb5 |
|
| https://github.com/bjohansebas |
| lib: docs deprecate _http_* | https://github.com/bjohansebas/node/commit/e947fb5533bfc2f45dbae5b79bcf2005f5cd2829 |
| e947fb5 | https://github.com/bjohansebas/node/commit/e947fb5533bfc2f45dbae5b79bcf2005f5cd2829 |
| nodejs#58535 | https://github.com/nodejs/node/pull/58535 |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
Aug 2, 2025
| https://github.com/nodejs/node/pull/58535#ref-commit-e4b748a |
|
| https://github.com/bjohansebas |
| lib: docs deprecate _http_* | https://github.com/nodejs/node/commit/e4b748a9cc0f7ceeb3a4299da68e42c8c83d2743 |
| e4b748a | https://github.com/nodejs/node/commit/e4b748a9cc0f7ceeb3a4299da68e42c8c83d2743 |
| #58535 | https://github.com/nodejs/node/pull/58535 |
| #59293 | https://github.com/nodejs/node/pull/59293 |
| meteorqz6 | https://github.com/meteorqz6 |
|
Aug 2, 2025
| https://github.com/nodejs/node/pull/58535#ref-commit-7c79238 |
|
| https://github.com/bjohansebas |
|
| https://github.com/meteorqz6 |
| lib: docs deprecate _http_* | https://github.com/meteorqz6/node/commit/7c792387cd987d9245a3b518fcca4cef3297e67b |
| 7c79238 | https://github.com/meteorqz6/node/commit/7c792387cd987d9245a3b518fcca4cef3297e67b |
| nodejs#58535 | https://github.com/nodejs/node/pull/58535 |
| nodejs#59293 | https://github.com/nodejs/node/pull/59293 |
| panva | https://github.com/panva |
|
Aug 7, 2025
| https://github.com/nodejs/node/pull/58535#ref-commit-b28c42c |
|
| https://github.com/bjohansebas |
|
| https://github.com/panva |
| lib: docs deprecate _http_* | https://github.com/panva/node/commit/b28c42cb9fdc56af4c22e03f1de21bfbc396d1f5 |
| b28c42c | https://github.com/panva/node/commit/b28c42cb9fdc56af4c22e03f1de21bfbc396d1f5 |
| nodejs#58535 | https://github.com/nodejs/node/pull/58535 |
| nodejs#59293 | https://github.com/nodejs/node/pull/59293 |
| targos | https://github.com/targos |
|
Aug 8, 2025
| https://github.com/nodejs/node/pull/58535#ref-commit-83b1be5 |
|
| https://github.com/bjohansebas |
|
| https://github.com/targos |
| lib: docs deprecate _http_* | https://github.com/nodejs/node/commit/83b1be53f4373684ad350a84b0e4dae9390d4406 |
| 83b1be5 | https://github.com/nodejs/node/commit/83b1be53f4373684ad350a84b0e4dae9390d4406 |
| #58535 | https://github.com/nodejs/node/pull/58535 |
| #59293 | https://github.com/nodejs/node/pull/59293 |
| mete0rfish | https://github.com/mete0rfish |
|
Aug 9, 2025
| https://github.com/nodejs/node/pull/58535#ref-commit-b6b3794 |
|
| https://github.com/bjohansebas |
|
| https://github.com/mete0rfish |
| lib: docs deprecate _http_* | https://github.com/mete0rfish/node-contribute/commit/b6b37941869fdd8934a9c10d827a5484587bd811 |
| b6b3794 | https://github.com/mete0rfish/node-contribute/commit/b6b37941869fdd8934a9c10d827a5484587bd811 |
| nodejs#58535 | https://github.com/nodejs/node/pull/58535 |
| nodejs#59293 | https://github.com/nodejs/node/pull/59293 |
| panva | https://github.com/panva |
|
Aug 9, 2025
| https://github.com/nodejs/node/pull/58535#ref-commit-239ef7c |
|
| https://github.com/bjohansebas |
|
| https://github.com/panva |
| lib: docs deprecate _http_* | https://github.com/panva/node/commit/239ef7c52720ab235c8bd7d89740e35a6ed0dfa4 |
| 239ef7c | https://github.com/panva/node/commit/239ef7c52720ab235c8bd7d89740e35a6ed0dfa4 |
| nodejs#58535 | https://github.com/nodejs/node/pull/58535 |
| nodejs#59293 | https://github.com/nodejs/node/pull/59293 |
| RafaelGSS | https://github.com/RafaelGSS |
|
Aug 12, 2025
| https://github.com/nodejs/node/pull/58535#ref-commit-c144d69 |
|
| https://github.com/bjohansebas |
|
| https://github.com/RafaelGSS |
| lib: docs deprecate _http_* | https://github.com/nodejs/node/commit/c144d69efc20578f9776241e58d7e29a7e0bf739 |
| c144d69 | https://github.com/nodejs/node/commit/c144d69efc20578f9776241e58d7e29a7e0bf739 |
| #58535 | https://github.com/nodejs/node/pull/58535 |
| #59293 | https://github.com/nodejs/node/pull/59293 |
| aduh95 | https://github.com/aduh95 |
|
Aug 21, 2025
| https://github.com/nodejs/node/pull/58535#ref-commit-8667f94 |
|
| https://github.com/bjohansebas |
|
| https://github.com/aduh95 |
| lib: docs deprecate _http_* | https://github.com/nodejs/node/commit/8667f948c8b5ba81ac6408e2dbb1a46dca8418e7 |
| 8667f94 | https://github.com/nodejs/node/commit/8667f948c8b5ba81ac6408e2dbb1a46dca8418e7 |
| #58535 | https://github.com/nodejs/node/pull/58535 |
| #59293 | https://github.com/nodejs/node/pull/59293 |
| aduh95 | https://github.com/aduh95 |
|
Aug 21, 2025
| https://github.com/nodejs/node/pull/58535#ref-commit-8846b53 |
|
| https://github.com/bjohansebas |
|
| https://github.com/aduh95 |
| lib: docs deprecate _http_* | https://github.com/nodejs/node/commit/8846b5351ee343961edd7a5a5eba6d64c375317c |
| 8846b53 | https://github.com/nodejs/node/commit/8846b5351ee343961edd7a5a5eba6d64c375317c |
| #58535 | https://github.com/nodejs/node/pull/58535 |
| #59293 | https://github.com/nodejs/node/pull/59293 |
| aduh95 | https://github.com/aduh95 |
|
Aug 25, 2025
| https://github.com/nodejs/node/pull/58535#ref-commit-bb38182 |
|
| https://github.com/bjohansebas |
|
| https://github.com/aduh95 |
| lib: docs deprecate _http_* | https://github.com/nodejs/node/commit/bb38182c0672f57155b84df9d76fef9250ce6db5 |
| bb38182 | https://github.com/nodejs/node/commit/bb38182c0672f57155b84df9d76fef9250ce6db5 |
| #58535 | https://github.com/nodejs/node/pull/58535 |
| #59293 | https://github.com/nodejs/node/pull/59293 |
| aduh95 | https://github.com/aduh95 |
|
Aug 26, 2025
| https://github.com/nodejs/node/pull/58535#ref-commit-c12c534 |
|
| https://github.com/bjohansebas |
|
| https://github.com/aduh95 |
| lib: docs deprecate _http_* | https://github.com/nodejs/node/commit/c12c5343ada24d7211fd5c70b40996260d9a5d68 |
| c12c534 | https://github.com/nodejs/node/commit/c12c5343ada24d7211fd5c70b40996260d9a5d68 |
| #58535 | https://github.com/nodejs/node/pull/58535 |
| #59293 | https://github.com/nodejs/node/pull/59293 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F58535 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/58535/files/bd305a8caf85e954bb6c69d6ec7010db6d3800b8 |
|
| https://github.com/dario-piotrowicz |
|
dario-piotrowicz
| https://github.com/dario-piotrowicz |
|
| https://github.com/nodejs/node/pull/58535/files/2103d6f19f5b44505c4bd02a8d6199115a75358f |
|
| https://github.com/mcollina |
|
mcollina
| https://github.com/mcollina |
|
deprecations
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adeprecations |
|
http
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
semver-major
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major |
|
Move _http_* to be internal APIs.
| https://github.com/nodejs/node/issues/58534 |
| Please reload this page | https://github.com/nodejs/node/pull/58535 |
|
| https://github.com/bjohansebas |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/jasnell |
|
| https://github.com/dario-piotrowicz |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |