René's URL Explorer Experiment


Title: lib: fix testNamePatterns and testSkipPatterns being ignored with isolation "none" by danielmbrasil · Pull Request #58496 · nodejs/node · GitHub

Open Graph Title: lib: fix testNamePatterns and testSkipPatterns being ignored with isolation "none" by danielmbrasil · Pull Request #58496 · nodejs/node

X Title: lib: fix testNamePatterns and testSkipPatterns being ignored with isolation "none" by danielmbrasil · Pull Request #58496 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes #57399.

X Description: Fixes #57399.

Opengraph URL: https://github.com/nodejs/node/pull/58496

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:61a92e95-c728-0e88-b34e-2da416a9bfe6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id835C:2D3467:7519D6:9B1830:6AED23C3
html-safe-nonce5e8056bf13e94c924e8bfb592b97e9ef85099311243063a571276d85c337ceb2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MzVDOjJEMzQ2Nzo3NTE5RDY6OUIxODMwOjZBRUQyM0MzIiwidmlzaXRvcl9pZCI6Ijg3MDY3MjI2ODMwODE3OTQ0OTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac98168dd13a6ca493b800ee33b290a9166a582036b19cb63848350ecdd85df034
hovercard-subject-tagpull_request:2549759659
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/58496/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b152079de7b463454975d6af5e3bf5eb2abc7403cf537850b2e36db43fde8ca4/nodejs/node/pull/58496
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b152079de7b463454975d6af5e3bf5eb2abc7403cf537850b2e36db43fde8ca4/nodejs/node/pull/58496
og:image:altFixes #57399.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedanielmbrasil
hostnamegithub.com
expected-hostnamegithub.com
Nonee3e0f7f63e50c6fe879198a93a0a023a648ecc0a5e9bc3b5e033ac57172237e6
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release707a24b346ac8a82878b9c084efaa38a997660cb
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/58496#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F58496
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F58496
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/58496
Reloadhttps://github.com/nodejs/node/pull/58496
Reloadhttps://github.com/nodejs/node/pull/58496
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues657 (657)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
danielmbrasilhttps://github.com/danielmbrasil
nodejs:mainhttps://github.com/nodejs/node/tree/main
danielmbrasil:fix/test-runner-ignore-patterns-isolation-nonehttps://github.com/danielmbrasil/node/tree/fix/test-runner-ignore-patterns-isolation-none
Conversationhttps://github.com/nodejs/node/pull/58496
Commits2 (2)https://github.com/nodejs/node/pull/58496/commits
Checkshttps://github.com/nodejs/node/pull/58496/checks
Files changedhttps://github.com/nodejs/node/pull/58496/files
lib: fix testNamePatterns and testSkipPatterns being ignored with isolation "none"https://github.com/nodejs/node/pull/58496#top
danielmbrasilhttps://github.com/danielmbrasil
nodejs:mainhttps://github.com/nodejs/node/tree/main
danielmbrasil:fix/test-runner-ignore-patterns-isolation-nonehttps://github.com/danielmbrasil/node/tree/fix/test-runner-ignore-patterns-isolation-none
https://github.com/danielmbrasil
danielmbrasilhttps://github.com/danielmbrasil
May 28, 2025https://github.com/nodejs/node/pull/58496#issue-3097604793
#57399https://github.com/nodejs/node/issues/57399
Please reload this pagehttps://github.com/nodejs/node/pull/58496
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 28, 2025https://github.com/nodejs/node/pull/58496#issuecomment-2916579303
Please reload this pagehttps://github.com/nodejs/node/pull/58496
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
test_runner https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest_runner
May 28, 2025https://github.com/nodejs/node/pull/58496#event-17852400185
https://github.com/danielmbrasil
danielmbrasilhttps://github.com/danielmbrasil
May 28, 2025 https://github.com/nodejs/node/pull/58496#pullrequestreview-2875357272
View reviewed changes https://github.com/nodejs/node/pull/58496/files
lib/internal/test_runner/runner.jshttps://github.com/nodejs/node/pull/58496/files#diff-840cee72cdda14be90e6c5607ffa844eaf73be966607ddc834cc667bd142fb21
danielmbrasilhttps://github.com/danielmbrasil
May 28, 2025https://github.com/nodejs/node/pull/58496#discussion_r2112074931
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#57399 (comment)https://github.com/nodejs/node/issues/57399#issuecomment-2744115794
Please reload this pagehttps://github.com/nodejs/node/pull/58496
pmarchinihttps://github.com/pmarchini
May 28, 2025https://github.com/nodejs/node/pull/58496#discussion_r2112370810
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/58496
test/parallel/test-runner-run.mjshttps://github.com/nodejs/node/pull/58496/files#diff-196bc4ec67eaf2b311f953b5282702f42d7c55a5e6ab5599fdf83f51fdf3c23c
danielmbrasilhttps://github.com/danielmbrasil
May 28, 2025https://github.com/nodejs/node/pull/58496#discussion_r2112078740
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/58496
pmarchinihttps://github.com/pmarchini
May 29, 2025https://github.com/nodejs/node/pull/58496#discussion_r2114567108
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://github.com/nodejs/node/blob/main/test/parallel/test-runner-run-watch.mjshttps://github.com/nodejs/node/blob/main/test/parallel/test-runner-run-watch.mjs
Please reload this pagehttps://github.com/nodejs/node/pull/58496
danielmbrasilhttps://github.com/danielmbrasil
Jul 4, 2025https://github.com/nodejs/node/pull/58496#discussion_r2185710816
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@pmarchinihttps://github.com/pmarchini
Please reload this pagehttps://github.com/nodejs/node/pull/58496
https://github.com/danielmbrasil
danielmbrasilhttps://github.com/danielmbrasil
force-pushedhttps://github.com/nodejs/node/compare/9af076f0891afd8a29233cec788178de3e4ee07b..9aeef6cb639727a4c940819ff2af6f6abc285fbd
9af076fhttps://github.com/nodejs/node/commit/9af076f0891afd8a29233cec788178de3e4ee07b
9aeef6chttps://github.com/nodejs/node/commit/9aeef6cb639727a4c940819ff2af6f6abc285fbd
Compare https://github.com/nodejs/node/compare/9af076f0891afd8a29233cec788178de3e4ee07b..9aeef6cb639727a4c940819ff2af6f6abc285fbd
May 28, 2025 14:37https://github.com/nodejs/node/pull/58496#event-17852489087
https://github.com/geeksilva97
geeksilva97https://github.com/geeksilva97
cjihrighttps://github.com/cjihrig
pmarchinihttps://github.com/pmarchini
May 28, 2025 14:40https://github.com/nodejs/node/pull/58496#event-17852531711
danielmbrasilhttps://github.com/danielmbrasil
July 4, 2025 13:07https://github.com/nodejs/node/pull/58496#commits-pushed-4c8e03d
https://github.com/danielmbrasil
lib: support testNamePatterns and testSkipPatterns with 'none' isolationhttps://github.com/nodejs/node/pull/58496/commits/4c8e03d41c4c71ddcea29a068dc8ffa7ba4e2ee3
4c8e03dhttps://github.com/nodejs/node/pull/58496/commits/4c8e03d41c4c71ddcea29a068dc8ffa7ba4e2ee3
https://github.com/danielmbrasil
test: fix testshttps://github.com/nodejs/node/pull/58496/commits/db620681d4ba419bdf3240c1db2a675dbc89281e
db62068https://github.com/nodejs/node/pull/58496/commits/db620681d4ba419bdf3240c1db2a675dbc89281e
https://github.com/danielmbrasil
danielmbrasilhttps://github.com/danielmbrasil
force-pushedhttps://github.com/nodejs/node/compare/9aeef6cb639727a4c940819ff2af6f6abc285fbd..db620681d4ba419bdf3240c1db2a675dbc89281e
9aeef6chttps://github.com/nodejs/node/commit/9aeef6cb639727a4c940819ff2af6f6abc285fbd
db62068https://github.com/nodejs/node/commit/db620681d4ba419bdf3240c1db2a675dbc89281e
Compare https://github.com/nodejs/node/compare/9aeef6cb639727a4c940819ff2af6f6abc285fbd..db620681d4ba419bdf3240c1db2a675dbc89281e
July 4, 2025 16:08https://github.com/nodejs/node/pull/58496#event-18475257983
https://github.com/danielmbrasil
danielmbrasilhttps://github.com/danielmbrasil
July 4, 2025 16:13https://github.com/nodejs/node/pull/58496#event-18475321273
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Jul 4, 2025https://github.com/nodejs/node/pull/58496#issuecomment-3036891247
Please reload this pagehttps://github.com/nodejs/node/pull/58496
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/58496?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
813b4e8https://app.codecov.io/gh/nodejs/node/commit/813b4e8b0ef4909b19993ce7f3627e3b4db58a82?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
db62068https://app.codecov.io/gh/nodejs/node/commit/db620681d4ba419bdf3240c1db2a675dbc89281e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/58496?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/test_runner/runner.jshttps://app.codecov.io/gh/nodejs/node/pull/58496?src=pr&el=tree&filepath=lib%2Finternal%2Ftest_runner%2Frunner.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3Rlc3RfcnVubmVyL3J1bm5lci5qcw==
24 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/58496/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/58496
https://github.com/pmarchini
pmarchinihttps://github.com/pmarchini
Jul 6, 2025 https://github.com/nodejs/node/pull/58496#pullrequestreview-2991593576
View reviewed changes https://github.com/nodejs/node/pull/58496/files/db620681d4ba419bdf3240c1db2a675dbc89281e
test/parallel/test-runner-run.mjshttps://github.com/nodejs/node/pull/58496/files/db620681d4ba419bdf3240c1db2a675dbc89281e#diff-196bc4ec67eaf2b311f953b5282702f42d7c55a5e6ab5599fdf83f51fdf3c23c
pmarchinihttps://github.com/pmarchini
Jul 6, 2025https://github.com/nodejs/node/pull/58496#discussion_r2188542283
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/58496
https://github.com/inukshuk
inukshukhttps://github.com/inukshuk
Mar 15, 2026 https://github.com/nodejs/node/pull/58496#ref-pullrequest-4079445918
test_runner: use run() options with isolation="none" #62269 https://github.com/nodejs/node/pull/62269
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jul 28, 2026https://github.com/nodejs/node/pull/58496#issuecomment-5098363552
Please reload this pagehttps://github.com/nodejs/node/pull/58496
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
stale https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astale
Jul 28, 2026https://github.com/nodejs/node/pull/58496#event-28569550960
https://github.com/danielmbrasil
danielmbrasilhttps://github.com/danielmbrasil
Jul 28, 2026https://github.com/nodejs/node/pull/58496#event-28599596149
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F58496
https://github.com/pmarchini
pmarchini https://github.com/pmarchini
https://github.com/nodejs/node/pull/58496/files/db620681d4ba419bdf3240c1db2a675dbc89281e
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
Please reload this pagehttps://github.com/nodejs/node/pull/58496
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
stale https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astale
test_runner https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest_runner
test runner run() ignores testNamePatterns and testSkipPatterns when isolation is "none" https://github.com/nodejs/node/issues/57399
Please reload this pagehttps://github.com/nodejs/node/pull/58496
https://github.com/danielmbrasil
https://github.com/nodejs-github-bot
https://github.com/pmarchini
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.