| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:200226b9-521b-ba75-1a5f-ad23332b2340 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C652:18B65E:B2725F:F369E3:6969EADB |
| html-safe-nonce | 9cb7dc94bb828c59dc4b0a43a55973efe76c69091cd944a4ce117e36c7935c74 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNjUyOjE4QjY1RTpCMjcyNUY6RjM2OUUzOjY5NjlFQURCIiwidmlzaXRvcl9pZCI6IjQxOTI0MjE1Nzc3MzIyNTQ0MjciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | ed4316714d18ab19491cd5e8e02f35ab645866c2a53cd0ba7bb4b055bf425a30 |
| hovercard-subject-tag | pull_request:2520927594 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/58342/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/e74c018a45a5ed66e9b39905448c7621e9a245f2f4ada979fb265680a38b811d/nodejs/node/pull/58342 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e74c018a45a5ed66e9b39905448c7621e9a245f2f4ada979fb265680a38b811d/nodejs/node/pull/58342 |
| og:image:alt | Node 20.19.2 currently fails to build from source since Xcode 16.3 (and LLVM Clang 18). This pull request backports three v8 commits that fix the issue:
deps: V8: cherry-pick third_party/zlib@646b... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Bo98 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | bdde15ad1b403e23b08bbd89b53fbe6bdf688cad |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/58342#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F58342 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F58342 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/58342 |
| Reload | https://github.com/nodejs/node/pull/58342 |
| Reload | https://github.com/nodejs/node/pull/58342 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/58342 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
697
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/58342 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/58342#issue-comment-box |
| Bo98 | https://github.com/Bo98 |
| nodejs:v20.x-staging | https://github.com/nodejs/node/tree/v20.x-staging |
| Bo98:v20.x-xcode16.3 | https://github.com/Bo98/node/tree/v20.x-xcode16.3 |
|
[v20.x] deps: V8: backport build fixes for Xcode 16.3
| https://github.com/nodejs/node/pull/58342#top |
| Bo98 | https://github.com/Bo98 |
| nodejs:v20.x-staging | https://github.com/nodejs/node/tree/v20.x-staging |
| Bo98:v20.x-xcode16.3 | https://github.com/Bo98/node/tree/v20.x-xcode16.3 |
|
Conversation
16
| https://github.com/nodejs/node/pull/58342 |
|
Commits
3
| https://github.com/nodejs/node/pull/58342/commits |
|
Checks
25
| https://github.com/nodejs/node/pull/58342/checks |
|
Files changed
| https://github.com/nodejs/node/pull/58342/files |
| Please reload this page | https://github.com/nodejs/node/pull/58342 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/Bo98 |
| Bo98 | https://github.com/Bo98 |
| May 15, 2025 | https://github.com/nodejs/node/pull/58342#issue-3064936919 |
| Please reload this page | https://github.com/nodejs/node/pull/58342 |
| deps: V8: cherry-pick third_party/zlib@646b7f569718 | https://github.com/nodejs/node/commit/3b5eb14cad3a493e99f84ca45871bd37570cae3d |
| https://chromium.googlesource.com/chromium/src/third_party/zlib/+/646b7f569718921d7d4b5b8e22572ff6c76f2596 | https://chromium.googlesource.com/chromium/src/third_party/zlib/+/646b7f569718921d7d4b5b8e22572ff6c76f2596 |
| deps: V8: cherry-pick 182d9c05e78b | https://github.com/nodejs/node/commit/e2ab76c1aeceaf866b8c5053cf71f199706d621d |
| v8/v8@182d9c0 | https://github.com/v8/v8/commit/182d9c05e78b1ddb1cb8242cd3628a7855a0336f |
| deps: V8: cherry-pick 1a3ecc2483b2 | https://github.com/nodejs/node/commit/a56d782971c30164545e76a97b07ade373a3a565 |
| v8/v8@182d9c0 | https://github.com/v8/v8/commit/182d9c05e78b1ddb1cb8242cd3628a7855a0336f |
| 4ad3479 | https://github.com/nodejs/node/commit/4ad3479ba7f01415c3cbdcbec0e617c6085002d8 |
| v8/v8@1a3ecc2 | https://github.com/v8/v8/commit/1a3ecc2483b2dba6ab9f7e9f8f4b60dbfef504b7 |
| Please reload this page | https://github.com/nodejs/node/pull/58342 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| May 15, 2025 | https://github.com/nodejs/node/pull/58342#issuecomment-2882403380 |
| Please reload this page | https://github.com/nodejs/node/pull/58342 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
v20.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av20.x |
|
v8 engine
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22 |
| May 15, 2025 | https://github.com/nodejs/node/pull/58342#event-17664574831 |
| https://github.com/marco-ippolito |
| marco-ippolito | https://github.com/marco-ippolito |
|
May 15, 2025
| https://github.com/nodejs/node/pull/58342#pullrequestreview-2844400030 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/58342/files/7b59afa0a2ec42f4febc02fddc985dc9b0d69c35 |
| https://github.com/mertcanaltin |
| mertcanaltin | https://github.com/mertcanaltin |
|
May 15, 2025
| https://github.com/nodejs/node/pull/58342#pullrequestreview-2844729464 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/58342/files/7b59afa0a2ec42f4febc02fddc985dc9b0d69c35 |
| https://github.com/marco-ippolito |
| marco-ippolito | https://github.com/marco-ippolito |
| May 16, 2025 | https://github.com/nodejs/node/pull/58342#issuecomment-2886736428 |
| Please reload this page | https://github.com/nodejs/node/pull/58342 |
| Please reload this page | https://github.com/nodejs/node/pull/58342 |
| https://github.com/marco-ippolito |
| marco-ippolito | https://github.com/marco-ippolito |
| force-pushed | https://github.com/nodejs/node/compare/a56d782971c30164545e76a97b07ade373a3a565..42c8a36842647925fe78df058eaca10ede0a0b6e |
| a56d782 | https://github.com/nodejs/node/commit/a56d782971c30164545e76a97b07ade373a3a565 |
| 42c8a36 | https://github.com/nodejs/node/commit/42c8a36842647925fe78df058eaca10ede0a0b6e |
|
Compare
| https://github.com/nodejs/node/compare/a56d782971c30164545e76a97b07ade373a3a565..42c8a36842647925fe78df058eaca10ede0a0b6e |
| June 3, 2025 13:32 | https://github.com/nodejs/node/pull/58342#event-17958368526 |
| https://github.com/marco-ippolito |
| marco-ippolito | https://github.com/marco-ippolito |
|
Jun 3, 2025
| https://github.com/nodejs/node/pull/58342#pullrequestreview-2892404855 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/58342/files/7b59afa0a2ec42f4febc02fddc985dc9b0d69c35 |
| https://github.com/marco-ippolito |
| marco-ippolito | https://github.com/marco-ippolito |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Jun 4, 2025 | https://github.com/nodejs/node/pull/58342#event-17974712925 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Jun 4, 2025 | https://github.com/nodejs/node/pull/58342#event-17974730374 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jun 4, 2025 | https://github.com/nodejs/node/pull/58342#issuecomment-2938749989 |
| https://ci.nodejs.org/job/node-test-pull-request/67268/ | https://ci.nodejs.org/job/node-test-pull-request/67268/ |
| Please reload this page | https://github.com/nodejs/node/pull/58342 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jun 4, 2025 | https://github.com/nodejs/node/pull/58342#issuecomment-2938750463 |
| https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6594/ | https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6594/ |
| Please reload this page | https://github.com/nodejs/node/pull/58342 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jun 4, 2025 | https://github.com/nodejs/node/pull/58342#issuecomment-2938753426 |
| https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6594/ | https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6594/ |
| Please reload this page | https://github.com/nodejs/node/pull/58342 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jun 4, 2025 | https://github.com/nodejs/node/pull/58342#issuecomment-2938753719 |
| https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6594/ | https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6594/ |
| Please reload this page | https://github.com/nodejs/node/pull/58342 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jun 4, 2025 | https://github.com/nodejs/node/pull/58342#issuecomment-2938996424 |
| https://ci.nodejs.org/job/node-test-pull-request/67270/ | https://ci.nodejs.org/job/node-test-pull-request/67270/ |
| Please reload this page | https://github.com/nodejs/node/pull/58342 |
| https://github.com/Bo98 |
| Bo98 | https://github.com/Bo98 |
| Jun 4, 2025 | https://github.com/nodejs/node/pull/58342#issuecomment-2940800755 |
| Please reload this page | https://github.com/nodejs/node/pull/58342 |
| 996a774 | https://github.com/nodejs/node/commit/996a774ebacabc55aa321f544f4788c2b0d16bcf |
| Please reload this page | https://github.com/nodejs/node/pull/58342 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jun 5, 2025 | https://github.com/nodejs/node/pull/58342#issuecomment-2942848567 |
| https://ci.nodejs.org/job/node-test-pull-request/67276/ | https://ci.nodejs.org/job/node-test-pull-request/67276/ |
| Please reload this page | https://github.com/nodejs/node/pull/58342 |
| https://github.com/Bo98 |
| Bo98 | https://github.com/Bo98 |
| Jun 5, 2025 | https://github.com/nodejs/node/pull/58342#issuecomment-2942970805 |
| Please reload this page | https://github.com/nodejs/node/pull/58342 |
| 8287f67 | https://github.com/nodejs/node/commit/8287f6748b6b62096a24e911a223cc783f4328c1 |
| Please reload this page | https://github.com/nodejs/node/pull/58342 |
| https://github.com/marco-ippolito |
| marco-ippolito | https://github.com/marco-ippolito |
| Jun 5, 2025 | https://github.com/nodejs/node/pull/58342#issuecomment-2942989904 |
| Please reload this page | https://github.com/nodejs/node/pull/58342 |
| Please reload this page | https://github.com/nodejs/node/pull/58342 |
| zmodem | https://github.com/zmodem |
| June 5, 2025 08:07 | https://github.com/nodejs/node/pull/58342#commits-pushed-43728c7 |
|
| https://github.com/zmodem |
|
| https://github.com/Bo98 |
| deps: V8: cherry-pick third_party/zlib@646b7f569718 | https://github.com/nodejs/node/pull/58342/commits/43728c7e3dfe6f65bc96d0485c639dad03ef9627 |
| 43728c7 | https://github.com/nodejs/node/pull/58342/commits/43728c7e3dfe6f65bc96d0485c639dad03ef9627 |
| madler/zlib@4bd9a71 | https://github.com/madler/zlib/commit/4bd9a71f3539b5ce47f0c67ab5e01f3196dc8ef9 |
| https://chromium-review.googlesource.com/c/chromium/src/+/5237020 | https://chromium-review.googlesource.com/c/chromium/src/+/5237020 |
| https://chromium.googlesource.com/chromium/src/third_party/zlib/+/646b7f569718921d7d4b5b8e22572ff6c76f2596 | https://chromium.googlesource.com/chromium/src/third_party/zlib/+/646b7f569718921d7d4b5b8e22572ff6c76f2596 |
|
| https://github.com/caseq |
|
| https://github.com/Bo98 |
| deps: V8: cherry-pick 182d9c05e78b | https://github.com/nodejs/node/pull/58342/commits/24ae734f53034b809ae348a2f0d6368d1ee2989a |
| 24ae734 | https://github.com/nodejs/node/pull/58342/commits/24ae734f53034b809ae348a2f0d6368d1ee2989a |
| https://chromium-review.googlesource.com/c/v8/v8/+/4789966 | https://chromium-review.googlesource.com/c/v8/v8/+/4789966 |
| v8/v8@182d9c0 | https://github.com/v8/v8/commit/182d9c05e78b1ddb1cb8242cd3628a7855a0336f |
|
| https://github.com/targos |
|
| https://github.com/Bo98 |
| deps: V8: cherry-pick 1a3ecc2483b2 | https://github.com/nodejs/node/pull/58342/commits/7b59afa0a2ec42f4febc02fddc985dc9b0d69c35 |
| 7b59afa | https://github.com/nodejs/node/pull/58342/commits/7b59afa0a2ec42f4febc02fddc985dc9b0d69c35 |
| https://groups.google.com/g/v8-dev/c/nsbshwlmP3c | https://groups.google.com/g/v8-dev/c/nsbshwlmP3c |
| https://chromium-review.googlesource.com/c/v8/v8/+/4823404 | https://chromium-review.googlesource.com/c/v8/v8/+/4823404 |
| v8/v8@1a3ecc2 | https://github.com/v8/v8/commit/1a3ecc2483b2dba6ab9f7e9f8f4b60dbfef504b7 |
| nodejs#49639 | https://github.com/nodejs/node/pull/49639 |
| https://github.com/Bo98 |
| Bo98 | https://github.com/Bo98 |
| force-pushed | https://github.com/nodejs/node/compare/42c8a36842647925fe78df058eaca10ede0a0b6e..7b59afa0a2ec42f4febc02fddc985dc9b0d69c35 |
| 42c8a36 | https://github.com/nodejs/node/commit/42c8a36842647925fe78df058eaca10ede0a0b6e |
| 7b59afa | https://github.com/nodejs/node/commit/7b59afa0a2ec42f4febc02fddc985dc9b0d69c35 |
|
Compare
| https://github.com/nodejs/node/compare/42c8a36842647925fe78df058eaca10ede0a0b6e..7b59afa0a2ec42f4febc02fddc985dc9b0d69c35 |
| June 5, 2025 07:07 | https://github.com/nodejs/node/pull/58342#event-17994652260 |
| https://github.com/marco-ippolito |
| marco-ippolito | https://github.com/marco-ippolito |
|
Jun 5, 2025
| https://github.com/nodejs/node/pull/58342#pullrequestreview-2899323657 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/58342/files/7b59afa0a2ec42f4febc02fddc985dc9b0d69c35 |
| https://github.com/marco-ippolito |
| marco-ippolito | https://github.com/marco-ippolito |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Jun 5, 2025 | https://github.com/nodejs/node/pull/58342#event-17995812762 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Jun 5, 2025 | https://github.com/nodejs/node/pull/58342#event-17995886671 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jun 5, 2025 | https://github.com/nodejs/node/pull/58342#issuecomment-2943226009 |
| https://ci.nodejs.org/job/node-test-pull-request/67277/ | https://ci.nodejs.org/job/node-test-pull-request/67277/ |
| Please reload this page | https://github.com/nodejs/node/pull/58342 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jun 5, 2025 | https://github.com/nodejs/node/pull/58342#issuecomment-2943227502 |
| https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6596/ | https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6596/ |
| Please reload this page | https://github.com/nodejs/node/pull/58342 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jun 5, 2025 | https://github.com/nodejs/node/pull/58342#issuecomment-2943233391 |
| https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6596/ | https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6596/ |
| Please reload this page | https://github.com/nodejs/node/pull/58342 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jun 5, 2025 | https://github.com/nodejs/node/pull/58342#issuecomment-2943238246 |
| https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6596/ | https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6596/ |
| Please reload this page | https://github.com/nodejs/node/pull/58342 |
| marco-ippolito | https://github.com/marco-ippolito |
|
Jun 5, 2025
| https://github.com/nodejs/node/pull/58342#ref-commit-450ae79 |
|
| https://github.com/zmodem |
|
| https://github.com/marco-ippolito |
| deps: V8: cherry-pick third_party/zlib@646b7f569718 | https://github.com/nodejs/node/commit/450ae798a6c3f3dda0aa726e0c7cfb9d1ae4690b |
| 450ae79 | https://github.com/nodejs/node/commit/450ae798a6c3f3dda0aa726e0c7cfb9d1ae4690b |
| madler/zlib@4bd9a71 | https://github.com/madler/zlib/commit/4bd9a71f3539b5ce47f0c67ab5e01f3196dc8ef9 |
| https://chromium-review.googlesource.com/c/chromium/src/+/5237020 | https://chromium-review.googlesource.com/c/chromium/src/+/5237020 |
| https://chromium.googlesource.com/chromium/src/third_party/zlib/+/646b7f569718921d7d4b5b8e22572ff6c76f2596 | https://chromium.googlesource.com/chromium/src/third_party/zlib/+/646b7f569718921d7d4b5b8e22572ff6c76f2596 |
| #58342 | https://github.com/nodejs/node/pull/58342 |
| marco-ippolito | https://github.com/marco-ippolito |
|
Jun 5, 2025
| https://github.com/nodejs/node/pull/58342#ref-commit-affe75d |
|
| https://github.com/caseq |
|
| https://github.com/marco-ippolito |
| deps: V8: cherry-pick 182d9c05e78b | https://github.com/nodejs/node/commit/affe75d576710d4479ef2db230cc887b31261989 |
| affe75d | https://github.com/nodejs/node/commit/affe75d576710d4479ef2db230cc887b31261989 |
| https://chromium-review.googlesource.com/c/v8/v8/+/4789966 | https://chromium-review.googlesource.com/c/v8/v8/+/4789966 |
| v8/v8@182d9c0 | https://github.com/v8/v8/commit/182d9c05e78b1ddb1cb8242cd3628a7855a0336f |
| #58342 | https://github.com/nodejs/node/pull/58342 |
| marco-ippolito | https://github.com/marco-ippolito |
|
Jun 5, 2025
| https://github.com/nodejs/node/pull/58342#ref-commit-7b14289 |
|
| https://github.com/targos |
|
| https://github.com/marco-ippolito |
| deps: V8: cherry-pick 1a3ecc2483b2 | https://github.com/nodejs/node/commit/7b142892c3ed768f0360fa10c99094da14f4abe4 |
| 7b14289 | https://github.com/nodejs/node/commit/7b142892c3ed768f0360fa10c99094da14f4abe4 |
| https://groups.google.com/g/v8-dev/c/nsbshwlmP3c | https://groups.google.com/g/v8-dev/c/nsbshwlmP3c |
| https://chromium-review.googlesource.com/c/v8/v8/+/4823404 | https://chromium-review.googlesource.com/c/v8/v8/+/4823404 |
| v8/v8@1a3ecc2 | https://github.com/v8/v8/commit/1a3ecc2483b2dba6ab9f7e9f8f4b60dbfef504b7 |
| #49639 | https://github.com/nodejs/node/pull/49639 |
| #58342 | https://github.com/nodejs/node/pull/58342 |
| https://github.com/marco-ippolito |
| marco-ippolito | https://github.com/marco-ippolito |
| Jun 5, 2025 | https://github.com/nodejs/node/pull/58342#issuecomment-2943849521 |
| ff210ca...7b14289 | https://github.com/nodejs/node/compare/ff210ca7f3f96743f9c6948a61a43be66dba4282...7b142892c3ed768f0360fa10c99094da14f4abe4 |
| Please reload this page | https://github.com/nodejs/node/pull/58342 |
| https://github.com/marco-ippolito |
| marco-ippolito | https://github.com/marco-ippolito |
| Jun 5, 2025 | https://github.com/nodejs/node/pull/58342#event-17999161955 |
| marco-ippolito | https://github.com/marco-ippolito |
|
Jun 5, 2025
| https://github.com/nodejs/node/pull/58342#ref-commit-bb74019 |
|
| https://github.com/zmodem |
|
| https://github.com/marco-ippolito |
| deps: V8: cherry-pick third_party/zlib@646b7f569718 | https://github.com/nodejs/node/commit/bb74019d6217dc5f1e0f03f60bb567f467658078 |
| bb74019 | https://github.com/nodejs/node/commit/bb74019d6217dc5f1e0f03f60bb567f467658078 |
| madler/zlib@4bd9a71 | https://github.com/madler/zlib/commit/4bd9a71f3539b5ce47f0c67ab5e01f3196dc8ef9 |
| https://chromium-review.googlesource.com/c/chromium/src/+/5237020 | https://chromium-review.googlesource.com/c/chromium/src/+/5237020 |
| https://chromium.googlesource.com/chromium/src/third_party/zlib/+/646b7f569718921d7d4b5b8e22572ff6c76f2596 | https://chromium.googlesource.com/chromium/src/third_party/zlib/+/646b7f569718921d7d4b5b8e22572ff6c76f2596 |
| #58342 | https://github.com/nodejs/node/pull/58342 |
| marco-ippolito | https://github.com/marco-ippolito |
|
Jun 5, 2025
| https://github.com/nodejs/node/pull/58342#ref-commit-e6b1ad3 |
|
| https://github.com/caseq |
|
| https://github.com/marco-ippolito |
| deps: V8: cherry-pick 182d9c05e78b | https://github.com/nodejs/node/commit/e6b1ad3da27445b9249a97eb9858b887e685cc8a |
| e6b1ad3 | https://github.com/nodejs/node/commit/e6b1ad3da27445b9249a97eb9858b887e685cc8a |
| https://chromium-review.googlesource.com/c/v8/v8/+/4789966 | https://chromium-review.googlesource.com/c/v8/v8/+/4789966 |
| v8/v8@182d9c0 | https://github.com/v8/v8/commit/182d9c05e78b1ddb1cb8242cd3628a7855a0336f |
| #58342 | https://github.com/nodejs/node/pull/58342 |
| marco-ippolito | https://github.com/marco-ippolito |
|
Jun 5, 2025
| https://github.com/nodejs/node/pull/58342#ref-commit-995f1ba |
|
| https://github.com/targos |
|
| https://github.com/marco-ippolito |
| deps: V8: cherry-pick 1a3ecc2483b2 | https://github.com/nodejs/node/commit/995f1ba43d4c0ce281c15cf3f7993a1369773897 |
| 995f1ba | https://github.com/nodejs/node/commit/995f1ba43d4c0ce281c15cf3f7993a1369773897 |
| https://groups.google.com/g/v8-dev/c/nsbshwlmP3c | https://groups.google.com/g/v8-dev/c/nsbshwlmP3c |
| https://chromium-review.googlesource.com/c/v8/v8/+/4823404 | https://chromium-review.googlesource.com/c/v8/v8/+/4823404 |
| v8/v8@1a3ecc2 | https://github.com/v8/v8/commit/1a3ecc2483b2dba6ab9f7e9f8f4b60dbfef504b7 |
| #49639 | https://github.com/nodejs/node/pull/49639 |
| #58342 | https://github.com/nodejs/node/pull/58342 |
| marco-ippolito | https://github.com/marco-ippolito |
|
Jun 5, 2025
| https://github.com/nodejs/node/pull/58342#ref-commit-f96762c |
|
| https://github.com/zmodem |
|
| https://github.com/marco-ippolito |
| deps: V8: cherry-pick third_party/zlib@646b7f569718 | https://github.com/nodejs/node/commit/f96762cfb1b87e5e34bda5b14467581d01ecf0f2 |
| f96762c | https://github.com/nodejs/node/commit/f96762cfb1b87e5e34bda5b14467581d01ecf0f2 |
| madler/zlib@4bd9a71 | https://github.com/madler/zlib/commit/4bd9a71f3539b5ce47f0c67ab5e01f3196dc8ef9 |
| https://chromium-review.googlesource.com/c/chromium/src/+/5237020 | https://chromium-review.googlesource.com/c/chromium/src/+/5237020 |
| https://chromium.googlesource.com/chromium/src/third_party/zlib/+/646b7f569718921d7d4b5b8e22572ff6c76f2596 | https://chromium.googlesource.com/chromium/src/third_party/zlib/+/646b7f569718921d7d4b5b8e22572ff6c76f2596 |
| #58342 | https://github.com/nodejs/node/pull/58342 |
| marco-ippolito | https://github.com/marco-ippolito |
|
Jun 5, 2025
| https://github.com/nodejs/node/pull/58342#ref-commit-2060738 |
|
| https://github.com/caseq |
|
| https://github.com/marco-ippolito |
| deps: V8: cherry-pick 182d9c05e78b | https://github.com/nodejs/node/commit/2060738e193a30dac9a4d87feddc569920366d63 |
| 2060738 | https://github.com/nodejs/node/commit/2060738e193a30dac9a4d87feddc569920366d63 |
| https://chromium-review.googlesource.com/c/v8/v8/+/4789966 | https://chromium-review.googlesource.com/c/v8/v8/+/4789966 |
| v8/v8@182d9c0 | https://github.com/v8/v8/commit/182d9c05e78b1ddb1cb8242cd3628a7855a0336f |
| #58342 | https://github.com/nodejs/node/pull/58342 |
| marco-ippolito | https://github.com/marco-ippolito |
|
Jun 5, 2025
| https://github.com/nodejs/node/pull/58342#ref-commit-b1aca24 |
|
| https://github.com/targos |
|
| https://github.com/marco-ippolito |
| deps: V8: cherry-pick 1a3ecc2483b2 | https://github.com/nodejs/node/commit/b1aca2455be679e4cb6e369638ce3daf51b94003 |
| b1aca24 | https://github.com/nodejs/node/commit/b1aca2455be679e4cb6e369638ce3daf51b94003 |
| https://groups.google.com/g/v8-dev/c/nsbshwlmP3c | https://groups.google.com/g/v8-dev/c/nsbshwlmP3c |
| https://chromium-review.googlesource.com/c/v8/v8/+/4823404 | https://chromium-review.googlesource.com/c/v8/v8/+/4823404 |
| v8/v8@1a3ecc2 | https://github.com/v8/v8/commit/1a3ecc2483b2dba6ab9f7e9f8f4b60dbfef504b7 |
| #49639 | https://github.com/nodejs/node/pull/49639 |
| #58342 | https://github.com/nodejs/node/pull/58342 |
| https://github.com/marco-ippolito |
| marco-ippolito | https://github.com/marco-ippolito |
|
Jun 5, 2025
| https://github.com/nodejs/node/pull/58342#ref-pullrequest-3120973479 |
|
v20.19.3 proposal
#58588
| https://github.com/nodejs/node/pull/58588 |
| marco-ippolito | https://github.com/marco-ippolito |
|
Jun 10, 2025
| https://github.com/nodejs/node/pull/58342#ref-commit-acd6efa |
|
| https://github.com/zmodem |
|
| https://github.com/marco-ippolito |
| deps: V8: cherry-pick third_party/zlib@646b7f569718 | https://github.com/nodejs/node/commit/acd6efaffc53a3d08116d9b106df0b5bd922ec1c |
| acd6efa | https://github.com/nodejs/node/commit/acd6efaffc53a3d08116d9b106df0b5bd922ec1c |
| madler/zlib@4bd9a71 | https://github.com/madler/zlib/commit/4bd9a71f3539b5ce47f0c67ab5e01f3196dc8ef9 |
| https://chromium-review.googlesource.com/c/chromium/src/+/5237020 | https://chromium-review.googlesource.com/c/chromium/src/+/5237020 |
| https://chromium.googlesource.com/chromium/src/third_party/zlib/+/646b7f569718921d7d4b5b8e22572ff6c76f2596 | https://chromium.googlesource.com/chromium/src/third_party/zlib/+/646b7f569718921d7d4b5b8e22572ff6c76f2596 |
| #58342 | https://github.com/nodejs/node/pull/58342 |
| marco-ippolito | https://github.com/marco-ippolito |
|
Jun 10, 2025
| https://github.com/nodejs/node/pull/58342#ref-commit-0f24eb7 |
|
| https://github.com/caseq |
|
| https://github.com/marco-ippolito |
| deps: V8: cherry-pick 182d9c05e78b | https://github.com/nodejs/node/commit/0f24eb77225210b9fd4530b73a3e5109f3299b0e |
| 0f24eb7 | https://github.com/nodejs/node/commit/0f24eb77225210b9fd4530b73a3e5109f3299b0e |
| https://chromium-review.googlesource.com/c/v8/v8/+/4789966 | https://chromium-review.googlesource.com/c/v8/v8/+/4789966 |
| v8/v8@182d9c0 | https://github.com/v8/v8/commit/182d9c05e78b1ddb1cb8242cd3628a7855a0336f |
| #58342 | https://github.com/nodejs/node/pull/58342 |
| marco-ippolito | https://github.com/marco-ippolito |
|
Jun 10, 2025
| https://github.com/nodejs/node/pull/58342#ref-commit-3b97c54 |
|
| https://github.com/targos |
|
| https://github.com/marco-ippolito |
| deps: V8: cherry-pick 1a3ecc2483b2 | https://github.com/nodejs/node/commit/3b97c549cdf19509315e36a4ab90382105ae81c1 |
| 3b97c54 | https://github.com/nodejs/node/commit/3b97c549cdf19509315e36a4ab90382105ae81c1 |
| https://groups.google.com/g/v8-dev/c/nsbshwlmP3c | https://groups.google.com/g/v8-dev/c/nsbshwlmP3c |
| https://chromium-review.googlesource.com/c/v8/v8/+/4823404 | https://chromium-review.googlesource.com/c/v8/v8/+/4823404 |
| v8/v8@1a3ecc2 | https://github.com/v8/v8/commit/1a3ecc2483b2dba6ab9f7e9f8f4b60dbfef504b7 |
| #49639 | https://github.com/nodejs/node/pull/49639 |
| #58342 | https://github.com/nodejs/node/pull/58342 |
| marco-ippolito | https://github.com/marco-ippolito |
|
Jun 11, 2025
| https://github.com/nodejs/node/pull/58342#ref-commit-447481e |
|
| https://github.com/zmodem |
|
| https://github.com/marco-ippolito |
| deps: V8: cherry-pick third_party/zlib@646b7f569718 | https://github.com/nodejs/node/commit/447481e8294680f3e9de279567e63c1a94ac4f16 |
| 447481e | https://github.com/nodejs/node/commit/447481e8294680f3e9de279567e63c1a94ac4f16 |
| madler/zlib@4bd9a71 | https://github.com/madler/zlib/commit/4bd9a71f3539b5ce47f0c67ab5e01f3196dc8ef9 |
| https://chromium-review.googlesource.com/c/chromium/src/+/5237020 | https://chromium-review.googlesource.com/c/chromium/src/+/5237020 |
| https://chromium.googlesource.com/chromium/src/third_party/zlib/+/646b7f569718921d7d4b5b8e22572ff6c76f2596 | https://chromium.googlesource.com/chromium/src/third_party/zlib/+/646b7f569718921d7d4b5b8e22572ff6c76f2596 |
| #58342 | https://github.com/nodejs/node/pull/58342 |
| marco-ippolito | https://github.com/marco-ippolito |
|
Jun 11, 2025
| https://github.com/nodejs/node/pull/58342#ref-commit-fd56652 |
|
| https://github.com/caseq |
|
| https://github.com/marco-ippolito |
| deps: V8: cherry-pick 182d9c05e78b | https://github.com/nodejs/node/commit/fd566524257514f88a3db4bc6218f47c1c813ed9 |
| fd56652 | https://github.com/nodejs/node/commit/fd566524257514f88a3db4bc6218f47c1c813ed9 |
| https://chromium-review.googlesource.com/c/v8/v8/+/4789966 | https://chromium-review.googlesource.com/c/v8/v8/+/4789966 |
| v8/v8@182d9c0 | https://github.com/v8/v8/commit/182d9c05e78b1ddb1cb8242cd3628a7855a0336f |
| #58342 | https://github.com/nodejs/node/pull/58342 |
| marco-ippolito | https://github.com/marco-ippolito |
|
Jun 11, 2025
| https://github.com/nodejs/node/pull/58342#ref-commit-d09008a |
|
| https://github.com/targos |
|
| https://github.com/marco-ippolito |
| deps: V8: cherry-pick 1a3ecc2483b2 | https://github.com/nodejs/node/commit/d09008add30ddd3667c0efc9d63819be98c30413 |
| d09008a | https://github.com/nodejs/node/commit/d09008add30ddd3667c0efc9d63819be98c30413 |
| https://groups.google.com/g/v8-dev/c/nsbshwlmP3c | https://groups.google.com/g/v8-dev/c/nsbshwlmP3c |
| https://chromium-review.googlesource.com/c/v8/v8/+/4823404 | https://chromium-review.googlesource.com/c/v8/v8/+/4823404 |
| v8/v8@1a3ecc2 | https://github.com/v8/v8/commit/1a3ecc2483b2dba6ab9f7e9f8f4b60dbfef504b7 |
| #49639 | https://github.com/nodejs/node/pull/49639 |
| #58342 | https://github.com/nodejs/node/pull/58342 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F58342 |
|
| https://github.com/marco-ippolito |
|
marco-ippolito
| https://github.com/marco-ippolito |
|
| https://github.com/nodejs/node/pull/58342/files/7b59afa0a2ec42f4febc02fddc985dc9b0d69c35 |
|
| https://github.com/mertcanaltin |
|
mertcanaltin
| https://github.com/mertcanaltin |
|
| https://github.com/nodejs/node/pull/58342/files/7b59afa0a2ec42f4febc02fddc985dc9b0d69c35 |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
v8 engine
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22v8%20engine%22 |
|
v20.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av20.x |
| Please reload this page | https://github.com/nodejs/node/pull/58342 |
|
| https://github.com/Bo98 |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/marco-ippolito |
|
| https://github.com/mertcanaltin |
|
| https://github.com/zmodem |
|
| https://github.com/caseq |
|
| https://github.com/targos |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |