René's URL Explorer Experiment


Title: src: remove Environment::GetCurrent(isolate) by anonrig · Pull Request #58311 · nodejs/node · GitHub

Open Graph Title: src: remove Environment::GetCurrent(isolate) by anonrig · Pull Request #58311 · nodejs/node

X Title: src: remove Environment::GetCurrent(isolate) by anonrig · Pull Request #58311 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Removes Environment::GetCurrent(isolate) calls cc @nodejs/cpp-reviewers

X Description: Removes Environment::GetCurrent(isolate) calls cc @nodejs/cpp-reviewers

Opengraph URL: https://github.com/nodejs/node/pull/58311

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:9ca2da75-9e52-0984-1941-23bd618397d7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB3B4:3EED53:8A38AF:B8894A:6AED2B4F
html-safe-nonceb3a386645312187180a6d07cbfbe761866b06748267cf9d8c1afffd010eb051a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCM0I0OjNFRUQ1Mzo4QTM4QUY6Qjg4OTRBOjZBRUQyQjRGIiwidmlzaXRvcl9pZCI6IjEwMzU5NDU1MDM3MDM3NzE5ODMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac0a5c67f6931a98ce4c541abb4b53502796f84141f4ff120834d4df0c7dfce00c
hovercard-subject-tagpull_request:2516730685
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/58311/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f44693b0e42c15b7795f546083d8ce06c79d5602dffc30e5d01168ebf518b7f0/nodejs/node/pull/58311
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f44693b0e42c15b7795f546083d8ce06c79d5602dffc30e5d01168ebf518b7f0/nodejs/node/pull/58311
og:image:altRemoves Environment::GetCurrent(isolate) calls cc @nodejs/cpp-reviewers
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameanonrig
hostnamegithub.com
expected-hostnamegithub.com
None9d95365dda0576efe9b71f45807595e396bd0ca9286fba5367a05048e6ddf8f2
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release98b41fa4b5635ceb45a4c54320fced73817ff290
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/58311#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F58311
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F58311
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/58311
Reloadhttps://github.com/nodejs/node/pull/58311
Reloadhttps://github.com/nodejs/node/pull/58311
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues656 (656)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
anonrighttps://github.com/anonrig
nodejs:mainhttps://github.com/nodejs/node/tree/main
anonrig:yagiz/refactor-environment-getcurrenthttps://github.com/anonrig/node/tree/yagiz/refactor-environment-getcurrent
Conversationhttps://github.com/nodejs/node/pull/58311
Commits1 (1)https://github.com/nodejs/node/pull/58311/commits
Checkshttps://github.com/nodejs/node/pull/58311/checks
Files changedhttps://github.com/nodejs/node/pull/58311/files
src: remove Environment::GetCurrent(isolate)https://github.com/nodejs/node/pull/58311#top
anonrighttps://github.com/anonrig
nodejs:mainhttps://github.com/nodejs/node/tree/main
anonrig:yagiz/refactor-environment-getcurrenthttps://github.com/anonrig/node/tree/yagiz/refactor-environment-getcurrent
https://github.com/anonrig
anonrighttps://github.com/anonrig
May 13, 2025https://github.com/nodejs/node/pull/58311#issue-3060186240
Please reload this pagehttps://github.com/nodejs/node/pull/58311
https://github.com/anonrig
anonrighttps://github.com/anonrig
addaleaxhttps://github.com/addaleax
jasnellhttps://github.com/jasnell
joyeecheunghttps://github.com/joyeecheung
May 13, 2025 13:58https://github.com/nodejs/node/pull/58311#event-17636271162
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 13, 2025https://github.com/nodejs/node/pull/58311#issuecomment-2876640519
Please reload this pagehttps://github.com/nodejs/node/pull/58311
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
May 13, 2025https://github.com/nodejs/node/pull/58311#event-17636274664
https://github.com/anonrig
anonrighttps://github.com/anonrig
force-pushedhttps://github.com/nodejs/node/compare/3f4dfa87997dbd903707fd3e4283139ef0cab8db..9a1be50f8d5957652409aed90397fb1d3967594f
3f4dfa8https://github.com/nodejs/node/commit/3f4dfa87997dbd903707fd3e4283139ef0cab8db
9a1be50https://github.com/nodejs/node/commit/9a1be50f8d5957652409aed90397fb1d3967594f
Compare https://github.com/nodejs/node/compare/3f4dfa87997dbd903707fd3e4283139ef0cab8db..9a1be50f8d5957652409aed90397fb1d3967594f
May 13, 2025 13:58https://github.com/nodejs/node/pull/58311#event-17636287177
https://github.com/legendecas
legendecashttps://github.com/legendecas
May 13, 2025 https://github.com/nodejs/node/pull/58311#pullrequestreview-2837021814
View reviewed changes https://github.com/nodejs/node/pull/58311/files
src/api/callback.cchttps://github.com/nodejs/node/pull/58311/files#diff-6f5066579791abb5154463a462bf370248ebb2bc501b85960caf8d4d8645526d
Please reload this pagehttps://github.com/nodejs/node/pull/58311
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
May 13, 2025https://github.com/nodejs/node/pull/58311#issuecomment-2876869020
Please reload this pagehttps://github.com/nodejs/node/pull/58311
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/58311?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
2281a04https://app.codecov.io/gh/nodejs/node/commit/2281a04e5e38f4dda8d95adc40fe69f02605e333?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
ea46cf2https://app.codecov.io/gh/nodejs/node/commit/ea46cf26591f07da03a30fd9cce245b6dc290aef?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/58311?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
src/api/hooks.cchttps://app.codecov.io/gh/nodejs/node/pull/58311?src=pr&el=tree&filepath=src%2Fapi%2Fhooks.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL2FwaS9ob29rcy5jYw==
2 Missing ⚠️ https://app.codecov.io/gh/nodejs/node/pull/58311?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
src/api/callback.cchttps://app.codecov.io/gh/nodejs/node/pull/58311?src=pr&el=tree&filepath=src%2Fapi%2Fcallback.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL2FwaS9jYWxsYmFjay5jYw==
0 Missing and 1 partial ⚠️ https://app.codecov.io/gh/nodejs/node/pull/58311?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
src/api/environment.cchttps://app.codecov.io/gh/nodejs/node/pull/58311?src=pr&el=tree&filepath=src%2Fapi%2Fenvironment.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL2FwaS9lbnZpcm9ubWVudC5jYw==
0 Missing and 1 partial ⚠️ https://app.codecov.io/gh/nodejs/node/pull/58311?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
src/node_buffer.cchttps://app.codecov.io/gh/nodejs/node/pull/58311?src=pr&el=tree&filepath=src%2Fnode_buffer.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfYnVmZmVyLmNj
1 Missing ⚠️ https://app.codecov.io/gh/nodejs/node/pull/58311?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/58311?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
src/api/async_resource.cchttps://app.codecov.io/gh/nodejs/node/pull/58311?src=pr&el=tree&filepath=src%2Fapi%2Fasync_resource.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL2FwaS9hc3luY19yZXNvdXJjZS5jYw==
src/api/exceptions.cchttps://app.codecov.io/gh/nodejs/node/pull/58311?src=pr&el=tree&filepath=src%2Fapi%2Fexceptions.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL2FwaS9leGNlcHRpb25zLmNj
src/async_context_frame.cchttps://app.codecov.io/gh/nodejs/node/pull/58311?src=pr&el=tree&filepath=src%2Fasync_context_frame.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL2FzeW5jX2NvbnRleHRfZnJhbWUuY2M=
src/env-inl.hhttps://app.codecov.io/gh/nodejs/node/pull/58311?src=pr&el=tree&filepath=src%2Fenv-inl.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL2Vudi1pbmwuaA==
src/env.hhttps://app.codecov.io/gh/nodejs/node/pull/58311?src=pr&el=tree&filepath=src%2Fenv.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL2Vudi5o
src/node_errors.cchttps://app.codecov.io/gh/nodejs/node/pull/58311?src=pr&el=tree&filepath=src%2Fnode_errors.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfZXJyb3JzLmNj
src/node_platform.cchttps://app.codecov.io/gh/nodejs/node/pull/58311?src=pr&el=tree&filepath=src%2Fnode_platform.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfcGxhdGZvcm0uY2M=
src/node_report.cchttps://app.codecov.io/gh/nodejs/node/pull/58311?src=pr&el=tree&filepath=src%2Fnode_report.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfcmVwb3J0LmNj
src/node_sqlite.cchttps://app.codecov.io/gh/nodejs/node/pull/58311?src=pr&el=tree&filepath=src%2Fnode_sqlite.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfc3FsaXRlLmNj
src/node_task_queue.cchttps://app.codecov.io/gh/nodejs/node/pull/58311?src=pr&el=tree&filepath=src%2Fnode_task_queue.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfdGFza19xdWV1ZS5jYw==
5 morehttps://app.codecov.io/gh/nodejs/node/pull/58311?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
95 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/58311/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/58311
https://github.com/anonrig
src: remove Environment::GetCurrent(isolate)https://github.com/nodejs/node/pull/58311/commits/ea46cf26591f07da03a30fd9cce245b6dc290aef
ea46cf2https://github.com/nodejs/node/pull/58311/commits/ea46cf26591f07da03a30fd9cce245b6dc290aef
https://github.com/anonrig
anonrighttps://github.com/anonrig
force-pushedhttps://github.com/nodejs/node/compare/9a1be50f8d5957652409aed90397fb1d3967594f..ea46cf26591f07da03a30fd9cce245b6dc290aef
9a1be50https://github.com/nodejs/node/commit/9a1be50f8d5957652409aed90397fb1d3967594f
ea46cf2https://github.com/nodejs/node/commit/ea46cf26591f07da03a30fd9cce245b6dc290aef
Compare https://github.com/nodejs/node/compare/9a1be50f8d5957652409aed90397fb1d3967594f..ea46cf26591f07da03a30fd9cce245b6dc290aef
May 13, 2025 15:34https://github.com/nodejs/node/pull/58311#event-17638121940
https://github.com/jasnell
jasnellhttps://github.com/jasnell
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
May 17, 2025https://github.com/nodejs/node/pull/58311#event-17700638383
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 17, 2025 https://github.com/nodejs/node/pull/58311#pullrequestreview-2848450589
View reviewed changes https://github.com/nodejs/node/pull/58311/files/ea46cf26591f07da03a30fd9cce245b6dc290aef
jasnellhttps://github.com/jasnell
https://github.com/nodejs/node/pull/58311#pullrequestreview-2848450589
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/58311
https://github.com/targos
targoshttps://github.com/targos
May 19, 2025https://github.com/nodejs/node/pull/58311#issuecomment-2889637545
@jasnellhttps://github.com/jasnell
node/src/node.hhttps://github.com/nodejs/node/blob/20c4b80ffca2738046b21f5792e239ccfa8c9321/src/node.h#L231
20c4b80https://github.com/nodejs/node/commit/20c4b80ffca2738046b21f5792e239ccfa8c9321
Please reload this pagehttps://github.com/nodejs/node/pull/58311
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 19, 2025https://github.com/nodejs/node/pull/58311#issuecomment-2889647698
Please reload this pagehttps://github.com/nodejs/node/pull/58311
https://github.com/targos
targoshttps://github.com/targos
May 19, 2025https://github.com/nodejs/node/pull/58311#issuecomment-2890210660
Please reload this pagehttps://github.com/nodejs/node/pull/58311
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 19, 2025https://github.com/nodejs/node/pull/58311#issuecomment-2891316740
https://github.com/search?type=code&q=%22node%3A%3AEnvironment%3A%3AGetCurrent%28%22+language%3AC%2B%2B&l=C%2B%2Bhttps://github.com/search?type=code&q=%22node%3A%3AEnvironment%3A%3AGetCurrent%28%22+language%3AC%2B%2B&l=C%2B%2B
Please reload this pagehttps://github.com/nodejs/node/pull/58311
https://github.com/anonrig
anonrighttps://github.com/anonrig
May 19, 2025https://github.com/nodejs/node/pull/58311#issuecomment-2891339015
Please reload this pagehttps://github.com/nodejs/node/pull/58311
https://github.com/search?type=code&q=%22node%3A%3AEnvironment%3A%3AGetCurrent%28%22+language%3AC%2B%2B&l=C%2B%2Bhttps://github.com/search?type=code&q=%22node%3A%3AEnvironment%3A%3AGetCurrent%28%22+language%3AC%2B%2B&l=C%2B%2B
Please reload this pagehttps://github.com/nodejs/node/pull/58311
https://github.com/targos
targoshttps://github.com/targos
May 19, 2025https://github.com/nodejs/node/pull/58311#issuecomment-2891340693
Please reload this pagehttps://github.com/nodejs/node/pull/58311
https://github.com/jasnell
jasnellhttps://github.com/jasnell
May 19, 2025https://github.com/nodejs/node/pull/58311#issuecomment-2891386464
Please reload this pagehttps://github.com/nodejs/node/pull/58311
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
May 19, 2025https://github.com/nodejs/node/pull/58311#issuecomment-2891728641
Please reload this pagehttps://github.com/nodejs/node/pull/58311
Please reload this pagehttps://github.com/nodejs/node/pull/58311
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
May 19, 2025 https://github.com/nodejs/node/pull/58311#pullrequestreview-2851539135
View reviewed changes https://github.com/nodejs/node/pull/58311/files/ea46cf26591f07da03a30fd9cce245b6dc290aef
src/api/async_resource.cchttps://github.com/nodejs/node/pull/58311/files/ea46cf26591f07da03a30fd9cce245b6dc290aef#diff-856a7984ddc2de4fef88030ee1ee52b4033cfe931c3c367881c50e851d938e7c
joyeecheunghttps://github.com/joyeecheung
May 19, 2025https://github.com/nodejs/node/pull/58311#discussion_r2096197150
Please reload this pagehttps://github.com/nodejs/node/pull/58311
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/58311
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jul 28, 2026https://github.com/nodejs/node/pull/58311#issuecomment-5098365338
Please reload this pagehttps://github.com/nodejs/node/pull/58311
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
stale https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astale
Jul 28, 2026https://github.com/nodejs/node/pull/58311#event-28569556809
https://github.com/avivkeller
avivkellerhttps://github.com/avivkeller
Aug 9, 2026https://github.com/nodejs/node/pull/58311#event-29171028717
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F58311
https://github.com/joyeecheung
joyeecheung https://github.com/joyeecheung
https://github.com/nodejs/node/pull/58311/files/ea46cf26591f07da03a30fd9cce245b6dc290aef
https://github.com/legendecas
legendecas https://github.com/legendecas
https://github.com/nodejs/node/pull/58311/files/9a1be50f8d5957652409aed90397fb1d3967594f
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/58311/files/ea46cf26591f07da03a30fd9cce245b6dc290aef
https://github.com/addaleax
addaleax https://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/58311
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
stale https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astale
Please reload this pagehttps://github.com/nodejs/node/pull/58311
https://github.com/anonrig
https://github.com/nodejs-github-bot
https://github.com/targos
https://github.com/jasnell
https://github.com/joyeecheung
https://github.com/legendecas
https://github.com/avivkeller
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.