René's URL Explorer Experiment


Title: Revert "watch: fix watch args not being properly filtered" by joyeecheung · Pull Request #58190 · nodejs/node · GitHub

Open Graph Title: Revert "watch: fix watch args not being properly filtered" by joyeecheung · Pull Request #58190 · nodejs/node

X Title: Revert "watch: fix watch args not being properly filtered" by joyeecheung · Pull Request #58190 · nodejs/node

Description: #57936 landed despite failing the test cases it added to test-watch-mode.mjs https://ci.nodejs.org/job/node-test-pull-request/66587/ - likely because the the test file has already been being marked as flaky so failures in it were ignored. This was one of the reason why we should refrain from appending test cases to existing files as suggested in https://github.com/nodejs/node/blob/main/doc/contributing/writing-tests.md - maybe we should make that mandatory for any test files that are already marked as flaky. Reverting this because this has been making the Jenkins very orange and has been failing several GitHub actions (not sure why but they are not ignoring flakes), and should not have landed in the first place when it already failed the tests it added.

Open Graph Description: #57936 landed despite failing the test cases it added to test-watch-mode.mjs https://ci.nodejs.org/job/node-test-pull-request/66587/ - likely because the the test file has already been being marked...

X Description: #57936 landed despite failing the test cases it added to test-watch-mode.mjs https://ci.nodejs.org/job/node-test-pull-request/66587/ - likely because the the test file has already been being marked...

Opengraph URL: https://github.com/nodejs/node/pull/58190

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/commits/:range(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:f52eeb39-0a14-76ac-84ec-bb5307a4ad70
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAE72:3449FA:E9963A:145F9D7:69970E21
html-safe-noncee080fabbfaf136f5f1fd4716d93c666ff0d2b90d45451034e008cbab90d160f3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRTcyOjM0NDlGQTpFOTk2M0E6MTQ1RjlENzo2OTk3MEUyMSIsInZpc2l0b3JfaWQiOiI0NDAwOTgyNTk1NDY4NzI1NzkzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacd8b7c451356ed79bdcfde754bac4dde66042b832ce0f69fcca7220b21afd6e90
hovercard-subject-tagpull_request:2501358901
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/58190/commits/749a9fe773dc2a274ea6e72ffdac7c429c00dab8
twitter:imagehttps://avatars.githubusercontent.com/u/4299420?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4299420?s=400&v=4
og:image:alt#57936 landed despite failing the test cases it added to test-watch-mode.mjs https://ci.nodejs.org/job/node-test-pull-request/66587/ - likely because the the test file has already been being marked...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5513290f8d09a9ed78de519ab8316ed23b2b0ddd5e91d2420df56691d00827e8
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasec063d3d8462b0824204ccee50b071516c46f8681
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/58190/commits/749a9fe773dc2a274ea6e72ffdac7c429c00dab8#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F58190%2Fcommits%2F749a9fe773dc2a274ea6e72ffdac7c429c00dab8
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F58190%2Fcommits%2F749a9fe773dc2a274ea6e72ffdac7c429c00dab8
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/58190/commits/749a9fe773dc2a274ea6e72ffdac7c429c00dab8
Reloadhttps://github.com/nodejs/node/pull/58190/commits/749a9fe773dc2a274ea6e72ffdac7c429c00dab8
Reloadhttps://github.com/nodejs/node/pull/58190/commits/749a9fe773dc2a274ea6e72ffdac7c429c00dab8
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/58190/commits/749a9fe773dc2a274ea6e72ffdac7c429c00dab8
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.8k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.8k https://github.com/nodejs/node/issues
Pull requests 712 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
joyeecheunghttps://github.com/joyeecheung
nodejs:mainhttps://github.com/nodejs/node/tree/main
joyeecheung:revert-watchhttps://github.com/joyeecheung/node/tree/revert-watch
Conversation 6 https://github.com/nodejs/node/pull/58190
Commits 2 https://github.com/nodejs/node/pull/58190/commits
Checks 53 https://github.com/nodejs/node/pull/58190/checks
Files changed https://github.com/nodejs/node/pull/58190/files
Please reload this pagehttps://github.com/nodejs/node/pull/58190/commits/749a9fe773dc2a274ea6e72ffdac7c429c00dab8
Revert "watch: fix watch args not being properly filtered" https://github.com/nodejs/node/pull/58190/commits/749a9fe773dc2a274ea6e72ffdac7c429c00dab8#top
Show all changes 2 commits https://github.com/nodejs/node/pull/58190/files
a6fa7ca Revert "test: fix watch tests not including completion messages" joyeecheung May 6, 2025 https://github.com/nodejs/node/pull/58190/commits/a6fa7caf08f5b025934356562dff6ac6a39566ab
749a9fe Revert "watch: fix watch args not being properly filtered" joyeecheung May 6, 2025 https://github.com/nodejs/node/pull/58190/commits/749a9fe773dc2a274ea6e72ffdac7c429c00dab8
Clear filters https://github.com/nodejs/node/pull/58190/commits/749a9fe773dc2a274ea6e72ffdac7c429c00dab8
Please reload this pagehttps://github.com/nodejs/node/pull/58190/commits/749a9fe773dc2a274ea6e72ffdac7c429c00dab8
Please reload this pagehttps://github.com/nodejs/node/pull/58190/commits/749a9fe773dc2a274ea6e72ffdac7c429c00dab8
watch_mode.js https://github.com/nodejs/node/pull/58190/commits/749a9fe773dc2a274ea6e72ffdac7c429c00dab8#diff-61df471e4c313c778a503ae1a523d4839b71600b410e2c16b2f2d85101dbcda6
test-watch-mode.mjs https://github.com/nodejs/node/pull/58190/commits/749a9fe773dc2a274ea6e72ffdac7c429c00dab8#diff-6abeb493a0b12e140c3e2c56b8cc9877226cd31dfd89dde9b3347964782c421d
Prev https://github.com/nodejs/node/pull/58190/commits/a6fa7caf08f5b025934356562dff6ac6a39566ab
4acb854https://github.com/nodejs/node/commit/4acb85403950320773352ab127bee9fc85818153
Please reload this pagehttps://github.com/nodejs/node/pull/58190/commits/749a9fe773dc2a274ea6e72ffdac7c429c00dab8
https://github.com/joyeecheung
joyeecheunghttps://github.com/nodejs/node/commits?author=joyeecheung
lib/internal/main/watch_mode.jshttps://github.com/nodejs/node/pull/58190/commits/749a9fe773dc2a274ea6e72ffdac7c429c00dab8#diff-61df471e4c313c778a503ae1a523d4839b71600b410e2c16b2f2d85101dbcda6
View file https://github.com/joyeecheung/node/blob/749a9fe773dc2a274ea6e72ffdac7c429c00dab8/lib/internal/main/watch_mode.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/58190/commits/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/58190/commits/749a9fe773dc2a274ea6e72ffdac7c429c00dab8#diff-61df471e4c313c778a503ae1a523d4839b71600b410e2c16b2f2d85101dbcda6
https://github.com/nodejs/node/pull/58190/commits/749a9fe773dc2a274ea6e72ffdac7c429c00dab8#diff-61df471e4c313c778a503ae1a523d4839b71600b410e2c16b2f2d85101dbcda6
test/sequential/test-watch-mode.mjshttps://github.com/nodejs/node/pull/58190/commits/749a9fe773dc2a274ea6e72ffdac7c429c00dab8#diff-6abeb493a0b12e140c3e2c56b8cc9877226cd31dfd89dde9b3347964782c421d
View file https://github.com/joyeecheung/node/blob/749a9fe773dc2a274ea6e72ffdac7c429c00dab8/test/sequential/test-watch-mode.mjs
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/58190/commits/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/58190/commits/749a9fe773dc2a274ea6e72ffdac7c429c00dab8#diff-6abeb493a0b12e140c3e2c56b8cc9877226cd31dfd89dde9b3347964782c421d
Please reload this pagehttps://github.com/nodejs/node/pull/58190/commits/749a9fe773dc2a274ea6e72ffdac7c429c00dab8
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.