René's URL Explorer Experiment


Title: test: fix watch tests not including completion messages by dario-piotrowicz · Pull Request #58183 · nodejs/node · GitHub

Open Graph Title: test: fix watch tests not including completion messages by dario-piotrowicz · Pull Request #58183 · nodejs/node

X Title: test: fix watch tests not including completion messages by dario-piotrowicz · Pull Request #58183 · nodejs/node

Description: Earlier I merged #57936 which was out of sync with main so it didn't include the watch completion messages introduced in #57926 This causes the watch tests to be failing on main, this PR is address...

Open Graph Description: Earlier I merged #57936 which was out of sync with main so it didn't include the watch completion messages introduced in #57926 This causes the watch tests to be failing on main, this PR is add...

X Description: Earlier I merged #57936 which was out of sync with main so it didn't include the watch completion messages introduced in #57926 This causes the watch tests to be failing on main, this PR is...

Opengraph URL: https://github.com/nodejs/node/pull/58183

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:db34869d-ecc1-c7d8-ae04-01cea6378b0a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCF26:2CB3E6:8122C:A71D7:696AF449
html-safe-nonce2f875f21e6c5bb955006852ab5d79c7342cb91215d1fc53c586b004a2be36427
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRjI2OjJDQjNFNjo4MTIyQzpBNzFENzo2OTZBRjQ0OSIsInZpc2l0b3JfaWQiOiIyNzg4MzQ5NzY4ODQyODAyMjQ5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaca39916fa93b037fd733fda86385835721bfc8d48a3e94ff8b29b27b845f01f58
hovercard-subject-tagpull_request:2499260224
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/58183/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8f8cb6865e1b8e7533927b5294b31d29d2b9ead56d0fa0e50f1545e8a27ae33a/nodejs/node/pull/58183
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8f8cb6865e1b8e7533927b5294b31d29d2b9ead56d0fa0e50f1545e8a27ae33a/nodejs/node/pull/58183
og:image:altEarlier I merged #57936 which was out of sync with main so it didn't include the watch completion messages introduced in #57926 This causes the watch tests to be failing on main, this PR is add...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedario-piotrowicz
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/58183#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F58183
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F58183
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/58183
Reloadhttps://github.com/nodejs/node/pull/58183
Reloadhttps://github.com/nodejs/node/pull/58183
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/58183
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 692 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/58183
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/58183#issue-comment-box
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
dario-piotrowicz:dario/fix-broken-watch-testshttps://github.com/dario-piotrowicz/node/tree/dario/fix-broken-watch-tests
test: fix watch tests not including completion messages https://github.com/nodejs/node/pull/58183#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
dario-piotrowicz:dario/fix-broken-watch-testshttps://github.com/dario-piotrowicz/node/tree/dario/fix-broken-watch-tests
Conversation 9 https://github.com/nodejs/node/pull/58183
Commits 1 https://github.com/nodejs/node/pull/58183/commits
Checks 44 https://github.com/nodejs/node/pull/58183/checks
Files changed https://github.com/nodejs/node/pull/58183/files
Please reload this pagehttps://github.com/nodejs/node/pull/58183
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/dario-piotrowicz
dario-piotrowiczhttps://github.com/dario-piotrowicz
May 5, 2025https://github.com/nodejs/node/pull/58183#issue-3040228830
Please reload this pagehttps://github.com/nodejs/node/pull/58183
#57936https://github.com/nodejs/node/pull/57936
#57926https://github.com/nodejs/node/pull/57926
Please reload this pagehttps://github.com/nodejs/node/pull/58183
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
May 5, 2025https://github.com/nodejs/node/pull/58183#event-17522816123
https://github.com/dario-piotrowicz
dario-piotrowiczhttps://github.com/dario-piotrowicz
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
May 5, 2025https://github.com/nodejs/node/pull/58183#event-17522878359
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
May 5, 2025https://github.com/nodejs/node/pull/58183#issuecomment-2851635405
@dario-piotrowiczhttps://github.com/dario-piotrowicz
Please reload this pagehttps://github.com/nodejs/node/pull/58183
https://github.com/dario-piotrowicz
dario-piotrowiczhttps://github.com/dario-piotrowicz
May 5, 2025 https://github.com/nodejs/node/pull/58183#pullrequestreview-2815450387
View reviewed changes https://github.com/nodejs/node/pull/58183/files
test/sequential/test-watch-mode.mjshttps://github.com/nodejs/node/pull/58183/files#diff-6abeb493a0b12e140c3e2c56b8cc9877226cd31dfd89dde9b3347964782c421d
dario-piotrowiczhttps://github.com/dario-piotrowicz
May 5, 2025https://github.com/nodejs/node/pull/58183#discussion_r2073810536
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/58183
https://github.com/anonrig
anonrighttps://github.com/anonrig
May 5, 2025 https://github.com/nodejs/node/pull/58183#pullrequestreview-2815458518
View reviewed changes https://github.com/nodejs/node/pull/58183/files/7c8ec533472b615e4f38091243f7569e6e8c3c4e
https://github.com/dario-piotrowicz
dario-piotrowiczhttps://github.com/dario-piotrowicz
May 5, 2025https://github.com/nodejs/node/pull/58183#event-17522946500
https://github.com/dario-piotrowicz
test: fix watch tests not including completion messageshttps://github.com/nodejs/node/pull/58183/commits/7c8ec533472b615e4f38091243f7569e6e8c3c4e
7c8ec53https://github.com/nodejs/node/pull/58183/commits/7c8ec533472b615e4f38091243f7569e6e8c3c4e
https://github.com/dario-piotrowicz
dario-piotrowiczhttps://github.com/dario-piotrowicz
force-pushedhttps://github.com/nodejs/node/compare/a919cb9c65350cef218e84513016aaebb757635a..7c8ec533472b615e4f38091243f7569e6e8c3c4e
a919cb9https://github.com/nodejs/node/commit/a919cb9c65350cef218e84513016aaebb757635a
7c8ec53https://github.com/nodejs/node/commit/7c8ec533472b615e4f38091243f7569e6e8c3c4e
Compare https://github.com/nodejs/node/compare/a919cb9c65350cef218e84513016aaebb757635a..7c8ec533472b615e4f38091243f7569e6e8c3c4e
May 5, 2025 16:58https://github.com/nodejs/node/pull/58183#event-17522952027
https://github.com/LiviaMedeiros
LiviaMedeiroshttps://github.com/LiviaMedeiros
May 5, 2025 https://github.com/nodejs/node/pull/58183#pullrequestreview-2815517258
View reviewed changes https://github.com/nodejs/node/pull/58183/files/7c8ec533472b615e4f38091243f7569e6e8c3c4e
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
May 5, 2025https://github.com/nodejs/node/pull/58183#issuecomment-2851845227
Please reload this pagehttps://github.com/nodejs/node/pull/58183
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/58183?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
(4acb854)https://app.codecov.io/gh/nodejs/node/commit/4acb85403950320773352ab127bee9fc85818153?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
(7c8ec53)https://app.codecov.io/gh/nodejs/node/commit/7c8ec533472b615e4f38091243f7569e6e8c3c4e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
see 27 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/58183/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/58183
https://github.com/LiviaMedeiros
LiviaMedeiroshttps://github.com/LiviaMedeiros
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
May 5, 2025https://github.com/nodejs/node/pull/58183#event-17523760322
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
May 5, 2025https://github.com/nodejs/node/pull/58183#event-17523910488
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F58183
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 5, 2025https://github.com/nodejs/node/pull/58183#issuecomment-2852361718
https://ci.nodejs.org/job/node-test-pull-request/66625/https://ci.nodejs.org/job/node-test-pull-request/66625/
Please reload this pagehttps://github.com/nodejs/node/pull/58183
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 5, 2025https://github.com/nodejs/node/pull/58183#issuecomment-2852578323
https://ci.nodejs.org/job/node-test-pull-request/66628/https://ci.nodejs.org/job/node-test-pull-request/66628/
Please reload this pagehttps://github.com/nodejs/node/pull/58183
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 5, 2025https://github.com/nodejs/node/pull/58183#issuecomment-2852578764
https://ci.nodejs.org/job/node-test-pull-request/66629/https://ci.nodejs.org/job/node-test-pull-request/66629/
Please reload this pagehttps://github.com/nodejs/node/pull/58183
https://github.com/LiviaMedeiros
LiviaMedeiroshttps://github.com/LiviaMedeiros
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
May 6, 2025https://github.com/nodejs/node/pull/58183#event-17529435985
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
May 6, 2025https://github.com/nodejs/node/pull/58183#event-17529571702
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
6102159https://github.com/nodejs/node/commit/6102159fa10eb153ed5de6a2f945f120be32cebd
May 6, 2025https://github.com/nodejs/node/pull/58183#event-17529572086
Please reload this pagehttps://github.com/nodejs/node/pull/58183
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
May 6, 2025https://github.com/nodejs/node/pull/58183#issuecomment-2853138812
6102159https://github.com/nodejs/node/commit/6102159fa10eb153ed5de6a2f945f120be32cebd
Please reload this pagehttps://github.com/nodejs/node/pull/58183
https://github.com/dario-piotrowicz
dario-piotrowiczhttps://github.com/dario-piotrowicz
May 6, 2025 08:04https://github.com/nodejs/node/pull/58183#event-17532440801
https://github.com/dario-piotrowicz
dario-piotrowiczhttps://github.com/dario-piotrowicz
May 6, 2025https://github.com/nodejs/node/pull/58183#issuecomment-2853635552
@LiviaMedeiroshttps://github.com/LiviaMedeiros
Please reload this pagehttps://github.com/nodejs/node/pull/58183
https://github.com/aduh95
aduh95https://github.com/aduh95
dont-land-on-v20.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v20.x
dont-land-on-v22.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v22.x
dont-land-on-v23.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v23.x
dont-land-on-v24.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v24.x
May 8, 2025https://github.com/nodejs/node/pull/58183#event-17569053837
watch: fix watch args not being properly filtered #57936 https://github.com/nodejs/node/pull/57936
watch: fix watch args not being properly filtered (second attempt) #58279 https://github.com/nodejs/node/pull/58279
https://github.com/RafaelGSS
RafaelGSShttps://github.com/RafaelGSS
Oct 9, 2025 https://github.com/nodejs/node/pull/58183#ref-pullrequest-3419525415
2025-10-15, Version 25.0.0 (Current) #59896 https://github.com/nodejs/node/pull/59896
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F58183
https://github.com/anonrig
anonrig https://github.com/anonrig
https://github.com/nodejs/node/pull/58183/files/7c8ec533472b615e4f38091243f7569e6e8c3c4e
https://github.com/LiviaMedeiros
LiviaMedeiros https://github.com/LiviaMedeiros
https://github.com/nodejs/node/pull/58183/files/7c8ec533472b615e4f38091243f7569e6e8c3c4e
dont-land-on-v20.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v20.x
dont-land-on-v22.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v22.x
dont-land-on-v24.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v24.x
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/58183
https://github.com/dario-piotrowicz
https://github.com/nodejs-github-bot
https://github.com/anonrig
https://github.com/LiviaMedeiros
https://github.com/aduh95
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.