| route-pattern | /:user_id/:repository/pull/*id(.:format) |
| route-controller | pull_requests |
| route-action | show |
| fetch-nonce | v2:8072c4e0-d500-2517-51b9-0cd282a68ca9 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D408:A2022:257F6E2:3398795:6A4EEC6A |
| html-safe-nonce | 354f2322cedab6d62b8aa539d35cca3d327ba763c9774f039262a9ae43136e7b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENDA4OkEyMDIyOjI1N0Y2RTI6MzM5ODc5NTo2QTRFRUM2QSIsInZpc2l0b3JfaWQiOiI2NDI3NDQ2OTg4NjM2MDg5NDUwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | c804487650d200f173acd45b421cec2a6f2c94fb9dd6d3818257e54fbb4e00b4 |
| hovercard-subject-tag | pull_request:63495137 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodejs/node/pull/5809 |
| twitter:image | https://opengraph.githubassets.com/6b354c6d80eb2ef7b35984d361689a3b8810ebc497bff1aace41f0a80860bd28/nodejs/node/pull/5809 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/6b354c6d80eb2ef7b35984d361689a3b8810ebc497bff1aace41f0a80860bd28/nodejs/node/pull/5809 |
| og:image:alt | Affected core subsystem(s)
dns
Description of change
Prefer the use of template string literals over string concatenation in the dns module, makes dns consistent with other modules basically doing ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | benjamingr |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 00d04d6b867d2f16ab50bebae8ccc56e07c8988b |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/5809#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F5809 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F5809 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/5809 |
| Reload | https://github.com/nodejs/node/pull/5809 |
| Reload | https://github.com/nodejs/node/pull/5809 |
| Please reload this page | https://github.com/nodejs/node/pull/5809 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/5809 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
965
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| benjamingr | https://github.com/benjamingr |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| benjamingr:dns-refactor-errors-to-template-literals | https://github.com/benjamingr/io.js/tree/dns-refactor-errors-to-template-literals |
| Conversation | https://github.com/nodejs/node/pull/5809 |
| Commits1 (1) | https://github.com/nodejs/node/pull/5809/commits |
| Checks | https://github.com/nodejs/node/pull/5809/checks |
| Files changed | https://github.com/nodejs/node/pull/5809/files |
| dns: use template literals | https://github.com/nodejs/node/pull/5809#top |
| benjamingr | https://github.com/benjamingr |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| benjamingr:dns-refactor-errors-to-template-literals | https://github.com/benjamingr/io.js/tree/dns-refactor-errors-to-template-literals |
|
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
| Mar 20, 2016 | https://github.com/nodejs/node/pull/5809#issue-142163218 |
| #5778 | https://github.com/nodejs/node/pull/5778 |
| https://ci.nodejs.org/job/node-test-pull-request/1976/ | https://ci.nodejs.org/job/node-test-pull-request/1976/ |
| Please reload this page | https://github.com/nodejs/node/pull/5809 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
|
dns
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adns |
| Mar 20, 2016 | https://github.com/nodejs/node/pull/5809#event-596250728 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
| Mar 20, 2016 | https://github.com/nodejs/node/pull/5809#event-596250729 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
| Mar 21, 2016 | https://github.com/nodejs/node/pull/5809#issuecomment-199244199 |
| @Trott | https://github.com/Trott |
| Please reload this page | https://github.com/nodejs/node/pull/5809 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Mar 21, 2016 | https://github.com/nodejs/node/pull/5809#issuecomment-199323853 |
| Please reload this page | https://github.com/nodejs/node/pull/5809 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
lts-watch-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x |
| Mar 21, 2016 | https://github.com/nodejs/node/pull/5809#event-597383046 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Mar 21, 2016 | https://github.com/nodejs/node/pull/5809#issuecomment-199361306 |
| Please reload this page | https://github.com/nodejs/node/pull/5809 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
| Mar 21, 2016 | https://github.com/nodejs/node/pull/5809#issuecomment-199421126 |
| @Fishrock123 | https://github.com/Fishrock123 |
| Please reload this page | https://github.com/nodejs/node/pull/5809 |
| Trott | https://github.com/Trott |
|
Mar 21, 2016
| https://github.com/nodejs/node/pull/5809#discussion-diff-56914700 |
| View reviewed changes
| https://github.com/nodejs/node/pull/5809/files#diff-b8086b209233eccf9f74c4d6a38cac729b52c507ef60afb2e4597544700cf110 |
| lib/dns.js | https://github.com/nodejs/node/pull/5809/files#diff-b8086b209233eccf9f74c4d6a38cac729b52c507ef60afb2e4597544700cf110 |
| Trott | https://github.com/Trott |
| Mar 21, 2016 | https://github.com/nodejs/node/pull/5809#discussion_r56914700 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/5809 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Mar 21, 2016 | https://github.com/nodejs/node/pull/5809#issuecomment-199536192 |
| @Trott | https://github.com/Trott |
| Please reload this page | https://github.com/nodejs/node/pull/5809 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
| Mar 22, 2016 | https://github.com/nodejs/node/pull/5809#issuecomment-199705615 |
| https://ci.nodejs.org/job/node-test-pull-request/2015/ | https://ci.nodejs.org/job/node-test-pull-request/2015/ |
| Please reload this page | https://github.com/nodejs/node/pull/5809 |
|
| https://github.com/benjamingr |
| dns: use template literals | https://github.com/nodejs/node/pull/5809/commits/74174d668af07eae56c6d60e8f582dfc013e2af3 |
| 74174d6 | https://github.com/nodejs/node/pull/5809/commits/74174d668af07eae56c6d60e8f582dfc013e2af3 |
| nodejs#5778 | https://github.com/nodejs/node/pull/5778 |
| nodejs#5809 | https://github.com/nodejs/node/pull/5809 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
| force-pushed | https://github.com/nodejs/node/compare/8a700214fe6442e2636c5a5131f1decae8a08f52..74174d668af07eae56c6d60e8f582dfc013e2af3 |
| 8a70021 | https://github.com/nodejs/node/commit/8a700214fe6442e2636c5a5131f1decae8a08f52 |
| 74174d6 | https://github.com/nodejs/node/commit/74174d668af07eae56c6d60e8f582dfc013e2af3 |
|
Compare
| https://github.com/nodejs/node/compare/8a700214fe6442e2636c5a5131f1decae8a08f52..74174d668af07eae56c6d60e8f582dfc013e2af3 |
| March 22, 2016 09:30 | https://github.com/nodejs/node/pull/5809#event-598397637 |
| benjamingr | https://github.com/benjamingr |
|
Mar 22, 2016
| https://github.com/nodejs/node/pull/5809#ref-commit-8baaa25 |
|
| https://github.com/benjamingr |
| dns: use template literals | https://github.com/nodejs/node/commit/8baaa25aec5a052c32d63f1f7f77bbd0e4a78796 |
| 8baaa25 | https://github.com/nodejs/node/commit/8baaa25aec5a052c32d63f1f7f77bbd0e4a78796 |
| #5778 | https://github.com/nodejs/node/pull/5778 |
| #5809 | https://github.com/nodejs/node/pull/5809 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
| Mar 22, 2016 | https://github.com/nodejs/node/pull/5809#issuecomment-199717217 |
| 8baaa25 | https://github.com/nodejs/node/commit/8baaa25aec5a052c32d63f1f7f77bbd0e4a78796 |
| Please reload this page | https://github.com/nodejs/node/pull/5809 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
| Mar 22, 2016 | https://github.com/nodejs/node/pull/5809#event-598402778 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
|
Mar 22, 2016
| https://github.com/nodejs/node/pull/5809#ref-pullrequest-141645578 |
|
dns: refactor dns to more modern JavaScript
#5762
| https://github.com/nodejs/node/pull/5762 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Mar 22, 2016
| https://github.com/nodejs/node/pull/5809#ref-pullrequest-142415910 |
|
v5.9.1 Release Proposal
#5831
| https://github.com/nodejs/node/pull/5831 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Mar 22, 2016
| https://github.com/nodejs/node/pull/5809#ref-commit-54abbe7 |
|
| https://github.com/benjamingr |
|
| https://github.com/Fishrock123 |
| dns: use template literals | https://github.com/nodejs/node/commit/54abbe7e6f6309731f1265bf9af4e09d02492726 |
| 54abbe7 | https://github.com/nodejs/node/commit/54abbe7e6f6309731f1265bf9af4e09d02492726 |
| #5778 | https://github.com/nodejs/node/pull/5778 |
| #5809 | https://github.com/nodejs/node/pull/5809 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Mar 23, 2016
| https://github.com/nodejs/node/pull/5809#ref-commit-7d1918b |
|
| https://github.com/benjamingr |
|
| https://github.com/Fishrock123 |
| dns: use template literals | https://github.com/nodejs/node/commit/7d1918ba849c5c4a16e1f09c3d0a1fb9f95c839f |
| 7d1918b | https://github.com/nodejs/node/commit/7d1918ba849c5c4a16e1f09c3d0a1fb9f95c839f |
| #5778 | https://github.com/nodejs/node/pull/5778 |
| #5809 | https://github.com/nodejs/node/pull/5809 |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 30, 2016
| https://github.com/nodejs/node/pull/5809#ref-commit-9bdc12a |
|
| https://github.com/benjamingr |
| dns: use template literals | https://github.com/nodejs/node/commit/9bdc12a2ebb005a2a0117bb44891b864489879a2 |
| 9bdc12a | https://github.com/nodejs/node/commit/9bdc12a2ebb005a2a0117bb44891b864489879a2 |
| #5778 | https://github.com/nodejs/node/pull/5778 |
| #5809 | https://github.com/nodejs/node/pull/5809 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v4.x |
|
lts-watch-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x |
| Mar 30, 2016 | https://github.com/nodejs/node/pull/5809#event-608795780 |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 30, 2016
| https://github.com/nodejs/node/pull/5809#ref-commit-d55599f |
|
| https://github.com/benjamingr |
| dns: use template literals | https://github.com/nodejs/node/commit/d55599f4d83b85f60280b43803060cb9e50f34c9 |
| d55599f | https://github.com/nodejs/node/commit/d55599f4d83b85f60280b43803060cb9e50f34c9 |
| #5778 | https://github.com/nodejs/node/pull/5778 |
| #5809 | https://github.com/nodejs/node/pull/5809 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F5809 |
|
| https://github.com/benjamingr |
|
benjamingr
| https://github.com/benjamingr |
|
dns
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adns |
| Please reload this page | https://github.com/nodejs/node/pull/5809 |
|
| https://github.com/benjamingr |
|
| https://github.com/Fishrock123 |
|
| https://github.com/jasnell |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |