| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:8c758108-33b9-2c14-3fad-eb797ed22b9a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8BB8:1793BD:2B0AAEE:3BE58F0:6A633462 |
| html-safe-nonce | 2c9eb15b51b99b06e79c1bd494ef58f41307188c462651412d1ab9457142a316 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QkI4OjE3OTNCRDoyQjBBQUVFOjNCRTU4RjA6NkE2MzM0NjIiLCJ2aXNpdG9yX2lkIjoiMjcyMTgzODA0Mjc1MjE2OTA1OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | ece5687d514302b437dcd2ae71ce1561c16a9042690ebcac4dd0b681717b642c |
| hovercard-subject-tag | pull_request:2464406493 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/57901/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/9c3c39e2e140f02d09bdb40f9ac73740400c1458164e2f2e8fb185e9be32d1b4/nodejs/node/pull/57901 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/9c3c39e2e140f02d09bdb40f9ac73740400c1458164e2f2e8fb185e9be32d1b4/nodejs/node/pull/57901 |
| og:image:alt | Refs: #57899
This PR adds a node-core/func-name-matching linter rule that correctly handles defining properties with functions as value, and fixes the function names accordingly.
Authored by @louie... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | LiviaMedeiros |
| hostname | github.com |
| expected-hostname | github.com |
| None | df6e1c2adcceb061ec8c4106a1b34f38280f08e13f2b195c661c202834cbc3b1 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 822a0ff2a479845adcdd40a1a7b1734a56e05818 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/57901#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F57901 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| Code QualityEnforce quality at merge | https://github.com/features/code-quality |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F57901 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/57901 |
| Reload | https://github.com/nodejs/node/pull/57901 |
| Reload | https://github.com/nodejs/node/pull/57901 |
| Please reload this page | https://github.com/nodejs/node/pull/57901 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/57901 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36.1k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
1k
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| aduh95 | https://github.com/aduh95 |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| LiviaMedeiros:lib-name-functions | https://github.com/LiviaMedeiros/node/tree/lib-name-functions |
| Conversation | https://github.com/nodejs/node/pull/57901 |
| Commits19 (19) | https://github.com/nodejs/node/pull/57901/commits |
| Checks | https://github.com/nodejs/node/pull/57901/checks |
| Files changed | https://github.com/nodejs/node/pull/57901/files |
| lib,tools: rename functions named value | https://github.com/nodejs/node/pull/57901#top |
| aduh95 | https://github.com/aduh95 |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| LiviaMedeiros:lib-name-functions | https://github.com/LiviaMedeiros/node/tree/lib-name-functions |
|
| https://github.com/LiviaMedeiros |
| LiviaMedeiros | https://github.com/LiviaMedeiros |
| Apr 16, 2025 | https://github.com/nodejs/node/pull/57901#issue-3000584067 |
| Please reload this page | https://github.com/nodejs/node/pull/57901 |
| #57899 | https://github.com/nodejs/node/issues/57899 |
| @louiellan | https://github.com/louiellan |
| Please reload this page | https://github.com/nodejs/node/pull/57901 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 16, 2025 | https://github.com/nodejs/node/pull/57901#issuecomment-2810587662 |
| Please reload this page | https://github.com/nodejs/node/pull/57901 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
| Apr 16, 2025 | https://github.com/nodejs/node/pull/57901#event-17294966029 |
| https://github.com/LiviaMedeiros |
| LiviaMedeiros | https://github.com/LiviaMedeiros |
|
help wanted
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22help%20wanted%22 |
|
wip
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip |
| Apr 16, 2025 | https://github.com/nodejs/node/pull/57901#event-17294970058 |
| https://github.com/ljharb |
| ljharb | https://github.com/ljharb |
| Apr 16, 2025 | https://github.com/nodejs/node/pull/57901#issuecomment-2810678753 |
| Please reload this page | https://github.com/nodejs/node/pull/57901 |
| https://github.com/apps/codecov |
| codecov | https://github.com/apps/codecov |
| Apr 16, 2025 | https://github.com/nodejs/node/pull/57901#issuecomment-2810702583 |
| Please reload this page | https://github.com/nodejs/node/pull/57901 |
| Codecov | https://app.codecov.io/gh/nodejs/node/pull/57901?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| 4ee7567 | https://app.codecov.io/gh/nodejs/node/commit/4ee756741b41592ad80bfb7d95d0011d756ed744?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| c025626 | https://app.codecov.io/gh/nodejs/node/commit/c025626c790e085b8f115b4bf14c001cf9d21829?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| Files with missing lines | https://app.codecov.io/gh/nodejs/node/pull/57901?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| lib/fs.js | https://app.codecov.io/gh/nodejs/node/pull/57901?src=pr&el=tree&filepath=lib%2Ffs.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ZzLmpz |
| ...internal/bootstrap/web/exposed-window-or-worker.js | https://app.codecov.io/gh/nodejs/node/pull/57901?src=pr&el=tree&filepath=lib%2Finternal%2Fbootstrap%2Fweb%2Fexposed-window-or-worker.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL2Jvb3RzdHJhcC93ZWIvZXhwb3NlZC13aW5kb3ctb3Itd29ya2VyLmpz |
| lib/internal/console/constructor.js | https://app.codecov.io/gh/nodejs/node/pull/57901?src=pr&el=tree&filepath=lib%2Finternal%2Fconsole%2Fconstructor.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL2NvbnNvbGUvY29uc3RydWN0b3IuanM= |
| lib/internal/modules/esm/hooks.js | https://app.codecov.io/gh/nodejs/node/pull/57901?src=pr&el=tree&filepath=lib%2Finternal%2Fmodules%2Fesm%2Fhooks.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL21vZHVsZXMvZXNtL2hvb2tzLmpz |
| lib/internal/modules/esm/translators.js | https://app.codecov.io/gh/nodejs/node/pull/57901?src=pr&el=tree&filepath=lib%2Finternal%2Fmodules%2Fesm%2Ftranslators.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL21vZHVsZXMvZXNtL3RyYW5zbGF0b3JzLmpz |
| lib/internal/per_context/domexception.js | https://app.codecov.io/gh/nodejs/node/pull/57901?src=pr&el=tree&filepath=lib%2Finternal%2Fper_context%2Fdomexception.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3Blcl9jb250ZXh0L2RvbWV4Y2VwdGlvbi5qcw== |
| lib/internal/streams/writable.js | https://app.codecov.io/gh/nodejs/node/pull/57901?src=pr&el=tree&filepath=lib%2Finternal%2Fstreams%2Fwritable.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3N0cmVhbXMvd3JpdGFibGUuanM= |
| lib/internal/test_runner/mock/mock_timers.js | https://app.codecov.io/gh/nodejs/node/pull/57901?src=pr&el=tree&filepath=lib%2Finternal%2Ftest_runner%2Fmock%2Fmock_timers.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3Rlc3RfcnVubmVyL21vY2svbW9ja190aW1lcnMuanM= |
| lib/internal/util/types.js | https://app.codecov.io/gh/nodejs/node/pull/57901?src=pr&el=tree&filepath=lib%2Finternal%2Futil%2Ftypes.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3V0aWwvdHlwZXMuanM= |
| lib/internal/worker/io.js | https://app.codecov.io/gh/nodejs/node/pull/57901?src=pr&el=tree&filepath=lib%2Finternal%2Fworker%2Fio.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3dvcmtlci9pby5qcw== |
| 2 more | https://app.codecov.io/gh/nodejs/node/pull/57901?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| 114 files with indirect coverage changes | https://app.codecov.io/gh/nodejs/node/pull/57901/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| Test Analytics | https://docs.codecov.com/docs/test-analytics |
| JS Bundle Analysis | https://docs.codecov.com/docs/javascript-bundle-analysis |
| Please reload this page | https://github.com/nodejs/node/pull/57901 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Apr 16, 2025
| https://github.com/nodejs/node/pull/57901#pullrequestreview-2773961488 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/57901/files |
| lib/internal/streams/writable.js | https://github.com/nodejs/node/pull/57901/files#diff-28ea8bff0d427c8a06dab3edfba075da70ed458a5a23d250e500a88e92a468f8 |
| Please reload this page | https://github.com/nodejs/node/pull/57901 |
| https://github.com/LiviaMedeiros |
| LiviaMedeiros | https://github.com/LiviaMedeiros |
|
Apr 17, 2025
| https://github.com/nodejs/node/pull/57901#ref-pullrequest-3003076755 |
|
util: add internal assignFunctionName() function
#57916
| https://github.com/nodejs/node/pull/57916 |
| https://github.com/LiviaMedeiros |
| LiviaMedeiros | https://github.com/LiviaMedeiros |
| force-pushed | https://github.com/nodejs/node/compare/8345a4602757859236d74627361dce76472f1c33..c969ef7a7039f45c9e1d2bcf11ca6b03e2eb1bc3 |
| 8345a46 | https://github.com/nodejs/node/commit/8345a4602757859236d74627361dce76472f1c33 |
| c969ef7 | https://github.com/nodejs/node/commit/c969ef7a7039f45c9e1d2bcf11ca6b03e2eb1bc3 |
|
Compare
| https://github.com/nodejs/node/compare/8345a4602757859236d74627361dce76472f1c33..c969ef7a7039f45c9e1d2bcf11ca6b03e2eb1bc3 |
| May 4, 2025 08:35 | https://github.com/nodejs/node/pull/57901#event-17509811552 |
| https://github.com/louiellan |
| louiellan | https://github.com/louiellan |
| Jul 24, 2025 | https://github.com/nodejs/node/pull/57901#issuecomment-3111976677 |
| lib-name-functions | https://github.com/nodejs/node/compare/main...louiellan:node:lib-name-functions |
| Please reload this page | https://github.com/nodejs/node/pull/57901 |
| https://github.com/LiviaMedeiros |
| LiviaMedeiros | https://github.com/LiviaMedeiros |
| Jul 30, 2025 | https://github.com/nodejs/node/pull/57901#issuecomment-3136695883 |
| Please reload this page | https://github.com/nodejs/node/pull/57901 |
| @louiellan | https://github.com/louiellan |
| Please reload this page | https://github.com/nodejs/node/pull/57901 |
| https://github.com/louiellan |
| louiellan | https://github.com/louiellan |
| Jul 31, 2025 | https://github.com/nodejs/node/pull/57901#issuecomment-3138540497 |
| @LiviaMedeiros | https://github.com/LiviaMedeiros |
| LiviaMedeiros#1 | https://github.com/LiviaMedeiros/node/pull/1 |
| Please reload this page | https://github.com/nodejs/node/pull/57901 |
| https://github.com/LiviaMedeiros |
| LiviaMedeiros | https://github.com/LiviaMedeiros |
| force-pushed | https://github.com/nodejs/node/compare/840384437c3762d113de8c39fc3f2e4249578326..cb53cff6745171016c019768ccb66757149756f8 |
| 8403844 | https://github.com/nodejs/node/commit/840384437c3762d113de8c39fc3f2e4249578326 |
| cb53cff | https://github.com/nodejs/node/commit/cb53cff6745171016c019768ccb66757149756f8 |
|
Compare
| https://github.com/nodejs/node/compare/840384437c3762d113de8c39fc3f2e4249578326..cb53cff6745171016c019768ccb66757149756f8 |
| July 31, 2025 07:02 | https://github.com/nodejs/node/pull/57901#event-18913038575 |
| https://github.com/LiviaMedeiros |
| LiviaMedeiros | https://github.com/LiviaMedeiros |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
|
help wanted
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22help%20wanted%22 |
|
wip
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awip |
| Jul 31, 2025 | https://github.com/nodejs/node/pull/57901#event-18913050604 |
| https://github.com/LiviaMedeiros |
| LiviaMedeiros | https://github.com/LiviaMedeiros |
| Jul 31, 2025 | https://github.com/nodejs/node/pull/57901#event-18921009099 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F57901 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Aug 1, 2025
| https://github.com/nodejs/node/pull/57901#pullrequestreview-3078465119 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/57901/files |
| test/parallel/test-eslint-func-name-matching.js | https://github.com/nodejs/node/pull/57901/files#diff-63e75e1222f6d84b44d3f245aea0349e105696c2f600097b1be2ded2dd4ac3af |
| Please reload this page | https://github.com/nodejs/node/pull/57901 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Aug 1, 2025
| https://github.com/nodejs/node/pull/57901#pullrequestreview-3078466869 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/57901/files |
| tools/eslint-rules/func-name-matching.js | https://github.com/nodejs/node/pull/57901/files#diff-a77353341484f4afb7402d0c379bc664d1e465300baa4ca25e8da6301ac3a639 |
| Please reload this page | https://github.com/nodejs/node/pull/57901 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Aug 1, 2025
| https://github.com/nodejs/node/pull/57901#pullrequestreview-3078480482 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/57901/files |
| tools/eslint-rules/func-name-matching.js | https://github.com/nodejs/node/pull/57901/files#diff-a77353341484f4afb7402d0c379bc664d1e465300baa4ca25e8da6301ac3a639 |
| Please reload this page | https://github.com/nodejs/node/pull/57901 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Aug 1, 2025 | https://github.com/nodejs/node/pull/57901#issuecomment-3143933877 |
| https://ci.nodejs.org/job/node-test-pull-request/68346/ | https://ci.nodejs.org/job/node-test-pull-request/68346/ |
| Please reload this page | https://github.com/nodejs/node/pull/57901 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Aug 1, 2025
| https://github.com/nodejs/node/pull/57901#pullrequestreview-3078488265 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/57901/files |
| tools/eslint-rules/func-name-matching.js | https://github.com/nodejs/node/pull/57901/files#diff-a77353341484f4afb7402d0c379bc664d1e465300baa4ca25e8da6301ac3a639 |
| Please reload this page | https://github.com/nodejs/node/pull/57901 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Aug 1, 2025
| https://github.com/nodejs/node/pull/57901#pullrequestreview-3078502342 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/57901/files |
| tools/eslint-rules/func-name-matching.js | https://github.com/nodejs/node/pull/57901/files#diff-a77353341484f4afb7402d0c379bc664d1e465300baa4ca25e8da6301ac3a639 |
| Please reload this page | https://github.com/nodejs/node/pull/57901 |
| https://github.com/louiellan |
| louiellan | https://github.com/louiellan |
| Apr 7, 2026 | https://github.com/nodejs/node/pull/57901#issuecomment-4196756072 |
| Please reload this page | https://github.com/nodejs/node/pull/57901 |
| https://github.com/LiviaMedeiros |
| LiviaMedeiros | https://github.com/LiviaMedeiros |
| May 14, 2026 | https://github.com/nodejs/node/pull/57901#issuecomment-4454620136 |
| @louiellan | https://github.com/louiellan |
| Please reload this page | https://github.com/nodejs/node/pull/57901 |
| https://github.com/louiellan |
| louiellan | https://github.com/louiellan |
| May 15, 2026 | https://github.com/nodejs/node/pull/57901#issuecomment-4456977773 |
| Please reload this page | https://github.com/nodejs/node/pull/57901 |
| Please reload this page | https://github.com/nodejs/node/pull/57901 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
May 15, 2026
| https://github.com/nodejs/node/pull/57901#pullrequestreview-4296030168 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/57901/files |
| mcollina | https://github.com/mcollina |
| https://github.com/nodejs/node/pull/57901#pullrequestreview-4296030168 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/57901 |
| https://github.com/Ethan-Arrowood |
| Ethan-Arrowood | https://github.com/Ethan-Arrowood |
|
May 15, 2026
| https://github.com/nodejs/node/pull/57901#pullrequestreview-4299441122 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/57901/files |
| Ethan-Arrowood | https://github.com/Ethan-Arrowood |
| https://github.com/nodejs/node/pull/57901#pullrequestreview-4299441122 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/57901 |
| louiellan | https://github.com/louiellan |
| May 22, 2026 00:10 | https://github.com/nodejs/node/pull/57901#commits-pushed-95d7e11 |
|
| https://github.com/louiellan |
|
| https://github.com/LiviaMedeiros |
| tools,test: added eslint's license | https://github.com/nodejs/node/pull/57901/commits/95d7e11872a07d84ad240c37251ee60d83eec625 |
| 95d7e11 | https://github.com/nodejs/node/pull/57901/commits/95d7e11872a07d84ad240c37251ee60d83eec625 |
|
| https://github.com/louiellan |
|
| https://github.com/LiviaMedeiros |
| test: renamed ruletester file | https://github.com/nodejs/node/pull/57901/commits/245dd38c4fa8a841ce953c506ccd9b3b940634e3 |
| 245dd38 | https://github.com/nodejs/node/pull/57901/commits/245dd38c4fa8a841ce953c506ccd9b3b940634e3 |
|
| https://github.com/louiellan |
|
| https://github.com/LiviaMedeiros |
| tools: changed to multiple author tags | https://github.com/nodejs/node/pull/57901/commits/919bf1f5a6334124c13c069b40e02abd7d89a49e |
| 919bf1f | https://github.com/nodejs/node/pull/57901/commits/919bf1f5a6334124c13c069b40e02abd7d89a49e |
|
| https://github.com/LiviaMedeiros |
| squash: remove empty line | https://github.com/nodejs/node/pull/57901/commits/8d08aadccebaf6c0c87e68a03004ab72b74a3bdb |
| 8d08aad | https://github.com/nodejs/node/pull/57901/commits/8d08aadccebaf6c0c87e68a03004ab72b74a3bdb |
|
| https://github.com/LiviaMedeiros |
|
| https://github.com/aduh95 |
| squash: remove copyright notice | https://github.com/nodejs/node/pull/57901/commits/7c44fd238df67ace22168122ef5fd0319e1f327e |
| 7c44fd2 | https://github.com/nodejs/node/pull/57901/commits/7c44fd238df67ace22168122ef5fd0319e1f327e |
|
| https://github.com/LiviaMedeiros |
| squash: move checks to selectors | https://github.com/nodejs/node/pull/57901/commits/bbb111d24d1167ce94e0d242d8bdcf2c366c67aa |
| bbb111d | https://github.com/nodejs/node/pull/57901/commits/bbb111d24d1167ce94e0d242d8bdcf2c366c67aa |
|
| https://github.com/LiviaMedeiros |
|
| https://github.com/louiellan |
| squash: Update tools/eslint-rules/func-name-matching.js | https://github.com/nodejs/node/pull/57901/commits/55163d905dcbca416e9af4ef5ce4c217e5695d75 |
| 55163d9 | https://github.com/nodejs/node/pull/57901/commits/55163d905dcbca416e9af4ef5ce4c217e5695d75 |
| https://github.com/LiviaMedeiros |
| LiviaMedeiros | https://github.com/LiviaMedeiros |
| force-pushed | https://github.com/nodejs/node/compare/d2280cc89cced87ac52d927ec683689938c7ac17..55163d905dcbca416e9af4ef5ce4c217e5695d75 |
| d2280cc | https://github.com/nodejs/node/commit/d2280cc89cced87ac52d927ec683689938c7ac17 |
| 55163d9 | https://github.com/nodejs/node/commit/55163d905dcbca416e9af4ef5ce4c217e5695d75 |
|
Compare
| https://github.com/nodejs/node/compare/d2280cc89cced87ac52d927ec683689938c7ac17..55163d905dcbca416e9af4ef5ce4c217e5695d75 |
| May 21, 2026 16:11 | https://github.com/nodejs/node/pull/57901#event-25813611270 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| May 24, 2026 | https://github.com/nodejs/node/pull/57901#issuecomment-4529855626 |
| Please reload this page | https://github.com/nodejs/node/pull/57901 |
| LiviaMedeiros | https://github.com/LiviaMedeiros |
| May 25, 2026 08:54 | https://github.com/nodejs/node/pull/57901#commits-pushed-ea7c4e5 |
|
| https://github.com/LiviaMedeiros |
| squash: rename yet another function value | https://github.com/nodejs/node/pull/57901/commits/ea7c4e590e6fa12f097a3391fe24867d282d1971 |
| ea7c4e5 | https://github.com/nodejs/node/pull/57901/commits/ea7c4e590e6fa12f097a3391fe24867d282d1971 |
|
| https://github.com/LiviaMedeiros |
| squash: remove unused linter directive | https://github.com/nodejs/node/pull/57901/commits/7699aa20f53f0a1b7e34df0e29949d8acdd450f2 |
| 7699aa2 | https://github.com/nodejs/node/pull/57901/commits/7699aa20f53f0a1b7e34df0e29949d8acdd450f2 |
|
| https://github.com/LiviaMedeiros |
| squash: set new linter directive | https://github.com/nodejs/node/pull/57901/commits/c025626c790e085b8f115b4bf14c001cf9d21829 |
| c025626 | https://github.com/nodejs/node/pull/57901/commits/c025626c790e085b8f115b4bf14c001cf9d21829 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| May 25, 2026 | https://github.com/nodejs/node/pull/57901#issuecomment-4531069760 |
| https://ci.nodejs.org/job/node-test-pull-request/73687/ | https://ci.nodejs.org/job/node-test-pull-request/73687/ |
| Please reload this page | https://github.com/nodejs/node/pull/57901 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
May 25, 2026
| https://github.com/nodejs/node/pull/57901#pullrequestreview-4355421523 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/57901/files/c025626c790e085b8f115b4bf14c001cf9d21829 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| May 25, 2026 | https://github.com/nodejs/node/pull/57901#issuecomment-4532928952 |
| https://ci.nodejs.org/job/node-test-pull-request/73698/ | https://ci.nodejs.org/job/node-test-pull-request/73698/ |
| Please reload this page | https://github.com/nodejs/node/pull/57901 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Jul 13, 2026 | https://github.com/nodejs/node/pull/57901#event-27895814205 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci-failed
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci-failed |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Jul 13, 2026 | https://github.com/nodejs/node/pull/57901#event-27896071704 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Jul 13, 2026 | https://github.com/nodejs/node/pull/57901#issuecomment-4955645346 |
| https://github.com/nodejs/node/actions/runs/29233234906 | https://github.com/nodejs/node/actions/runs/29233234906 |
| Please reload this page | https://github.com/nodejs/node/pull/57901 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 13, 2026 | https://github.com/nodejs/node/pull/57901#issuecomment-4955743470 |
| https://ci.nodejs.org/job/node-test-pull-request/74771/ | https://ci.nodejs.org/job/node-test-pull-request/74771/ |
| Please reload this page | https://github.com/nodejs/node/pull/57901 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 13, 2026 | https://github.com/nodejs/node/pull/57901#issuecomment-4957001050 |
| https://ci.nodejs.org/job/node-test-pull-request/74777/ | https://ci.nodejs.org/job/node-test-pull-request/74777/ |
| Please reload this page | https://github.com/nodejs/node/pull/57901 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 13, 2026 | https://github.com/nodejs/node/pull/57901#issuecomment-4958827532 |
| https://ci.nodejs.org/job/node-test-pull-request/74782/ | https://ci.nodejs.org/job/node-test-pull-request/74782/ |
| Please reload this page | https://github.com/nodejs/node/pull/57901 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 13, 2026 | https://github.com/nodejs/node/pull/57901#issuecomment-4960691750 |
| https://ci.nodejs.org/job/node-test-pull-request/74789/ | https://ci.nodejs.org/job/node-test-pull-request/74789/ |
| Please reload this page | https://github.com/nodejs/node/pull/57901 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 13, 2026 | https://github.com/nodejs/node/pull/57901#issuecomment-4962482676 |
| https://ci.nodejs.org/job/node-test-pull-request/74796/ | https://ci.nodejs.org/job/node-test-pull-request/74796/ |
| Please reload this page | https://github.com/nodejs/node/pull/57901 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| 727e2bc | https://github.com/nodejs/node/commit/727e2bce8e94b954affd5e9b74353f18b3a0f0f3 |
| Jul 14, 2026 | https://github.com/nodejs/node/pull/57901#event-27964602801 |
| Please reload this page | https://github.com/nodejs/node/pull/57901 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| Jul 14, 2026 | https://github.com/nodejs/node/pull/57901#issuecomment-4969713344 |
| 727e2bc | https://github.com/nodejs/node/commit/727e2bce8e94b954affd5e9b74353f18b3a0f0f3 |
| Please reload this page | https://github.com/nodejs/node/pull/57901 |
| aduh95 | https://github.com/aduh95 |
|
Jul 21, 2026
| https://github.com/nodejs/node/pull/57901#ref-commit-b297227 |
|
| https://github.com/LiviaMedeiros |
|
| https://github.com/louiellan |
|
| https://github.com/aduh95 |
| lib,tools: add node-core/func-name-matching lint rule | https://github.com/nodejs/node/commit/b297227137e18f704fb33afc93b1504efe25d520 |
| b297227 | https://github.com/nodejs/node/commit/b297227137e18f704fb33afc93b1504efe25d520 |
| #57901 | https://github.com/nodejs/node/pull/57901 |
| #57899 | https://github.com/nodejs/node/issues/57899 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
Jul 21, 2026
| https://github.com/nodejs/node/pull/57901#ref-pullrequest-4940321437 |
|
2026-07-22, Version 26.6.0 (Current)
#64655
| https://github.com/nodejs/node/pull/64655 |
| aduh95 | https://github.com/aduh95 |
|
Jul 21, 2026
| https://github.com/nodejs/node/pull/57901#ref-commit-15860ff |
|
| https://github.com/LiviaMedeiros |
|
| https://github.com/louiellan |
|
| https://github.com/aduh95 |
| lib,tools: add node-core/func-name-matching lint rule | https://github.com/nodejs/node/commit/15860ffc21ce715f6738a82189ee8d3085c15190 |
| 15860ff | https://github.com/nodejs/node/commit/15860ffc21ce715f6738a82189ee8d3085c15190 |
| #57901 | https://github.com/nodejs/node/pull/57901 |
| #57899 | https://github.com/nodejs/node/issues/57899 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F57901 |
|
| https://github.com/mcollina |
|
mcollina
| https://github.com/mcollina |
|
| https://github.com/nodejs/node/pull/57901/files/fb8490491f4f20f8a024065cee6c96c96872e8e5 |
|
| https://github.com/aduh95 |
|
aduh95
| https://github.com/aduh95 |
|
| https://github.com/nodejs/node/pull/57901/files/c025626c790e085b8f115b4bf14c001cf9d21829 |
|
| https://github.com/Ethan-Arrowood |
|
Ethan-Arrowood
| https://github.com/Ethan-Arrowood |
|
| https://github.com/nodejs/node/pull/57901/files/fb8490491f4f20f8a024065cee6c96c96872e8e5 |
|
| https://github.com/louiellan |
|
louiellan
| https://github.com/louiellan |
|
| https://github.com/nodejs/node/pull/57901/files/fb8490491f4f20f8a024065cee6c96c96872e8e5 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
request-ci-failed
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci-failed |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
| Please reload this page | https://github.com/nodejs/node/pull/57901 |
|
| https://github.com/LiviaMedeiros |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/ljharb |
|
| https://github.com/louiellan |
|
| https://github.com/mcollina |
|
| https://github.com/aduh95 |
|
| https://github.com/Ethan-Arrowood |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |