René's URL Explorer Experiment


Title: esm: remove check for trailing slash during resolve by cyyynthia · Pull Request #57773 · nodejs/node · GitHub

Open Graph Title: esm: remove check for trailing slash during resolve by cyyynthia · Pull Request #57773 · nodejs/node

X Title: esm: remove check for trailing slash during resolve by cyyynthia · Pull Request #57773 · nodejs/node

Description: The check was incorrectly altered in #54408, passing the bindings as argument for this instead of the path string. This check not working having no significant impact on Node.js as far as I can tel...

Open Graph Description: The check was incorrectly altered in #54408, passing the bindings as argument for this instead of the path string. This check not working having no significant impact on Node.js as far as I can tel...

X Description: The check was incorrectly altered in #54408, passing the bindings as argument for this instead of the path string. This check not working having no significant impact on Node.js as far as I can tel...

Opengraph URL: https://github.com/nodejs/node/pull/57773

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ad87c641-15c2-dfb3-b796-fdfd497275e8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE96A:3372CB:D3D317:12592FB:696A8313
html-safe-nonce4b994489b4589970ff5867c68ca49ba83c315aa121acf2ddd75d0ca5f171a209
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOTZBOjMzNzJDQjpEM0QzMTc6MTI1OTJGQjo2OTZBODMxMyIsInZpc2l0b3JfaWQiOiI3Mjk4NDIwMDc2NzE0NzI5MTUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac9e378175b8a7dc534a97db6138b57808e5a1b8718b86bba410091c77c68be119
hovercard-subject-tagpull_request:2441618922
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/57773/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f61af4c97dcf3874c0dfb983192dd5e82f572331e1d4b523081e249c2cb9574b/nodejs/node/pull/57773
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f61af4c97dcf3874c0dfb983192dd5e82f572331e1d4b523081e249c2cb9574b/nodejs/node/pull/57773
og:image:altThe check was incorrectly altered in #54408, passing the bindings as argument for this instead of the path string. This check not working having no significant impact on Node.js as far as I can tel...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecyyynthia
hostnamegithub.com
expected-hostnamegithub.com
None913560fa317c3c5a71e34f9b19253c9f09d02b4b958a86c2a56f4c8541116377
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5998c30593994bf2589055aef7b22d368a499367
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/57773#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F57773
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F57773
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/57773
Reloadhttps://github.com/nodejs/node/pull/57773
Reloadhttps://github.com/nodejs/node/pull/57773
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/57773
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 693 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/57773
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/57773#issue-comment-box
cyyynthiahttps://github.com/cyyynthia
nodejs:mainhttps://github.com/nodejs/node/tree/main
cyyynthia:fix/esm-resolve-stat-ends-withhttps://github.com/cyyynthia/node/tree/fix/esm-resolve-stat-ends-with
esm: remove check for trailing slash during resolve https://github.com/nodejs/node/pull/57773#top
cyyynthiahttps://github.com/cyyynthia
nodejs:mainhttps://github.com/nodejs/node/tree/main
cyyynthia:fix/esm-resolve-stat-ends-withhttps://github.com/cyyynthia/node/tree/fix/esm-resolve-stat-ends-with
Conversation 9 https://github.com/nodejs/node/pull/57773
Commits 1 https://github.com/nodejs/node/pull/57773/commits
Checks 0 https://github.com/nodejs/node/pull/57773/checks
Files changed https://github.com/nodejs/node/pull/57773/files
Please reload this pagehttps://github.com/nodejs/node/pull/57773
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/cyyynthia
cyyynthiahttps://github.com/cyyynthia
Apr 6, 2025https://github.com/nodejs/node/pull/57773#issue-2974902414
#54408https://github.com/nodejs/node/pull/54408
Please reload this pagehttps://github.com/nodejs/node/pull/57773
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Apr 6, 2025https://github.com/nodejs/node/pull/57773#issuecomment-2781382741
Please reload this pagehttps://github.com/nodejs/node/pull/57773
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
esm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Apr 6, 2025https://github.com/nodejs/node/pull/57773#event-17142990616
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Apr 6, 2025https://github.com/nodejs/node/pull/57773#issuecomment-2781455344
Please reload this pagehttps://github.com/nodejs/node/pull/57773
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/57773?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
(8456a12)https://app.codecov.io/gh/nodejs/node/commit/8456a1245902b159a9178e168e5216071aa32319?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
(743dba0)https://app.codecov.io/gh/nodejs/node/commit/743dba0d0d8a4d5f5cb2993d747bbb003d4f4f7a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/57773?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/modules/esm/resolve.jshttps://app.codecov.io/gh/nodejs/node/pull/57773?src=pr&el=tree&filepath=lib%2Finternal%2Fmodules%2Fesm%2Fresolve.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL21vZHVsZXMvZXNtL3Jlc29sdmUuanM=
30 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/57773/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/57773
https://github.com/cyyynthia
cyyynthiahttps://github.com/cyyynthia
force-pushedhttps://github.com/nodejs/node/compare/a12da1074f707cfd57831166808e6283f95ed585..743dba0d0d8a4d5f5cb2993d747bbb003d4f4f7a
a12da10https://github.com/nodejs/node/commit/a12da1074f707cfd57831166808e6283f95ed585
743dba0https://github.com/nodejs/node/commit/743dba0d0d8a4d5f5cb2993d747bbb003d4f4f7a
Compare https://github.com/nodejs/node/compare/a12da1074f707cfd57831166808e6283f95ed585..743dba0d0d8a4d5f5cb2993d747bbb003d4f4f7a
April 6, 2025 15:05https://github.com/nodejs/node/pull/57773#event-17143460012
https://github.com/mcollina
mcollinahttps://github.com/mcollina
ljharbhttps://github.com/ljharb
April 7, 2025 14:50https://github.com/nodejs/node/pull/57773#event-17155329959
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Apr 7, 2025https://github.com/nodejs/node/pull/57773#issuecomment-2783611781
Please reload this pagehttps://github.com/nodejs/node/pull/57773
https://github.com/cyyynthia
cyyynthiahttps://github.com/cyyynthia
Apr 7, 2025https://github.com/nodejs/node/pull/57773#issuecomment-2783740813
Please reload this pagehttps://github.com/nodejs/node/pull/57773
https://github.com/ljharb
ljharbhttps://github.com/ljharb
Apr 7, 2025 https://github.com/nodejs/node/pull/57773#pullrequestreview-2747293643
View reviewed changes https://github.com/nodejs/node/pull/57773/files
lib/internal/modules/esm/resolve.jshttps://github.com/nodejs/node/pull/57773/files#diff-b4c24f634e3741e5ad9e8c29864a48f2bd284a9d66d8fed3d077ccee0c44087b
ljharbhttps://github.com/ljharb
Apr 7, 2025https://github.com/nodejs/node/pull/57773#discussion_r2031522433
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/57773
cyyynthiahttps://github.com/cyyynthia
Apr 7, 2025https://github.com/nodejs/node/pull/57773#discussion_r2031714309
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#34744https://github.com/nodejs/node/pull/34744
Please reload this pagehttps://github.com/nodejs/node/pull/57773
ljharbhttps://github.com/ljharb
Apr 7, 2025https://github.com/nodejs/node/pull/57773#discussion_r2031750929
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/57773
cyyynthiahttps://github.com/cyyynthia
Apr 11, 2025https://github.com/nodejs/node/pull/57773#discussion_r2039080837
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/57773
https://github.com/cyyynthia
esm: fix check for trailing slash during resolvehttps://github.com/nodejs/node/pull/57773/commits/48c9e3c66f2681a53a78ac75b4a7e521abd2cf3b
48c9e3chttps://github.com/nodejs/node/pull/57773/commits/48c9e3c66f2681a53a78ac75b4a7e521abd2cf3b
nodejs#54408https://github.com/nodejs/node/pull/54408
https://github.com/cyyynthia
cyyynthiahttps://github.com/cyyynthia
force-pushedhttps://github.com/nodejs/node/compare/743dba0d0d8a4d5f5cb2993d747bbb003d4f4f7a..48c9e3c66f2681a53a78ac75b4a7e521abd2cf3b
743dba0https://github.com/nodejs/node/commit/743dba0d0d8a4d5f5cb2993d747bbb003d4f4f7a
48c9e3chttps://github.com/nodejs/node/commit/48c9e3c66f2681a53a78ac75b4a7e521abd2cf3b
Compare https://github.com/nodejs/node/compare/743dba0d0d8a4d5f5cb2993d747bbb003d4f4f7a..48c9e3c66f2681a53a78ac75b4a7e521abd2cf3b
April 11, 2025 08:34https://github.com/nodejs/node/pull/57773#event-17219852294
https://github.com/ljharb
ljharbhttps://github.com/ljharb
Apr 11, 2025 https://github.com/nodejs/node/pull/57773#pullrequestreview-2761310393
View reviewed changes https://github.com/nodejs/node/pull/57773/files/48c9e3c66f2681a53a78ac75b4a7e521abd2cf3b
lib/internal/modules/esm/resolve.jshttps://github.com/nodejs/node/pull/57773/files/48c9e3c66f2681a53a78ac75b4a7e521abd2cf3b#diff-b4c24f634e3741e5ad9e8c29864a48f2bd284a9d66d8fed3d077ccee0c44087b
ljharbhttps://github.com/ljharb
Apr 11, 2025https://github.com/nodejs/node/pull/57773#discussion_r2040134851
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/57773
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F57773
https://github.com/ljharb
ljharb https://github.com/ljharb
https://github.com/nodejs/node/pull/57773/files/48c9e3c66f2681a53a78ac75b4a7e521abd2cf3b
esm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Please reload this pagehttps://github.com/nodejs/node/pull/57773
https://github.com/cyyynthia
https://github.com/nodejs-github-bot
https://github.com/mcollina
https://github.com/ljharb
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.