René's URL Explorer Experiment


Title: dns: refactor dns to more modern JavaScript by benjamingr · Pull Request #5762 · nodejs/node · GitHub

Open Graph Title: dns: refactor dns to more modern JavaScript by benjamingr · Pull Request #5762 · nodejs/node

X Title: dns: refactor dns to more modern JavaScript by benjamingr · Pull Request #5762 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Pull Request check-list Affected core subsystem(s) dns Description of change The current dns.js file contains some pretty outdated JavaScript practices - this pull request aims to improve the file ...

X Description: Pull Request check-list Affected core subsystem(s) dns Description of change The current dns.js file contains some pretty outdated JavaScript practices - this pull request aims to improve the file ...

Opengraph URL: https://github.com/nodejs/node/pull/5762

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:4048d85b-a0c3-acaf-5727-bddf49feee9d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDCEE:50FD4:48A2ECB:6586802:6A4F7BF8
html-safe-nonce929c3d78c0746875c49818a78b00568f7b078b3a40d4c574f41b493ef8bb539a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQ0VFOjUwRkQ0OjQ4QTJFQ0I6NjU4NjgwMjo2QTRGN0JGOCIsInZpc2l0b3JfaWQiOiI0MzU1MjIwOTg1OTU3Mjg0ODU2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac88b9bf20f3da4c213baa39c142d040e9cdecbbd4f2898e3706f8e852baccb70d
hovercard-subject-tagpull_request:63258060
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/5762/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/60756cbb0abf563abbadf792cace4eb0a66023021688ffdb8a4d33cd47ebb7cb/nodejs/node/pull/5762
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/60756cbb0abf563abbadf792cace4eb0a66023021688ffdb8a4d33cd47ebb7cb/nodejs/node/pull/5762
og:image:altPull Request check-list Affected core subsystem(s) dns Description of change The current dns.js file contains some pretty outdated JavaScript practices - this pull request aims to improve the file ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebenjamingr
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/5762#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F5762
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F5762
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/5762
Reloadhttps://github.com/nodejs/node/pull/5762
Reloadhttps://github.com/nodejs/node/pull/5762
Please reload this pagehttps://github.com/nodejs/node/pull/5762
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/5762
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 973 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
benjamingrhttps://github.com/benjamingr
nodejs:masterhttps://github.com/nodejs/node/tree/master
benjamingr:dns-refactorhttps://github.com/benjamingr/io.js/tree/dns-refactor
Conversationhttps://github.com/nodejs/node/pull/5762
Commits11 (11)https://github.com/nodejs/node/pull/5762/commits
Checkshttps://github.com/nodejs/node/pull/5762/checks
Files changedhttps://github.com/nodejs/node/pull/5762/files
dns: refactor dns to more modern JavaScripthttps://github.com/nodejs/node/pull/5762#top
benjamingrhttps://github.com/benjamingr
nodejs:masterhttps://github.com/nodejs/node/tree/master
benjamingr:dns-refactorhttps://github.com/benjamingr/io.js/tree/dns-refactor
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Mar 17, 2016https://github.com/nodejs/node/pull/5762#issue-141645578
Please reload this pagehttps://github.com/nodejs/node/pull/5762
benjamingrhttps://github.com/benjamingr
March 17, 2016 18:58https://github.com/nodejs/node/pull/5762#commits-pushed-8d6c22e
https://github.com/benjamingr
initial work - normalize if/else stylehttps://github.com/nodejs/node/pull/5762/commits/8d6c22e493820255d1fddb27c9fd169032870f41
8d6c22ehttps://github.com/nodejs/node/pull/5762/commits/8d6c22e493820255d1fddb27c9fd169032870f41
https://github.com/benjamingr
more template strings and less abused returnshttps://github.com/nodejs/node/pull/5762/commits/f5c4f55fb96ca56e650f2404580009946b13709f
f5c4f55https://github.com/nodejs/node/pull/5762/commits/f5c4f55fb96ca56e650f2404580009946b13709f
https://github.com/benjamingr
block over for loop, spread arguments from applyhttps://github.com/nodejs/node/pull/5762/commits/2784847fc6b2ca60e89fd4c941b6f63fc7fb4b67
2784847https://github.com/nodejs/node/pull/5762/commits/2784847fc6b2ca60e89fd4c941b6f63fc7fb4b67
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
dns https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adns
dont-land-on-v5.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v5.x
Mar 17, 2016https://github.com/nodejs/node/pull/5762#event-593735005
mscdexhttps://github.com/mscdex
Mar 17, 2016 https://github.com/nodejs/node/pull/5762#discussion-diff-56550566
View reviewed changes https://github.com/nodejs/node/pull/5762/files/2784847fc6b2ca60e89fd4c941b6f63fc7fb4b67#diff-b8086b209233eccf9f74c4d6a38cac729b52c507ef60afb2e4597544700cf110
lib/dns.jshttps://github.com/nodejs/node/pull/5762/files#diff-b8086b209233eccf9f74c4d6a38cac729b52c507ef60afb2e4597544700cf110
mscdexhttps://github.com/mscdex
Mar 17, 2016https://github.com/nodejs/node/pull/5762#discussion_r56550566
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/5762
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Mar 17, 2016https://github.com/nodejs/node/pull/5762#issuecomment-198009755
Please reload this pagehttps://github.com/nodejs/node/pull/5762
benjamingrhttps://github.com/benjamingr
March 17, 2016 20:25https://github.com/nodejs/node/pull/5762#commits-pushed-48fde13
https://github.com/benjamingr
address commentshttps://github.com/nodejs/node/pull/5762/commits/48fde13751ad777302751495d89791bbbfb2380f
48fde13https://github.com/nodejs/node/pull/5762/commits/48fde13751ad777302751495d89791bbbfb2380f
https://github.com/benjamingr
address comments from mscdexhttps://github.com/nodejs/node/pull/5762/commits/bfe0f40fe261747cc2da0e53040e72919f9138a0
bfe0f40https://github.com/nodejs/node/pull/5762/commits/bfe0f40fe261747cc2da0e53040e72919f9138a0
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Mar 17, 2016https://github.com/nodejs/node/pull/5762#issuecomment-198019225
@mscdexhttps://github.com/mscdex
Please reload this pagehttps://github.com/nodejs/node/pull/5762
benjamingrhttps://github.com/benjamingr
March 17, 2016 20:49https://github.com/nodejs/node/pull/5762#commits-pushed-2d54ae9
https://github.com/benjamingr
refactor forEach to maphttps://github.com/nodejs/node/pull/5762/commits/2d54ae9ebe9241dbf1dbc649dc0de162784d9344
2d54ae9https://github.com/nodejs/node/pull/5762/commits/2d54ae9ebe9241dbf1dbc649dc0de162784d9344
https://github.com/benjamingr
var to consthttps://github.com/nodejs/node/pull/5762/commits/85f9b8718af7ccd5eeee4dff7cc7022ee885eb65
85f9b87https://github.com/nodejs/node/pull/5762/commits/85f9b8718af7ccd5eeee4dff7cc7022ee885eb65
https://github.com/benjamingr
removed references to net modulehttps://github.com/nodejs/node/pull/5762/commits/457de39ca7279a29e725abdf33c7ebb2c9e26d05
457de39https://github.com/nodejs/node/pull/5762/commits/457de39ca7279a29e725abdf33c7ebb2c9e26d05
mscdexhttps://github.com/mscdex
Mar 17, 2016 https://github.com/nodejs/node/pull/5762#discussion-diff-56559026
View reviewed changes https://github.com/nodejs/node/pull/5762/files/2784847fc6b2ca60e89fd4c941b6f63fc7fb4b67..85f9b8718af7ccd5eeee4dff7cc7022ee885eb65#diff-b8086b209233eccf9f74c4d6a38cac729b52c507ef60afb2e4597544700cf110
lib/dns.jshttps://github.com/nodejs/node/pull/5762/files#diff-b8086b209233eccf9f74c4d6a38cac729b52c507ef60afb2e4597544700cf110
mscdexhttps://github.com/mscdex
Mar 17, 2016https://github.com/nodejs/node/pull/5762#discussion_r56559026
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/5762
benjamingrhttps://github.com/benjamingr
Mar 17, 2016https://github.com/nodejs/node/pull/5762#discussion_r56559719
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/5762
https://github.com/benjamingr
changed {} to Object.create(null) to prevent __proto__ meddlinghttps://github.com/nodejs/node/pull/5762/commits/4f124f71328457a00b3e7c64f6818f3c100772fb
4f124f7https://github.com/nodejs/node/pull/5762/commits/4f124f71328457a00b3e7c64f6818f3c100772fb
mscdexhttps://github.com/mscdex
Mar 17, 2016 https://github.com/nodejs/node/pull/5762#discussion-diff-56559308
View reviewed changes https://github.com/nodejs/node/pull/5762/files/2784847fc6b2ca60e89fd4c941b6f63fc7fb4b67..85f9b8718af7ccd5eeee4dff7cc7022ee885eb65#diff-b8086b209233eccf9f74c4d6a38cac729b52c507ef60afb2e4597544700cf110
lib/dns.jshttps://github.com/nodejs/node/pull/5762/files#diff-b8086b209233eccf9f74c4d6a38cac729b52c507ef60afb2e4597544700cf110
mscdexhttps://github.com/mscdex
Mar 17, 2016https://github.com/nodejs/node/pull/5762#discussion_r56559308
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/5762
williamkapkehttps://github.com/williamkapke
Mar 17, 2016https://github.com/nodejs/node/pull/5762#discussion_r56559900
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@mscdexhttps://github.com/mscdex
Please reload this pagehttps://github.com/nodejs/node/pull/5762
benjamingrhttps://github.com/benjamingr
Mar 17, 2016https://github.com/nodejs/node/pull/5762#discussion_r56559924
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/5762
mscdexhttps://github.com/mscdex
Mar 17, 2016https://github.com/nodejs/node/pull/5762#discussion_r56560333
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
net.isIP()https://nodejs.org/docs/latest/api/net.html#net_net_isip_input
Please reload this pagehttps://github.com/nodejs/node/pull/5762
benjamingrhttps://github.com/benjamingr
Mar 17, 2016https://github.com/nodejs/node/pull/5762#discussion_r56563075
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/5762
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Mar 17, 2016https://github.com/nodejs/node/pull/5762#issuecomment-198034493
@benjamingrhttps://github.com/benjamingr
Please reload this pagehttps://github.com/nodejs/node/pull/5762
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Mar 17, 2016https://github.com/nodejs/node/pull/5762#issuecomment-198036189
@mscdexhttps://github.com/mscdex
Please reload this pagehttps://github.com/nodejs/node/pull/5762
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Mar 17, 2016https://github.com/nodejs/node/pull/5762#issuecomment-198036950
@benjamingrhttps://github.com/benjamingr
Please reload this pagehttps://github.com/nodejs/node/pull/5762
williamkapkehttps://github.com/williamkapke
Mar 17, 2016 https://github.com/nodejs/node/pull/5762#discussion-diff-56560811
View reviewed changes https://github.com/nodejs/node/pull/5762/files/4f124f71328457a00b3e7c64f6818f3c100772fb#diff-b8086b209233eccf9f74c4d6a38cac729b52c507ef60afb2e4597544700cf110
lib/dns.jshttps://github.com/nodejs/node/pull/5762/files#diff-b8086b209233eccf9f74c4d6a38cac729b52c507ef60afb2e4597544700cf110
williamkapkehttps://github.com/williamkapke
Mar 17, 2016https://github.com/nodejs/node/pull/5762#discussion_r56560811
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/5762
benjamingrhttps://github.com/benjamingr
Mar 17, 2016https://github.com/nodejs/node/pull/5762#discussion_r56562737
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@thefourtheyehttps://github.com/thefourtheye
Please reload this pagehttps://github.com/nodejs/node/pull/5762
thefourtheyehttps://github.com/thefourtheye
Mar 17, 2016https://github.com/nodejs/node/pull/5762#discussion_r56567910
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/5762
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Mar 17, 2016https://github.com/nodejs/node/pull/5762#issuecomment-198038431
@mscdexhttps://github.com/mscdex
Please reload this pagehttps://github.com/nodejs/node/pull/5762
https://github.com/vkurchatkin
vkurchatkinhttps://github.com/vkurchatkin
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
Mar 17, 2016https://github.com/nodejs/node/pull/5762#event-593918644
https://github.com/silverwind
silverwindhttps://github.com/silverwind
Mar 17, 2016https://github.com/nodejs/node/pull/5762#issuecomment-198042303
@benjamingrhttps://github.com/benjamingr
thishttps://github.com/airbnb/javascript
Please reload this pagehttps://github.com/nodejs/node/pull/5762
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Mar 17, 2016https://github.com/nodejs/node/pull/5762#issuecomment-198043232
Please reload this pagehttps://github.com/nodejs/node/pull/5762
https://github.com/benjamingr
remove isValidIp and check for 0 insteadhttps://github.com/nodejs/node/pull/5762/commits/6fe93ed8063458928d8851e60eaca9190eb35571
6fe93edhttps://github.com/nodejs/node/pull/5762/commits/6fe93ed8063458928d8851e60eaca9190eb35571
r-52https://github.com/r-52
Mar 17, 2016 https://github.com/nodejs/node/pull/5762#discussion-diff-56563782
View reviewed changes https://github.com/nodejs/node/pull/5762/files/6fe93ed8063458928d8851e60eaca9190eb35571#diff-b8086b209233eccf9f74c4d6a38cac729b52c507ef60afb2e4597544700cf110
lib/dns.jshttps://github.com/nodejs/node/pull/5762/files#diff-b8086b209233eccf9f74c4d6a38cac729b52c507ef60afb2e4597544700cf110
r-52https://github.com/r-52
Mar 17, 2016https://github.com/nodejs/node/pull/5762#discussion_r56563782
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/5762
benjamingrhttps://github.com/benjamingr
Mar 17, 2016https://github.com/nodejs/node/pull/5762#discussion_r56564444
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/5762
https://github.com/benjamingr
silly mistake missing $https://github.com/nodejs/node/pull/5762/commits/b3ced41b324f6baba0f4e32e7f62c6424bc8cd6c
b3ced41https://github.com/nodejs/node/pull/5762/commits/b3ced41b324f6baba0f4e32e7f62c6424bc8cd6c
https://github.com/Trott
Trotthttps://github.com/Trott
Mar 18, 2016https://github.com/nodejs/node/pull/5762#issuecomment-198203488
@vkurchatkinhttps://github.com/vkurchatkin
Please reload this pagehttps://github.com/nodejs/node/pull/5762
https://github.com/Trott
Trotthttps://github.com/Trott
Mar 18, 2016 https://github.com/nodejs/node/pull/5762#ref-pullrequest-141777651
src,tools: use template literals #5778 https://github.com/nodejs/node/pull/5778
https://github.com/Trott
Trotthttps://github.com/Trott
Mar 18, 2016https://github.com/nodejs/node/pull/5762#issuecomment-198211079
@mscdexhttps://github.com/mscdex
#5778https://github.com/nodejs/node/pull/5778
Please reload this pagehttps://github.com/nodejs/node/pull/5762
mscdexhttps://github.com/mscdex
Mar 18, 2016 https://github.com/nodejs/node/pull/5762#discussion-diff-56615266
View reviewed changes https://github.com/nodejs/node/pull/5762/files/b3ced41b324f6baba0f4e32e7f62c6424bc8cd6c#diff-b8086b209233eccf9f74c4d6a38cac729b52c507ef60afb2e4597544700cf110
lib/dns.jshttps://github.com/nodejs/node/pull/5762/files#diff-b8086b209233eccf9f74c4d6a38cac729b52c507ef60afb2e4597544700cf110
mscdexhttps://github.com/mscdex
Mar 18, 2016https://github.com/nodejs/node/pull/5762#discussion_r56615266
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/5762
benjamingrhttps://github.com/benjamingr
Mar 18, 2016https://github.com/nodejs/node/pull/5762#discussion_r56647054
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/5762
https://github.com/r-52
r-52https://github.com/r-52
Mar 18, 2016https://github.com/nodejs/node/pull/5762#issuecomment-198218187
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/5762
https://github.com/vkurchatkin
vkurchatkinhttps://github.com/vkurchatkin
Mar 18, 2016https://github.com/nodejs/node/pull/5762#issuecomment-198229144
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/5762
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
dont-land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x
Mar 18, 2016https://github.com/nodejs/node/pull/5762#event-594786522
jasnellhttps://github.com/jasnell
Mar 18, 2016 https://github.com/nodejs/node/pull/5762#discussion-diff-56693050
View reviewed changes https://github.com/nodejs/node/pull/5762/files/b3ced41b324f6baba0f4e32e7f62c6424bc8cd6c#diff-b8086b209233eccf9f74c4d6a38cac729b52c507ef60afb2e4597544700cf110
lib/dns.jshttps://github.com/nodejs/node/pull/5762/files#diff-b8086b209233eccf9f74c4d6a38cac729b52c507ef60afb2e4597544700cf110
jasnellhttps://github.com/jasnell
Mar 18, 2016https://github.com/nodejs/node/pull/5762#discussion_r56693050
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/5762
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Mar 18, 2016https://github.com/nodejs/node/pull/5762#issuecomment-198464780
Please reload this pagehttps://github.com/nodejs/node/pull/5762
https://github.com/jasnell
jasnellhttps://github.com/jasnell
error-handling https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aerror-handling
Mar 18, 2016https://github.com/nodejs/node/pull/5762#event-595227585
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Mar 18, 2016https://github.com/nodejs/node/pull/5762#issuecomment-198465086
Please reload this pagehttps://github.com/nodejs/node/pull/5762
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Mar 19, 2016https://github.com/nodejs/node/pull/5762#issuecomment-198694954
Please reload this pagehttps://github.com/nodejs/node/pull/5762
https://github.com/Trott
Trotthttps://github.com/Trott
Mar 19, 2016https://github.com/nodejs/node/pull/5762#issuecomment-198758108
Please reload this pagehttps://github.com/nodejs/node/pull/5762
dns: Refactor forEach to map #5803 https://github.com/nodejs/node/pull/5803
dns: use isIp consistently #5804 https://github.com/nodejs/node/pull/5804
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Mar 22, 2016https://github.com/nodejs/node/pull/5762#issuecomment-199728273
#5803https://github.com/nodejs/node/pull/5803
#5804https://github.com/nodejs/node/pull/5804
#5809https://github.com/nodejs/node/pull/5809
Please reload this pagehttps://github.com/nodejs/node/pull/5762
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Mar 22, 2016https://github.com/nodejs/node/pull/5762#event-598432297
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F5762
dns https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adns
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
Please reload this pagehttps://github.com/nodejs/node/pull/5762
https://github.com/benjamingr
https://github.com/mscdex
https://github.com/silverwind
https://github.com/Trott
https://github.com/r-52
https://github.com/vkurchatkin
https://github.com/jasnell
https://github.com/thefourtheye
https://github.com/williamkapke
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.