René's URL Explorer Experiment


Title: buffer: fix buffer alignment restriction by ofrobots · Pull Request #5752 · nodejs/node · GitHub

Open Graph Title: buffer: fix buffer alignment restriction by ofrobots · Pull Request #5752 · nodejs/node

X Title: buffer: fix buffer alignment restriction by ofrobots · Pull Request #5752 · nodejs/node

Description: Pull Request check-list Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with this change (including linting)? Is the commit message formatted according to CONTRIBUTING.md? If this change fixes a bug (or a performance problem), is a regression test (or a benchmark) included? Affected core subsystem(s) buffer Description of change @addaleax recently reported that recent phantom weakness changes (ebbbc5a) to buffer break node-ffi and possibly other modules that use create unaligned buffers. It turns out there is a simpler solution possible that doesn't introduce an alignment restriction. This also eliminates the need for Node-core to reserve the first internal field on buffers. Ref: #5204 R=@bnoordhuis, @trevnorris Marking with dont-land-on-* as the pre-requisite change is also marked likewise.

Open Graph Description: Pull Request check-list Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with this change (including linting)? Is the commit message formatted according to CONTRIBUTING.md? If th...

X Description: Pull Request check-list Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with this change (including linting)? Is the commit message formatted according to CONTRIBUTING.md? If th...

Opengraph URL: https://github.com/nodejs/node/pull/5752

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:da9f3a34-5cc9-0d1b-88cc-313d1d004f81
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB498:2CEF6D:54F2B56:774FC0E:6A57221D
html-safe-nonce955e59bf0f0526219bbe012408b13ceb153eab7ee408e0b2d815763084962808
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNDk4OjJDRUY2RDo1NEYyQjU2Ojc3NEZDMEU6NkE1NzIyMUQiLCJ2aXNpdG9yX2lkIjoiNDU5NjUxNDYxOTQ2OTAxMzUzMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacaf3b390fff34b9a984285ccef5d1b862885904409ff5e9f90e104e8fc42b2d58
hovercard-subject-tagpull_request:63161013
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/5752/files
twitter:imagehttps://avatars.githubusercontent.com/u/79017?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/79017?s=400&v=4
og:image:altPull Request check-list Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with this change (including linting)? Is the commit message formatted according to CONTRIBUTING.md? If th...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4e7a7296a3830877cf21a6ad2a972c9e618a48915e03966cf0c53eb08e5aad98
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2576d1f0198cf1588faf2edf27f1ed120903be10
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/5752/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F5752%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F5752%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/5752/files
Reloadhttps://github.com/nodejs/node/pull/5752/files
Reloadhttps://github.com/nodejs/node/pull/5752/files
Please reload this pagehttps://github.com/nodejs/node/pull/5752/files
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/5752/files
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.2k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 1k https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
ofrobotshttps://github.com/ofrobots
nodejs:masterhttps://github.com/nodejs/node/tree/master
ofrobots:fix-buffer-alignment-restrictionhttps://github.com/ofrobots/node/tree/fix-buffer-alignment-restriction
Conversation 21 https://github.com/nodejs/node/pull/5752
Commits 2 https://github.com/nodejs/node/pull/5752/commits
Checks 0 https://github.com/nodejs/node/pull/5752/checks
Files changed https://github.com/nodejs/node/pull/5752/files
Please reload this pagehttps://github.com/nodejs/node/pull/5752/files
buffer: fix buffer alignment restriction https://github.com/nodejs/node/pull/5752/files#top
Show all changes 2 commits https://github.com/nodejs/node/pull/5752/files
3bc8a0b buffer: fix buffer alignment restriction ofrobots Mar 17, 2016 https://github.com/nodejs/node/pull/5752/commits/3bc8a0b3e20d040ad27fa9202593d583b92dd507
662dad4 test: add buffer alignment regression tests addaleax Mar 17, 2016 https://github.com/nodejs/node/pull/5752/commits/662dad47a036683688adde756c9315f3ee2794fb
Clear filters https://github.com/nodejs/node/pull/5752/files
Please reload this pagehttps://github.com/nodejs/node/pull/5752/files
Please reload this pagehttps://github.com/nodejs/node/pull/5752/files
node_buffer.cc https://github.com/nodejs/node/pull/5752/files#diff-81f77f34c4f5b8cc35f1a506808b94e2a281f3341c0f1a38ef2b8a8ba730b22b
node_buffer.h https://github.com/nodejs/node/pull/5752/files#diff-6a309ecfbf94714588e273b440d68cacd751611353fc40fc056d533aa3c8c1f3
binding.cc https://github.com/nodejs/node/pull/5752/files#diff-9f9b582d919b8f7372703596344a5f8c70703206f7eaee3e39e9a5636fe76ded
test.js https://github.com/nodejs/node/pull/5752/files#diff-b826bcd47d4d40fc9903986765e174d3fc3ecb6294f1981a13502cfc44b82add
src/node_buffer.cchttps://github.com/nodejs/node/pull/5752/files#diff-81f77f34c4f5b8cc35f1a506808b94e2a281f3341c0f1a38ef2b8a8ba730b22b
View file https://github.com/ofrobots/node/blob/662dad47a036683688adde756c9315f3ee2794fb/src/node_buffer.cc
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/5752/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/5752/files#diff-81f77f34c4f5b8cc35f1a506808b94e2a281f3341c0f1a38ef2b8a8ba730b22b
https://github.com/nodejs/node/pull/5752/files#diff-81f77f34c4f5b8cc35f1a506808b94e2a281f3341c0f1a38ef2b8a8ba730b22b
https://github.com/nodejs/node/pull/5752/files#diff-81f77f34c4f5b8cc35f1a506808b94e2a281f3341c0f1a38ef2b8a8ba730b22b
https://github.com/nodejs/node/pull/5752/files#diff-81f77f34c4f5b8cc35f1a506808b94e2a281f3341c0f1a38ef2b8a8ba730b22b
https://github.com/nodejs/node/pull/5752/files#diff-81f77f34c4f5b8cc35f1a506808b94e2a281f3341c0f1a38ef2b8a8ba730b22b
https://github.com/nodejs/node/pull/5752/files#diff-81f77f34c4f5b8cc35f1a506808b94e2a281f3341c0f1a38ef2b8a8ba730b22b
src/node_buffer.hhttps://github.com/nodejs/node/pull/5752/files#diff-6a309ecfbf94714588e273b440d68cacd751611353fc40fc056d533aa3c8c1f3
View file https://github.com/ofrobots/node/blob/662dad47a036683688adde756c9315f3ee2794fb/src/node_buffer.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/5752/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/5752/files#diff-6a309ecfbf94714588e273b440d68cacd751611353fc40fc056d533aa3c8c1f3
https://github.com/nodejs/node/pull/5752/files#diff-6a309ecfbf94714588e273b440d68cacd751611353fc40fc056d533aa3c8c1f3
test/addons/buffer-free-callback/binding.cchttps://github.com/nodejs/node/pull/5752/files#diff-9f9b582d919b8f7372703596344a5f8c70703206f7eaee3e39e9a5636fe76ded
View file https://github.com/ofrobots/node/blob/662dad47a036683688adde756c9315f3ee2794fb/test/addons/buffer-free-callback/binding.cc
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/5752/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/5752/files#diff-9f9b582d919b8f7372703596344a5f8c70703206f7eaee3e39e9a5636fe76ded
https://github.com/nodejs/node/pull/5752/files#diff-9f9b582d919b8f7372703596344a5f8c70703206f7eaee3e39e9a5636fe76ded
test/addons/buffer-free-callback/test.jshttps://github.com/nodejs/node/pull/5752/files#diff-b826bcd47d4d40fc9903986765e174d3fc3ecb6294f1981a13502cfc44b82add
View file https://github.com/ofrobots/node/blob/662dad47a036683688adde756c9315f3ee2794fb/test/addons/buffer-free-callback/test.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/5752/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/5752/files#diff-b826bcd47d4d40fc9903986765e174d3fc3ecb6294f1981a13502cfc44b82add
https://github.com/nodejs/node/pull/5752/files#diff-b826bcd47d4d40fc9903986765e174d3fc3ecb6294f1981a13502cfc44b82add
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.