| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:7979bfe8-f478-1c73-4c5f-90339366145d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D14A:7E3A0:13E4E2:1C41C0:696A03D3 |
| html-safe-nonce | 99114c52b92aa229371f882dc8f2cc5e953b8d4aa5c3142f5c6ca56bf18e3337 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMTRBOjdFM0EwOjEzRTRFMjoxQzQxQzA6Njk2QTAzRDMiLCJ2aXNpdG9yX2lkIjoiNzkzNDk4MDkzOTAxMzgxNzI5OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 774d4a6e1086682c99aee6a2f0fb174709e04c69619ccdd27d0be5dcc784e83d |
| hovercard-subject-tag | pull_request:2386129376 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/57417/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/7d3df86a57cd421a63d41016946839547646470a37c58127e74e5a22eee756ae/nodejs/node/pull/57417 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/7d3df86a57cd421a63d41016946839547646470a37c58127e74e5a22eee756ae/nodejs/node/pull/57417 |
| og:image:alt | src: annotate BaseObjects in the heap snapshots correctly
This fixes two issues in the BaseObject views in the heap snapshots:
BaseObjects are not conceptually roots when the environment and
the r... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | joyeecheung |
| hostname | github.com |
| expected-hostname | github.com |
| None | 578c119ff0247c8b2f2491fbf4fc0395cdf909d4df66598cebdc96ddfc4418dc |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 671c2f67171dbced24284331f3133a613d08c366 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/57417#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F57417 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F57417 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/57417 |
| Reload | https://github.com/nodejs/node/pull/57417 |
| Reload | https://github.com/nodejs/node/pull/57417 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/57417 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
697
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/57417 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/57417#issue-comment-box |
| joyeecheung | https://github.com/joyeecheung |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| joyeecheung:baseobject-root | https://github.com/joyeecheung/node/tree/baseobject-root |
|
src: annotate BaseObjects in the heap snapshots correctly
| https://github.com/nodejs/node/pull/57417#top |
| joyeecheung | https://github.com/joyeecheung |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| joyeecheung:baseobject-root | https://github.com/joyeecheung/node/tree/baseobject-root |
|
Conversation
16
| https://github.com/nodejs/node/pull/57417 |
|
Commits
2
| https://github.com/nodejs/node/pull/57417/commits |
|
Checks
36
| https://github.com/nodejs/node/pull/57417/checks |
|
Files changed
| https://github.com/nodejs/node/pull/57417/files |
| Please reload this page | https://github.com/nodejs/node/pull/57417 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Mar 11, 2025 | https://github.com/nodejs/node/pull/57417#issue-2911673488 |
| https://private-user-images.githubusercontent.com/4299420/421541375-4c8e82ab-480f-4933-a815-65d945fc827e.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Njg1NTU3NzUsIm5iZiI6MTc2ODU1NTQ3NSwicGF0aCI6Ii80Mjk5NDIwLzQyMTU0MTM3NS00YzhlODJhYi00ODBmLTQ5MzMtYTgxNS02NWQ5NDVmYzgyN2UucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI2MDExNiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNjAxMTZUMDkyNDM1WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZTE3YzdiY2M3YjJjMTQ2YzQxOWJiMWZhZTk2ODkzNjdjZGI4OTA2OGZiMmVjMmQ3MWNjYTY3ZGFmODQ4ZjVmZSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.NFp0qRu-WfKKGJI5pW7AEG_evmm2NffdkYmQkzP0aIM |
| https://private-user-images.githubusercontent.com/4299420/421542738-688be530-4537-4167-b9f9-c9ad9be8d75c.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Njg1NTU3NzUsIm5iZiI6MTc2ODU1NTQ3NSwicGF0aCI6Ii80Mjk5NDIwLzQyMTU0MjczOC02ODhiZTUzMC00NTM3LTQxNjctYjlmOS1jOWFkOWJlOGQ3NWMucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI2MDExNiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNjAxMTZUMDkyNDM1WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9Y2U2YTJhNjE5OGQ0M2ExNTVhNzM1ODgzYzExNGI1ZTBjMDAyNWI4MWU0ODMxMTIxYjRkZmVhZWMyN2FmZGE2YiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.dCYjZ7wmSkq4TilRXBJGkeqSt4hDboHRzdSJN-HbKfQ |
| https://private-user-images.githubusercontent.com/4299420/421541426-91bbd077-6946-4bf3-9870-df0ccadb39ab.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Njg1NTU3NzUsIm5iZiI6MTc2ODU1NTQ3NSwicGF0aCI6Ii80Mjk5NDIwLzQyMTU0MTQyNi05MWJiZDA3Ny02OTQ2LTRiZjMtOTg3MC1kZjBjY2FkYjM5YWIucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI2MDExNiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNjAxMTZUMDkyNDM1WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MmRlYzZlNjEzMmQ3MWFlZWMwMmJkYjRiMmViODI4NDhhZTBmZTg3ZDFjNWQ5MWU1NzhmN2QwMGVjOWVjNGVmOSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.g9srZmOnjdfPk5TSuFu-UJ62jcqDYeTlhqKhyOcbEfU |
| https://private-user-images.githubusercontent.com/4299420/421541502-c658a3bb-4049-440e-a19c-0f5b947929e8.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Njg1NTU3NzUsIm5iZiI6MTc2ODU1NTQ3NSwicGF0aCI6Ii80Mjk5NDIwLzQyMTU0MTUwMi1jNjU4YTNiYi00MDQ5LTQ0MGUtYTE5Yy0wZjViOTQ3OTI5ZTgucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI2MDExNiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNjAxMTZUMDkyNDM1WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NzBiOWI1MmU1ZmViYTE3OWI0OGQxMjQ5YWVhYmUyOTk3OTYzOTcwMzY4NmY0ZmU2MzE5YTdiMjIxY2FkYjQyZCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.Hl2zFGmW8cH6C-QmFyGLs2llS99P6wIGaIjdRey8pLI |
| Please reload this page | https://github.com/nodejs/node/pull/57417 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
| Mar 11, 2025 | https://github.com/nodejs/node/pull/57417#event-16696229321 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Mar 11, 2025 | https://github.com/nodejs/node/pull/57417#event-16696239811 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Mar 11, 2025 | https://github.com/nodejs/node/pull/57417#event-16696251644 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Mar 11, 2025 | https://github.com/nodejs/node/pull/57417#issuecomment-2715504025 |
| https://ci.nodejs.org/job/node-test-pull-request/65690/ | https://ci.nodejs.org/job/node-test-pull-request/65690/ |
| Please reload this page | https://github.com/nodejs/node/pull/57417 |
| https://github.com/apps/codecov |
| codecov | https://github.com/apps/codecov |
| Mar 11, 2025 | https://github.com/nodejs/node/pull/57417#issuecomment-2715664852 |
| Please reload this page | https://github.com/nodejs/node/pull/57417 |
| Codecov | https://app.codecov.io/gh/nodejs/node/pull/57417?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| (8e4e4df) | https://app.codecov.io/gh/nodejs/node/commit/8e4e4df91a43fe81881e126e9e29de076490c77c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| (11115da) | https://app.codecov.io/gh/nodejs/node/commit/11115da19618f4ec0eb298354a5964d44ec03b58?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| Files with missing lines | https://app.codecov.io/gh/nodejs/node/pull/57417?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| src/base_object-inl.h | https://app.codecov.io/gh/nodejs/node/pull/57417?src=pr&el=tree&filepath=src%2Fbase_object-inl.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL2Jhc2Vfb2JqZWN0LWlubC5o |
| src/base_object.cc | https://app.codecov.io/gh/nodejs/node/pull/57417?src=pr&el=tree&filepath=src%2Fbase_object.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL2Jhc2Vfb2JqZWN0LmNj |
| src/base_object.h | https://app.codecov.io/gh/nodejs/node/pull/57417?src=pr&el=tree&filepath=src%2Fbase_object.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL2Jhc2Vfb2JqZWN0Lmg= |
| 26 files with indirect coverage changes | https://app.codecov.io/gh/nodejs/node/pull/57417/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| Test Analytics | https://docs.codecov.com/docs/test-analytics |
| JS Bundle Analysis | https://docs.codecov.com/docs/javascript-bundle-analysis |
| Please reload this page | https://github.com/nodejs/node/pull/57417 |
| https://github.com/legendecas |
| legendecas | https://github.com/legendecas |
|
Mar 12, 2025
| https://github.com/nodejs/node/pull/57417#pullrequestreview-2678119336 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/57417/files |
| test/pummel/test-heapdump-dns.js | https://github.com/nodejs/node/pull/57417/files#diff-71465ca6f728ccbf7ef03b430bd3d14a8d9ac8da5c6c177ec0e8fdcba52a0a6d |
| Please reload this page | https://github.com/nodejs/node/pull/57417 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Mar 12, 2025 | https://github.com/nodejs/node/pull/57417#issuecomment-2717836993 |
| Please reload this page | https://github.com/nodejs/node/pull/57417 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Mar 13, 2025 | https://github.com/nodejs/node/pull/57417#issuecomment-2721169623 |
| Please reload this page | https://github.com/nodejs/node/pull/57417 |
| node/src/node_realm.cc | https://github.com/nodejs/node/blob/84966703e0f90757d046f3ecfff479c463ad5ab3/src/node_realm.cc#L218 |
| 8496670 | https://github.com/nodejs/node/commit/84966703e0f90757d046f3ecfff479c463ad5ab3 |
| https://github.com/nodejs/node/blob/711f449c51297057df9b263d5133581410e1e9bc/src/base_object.cc#L31-L50 | https://github.com/nodejs/node/blob/711f449c51297057df9b263d5133581410e1e9bc/src/base_object.cc#L31-L50 |
| Please reload this page | https://github.com/nodejs/node/pull/57417 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Mar 13, 2025
| https://github.com/nodejs/node/pull/57417#pullrequestreview-2682996171 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/57417/files |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Mar 15, 2025 | https://github.com/nodejs/node/pull/57417#issuecomment-2727058968 |
| Please reload this page | https://github.com/nodejs/node/pull/57417 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Apr 16, 2025 | https://github.com/nodejs/node/pull/57417#issuecomment-2809723442 |
| Please reload this page | https://github.com/nodejs/node/pull/57417 |
| https://private-user-images.githubusercontent.com/4299420/434361826-fed32d35-2a73-4f54-990e-f1df3cbfa86d.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Njg1NTU3NzYsIm5iZiI6MTc2ODU1NTQ3NiwicGF0aCI6Ii80Mjk5NDIwLzQzNDM2MTgyNi1mZWQzMmQzNS0yYTczLTRmNTQtOTkwZS1mMWRmM2NiZmE4NmQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI2MDExNiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNjAxMTZUMDkyNDM2WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MTc2MmU1MGVjNzVlM2IzNThjYmZmODY5MmZiMGY4NWZmOTYwODAwOTdhM2I4YzMxNmVmY2IzMDg4OTQ0NTcyYyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.fBrR8SOwNB6GOAYTEaQuDClnZGH21LF9-LqvnG_Iy94 |
| Please reload this page | https://github.com/nodejs/node/pull/57417 |
| joyeecheung | https://github.com/joyeecheung |
| April 16, 2025 18:39 | https://github.com/nodejs/node/pull/57417#commits-pushed-c43faca |
|
| https://github.com/joyeecheung |
| test: use validateByRetainingPath in heapdump tests | https://github.com/nodejs/node/pull/57417/commits/c43faca452945672669208cbdeae1df9fe2f9ead |
| c43faca | https://github.com/nodejs/node/pull/57417/commits/c43faca452945672669208cbdeae1df9fe2f9ead |
|
| https://github.com/joyeecheung |
| src: annotate BaseObjects in the heap snapshots correctly | https://github.com/nodejs/node/pull/57417/commits/11115da19618f4ec0eb298354a5964d44ec03b58 |
| 11115da | https://github.com/nodejs/node/pull/57417/commits/11115da19618f4ec0eb298354a5964d44ec03b58 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| force-pushed | https://github.com/nodejs/node/compare/edf1a0cb08db42000fcb9b7481d1eeac5d1894e8..11115da19618f4ec0eb298354a5964d44ec03b58 |
| edf1a0c | https://github.com/nodejs/node/commit/edf1a0cb08db42000fcb9b7481d1eeac5d1894e8 |
| 11115da | https://github.com/nodejs/node/commit/11115da19618f4ec0eb298354a5964d44ec03b58 |
|
Compare
| https://github.com/nodejs/node/compare/edf1a0cb08db42000fcb9b7481d1eeac5d1894e8..11115da19618f4ec0eb298354a5964d44ec03b58 |
| April 16, 2025 16:42 | https://github.com/nodejs/node/pull/57417#event-17292604991 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 16, 2025 | https://github.com/nodejs/node/pull/57417#issuecomment-2810144347 |
| https://ci.nodejs.org/job/node-test-pull-request/66315/ | https://ci.nodejs.org/job/node-test-pull-request/66315/ |
| Please reload this page | https://github.com/nodejs/node/pull/57417 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Apr 18, 2025 | https://github.com/nodejs/node/pull/57417#issuecomment-2815554103 |
| @legendecas | https://github.com/legendecas |
| @jasnell | https://github.com/jasnell |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/57417 |
| https://github.com/legendecas |
| legendecas | https://github.com/legendecas |
|
Apr 18, 2025
| https://github.com/nodejs/node/pull/57417#pullrequestreview-2778748324 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/57417/files/11115da19618f4ec0eb298354a5964d44ec03b58 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Apr 18, 2025 | https://github.com/nodejs/node/pull/57417#issuecomment-2815594191 |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/57417 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Apr 22, 2025 | https://github.com/nodejs/node/pull/57417#issuecomment-2821744376 |
| Please reload this page | https://github.com/nodejs/node/pull/57417 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Apr 25, 2025 | https://github.com/nodejs/node/pull/57417#event-17409127459 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Apr 25, 2025 | https://github.com/nodejs/node/pull/57417#event-17409283637 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 25, 2025 | https://github.com/nodejs/node/pull/57417#issuecomment-2830895535 |
| https://ci.nodejs.org/job/node-test-pull-request/66457/ | https://ci.nodejs.org/job/node-test-pull-request/66457/ |
| Please reload this page | https://github.com/nodejs/node/pull/57417 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 26, 2025 | https://github.com/nodejs/node/pull/57417#issuecomment-2832315670 |
| https://ci.nodejs.org/job/node-test-pull-request/66468/ | https://ci.nodejs.org/job/node-test-pull-request/66468/ |
| Please reload this page | https://github.com/nodejs/node/pull/57417 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
|
commit-queue-rebase
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-rebase |
| Apr 27, 2025 | https://github.com/nodejs/node/pull/57417#event-17424633371 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Apr 27, 2025 | https://github.com/nodejs/node/pull/57417#event-17424640002 |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
Apr 27, 2025
| https://github.com/nodejs/node/pull/57417#ref-commit-e86adad |
|
| https://github.com/joyeecheung |
|
| https://github.com/nodejs-github-bot |
| test: use validateByRetainingPath in heapdump tests | https://github.com/nodejs/node/commit/e86adad759702799433b343a1703168e5bc65a6d |
| e86adad | https://github.com/nodejs/node/commit/e86adad759702799433b343a1703168e5bc65a6d |
| #57417 | https://github.com/nodejs/node/pull/57417 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 27, 2025 | https://github.com/nodejs/node/pull/57417#issuecomment-2833594836 |
| c1b15a4...6e60ab7 | https://github.com/nodejs/node/compare/c1b15a49be8cf4f14cfac3c2a8207e012b97bfd4...6e60ab744e6a1371aa514cb5b6a5cedceb2a706b |
| Please reload this page | https://github.com/nodejs/node/pull/57417 |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
Apr 27, 2025
| https://github.com/nodejs/node/pull/57417#ref-commit-6e60ab7 |
|
| https://github.com/joyeecheung |
|
| https://github.com/nodejs-github-bot |
| src: annotate BaseObjects in the heap snapshots correctly | https://github.com/nodejs/node/commit/6e60ab744e6a1371aa514cb5b6a5cedceb2a706b |
| 6e60ab7 | https://github.com/nodejs/node/commit/6e60ab744e6a1371aa514cb5b6a5cedceb2a706b |
| #57417 | https://github.com/nodejs/node/pull/57417 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Apr 27, 2025 | https://github.com/nodejs/node/pull/57417#event-17424640325 |
| RafaelGSS | https://github.com/RafaelGSS |
|
May 1, 2025
| https://github.com/nodejs/node/pull/57417#ref-commit-b083d0f |
|
| https://github.com/joyeecheung |
|
| https://github.com/RafaelGSS |
| test: use validateByRetainingPath in heapdump tests | https://github.com/nodejs/node/commit/b083d0fd05ef8e79286065301b2ea6f108a551c9 |
| b083d0f | https://github.com/nodejs/node/commit/b083d0fd05ef8e79286065301b2ea6f108a551c9 |
| #57417 | https://github.com/nodejs/node/pull/57417 |
| RafaelGSS | https://github.com/RafaelGSS |
|
May 1, 2025
| https://github.com/nodejs/node/pull/57417#ref-commit-ac2e08b |
|
| https://github.com/joyeecheung |
|
| https://github.com/RafaelGSS |
| src: annotate BaseObjects in the heap snapshots correctly | https://github.com/nodejs/node/commit/ac2e08bc2eefe78121a6112a24282b352bcb5d1a |
| ac2e08b | https://github.com/nodejs/node/commit/ac2e08bc2eefe78121a6112a24282b352bcb5d1a |
| #57417 | https://github.com/nodejs/node/pull/57417 |
| https://github.com/RafaelGSS |
| RafaelGSS | https://github.com/RafaelGSS |
|
May 1, 2025
| https://github.com/nodejs/node/pull/57417#ref-pullrequest-2944269169 |
|
2025-05-06, Version 24.0.0 (Current)
#57609
| https://github.com/nodejs/node/pull/57609 |
| RafaelGSS | https://github.com/RafaelGSS |
|
May 2, 2025
| https://github.com/nodejs/node/pull/57417#ref-commit-3457aee |
|
| https://github.com/joyeecheung |
|
| https://github.com/RafaelGSS |
| test: use validateByRetainingPath in heapdump tests | https://github.com/nodejs/node/commit/3457aee0095729d09940d71eb77980197126024f |
| 3457aee | https://github.com/nodejs/node/commit/3457aee0095729d09940d71eb77980197126024f |
| #57417 | https://github.com/nodejs/node/pull/57417 |
| RafaelGSS | https://github.com/RafaelGSS |
|
May 2, 2025
| https://github.com/nodejs/node/pull/57417#ref-commit-cfb39b9 |
|
| https://github.com/joyeecheung |
|
| https://github.com/RafaelGSS |
| src: annotate BaseObjects in the heap snapshots correctly | https://github.com/nodejs/node/commit/cfb39b9adb46fc02c33ff6ab36f79afa1f377f59 |
| cfb39b9 | https://github.com/nodejs/node/commit/cfb39b9adb46fc02c33ff6ab36f79afa1f377f59 |
| #57417 | https://github.com/nodejs/node/pull/57417 |
| aduh95 | https://github.com/aduh95 |
|
May 6, 2025
| https://github.com/nodejs/node/pull/57417#ref-commit-b6b78f6 |
|
| https://github.com/joyeecheung |
|
| https://github.com/aduh95 |
| src: annotate BaseObjects in the heap snapshots correctly | https://github.com/nodejs/node/commit/b6b78f694c8ec4c712ce489d773bbbc91c1ac3f3 |
| b6b78f6 | https://github.com/nodejs/node/commit/b6b78f694c8ec4c712ce489d773bbbc91c1ac3f3 |
| #57417 | https://github.com/nodejs/node/pull/57417 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
backport-requested-v22.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v22.x |
| May 6, 2025 | https://github.com/nodejs/node/pull/57417#event-17545214642 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| May 6, 2025 | https://github.com/nodejs/node/pull/57417#issuecomment-2856219438 |
| https://github.com/nodejs/node/actions/runs/14868900356/job/41752483961 | https://github.com/nodejs/node/actions/runs/14868900356/job/41752483961 |
| Please reload this page | https://github.com/nodejs/node/pull/57417 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F57417 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/57417/files/edf1a0cb08db42000fcb9b7481d1eeac5d1894e8 |
|
| https://github.com/legendecas |
|
legendecas
| https://github.com/legendecas |
|
| https://github.com/nodejs/node/pull/57417/files/11115da19618f4ec0eb298354a5964d44ec03b58 |
|
backport-requested-v22.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-requested-v22.x |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
commit-queue-rebase
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-rebase |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
| Please reload this page | https://github.com/nodejs/node/pull/57417 |
|
| https://github.com/joyeecheung |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/addaleax |
|
| https://github.com/jasnell |
|
| https://github.com/aduh95 |
|
| https://github.com/legendecas |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |