René's URL Explorer Experiment


Title: test_runner: ensure proper teardown when tests run without isolation by pmarchini · Pull Request #57394 · nodejs/node · GitHub

Open Graph Title: test_runner: ensure proper teardown when tests run without isolation by pmarchini · Pull Request #57394 · nodejs/node

X Title: test_runner: ensure proper teardown when tests run without isolation by pmarchini · Pull Request #57394 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This should address #57234. Adding the teardown in case of isolation: none addresses this specific issue, and I see no potential negative effects in having it. @cjihrig, was there a reason why we a...

X Description: This should address #57234. Adding the teardown in case of isolation: none addresses this specific issue, and I see no potential negative effects in having it. @cjihrig, was there a reason why we a...

Opengraph URL: https://github.com/nodejs/node/pull/57394

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b33e1f22-d1d6-8b10-a085-917b8190f65e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD894:2B6F5F:2A2CC9C:3B7A593:6AED2021
html-safe-noncedee8b8a2097b8fb0e01b1a5739eb89bf0f41a44b5d59ebdb5cbcbc34b0a09ae1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEODk0OjJCNkY1RjoyQTJDQzlDOjNCN0E1OTM6NkFFRDIwMjEiLCJ2aXNpdG9yX2lkIjoiNTI5MzIxMjIwMzg0NDcwNjMzNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb6a85140d45279f8bfdc2afad209aa9953e9d6b41b741add31c8cab292d81142
hovercard-subject-tagpull_request:2380905300
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/57394/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/55aa0d66750fe88b754669dec72fb35bbbb4acc2affcd9b98fb6620c72c63de4/nodejs/node/pull/57394
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/55aa0d66750fe88b754669dec72fb35bbbb4acc2affcd9b98fb6620c72c63de4/nodejs/node/pull/57394
og:image:altThis should address #57234. Adding the teardown in case of isolation: none addresses this specific issue, and I see no potential negative effects in having it. @cjihrig, was there a reason why we a...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepmarchini
hostnamegithub.com
expected-hostnamegithub.com
Nonee3e0f7f63e50c6fe879198a93a0a023a648ecc0a5e9bc3b5e033ac57172237e6
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release707a24b346ac8a82878b9c084efaa38a997660cb
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/57394#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F57394
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F57394
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/57394
Reloadhttps://github.com/nodejs/node/pull/57394
Reloadhttps://github.com/nodejs/node/pull/57394
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues656 (656)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
pmarchinihttps://github.com/pmarchini
nodejs:mainhttps://github.com/nodejs/node/tree/main
pmarchini:test_runner/57234https://github.com/pmarchini/node/tree/test_runner/57234
Conversationhttps://github.com/nodejs/node/pull/57394
Commits1 (1)https://github.com/nodejs/node/pull/57394/commits
Checkshttps://github.com/nodejs/node/pull/57394/checks
Files changedhttps://github.com/nodejs/node/pull/57394/files
test_runner: ensure proper teardown when tests run without isolationhttps://github.com/nodejs/node/pull/57394#top
pmarchinihttps://github.com/pmarchini
nodejs:mainhttps://github.com/nodejs/node/tree/main
pmarchini:test_runner/57234https://github.com/pmarchini/node/tree/test_runner/57234
https://github.com/pmarchini
pmarchinihttps://github.com/pmarchini
Mar 9, 2025https://github.com/nodejs/node/pull/57394#issue-2905726158
#57234https://github.com/nodejs/node/issues/57234
@cjihrighttps://github.com/cjihrig
Please reload this pagehttps://github.com/nodejs/node/pull/57394
https://github.com/pmarchini
test_runner: ensure proper teardown when tests run without isolationhttps://github.com/nodejs/node/pull/57394/commits/dd7af59445ddc5a1b3634cf7ffb4bcab3ba06c1b
dd7af59https://github.com/nodejs/node/pull/57394/commits/dd7af59445ddc5a1b3634cf7ffb4bcab3ba06c1b
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Mar 9, 2025https://github.com/nodejs/node/pull/57394#issuecomment-2709112864
Please reload this pagehttps://github.com/nodejs/node/pull/57394
https://github.com/pmarchini
pmarchinihttps://github.com/pmarchini
cjihrighttps://github.com/cjihrig
March 9, 2025 22:49https://github.com/nodejs/node/pull/57394#event-16646258555
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
test_runner https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest_runner
Mar 9, 2025https://github.com/nodejs/node/pull/57394#event-16646258704
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Mar 9, 2025https://github.com/nodejs/node/pull/57394#issuecomment-2709142827
Please reload this pagehttps://github.com/nodejs/node/pull/57394
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/57394?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
9df0ff7https://app.codecov.io/gh/nodejs/node/commit/9df0ff7015bed1613c09cc0b15b76390d21ee178?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
dd7af59https://app.codecov.io/gh/nodejs/node/commit/dd7af59445ddc5a1b3634cf7ffb4bcab3ba06c1b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/57394?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/internal/test_runner/runner.jshttps://app.codecov.io/gh/nodejs/node/pull/57394?src=pr&el=tree&filepath=lib%2Finternal%2Ftest_runner%2Frunner.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2ludGVybmFsL3Rlc3RfcnVubmVyL3J1bm5lci5qcw==
22 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/57394/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/nodejs/node/pull/57394
https://github.com/pmarchini
pmarchinihttps://github.com/pmarchini
Mar 10, 2025https://github.com/nodejs/node/pull/57394#issuecomment-2709759642
node/test/parallel/test-runner-extraneous-async-activity.jshttps://github.com/nodejs/node/blob/96457b433fb1b9cdcc7d957914ae815aa40a5c78/test/parallel/test-runner-extraneous-async-activity.js#L52-L68
96457b4https://github.com/nodejs/node/commit/96457b433fb1b9cdcc7d957914ae815aa40a5c78
Please reload this pagehttps://github.com/nodejs/node/pull/57394
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Mar 27, 2025 https://github.com/nodejs/node/pull/57394#pullrequestreview-2722578054
View reviewed changes https://github.com/nodejs/node/pull/57394/files/dd7af59445ddc5a1b3634cf7ffb4bcab3ba06c1b
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/57394#pullrequestreview-2722578054
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/57394
https://github.com/MoLow
MoLowhttps://github.com/MoLow
Apr 1, 2025 https://github.com/nodejs/node/pull/57394#pullrequestreview-2732144367
View reviewed changes https://github.com/nodejs/node/pull/57394/files/dd7af59445ddc5a1b3634cf7ffb4bcab3ba06c1b
https://github.com/JakobJingleheimer
JakobJingleheimerhttps://github.com/JakobJingleheimer
Mar 8, 2026 https://github.com/nodejs/node/pull/57394#ref-pullrequest-4006413095
test_runner: fix run() none-isolation teardown hang #62056 https://github.com/nodejs/node/pull/62056
https://github.com/inoway46
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F57394
https://github.com/inukshuk
inukshukhttps://github.com/inukshuk
Mar 15, 2026 https://github.com/nodejs/node/pull/57394#ref-pullrequest-4079445918
test_runner: use run() options with isolation="none" #62269 https://github.com/nodejs/node/pull/62269
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jul 28, 2026https://github.com/nodejs/node/pull/57394#issuecomment-5098370845
Please reload this pagehttps://github.com/nodejs/node/pull/57394
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
stale https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astale
Jul 28, 2026https://github.com/nodejs/node/pull/57394#event-28569577312
https://github.com/inukshuk
inukshukhttps://github.com/inukshuk
Jul 28, 2026https://github.com/nodejs/node/pull/57394#issuecomment-5102371495
like emitting a fake 'beforeExit' after the testshttps://github.com/inukshuk/spark/blob/main/lib/runner.js#L13
#62269https://github.com/nodejs/node/pull/62269
Please reload this pagehttps://github.com/nodejs/node/pull/57394
https://github.com/pmarchini
pmarchinihttps://github.com/pmarchini
Jul 28, 2026https://github.com/nodejs/node/pull/57394#issuecomment-5108839374
@inukshukhttps://github.com/inukshuk
Please reload this pagehttps://github.com/nodejs/node/pull/57394
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
stale https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astale
Jul 29, 2026https://github.com/nodejs/node/pull/57394#event-28632183635
https://github.com/avivkeller
avivkellerhttps://github.com/avivkeller
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jul 30, 2026https://github.com/nodejs/node/pull/57394#event-28745680181
https://github.com/avivkeller
avivkellerhttps://github.com/avivkeller
Jul 30, 2026 https://github.com/nodejs/node/pull/57394#pullrequestreview-4823319548
View reviewed changes https://github.com/nodejs/node/pull/57394/files/dd7af59445ddc5a1b3634cf7ffb4bcab3ba06c1b
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jul 30, 2026https://github.com/nodejs/node/pull/57394#event-28746388104
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 30, 2026https://github.com/nodejs/node/pull/57394#issuecomment-5136557512
https://ci.nodejs.org/job/node-test-pull-request/75318/https://ci.nodejs.org/job/node-test-pull-request/75318/
Please reload this pagehttps://github.com/nodejs/node/pull/57394
https://github.com/aduh95
aduh95https://github.com/aduh95
Aug 5, 2026https://github.com/nodejs/node/pull/57394#issuecomment-5194139349
Please reload this pagehttps://github.com/nodejs/node/pull/57394
https://github.com/aduh95
aduh95https://github.com/aduh95
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Aug 5, 2026https://github.com/nodejs/node/pull/57394#event-29019841345
https://github.com/apps/coderabbitai
coderabbitaihttps://github.com/apps/coderabbitai
Sep 23, 2026 https://github.com/nodejs/node/pull/57394#ref-pullrequest-5559531963
fix: schedule jobs from their last run so restarts and saves can't postpone them Migz93/pacearr#179 https://github.com/Migz93/pacearr/pull/179
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F57394
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/57394/files/dd7af59445ddc5a1b3634cf7ffb4bcab3ba06c1b
https://github.com/MoLow
MoLow https://github.com/MoLow
https://github.com/nodejs/node/pull/57394/files/dd7af59445ddc5a1b3634cf7ffb4bcab3ba06c1b
https://github.com/avivkeller
avivkeller https://github.com/avivkeller
https://github.com/nodejs/node/pull/57394/files/dd7af59445ddc5a1b3634cf7ffb4bcab3ba06c1b
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
Please reload this pagehttps://github.com/nodejs/node/pull/57394
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
test_runner https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest_runner
Please reload this pagehttps://github.com/nodejs/node/pull/57394
https://github.com/pmarchini
https://github.com/nodejs-github-bot
https://github.com/inoway46
https://github.com/inukshuk
https://github.com/aduh95
https://github.com/mcollina
https://github.com/MoLow
https://github.com/avivkeller
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.