René's URL Explorer Experiment

Title: inspector: skip promise hook in the inspector async hook by joyeecheung · Pull Request #57148 · nodejs/node · GitHub

Open Graph Title: inspector: skip promise hook in the inspector async hook by joyeecheung · Pull Request #57148 · nodejs/node

X Title: inspector: skip promise hook in the inspector async hook by joyeecheung · Pull Request #57148 · nodejs/node

Description: Instead of filtering out promises in the async hooks added for async task tracking, add an internal path to skip adding the promise hook completely for the inspector async hook. The actual user-land promise tracking is already handled by V8 inspector. This prevents the internal promise hook from showing up and creating unnecessary noise when stepping into async execution in the inspector. Refs: https://issues.chromium.org/issues/390581540 Quoting myself from the DevTools issue: From some code archeology my guess is: Node.js uses its own async hooks to call asyncTaskScheduled for all the async tasks so that they show up in the inspector #13870 The Node.js async hooks implementation unconditionally adds Promise hooks because the API is designed in a way that allows all promises to pass through the hook (with resource type being "Promise" that allows users to filter through) The implementation in 1 does not actually need the promise hooks unconditionally set in 2. In fact it is counter-productive as Node.js needs to filter them out to avoid extra counting in the inspector #17118 I think it can probably be cleaned up by just carving out some internal path in the Node.js async hooks implementation to skip that useless promise hook. When running node --inspect-brk await.mjs on this snippet const test = await Promise.resolve('test') console.log(test); Previously, this is what you'd see in the Chrome DevTools After this patch

Open Graph Description: Instead of filtering out promises in the async hooks added for async task tracking, add an internal path to skip adding the promise hook completely for the inspector async hook. The actual user-lan...

X Description: Instead of filtering out promises in the async hooks added for async task tracking, add an internal path to skip adding the promise hook completely for the inspector async hook. The actual user-lan...

Opengraph URL: https://github.com/nodejs/node/pull/57148

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width