| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:57b29f80-a57a-f1ff-101d-56d79b883224 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B150:282357:19C9655:23F93FD:6A4CBE93 |
| html-safe-nonce | 7e2be2504d533fc2468a4c902f1c578541a88a62705c3886ad6f966970d7fcbc |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMTUwOjI4MjM1NzoxOUM5NjU1OjIzRjkzRkQ6NkE0Q0JFOTMiLCJ2aXNpdG9yX2lkIjoiNzY0MTE3MzQ4ODE3NzkzNDciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 2973f2b8a85656ad69ccc4cb993ed600a32d59e204e1ff04d58d718289ec9272 |
| hovercard-subject-tag | pull_request:2318879932 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/56934/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/77f12205f0272167a238b90d14a80d1d216a9bbddf6200db87850961fda5861b/nodejs/node/pull/56934 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/77f12205f0272167a238b90d14a80d1d216a9bbddf6200db87850961fda5861b/nodejs/node/pull/56934 |
| og:image:alt | This is a fresh version of PR #56117
Update fs.rmSync to properly handle file paths that include non-ASCII characters. This change prevents crashes and errors when attempting to delete files with i... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Yeaseen |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3d11bb817438277de2a940854450e83a7d32b6aeb5014e9e6b00a6423900251c |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | c03e7e569190bc89b638cdd4acb4b6c6b38a170a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/56934#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F56934 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F56934 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/56934 |
| Reload | https://github.com/nodejs/node/pull/56934 |
| Reload | https://github.com/nodejs/node/pull/56934 |
| Please reload this page | https://github.com/nodejs/node/pull/56934 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/56934 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.4k
| https://github.com/nodejs/node/issues |
|
Pull requests
963
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Yeaseen | https://github.com/Yeaseen |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| Conversation | https://github.com/nodejs/node/pull/56934 |
| Commits2 (2) | https://github.com/nodejs/node/pull/56934/commits |
| Checks | https://github.com/nodejs/node/pull/56934/checks |
| Files changed | https://github.com/nodejs/node/pull/56934/files |
| fs: fix rmSync to handle non-ASCII characters | https://github.com/nodejs/node/pull/56934#top |
| Yeaseen | https://github.com/Yeaseen |
| nodejs:main | https://github.com/nodejs/node/tree/main |
|
| https://github.com/Yeaseen |
| Yeaseen | https://github.com/Yeaseen |
| Feb 6, 2025 | https://github.com/nodejs/node/pull/56934#issue-2834359567 |
| Please reload this page | https://github.com/nodejs/node/pull/56934 |
| #56117 | https://github.com/nodejs/node/pull/56117 |
| #56049 | https://github.com/nodejs/node/issues/56049 |
| @lemire | https://github.com/lemire |
| Please reload this page | https://github.com/nodejs/node/pull/56934 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
fs
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
| Feb 6, 2025 | https://github.com/nodejs/node/pull/56934#event-16203108958 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Feb 6, 2025
| https://github.com/nodejs/node/pull/56934#pullrequestreview-2598329255 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/56934/files |
| joyeecheung | https://github.com/joyeecheung |
| https://github.com/nodejs/node/pull/56934#pullrequestreview-2598329255 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/56934 |
| src/node_file.cc | https://github.com/nodejs/node/pull/56934/files#diff-70e3325bd2115867617ae2a16321c5de53c070ff2841976fe5b849675a5111e6 |
| Please reload this page | https://github.com/nodejs/node/pull/56934 |
| https://github.com/Yeaseen |
| Yeaseen | https://github.com/Yeaseen |
| Feb 6, 2025 | https://github.com/nodejs/node/pull/56934#issuecomment-2640073671 |
| @joyeecheung | https://github.com/joyeecheung |
| Please reload this page | https://github.com/nodejs/node/pull/56934 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Feb 6, 2025
| https://github.com/nodejs/node/pull/56934#pullrequestreview-2599238842 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/56934/files/50acccabb495c23f9f83421dc0af613024be4e09 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Feb 6, 2025 | https://github.com/nodejs/node/pull/56934#event-16212805668 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Feb 6, 2025 | https://github.com/nodejs/node/pull/56934#event-16212890568 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Feb 6, 2025 | https://github.com/nodejs/node/pull/56934#issuecomment-2640358256 |
| https://ci.nodejs.org/job/node-test-pull-request/65037/ | https://ci.nodejs.org/job/node-test-pull-request/65037/ |
| Please reload this page | https://github.com/nodejs/node/pull/56934 |
| https://github.com/apps/codecov |
| codecov | https://github.com/apps/codecov |
| Feb 6, 2025 | https://github.com/nodejs/node/pull/56934#issuecomment-2640579945 |
| Please reload this page | https://github.com/nodejs/node/pull/56934 |
| Codecov | https://app.codecov.io/gh/nodejs/node/pull/56934?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| (1671921) | https://app.codecov.io/gh/nodejs/node/commit/1671921c4d8c956a75a3936a7b9e435692058c31?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| (81955c8) | https://app.codecov.io/gh/nodejs/node/commit/81955c867d9c06c6c1fd9ab32a97217124c03f5c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| Files with missing lines | https://app.codecov.io/gh/nodejs/node/pull/56934?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| src/node_file.cc | https://app.codecov.io/gh/nodejs/node/pull/56934?src=pr&el=tree&filepath=src%2Fnode_file.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfZmlsZS5jYw== |
| 5 Missing ⚠️ | https://app.codecov.io/gh/nodejs/node/pull/56934?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| Files with missing lines | https://app.codecov.io/gh/nodejs/node/pull/56934?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| src/api/exceptions.cc | https://app.codecov.io/gh/nodejs/node/pull/56934?src=pr&el=tree&filepath=src%2Fapi%2Fexceptions.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL2FwaS9leGNlcHRpb25zLmNj |
| src/node_file.cc | https://app.codecov.io/gh/nodejs/node/pull/56934?src=pr&el=tree&filepath=src%2Fnode_file.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfZmlsZS5jYw== |
| 26 files with indirect coverage changes | https://app.codecov.io/gh/nodejs/node/pull/56934/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| Please reload this page | https://github.com/nodejs/node/pull/56934 |
| https://github.com/Yeaseen |
| Yeaseen | https://github.com/Yeaseen |
| Feb 6, 2025 | https://github.com/nodejs/node/pull/56934#issuecomment-2640760894 |
| @joyeecheung | https://github.com/joyeecheung |
| Please reload this page | https://github.com/nodejs/node/pull/56934 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Feb 6, 2025 | https://github.com/nodejs/node/pull/56934#issuecomment-2640889780 |
| Please reload this page | https://github.com/nodejs/node/pull/56934 |
| https://github.com/Yeaseen |
| Yeaseen | https://github.com/Yeaseen |
| Feb 6, 2025 | https://github.com/nodejs/node/pull/56934#issuecomment-2641081566 |
| @joyeecheung | https://github.com/joyeecheung |
| Please reload this page | https://github.com/nodejs/node/pull/56934 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Feb 7, 2025
| https://github.com/nodejs/node/pull/56934#pullrequestreview-2600556643 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/56934/files/50acccabb495c23f9f83421dc0af613024be4e09 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Feb 7, 2025 | https://github.com/nodejs/node/pull/56934#issuecomment-2643394475 |
| Please reload this page | https://github.com/nodejs/node/pull/56934 |
| Yeaseen | https://github.com/Yeaseen |
| February 7, 2025 09:32 | https://github.com/nodejs/node/pull/56934#commits-pushed-2d0e9c8 |
|
| https://github.com/Yeaseen |
| fs: fix rmSync to handle non-ASCII characters | https://github.com/nodejs/node/pull/56934/commits/2d0e9c876a1592b8be986b4e221e58ad71c47743 |
| 2d0e9c8 | https://github.com/nodejs/node/pull/56934/commits/2d0e9c876a1592b8be986b4e221e58ad71c47743 |
| #56049 | https://github.com/nodejs/node/issues/56049 |
|
| https://github.com/Yeaseen |
| adressred reviewer suggestions | https://github.com/nodejs/node/pull/56934/commits/50acccabb495c23f9f83421dc0af613024be4e09 |
| 50accca | https://github.com/nodejs/node/pull/56934/commits/50acccabb495c23f9f83421dc0af613024be4e09 |
| https://github.com/Yeaseen |
| Yeaseen | https://github.com/Yeaseen |
| Feb 7, 2025 | https://github.com/nodejs/node/pull/56934#issuecomment-2643428318 |
| @joyeecheung | https://github.com/joyeecheung |
| Please reload this page | https://github.com/nodejs/node/pull/56934 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
|
Feb 7, 2025
| https://github.com/nodejs/node/pull/56934#pullrequestreview-2602833325 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/56934/files/50acccabb495c23f9f83421dc0af613024be4e09 |
| src/node_file.cc | https://github.com/nodejs/node/pull/56934/files/50acccabb495c23f9f83421dc0af613024be4e09#diff-70e3325bd2115867617ae2a16321c5de53c070ff2841976fe5b849675a5111e6 |
| anonrig | https://github.com/anonrig |
| Feb 7, 2025 | https://github.com/nodejs/node/pull/56934#discussion_r1947187509 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/56934 |
| Yeaseen | https://github.com/Yeaseen |
| Feb 7, 2025 | https://github.com/nodejs/node/pull/56934#discussion_r1947284159 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| test file | https://github.com/nodejs/node/blob/50acccabb495c23f9f83421dc0af613024be4e09/test/parallel/test-fs-rmSync-special-char-additional-error.js#L33 |
| Please reload this page | https://github.com/nodejs/node/pull/56934 |
| Yeaseen | https://github.com/Yeaseen |
| Feb 15, 2025 | https://github.com/nodejs/node/pull/56934#discussion_r1957187813 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @anonrig | https://github.com/anonrig |
| Please reload this page | https://github.com/nodejs/node/pull/56934 |
| joyeecheung | https://github.com/joyeecheung |
| May 28, 2025 | https://github.com/nodejs/node/pull/56934#discussion_r2111365982 |
| Please reload this page | https://github.com/nodejs/node/pull/56934 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/56934 |
| src/api/exceptions.cc | https://github.com/nodejs/node/pull/56934/files/50acccabb495c23f9f83421dc0af613024be4e09#diff-d07db40c9fc51ff60b01b853f748cc4acab38087773edae6c69aaa65c3645d8e |
| anonrig | https://github.com/anonrig |
| Feb 7, 2025 | https://github.com/nodejs/node/pull/56934#discussion_r1947188295 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/56934 |
| Yeaseen | https://github.com/Yeaseen |
| Feb 7, 2025 | https://github.com/nodejs/node/pull/56934#discussion_r1947285472 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/56934 |
| joyeecheung | https://github.com/joyeecheung |
| May 28, 2025 | https://github.com/nodejs/node/pull/56934#discussion_r2111371885 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/56934 |
| joyeecheung | https://github.com/joyeecheung |
| May 28, 2025 | https://github.com/nodejs/node/pull/56934#discussion_r2111378097 |
| Please reload this page | https://github.com/nodejs/node/pull/56934 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/56934 |
| https://github.com/Yeaseen |
| Yeaseen | https://github.com/Yeaseen |
| anonrig | https://github.com/anonrig |
| February 22, 2025 10:37 | https://github.com/nodejs/node/pull/56934#event-16412296622 |
| https://github.com/Yeaseen |
| Yeaseen | https://github.com/Yeaseen |
| Feb 25, 2025 | https://github.com/nodejs/node/pull/56934#issuecomment-2683549277 |
| Please reload this page | https://github.com/nodejs/node/pull/56934 |
| @joyeecheung | https://github.com/joyeecheung |
| #56049 | https://github.com/nodejs/node/issues/56049 |
| Please reload this page | https://github.com/nodejs/node/pull/56934 |
| https://github.com/Yuchen-Dai |
| Yuchen-Dai | https://github.com/Yuchen-Dai |
| Dec 12, 2025 | https://github.com/nodejs/node/pull/56934#issuecomment-3645185960 |
| Please reload this page | https://github.com/nodejs/node/pull/56934 |
| @joyeecheung | https://github.com/joyeecheung |
| #56049 | https://github.com/nodejs/node/issues/56049 |
| @Yeaseen | https://github.com/Yeaseen |
| Please reload this page | https://github.com/nodejs/node/pull/56934 |
| https://github.com/Yeaseen |
| Yeaseen | https://github.com/Yeaseen |
| Dec 14, 2025 | https://github.com/nodejs/node/pull/56934#issuecomment-3652030332 |
| @Yuchen-Dai | https://github.com/Yuchen-Dai |
| #56049 | https://github.com/nodejs/node/issues/56049 |
| Please reload this page | https://github.com/nodejs/node/pull/56934 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
|
Dec 14, 2025
| https://github.com/nodejs/node/pull/56934#pullrequestreview-3575973103 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/56934/files/50acccabb495c23f9f83421dc0af613024be4e09 |
| https://github.com/Yeaseen |
| Yeaseen | https://github.com/Yeaseen |
| Dec 18, 2025 | https://github.com/nodejs/node/pull/56934#event-21637317507 |
| https://github.com/Yeaseen |
| Yeaseen | https://github.com/Yeaseen |
|
Dec 18, 2025
| https://github.com/nodejs/node/pull/56934#ref-pullrequest-3742349293 |
|
fs: fix rmSync to handle non-ASCII characters
#61108
| https://github.com/nodejs/node/pull/61108 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F56934 |
|
| https://github.com/joyeecheung |
|
joyeecheung
| https://github.com/joyeecheung |
|
| https://github.com/nodejs/node/pull/56934/files/50acccabb495c23f9f83421dc0af613024be4e09 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/56934/files/50acccabb495c23f9f83421dc0af613024be4e09 |
|
| https://github.com/anonrig |
|
anonrig
| https://github.com/anonrig |
|
| https://github.com/nodejs/node/pull/56934/files/50acccabb495c23f9f83421dc0af613024be4e09 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
fs
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
fs.rmSync('速') crash without throw
| https://github.com/nodejs/node/issues/56049 |
| Please reload this page | https://github.com/nodejs/node/pull/56934 |
|
| https://github.com/Yeaseen |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/joyeecheung |
|
| https://github.com/Yuchen-Dai |
|
| https://github.com/jasnell |
|
| https://github.com/anonrig |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |