| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:f88dfcbd-3610-db9f-23db-1b5bd0f5aba8 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AFA0:8AE8C:75916DA:A5453AF:6A501FCA |
| html-safe-nonce | b707eb3f7e7b82696e8fa864daee5d89e9314d6673a437fb439e3807734699fb |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRkEwOjhBRThDOjc1OTE2REE6QTU0NTNBRjo2QTUwMUZDQSIsInZpc2l0b3JfaWQiOiI5MTM0OTM2NTI3NDE1MDI1NjEwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 226a275893657f6ce549d36f87112cd2ffae83680284a69dbe59f11f323fdd47 |
| hovercard-subject-tag | pull_request:62207702 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/5621/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/ab3df20ec754b3aa053c7d50eec87e9eb7310c01f34afca9c71460cad2bd199c/nodejs/node/pull/5621 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/ab3df20ec754b3aa053c7d50eec87e9eb7310c01f34afca9c71460cad2bd199c/nodejs/node/pull/5621 |
| og:image:alt | Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
this change (including linting)?
Is the commit message formatted according to [CONTRIBUTING.md][0]?
If this change fixes a bug... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | gibfahn |
| hostname | github.com |
| expected-hostname | github.com |
| None | a08040246389072795e3b4e7b33c6d9a0c564eee02e829a809326d67c418b069 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | d1b91b18e7330fc458dfd824c61eaed7daa830d6 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/5621#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F5621 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F5621 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/5621 |
| Reload | https://github.com/nodejs/node/pull/5621 |
| Reload | https://github.com/nodejs/node/pull/5621 |
| Please reload this page | https://github.com/nodejs/node/pull/5621 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/5621 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
977
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| gibfahn | https://github.com/gibfahn |
| nodejs:v0.12-staging | https://github.com/nodejs/node/tree/v0.12-staging |
| gibfahn:cluster-disconnect-race-v0.12 | https://github.com/gibfahn/node/tree/cluster-disconnect-race-v0.12 |
| Conversation | https://github.com/nodejs/node/pull/5621 |
| Commits1 (1) | https://github.com/nodejs/node/pull/5621/commits |
| Checks | https://github.com/nodejs/node/pull/5621/checks |
| Files changed | https://github.com/nodejs/node/pull/5621/files |
| test: skip cluster-disconnect-race on Windows | https://github.com/nodejs/node/pull/5621#top |
| gibfahn | https://github.com/gibfahn |
| nodejs:v0.12-staging | https://github.com/nodejs/node/tree/v0.12-staging |
| gibfahn:cluster-disconnect-race-v0.12 | https://github.com/gibfahn/node/tree/cluster-disconnect-race-v0.12 |
|
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
| Mar 9, 2016 | https://github.com/nodejs/node/pull/5621#issue-139537447 |
| #5603 | https://github.com/nodejs/node/issues/5603 |
| simple/cluster-disconnect-race | https://github.com/nodejs/node/blob/v0.12-staging/test/simple/test-cluster-disconnect-race.js |
| #4457 | https://github.com/nodejs/node/pull/4457 |
| @rvagg | https://github.com/rvagg |
| Please reload this page | https://github.com/nodejs/node/pull/5621 |
|
| https://github.com/gibfahn |
| test: skip cluster-disconnect-race on Windows | https://github.com/nodejs/node/pull/5621/commits/a2b3cef543d996e4bc7a33f6314e840572bb857c |
| a2b3cef | https://github.com/nodejs/node/pull/5621/commits/a2b3cef543d996e4bc7a33f6314e840572bb857c |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
cluster
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acluster |
|
windows
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awindows |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Mar 9, 2016 | https://github.com/nodejs/node/pull/5621#event-583114612 |
| https://github.com/orangemocha |
| orangemocha | https://github.com/orangemocha |
| Mar 10, 2016 | https://github.com/nodejs/node/pull/5621#issuecomment-194977769 |
| https://nodejs.org/api/process.html#process_process_platform | https://nodejs.org/api/process.html#process_process_platform |
| https://ci.nodejs.org/job/node-test-pull-request/1895/ | https://ci.nodejs.org/job/node-test-pull-request/1895/ |
| Please reload this page | https://github.com/nodejs/node/pull/5621 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Mar 11, 2016 | https://github.com/nodejs/node/pull/5621#issuecomment-195155854 |
| Please reload this page | https://github.com/nodejs/node/pull/5621 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
| Mar 16, 2016 | https://github.com/nodejs/node/pull/5621#issuecomment-197398499 |
| the first one | https://ci.nodejs.org/job/node-test-commit-linux/2564/nodes=ubuntu1404-64/console |
| the second one | https://ci.nodejs.org/job/node-test-binary-windows/1348/RUN_SUBSET=0,VS_VERSION=vcbt2015,label=win10/tapTestReport/ |
| test-dgram-multicast-multi-process.js | https://ci.nodejs.org/job/node-test-binary-windows/1348/RUN_SUBSET=0,VS_VERSION=vcbt2015,label=win10/tapTestReport/test.tap-816/ |
| test-dns.js | https://ci.nodejs.org/job/node-test-binary-windows/1348/RUN_SUBSET=0,VS_VERSION=vcbt2015,label=win10/tapTestReport/test.tap-817/ |
| Please reload this page | https://github.com/nodejs/node/pull/5621 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
lts-watch-v0.12
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v0.12 |
| Mar 16, 2016 | https://github.com/nodejs/node/pull/5621#event-592402640 |
| jasnell | https://github.com/jasnell |
|
Mar 16, 2016
| https://github.com/nodejs/node/pull/5621#ref-commit-ab907eb |
|
| https://github.com/gibfahn |
|
| https://github.com/jasnell |
| test: skip cluster-disconnect-race on Windows | https://github.com/nodejs/node/commit/ab907eb5a8c83bb7c01e16a36f210e84923b6234 |
| ab907eb | https://github.com/nodejs/node/commit/ab907eb5a8c83bb7c01e16a36f210e84923b6234 |
| #5621 | https://github.com/nodejs/node/pull/5621 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Mar 16, 2016 | https://github.com/nodejs/node/pull/5621#issuecomment-197516011 |
| Please reload this page | https://github.com/nodejs/node/pull/5621 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Mar 16, 2016 | https://github.com/nodejs/node/pull/5621#event-592406431 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
land-on-v0.12
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v0.12 |
|
lts-watch-v0.12
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v0.12 |
| Mar 16, 2016 | https://github.com/nodejs/node/pull/5621#event-592406605 |
| https://github.com/rvagg |
| rvagg | https://github.com/rvagg |
|
Mar 31, 2016
| https://github.com/nodejs/node/pull/5621#ref-pullrequest-144855621 |
|
Release proposal: v0.12.13
#5967
| https://github.com/nodejs/node/pull/5967 |
| https://github.com/lance |
| lance | https://github.com/lance |
|
Jun 17, 2016
| https://github.com/nodejs/node/pull/5621#ref-pullrequest-157077353 |
|
repl: History file locking and other improvements
#7005
| https://github.com/nodejs/node/pull/7005 |
| jBarz | https://github.com/jBarz |
|
Nov 4, 2016
| https://github.com/nodejs/node/pull/5621#ref-commit-258c159 |
|
| https://github.com/gibfahn |
|
| https://github.com/jBarz |
| test: skip cluster-disconnect-race on Windows | https://github.com/ibmruntimes/node/commit/258c159f1fb791fb69bd699b5e502d7927447daa |
| 258c159 | https://github.com/ibmruntimes/node/commit/258c159f1fb791fb69bd699b5e502d7927447daa |
| nodejs/node#5621 | https://github.com/nodejs/node/pull/5621 |
| https://github.com/gibfahn |
| gibfahn | https://github.com/gibfahn |
| December 16, 2016 11:18 | https://github.com/nodejs/node/pull/5621#event-896556388 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F5621 |
|
cluster
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acluster |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
|
windows
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awindows |
| Please reload this page | https://github.com/nodejs/node/pull/5621 |
|
| https://github.com/gibfahn |
|
| https://github.com/orangemocha |
|
| https://github.com/jasnell |
|
| https://github.com/mscdex |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |