René's URL Explorer Experiment


Title: fs: fix rmSync to handle non-ASCII characters by Yeaseen · Pull Request #56117 · nodejs/node · GitHub

Open Graph Title: fs: fix rmSync to handle non-ASCII characters by Yeaseen · Pull Request #56117 · nodejs/node

X Title: fs: fix rmSync to handle non-ASCII characters by Yeaseen · Pull Request #56117 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: This is my first pull request here and I read the contribution guide and commit guide. Update fs.rmSync in src/node_file.cc to properly handle file paths that include non-ASCII characters. This ch...

X Description: This is my first pull request here and I read the contribution guide and commit guide. Update fs.rmSync in src/node_file.cc to properly handle file paths that include non-ASCII characters. This ch...

Opengraph URL: https://github.com/nodejs/node/pull/56117

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f81f223d-648b-1e09-e0ee-2fdd9d52a366
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE808:299851:158CB25:1DDD1A7:6A4DEFF7
html-safe-noncee7887bb933745814a3268455832ba0d92084fe62bc31e590f469eed4777ea5dd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFODA4OjI5OTg1MToxNThDQjI1OjFEREQxQTc6NkE0REVGRjciLCJ2aXNpdG9yX2lkIjoiNDQxMDY4OTA1ODM2MDkxMzkxMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac107c3f0437657993e203f7f46806670f15a4ed8712b59818cc0195c5fa4ab367
hovercard-subject-tagpull_request:2212378397
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/56117/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a461305b97626b4759ff31250455ab8739f03a623d2c36edc419136d2afa88b2/nodejs/node/pull/56117
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a461305b97626b4759ff31250455ab8739f03a623d2c36edc419136d2afa88b2/nodejs/node/pull/56117
og:image:altThis is my first pull request here and I read the contribution guide and commit guide. Update fs.rmSync in src/node_file.cc to properly handle file paths that include non-ASCII characters. This ch...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameYeaseen
hostnamegithub.com
expected-hostnamegithub.com
None5818716c93c6a2925b815402541a32814e43a7b1261c322b0c2df75224289566
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef4bb89367ca678f057d79b1abc45d6675b1bd5b2
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/56117#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F56117
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F56117
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/56117
Reloadhttps://github.com/nodejs/node/pull/56117
Reloadhttps://github.com/nodejs/node/pull/56117
Please reload this pagehttps://github.com/nodejs/node/pull/56117
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/56117
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 964 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Yeaseenhttps://github.com/Yeaseen
nodejs:mainhttps://github.com/nodejs/node/tree/main
Conversationhttps://github.com/nodejs/node/pull/56117
Commits18 (18)https://github.com/nodejs/node/pull/56117/commits
Checkshttps://github.com/nodejs/node/pull/56117/checks
Files changedhttps://github.com/nodejs/node/pull/56117/files
fs: fix rmSync to handle non-ASCII charactershttps://github.com/nodejs/node/pull/56117#top
Yeaseenhttps://github.com/Yeaseen
nodejs:mainhttps://github.com/nodejs/node/tree/main
https://github.com/Yeaseen
Yeaseenhttps://github.com/Yeaseen
Dec 3, 2024https://github.com/nodejs/node/pull/56117#issue-2714557767
#56049https://github.com/nodejs/node/issues/56049
Please reload this pagehttps://github.com/nodejs/node/pull/56117
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Dec 3, 2024https://github.com/nodejs/node/pull/56117#event-15506896246
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Dec 3, 2024 https://github.com/nodejs/node/pull/56117#pullrequestreview-2475354295
View reviewed changes https://github.com/nodejs/node/pull/56117/files
test/parallel/test-fs-rmSync-special-char.jshttps://github.com/nodejs/node/pull/56117/files#diff-222024aafb40bce2b8abf04616adf3f76ccfe750b7a9effefdbf265e2e2ffa2a
Please reload this pagehttps://github.com/nodejs/node/pull/56117
test/parallel/test-fs-rmSync-special-char.jshttps://github.com/nodejs/node/pull/56117/files#diff-222024aafb40bce2b8abf04616adf3f76ccfe750b7a9effefdbf265e2e2ffa2a
Please reload this pagehttps://github.com/nodejs/node/pull/56117
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Dec 3, 2024 https://github.com/nodejs/node/pull/56117#pullrequestreview-2475514166
View reviewed changes https://github.com/nodejs/node/pull/56117/files
test/parallel/test-fs-rmSync-special-char.jshttps://github.com/nodejs/node/pull/56117/files#diff-222024aafb40bce2b8abf04616adf3f76ccfe750b7a9effefdbf265e2e2ffa2a
Please reload this pagehttps://github.com/nodejs/node/pull/56117
test/parallel/test-fs-rmSync-special-char.jshttps://github.com/nodejs/node/pull/56117/files#diff-222024aafb40bce2b8abf04616adf3f76ccfe750b7a9effefdbf265e2e2ffa2a
Please reload this pagehttps://github.com/nodejs/node/pull/56117
https://github.com/anonrig
anonrighttps://github.com/anonrig
Dec 3, 2024 https://github.com/nodejs/node/pull/56117#pullrequestreview-2475802686
View reviewed changes https://github.com/nodejs/node/pull/56117/files
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Dec 3, 2024 https://github.com/nodejs/node/pull/56117#pullrequestreview-2475823836
View reviewed changes https://github.com/nodejs/node/pull/56117/files
test/parallel/test-fs-rmSync-special-char.jshttps://github.com/nodejs/node/pull/56117/files#diff-222024aafb40bce2b8abf04616adf3f76ccfe750b7a9effefdbf265e2e2ffa2a
Please reload this pagehttps://github.com/nodejs/node/pull/56117
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Dec 3, 2024 https://github.com/nodejs/node/pull/56117#pullrequestreview-2475853219
View reviewed changes https://github.com/nodejs/node/pull/56117/files
BridgeARhttps://github.com/BridgeAR
https://github.com/nodejs/node/pull/56117#pullrequestreview-2475853219
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/56117
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Dec 3, 2024https://github.com/nodejs/node/pull/56117#issuecomment-2514934779
Please reload this pagehttps://github.com/nodejs/node/pull/56117
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/56117?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
(50d405a)https://app.codecov.io/gh/nodejs/node/commit/50d405a2b6db859fe5e0f67c71b0b706e89cd5f2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
(896e117)https://app.codecov.io/gh/nodejs/node/commit/896e1177d0ae3a7d98fbc1792b9070e33e73799a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/56117?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
src/node_file.cchttps://app.codecov.io/gh/nodejs/node/pull/56117?src=pr&el=tree&filepath=src%2Fnode_file.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfZmlsZS5jYw==
18 Missing and 13 partials ⚠️ https://app.codecov.io/gh/nodejs/node/pull/56117?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/56117?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
src/api/exceptions.cchttps://app.codecov.io/gh/nodejs/node/pull/56117?src=pr&el=tree&filepath=src%2Fapi%2Fexceptions.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL2FwaS9leGNlcHRpb25zLmNj
src/node_file.cchttps://app.codecov.io/gh/nodejs/node/pull/56117?src=pr&el=tree&filepath=src%2Fnode_file.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfZmlsZS5jYw==
48 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/56117/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Please reload this pagehttps://github.com/nodejs/node/pull/56117
https://github.com/jazelly
jazellyhttps://github.com/jazelly
Dec 4, 2024 https://github.com/nodejs/node/pull/56117#pullrequestreview-2477289108
View reviewed changes https://github.com/nodejs/node/pull/56117/files
src/node_file.cchttps://github.com/nodejs/node/pull/56117/files#diff-70e3325bd2115867617ae2a16321c5de53c070ff2841976fe5b849675a5111e6
Please reload this pagehttps://github.com/nodejs/node/pull/56117
https://github.com/juanarbol
juanarbolhttps://github.com/juanarbol
Dec 5, 2024 https://github.com/nodejs/node/pull/56117#pullrequestreview-2480280872
View reviewed changes https://github.com/nodejs/node/pull/56117/files/f43419166c7cf40b1926e1302bb47efc8591522f
https://github.com/jazelly
jazellyhttps://github.com/jazelly
Dec 5, 2024https://github.com/nodejs/node/pull/56117#issuecomment-2520301102
Please reload this pagehttps://github.com/nodejs/node/pull/56117
Yeaseenhttps://github.com/Yeaseen
December 5, 2024 12:09https://github.com/nodejs/node/pull/56117#commits-pushed-a2fd236
https://github.com/Yeaseen
fs: fix rmSync to handle non-ASCII charactershttps://github.com/nodejs/node/pull/56117/commits/a2fd236e803380f17fdb199582c06698dde7c34c
a2fd236https://github.com/nodejs/node/pull/56117/commits/a2fd236e803380f17fdb199582c06698dde7c34c
#56049https://github.com/nodejs/node/issues/56049
https://github.com/Yeaseen
test: update fs.rmSync test to use tmpdir as per review feedbackhttps://github.com/nodejs/node/pull/56117/commits/3a92727886d826d519797b62244f6352bd505e80
3a92727https://github.com/nodejs/node/pull/56117/commits/3a92727886d826d519797b62244f6352bd505e80
https://github.com/Yeaseen
src: use BufferValueToPath for cross-platform path handlinghttps://github.com/nodejs/node/pull/56117/commits/f43419166c7cf40b1926e1302bb47efc8591522f
f434191https://github.com/nodejs/node/pull/56117/commits/f43419166c7cf40b1926e1302bb47efc8591522f
https://github.com/Yeaseen
Yeaseenhttps://github.com/Yeaseen
Dec 5, 2024https://github.com/nodejs/node/pull/56117#issuecomment-2521233049
@jazellyhttps://github.com/jazelly
Please reload this pagehttps://github.com/nodejs/node/pull/56117
https://github.com/Yeaseen
test: fix linter issues in test-fs-rmSync-special-char.jshttps://github.com/nodejs/node/pull/56117/commits/2572f57ae3525299af21811c4bcec6b14cac0581
2572f57https://github.com/nodejs/node/pull/56117/commits/2572f57ae3525299af21811c4bcec6b14cac0581
https://github.com/Yeaseen
Yeaseenhttps://github.com/Yeaseen
Dec 6, 2024https://github.com/nodejs/node/pull/56117#issuecomment-2522518097
Please reload this pagehttps://github.com/nodejs/node/pull/56117
@jazellyhttps://github.com/jazelly
Please reload this pagehttps://github.com/nodejs/node/pull/56117
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Dec 6, 2024 https://github.com/nodejs/node/pull/56117#pullrequestreview-2485707168
View reviewed changes https://github.com/nodejs/node/pull/56117/files/2572f57ae3525299af21811c4bcec6b14cac0581
src/node_file.cchttps://github.com/nodejs/node/pull/56117/files/2572f57ae3525299af21811c4bcec6b14cac0581#diff-70e3325bd2115867617ae2a16321c5de53c070ff2841976fe5b849675a5111e6
Please reload this pagehttps://github.com/nodejs/node/pull/56117
https://github.com/Yeaseen
test: add more edge cases in test-fs-rmSync-special-char.jshttps://github.com/nodejs/node/pull/56117/commits/8b59d69415f3d18cba56b75506aad42fc88fdca7
8b59d69https://github.com/nodejs/node/pull/56117/commits/8b59d69415f3d18cba56b75506aad42fc88fdca7
https://github.com/Yeaseen
Yeaseenhttps://github.com/Yeaseen
Dec 7, 2024https://github.com/nodejs/node/pull/56117#issuecomment-2525082348
@jazellyhttps://github.com/jazelly
@joyeecheunghttps://github.com/joyeecheung
Please reload this pagehttps://github.com/nodejs/node/pull/56117
https://github.com/Yeaseen
[src] [test] addressed linter issues from CIhttps://github.com/nodejs/node/pull/56117/commits/1d07727050bae23d973b5c27900f62120cfa1c15
1d07727https://github.com/nodejs/node/pull/56117/commits/1d07727050bae23d973b5c27900f62120cfa1c15
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F56117
https://github.com/juanarbol
juanarbolhttps://github.com/juanarbol
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Dec 9, 2024https://github.com/nodejs/node/pull/56117#event-15575733514
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F56117
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F56117
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F56117
https://github.com/jazelly
jazellyhttps://github.com/jazelly
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Dec 11, 2024https://github.com/nodejs/node/pull/56117#event-15613987176
https://github.com/jazelly
jazellyhttps://github.com/jazelly
Dec 11, 2024 https://github.com/nodejs/node/pull/56117#pullrequestreview-2494751624
View reviewed changes https://github.com/nodejs/node/pull/56117/files/1d07727050bae23d973b5c27900f62120cfa1c15
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Dec 11, 2024 https://github.com/nodejs/node/pull/56117#pullrequestreview-2495548129
View reviewed changes https://github.com/nodejs/node/pull/56117/files/1d07727050bae23d973b5c27900f62120cfa1c15
src/node_file.cchttps://github.com/nodejs/node/pull/56117/files/1d07727050bae23d973b5c27900f62120cfa1c15#diff-70e3325bd2115867617ae2a16321c5de53c070ff2841976fe5b849675a5111e6
Please reload this pagehttps://github.com/nodejs/node/pull/56117
test/parallel/test-fs-rmSync-special-char.jshttps://github.com/nodejs/node/pull/56117/files/1d07727050bae23d973b5c27900f62120cfa1c15#diff-222024aafb40bce2b8abf04616adf3f76ccfe750b7a9effefdbf265e2e2ffa2a
Please reload this pagehttps://github.com/nodejs/node/pull/56117
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Jan 22, 2025 https://github.com/nodejs/node/pull/56117#pullrequestreview-2566110638
View reviewed changes https://github.com/nodejs/node/pull/56117/files/84f633162ca0a438e15b87dec77a11386fdda512
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jan 22, 2025https://github.com/nodejs/node/pull/56117#event-16022861387
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Jan 22, 2025https://github.com/nodejs/node/pull/56117#event-16033637255
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jan 22, 2025https://github.com/nodejs/node/pull/56117#issuecomment-2608041796
https://ci.nodejs.org/job/node-test-pull-request/64614/https://ci.nodejs.org/job/node-test-pull-request/64614/
Please reload this pagehttps://github.com/nodejs/node/pull/56117
https://github.com/anonrig
anonrighttps://github.com/anonrig
Jan 23, 2025 https://github.com/nodejs/node/pull/56117#pullrequestreview-2568628078
View reviewed changes https://github.com/nodejs/node/pull/56117/files/84f633162ca0a438e15b87dec77a11386fdda512
anonrighttps://github.com/anonrig
https://github.com/nodejs/node/pull/56117#pullrequestreview-2568628078
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#54653https://github.com/nodejs/node/pull/54653
@joyeecheunghttps://github.com/joyeecheung
Please reload this pagehttps://github.com/nodejs/node/pull/56117
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Jan 23, 2025https://github.com/nodejs/node/pull/56117#issuecomment-2608773866
Please reload this pagehttps://github.com/nodejs/node/pull/56117
Please reload this pagehttps://github.com/nodejs/node/pull/56117
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jan 23, 2025https://github.com/nodejs/node/pull/56117#issuecomment-2610081235
@joyeecheunghttps://github.com/joyeecheung
Please reload this pagehttps://github.com/nodejs/node/pull/56117
https://github.com/anonrig
anonrighttps://github.com/anonrig
Jan 23, 2025 https://github.com/nodejs/node/pull/56117#pullrequestreview-2570303922
View reviewed changes https://github.com/nodejs/node/pull/56117/files/84f633162ca0a438e15b87dec77a11386fdda512
https://github.com/aduh95
aduh95https://github.com/aduh95
Jan 23, 2025https://github.com/nodejs/node/pull/56117#issuecomment-2610215587
Please reload this pagehttps://github.com/nodejs/node/pull/56117
https://github.com/lemire
lemirehttps://github.com/lemire
Jan 23, 2025https://github.com/nodejs/node/pull/56117#issuecomment-2610234858
@Yeaseenhttps://github.com/Yeaseen
Please reload this pagehttps://github.com/nodejs/node/pull/56117
https://github.com/Yeaseen
Yeaseenhttps://github.com/Yeaseen
Jan 23, 2025https://github.com/nodejs/node/pull/56117#issuecomment-2610552636
@lemirehttps://github.com/lemire
Please reload this pagehttps://github.com/nodejs/node/pull/56117
https://github.com/lemire
lemirehttps://github.com/lemire
Jan 23, 2025https://github.com/nodejs/node/pull/56117#issuecomment-2611078612
@Yeaseenhttps://github.com/Yeaseen
Please reload this pagehttps://github.com/nodejs/node/pull/56117
Yeaseenhttps://github.com/Yeaseen
January 28, 2025 01:32https://github.com/nodejs/node/pull/56117#commits-pushed-50f5e96
https://github.com/Yeaseen
tests passed on both windows and linuxhttps://github.com/nodejs/node/pull/56117/commits/50f5e9616b4eec38ab7bd50f32ad3e90c85fd3eb
50f5e96https://github.com/nodejs/node/pull/56117/commits/50f5e9616b4eec38ab7bd50f32ad3e90c85fd3eb
https://github.com/Yeaseen
resolving conflicthttps://github.com/nodejs/node/pull/56117/commits/70c0a70c90870ebec88a7ff1b374592fbbe0aad4
70c0a70https://github.com/nodejs/node/pull/56117/commits/70c0a70c90870ebec88a7ff1b374592fbbe0aad4
https://github.com/Yeaseen
additional changes are donehttps://github.com/nodejs/node/pull/56117/commits/baba1ba68ec3cb410813a58694fe636882c34159
baba1bahttps://github.com/nodejs/node/pull/56117/commits/baba1ba68ec3cb410813a58694fe636882c34159
https://github.com/Yeaseen
Merge branch 'main' into fix-non-ascii-filepath-issuehttps://github.com/nodejs/node/pull/56117/commits/7108398ab67c749e9054878e388411b0aaed9149
7108398https://github.com/nodejs/node/pull/56117/commits/7108398ab67c749e9054878e388411b0aaed9149
https://github.com/Yeaseen
Updated src/node_file.cchttps://github.com/nodejs/node/pull/56117/commits/5050b94b718ba6ba203067b4e96fcd4a4efcced9
5050b94https://github.com/nodejs/node/pull/56117/commits/5050b94b718ba6ba203067b4e96fcd4a4efcced9
https://github.com/Yeaseen
conflict avoidhttps://github.com/nodejs/node/pull/56117/commits/7de54575996610569346e0f5f525e651ef613717
7de5457https://github.com/nodejs/node/pull/56117/commits/7de54575996610569346e0f5f525e651ef613717
https://github.com/Yeaseen
Yeaseenhttps://github.com/Yeaseen
Jan 28, 2025https://github.com/nodejs/node/pull/56117#issuecomment-2618533653
@joyeecheunghttps://github.com/joyeecheung
Please reload this pagehttps://github.com/nodejs/node/pull/56117
https://github.com/Yeaseen
addressred linter issuehttps://github.com/nodejs/node/pull/56117/commits/896e1177d0ae3a7d98fbc1792b9070e33e73799a
896e117https://github.com/nodejs/node/pull/56117/commits/896e1177d0ae3a7d98fbc1792b9070e33e73799a
https://github.com/Yeaseen
Yeaseenhttps://github.com/Yeaseen
Feb 5, 2025https://github.com/nodejs/node/pull/56117#issuecomment-2637603841
@lemirehttps://github.com/lemire
Please reload this pagehttps://github.com/nodejs/node/pull/56117
https://github.com/lemire
lemirehttps://github.com/lemire
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Feb 5, 2025https://github.com/nodejs/node/pull/56117#event-16201871783
https://github.com/lemire
lemirehttps://github.com/lemire
Feb 5, 2025 https://github.com/nodejs/node/pull/56117#pullrequestreview-2597192387
View reviewed changes https://github.com/nodejs/node/pull/56117/files/896e1177d0ae3a7d98fbc1792b9070e33e73799a
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Feb 5, 2025https://github.com/nodejs/node/pull/56117#event-16201939512
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Feb 5, 2025https://github.com/nodejs/node/pull/56117#issuecomment-2638256790
https://ci.nodejs.org/job/node-test-pull-request/65018/https://ci.nodejs.org/job/node-test-pull-request/65018/
Please reload this pagehttps://github.com/nodejs/node/pull/56117
Yeaseenhttps://github.com/Yeaseen
February 5, 2025 16:43https://github.com/nodejs/node/pull/56117#commits-pushed-7803546
https://github.com/Yeaseen
Merge branch 'main' into fix-non-ascii-filepath-issuehttps://github.com/nodejs/node/pull/56117/commits/7803546cd304e8adc567e9e8b291052f721b69ee
7803546https://github.com/nodejs/node/pull/56117/commits/7803546cd304e8adc567e9e8b291052f721b69ee
https://github.com/Yeaseen
src: use BufferValueToPath for cross-platform path handlinghttps://github.com/nodejs/node/pull/56117/commits/8db36d7824614fee352a8799ea6823ef09139dd9
8db36d7https://github.com/nodejs/node/pull/56117/commits/8db36d7824614fee352a8799ea6823ef09139dd9
f434191https://github.com/nodejs/node/commit/f43419166c7cf40b1926e1302bb47efc8591522f
https://github.com/Yeaseen
Yeaseenhttps://github.com/Yeaseen
Feb 6, 2025https://github.com/nodejs/node/pull/56117#event-16202325108
https://github.com/Yeaseen
Yeaseenhttps://github.com/Yeaseen
Feb 6, 2025https://github.com/nodejs/node/pull/56117#issuecomment-2638325535
Please reload this pagehttps://github.com/nodejs/node/pull/56117
https://github.com/Yeaseen
Yeaseenhttps://github.com/Yeaseen
Feb 6, 2025 https://github.com/nodejs/node/pull/56117#ref-pullrequest-2834359567
fs: fix rmSync to handle non-ASCII characters #56934 https://github.com/nodejs/node/pull/56934
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F56117
https://github.com/lemire
lemire https://github.com/lemire
https://github.com/nodejs/node/pull/56117/files/896e1177d0ae3a7d98fbc1792b9070e33e73799a
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/56117/files/1d07727050bae23d973b5c27900f62120cfa1c15
https://github.com/anonrig
anonrig https://github.com/anonrig
https://github.com/nodejs/node/pull/56117/files/84f633162ca0a438e15b87dec77a11386fdda512
https://github.com/joyeecheung
joyeecheung https://github.com/joyeecheung
https://github.com/nodejs/node/pull/56117/files/84f633162ca0a438e15b87dec77a11386fdda512
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/56117/files/f4a6ab53c6b8b683aef82dcf0c3e1fb74cd5b012
https://github.com/juanarbol
juanarbol https://github.com/juanarbol
https://github.com/nodejs/node/pull/56117/files/f43419166c7cf40b1926e1302bb47efc8591522f
https://github.com/jazelly
jazelly https://github.com/jazelly
https://github.com/nodejs/node/pull/56117/files/1d07727050bae23d973b5c27900f62120cfa1c15
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
fs.rmSync('速') crash without throw https://github.com/nodejs/node/issues/56049
Please reload this pagehttps://github.com/nodejs/node/pull/56117
https://github.com/Yeaseen
https://github.com/jazelly
https://github.com/nodejs-github-bot
https://github.com/joyeecheung
https://github.com/jasnell
https://github.com/aduh95
https://github.com/lemire
https://github.com/anonrig
https://github.com/BridgeAR
https://github.com/juanarbol
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.