| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:14021abb-f506-32a0-8304-10cc7dbb711e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 923A:992B3:95BEFA:D19D89:696A5CCE |
| html-safe-nonce | 4a4f4678e41e38a6b5fae6672feaa7da3f352204de4fd12fb2c9ee80c2ce332b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MjNBOjk5MkIzOjk1QkVGQTpEMTlEODk6Njk2QTVDQ0UiLCJ2aXNpdG9yX2lkIjoiMzE3ODk0OTU5MDk4MzAwNzQzOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | b41ec088a6a6414837946af71b4aff9177a61de0cec1cb22dfa442b132eaf276 |
| hovercard-subject-tag | pull_request:2207417925 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/56073/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/12756b87c5eac41ba4408666d20bc102aa83ac582b8ae5962fe86a03e12c4fb8/nodejs/node/pull/56073 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/12756b87c5eac41ba4408666d20bc102aa83ac582b8ae5962fe86a03e12c4fb8/nodejs/node/pull/56073 |
| og:image:alt | This change cherry-picks a small change from node-gyp needed for running native tests on ClangCL compiled binaries. The change was already approved here, so this is just the official port after the... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | StefanStojanovic |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3f871c8e07f0ae1886fa8dac284166d28b09ad5bada6476fc10b674e489788ef |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 63c426b30d262aba269ef14c40e3c817b384cd61 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/56073#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F56073 |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F56073 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/56073 |
| Reload | https://github.com/nodejs/node/pull/56073 |
| Reload | https://github.com/nodejs/node/pull/56073 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/56073 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
695
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/56073 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/56073#issue-comment-box |
| StefanStojanovic | https://github.com/StefanStojanovic |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| JaneaSystems:mefi-node-gyp-clang | https://github.com/JaneaSystems/node/tree/mefi-node-gyp-clang |
|
deps: cherry-pick 88260bf from node-gyp upstream
| https://github.com/nodejs/node/pull/56073#top |
| StefanStojanovic | https://github.com/StefanStojanovic |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| JaneaSystems:mefi-node-gyp-clang | https://github.com/JaneaSystems/node/tree/mefi-node-gyp-clang |
|
Conversation
11
| https://github.com/nodejs/node/pull/56073 |
|
Commits
1
| https://github.com/nodejs/node/pull/56073/commits |
|
Checks
43
| https://github.com/nodejs/node/pull/56073/checks |
|
Files changed
| https://github.com/nodejs/node/pull/56073/files |
| Please reload this page | https://github.com/nodejs/node/pull/56073 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/StefanStojanovic |
| StefanStojanovic | https://github.com/StefanStojanovic |
| Nov 29, 2024 | https://github.com/nodejs/node/pull/56073#issue-2705178047 |
| here | https://github.com/nodejs/node/pull/55784 |
| nodejs/node-gyp#3098 | https://github.com/nodejs/node-gyp/pull/3098 |
| #55784 | https://github.com/nodejs/node/pull/55784 |
| Please reload this page | https://github.com/nodejs/node/pull/56073 |
|
| https://github.com/StefanStojanovic |
| deps: cherry-pick 88260bf from node-gyp upstream | https://github.com/nodejs/node/pull/56073/commits/7534679a9253cc691cb5ca80513bfe3757f35edb |
| 7534679 | https://github.com/nodejs/node/pull/56073/commits/7534679a9253cc691cb5ca80513bfe3757f35edb |
| nodejs/node-gyp#3098 | https://github.com/nodejs/node-gyp/pull/3098 |
| https://github.com/StefanStojanovic |
| StefanStojanovic | https://github.com/StefanStojanovic |
|
windows
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awindows |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
fast-track
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track |
| Nov 29, 2024 | https://github.com/nodejs/node/pull/56073#event-15475858706 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 29, 2024 | https://github.com/nodejs/node/pull/56073#issuecomment-2507849422 |
| Please reload this page | https://github.com/nodejs/node/pull/56073 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Nov 29, 2024 | https://github.com/nodejs/node/pull/56073#issuecomment-2507849570 |
| @StefanStojanovic | https://github.com/StefanStojanovic |
| Please reload this page | https://github.com/nodejs/node/pull/56073 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
npm
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anpm |
| Nov 29, 2024 | https://github.com/nodejs/node/pull/56073#event-15475860689 |
| https://github.com/StefanStojanovic |
| StefanStojanovic | https://github.com/StefanStojanovic |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Nov 29, 2024 | https://github.com/nodejs/node/pull/56073#event-15476061431 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Nov 29, 2024 | https://github.com/nodejs/node/pull/56073#event-15476153986 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Nov 29, 2024 | https://github.com/nodejs/node/pull/56073#issuecomment-2507900310 |
| https://ci.nodejs.org/job/node-test-pull-request/63776/ | https://ci.nodejs.org/job/node-test-pull-request/63776/ |
| Please reload this page | https://github.com/nodejs/node/pull/56073 |
| https://github.com/legendecas |
| legendecas | https://github.com/legendecas |
| Nov 29, 2024 | https://github.com/nodejs/node/pull/56073#issuecomment-2507921596 |
| nodejs/node-gyp#3050 | https://github.com/nodejs/node-gyp/pull/3050 |
| Please reload this page | https://github.com/nodejs/node/pull/56073 |
| https://github.com/StefanStojanovic |
| StefanStojanovic | https://github.com/StefanStojanovic |
|
Dec 2, 2024
| https://github.com/nodejs/node/pull/56073#ref-pullrequest-2644259199 |
|
Enabling ClangCL compilation testing
#55784
| https://github.com/nodejs/node/pull/55784 |
| https://github.com/legendecas |
| legendecas | https://github.com/legendecas |
|
Dec 2, 2024
| https://github.com/nodejs/node/pull/56073#pullrequestreview-2472992183 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/56073/files/7534679a9253cc691cb5ca80513bfe3757f35edb |
| https://github.com/legendecas |
| legendecas | https://github.com/legendecas |
| December 2, 2024 15:16 | https://github.com/nodejs/node/pull/56073#event-15494675026 |
| https://github.com/legendecas |
| legendecas | https://github.com/legendecas |
| Dec 2, 2024 | https://github.com/nodejs/node/pull/56073#issuecomment-2511819890 |
| Please reload this page | https://github.com/nodejs/node/pull/56073 |
| Please reload this page | https://github.com/nodejs/node/pull/56073 |
| https://github.com/legendecas |
| legendecas | https://github.com/legendecas |
| stale review | https://github.com/nodejs/node/pull/56073#pullrequestreview-2472992183 |
| December 2, 2024 15:19 | https://github.com/nodejs/node/pull/56073#event-15494720706 |
| https://github.com/wraithgar |
| wraithgar | https://github.com/wraithgar |
| Dec 2, 2024 | https://github.com/nodejs/node/pull/56073#issuecomment-2511943901 |
| 10.3.0 | https://github.com/nodejs/node-gyp/pull/3050 |
| Please reload this page | https://github.com/nodejs/node/pull/56073 |
| https://github.com/legendecas |
| legendecas | https://github.com/legendecas |
| Dec 2, 2024 | https://github.com/nodejs/node/pull/56073#issuecomment-2512040969 |
| Please reload this page | https://github.com/nodejs/node/pull/56073 |
| nodejs/node-gyp#3099 | https://github.com/nodejs/node-gyp/pull/3099 |
| Please reload this page | https://github.com/nodejs/node/pull/56073 |
| https://github.com/StefanStojanovic |
| StefanStojanovic | https://github.com/StefanStojanovic |
| Dec 2, 2024 | https://github.com/nodejs/node/pull/56073#issuecomment-2512517593 |
| Please reload this page | https://github.com/nodejs/node/pull/56073 |
| https://github.com/legendecas |
| legendecas | https://github.com/legendecas |
| Dec 2, 2024 | https://github.com/nodejs/node/pull/56073#issuecomment-2512805562 |
| https://www.npmjs.com/package/node-gyp/v/10.3.1 | https://www.npmjs.com/package/node-gyp/v/10.3.1 |
| Please reload this page | https://github.com/nodejs/node/pull/56073 |
| https://github.com/wraithgar |
| wraithgar | https://github.com/wraithgar |
| Dec 4, 2024 | https://github.com/nodejs/node/pull/56073#issuecomment-2518787788 |
| npm@10.9.2 | https://github.com/nodejs/node/pull/56135 |
| Please reload this page | https://github.com/nodejs/node/pull/56073 |
| https://github.com/lukekarrys |
| lukekarrys | https://github.com/lukekarrys |
| Dec 5, 2024 | https://github.com/nodejs/node/pull/56073#issuecomment-2521181329 |
| #56135 | https://github.com/nodejs/node/pull/56135 |
| Please reload this page | https://github.com/nodejs/node/pull/56073 |
| https://github.com/StefanStojanovic |
| StefanStojanovic | https://github.com/StefanStojanovic |
| Dec 6, 2024 | https://github.com/nodejs/node/pull/56073#event-15557040132 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F56073 |
|
| https://github.com/legendecas |
|
legendecas
| https://github.com/legendecas |
|
build
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild |
|
fast-track
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
npm
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anpm |
|
windows
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awindows |
| Please reload this page | https://github.com/nodejs/node/pull/56073 |
|
| https://github.com/StefanStojanovic |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/legendecas |
|
| https://github.com/wraithgar |
|
| https://github.com/lukekarrys |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |