René's URL Explorer Experiment


Title: sqlite: refactor open options by tniessen · Pull Request #55442 · nodejs/node · GitHub

Open Graph Title: sqlite: refactor open options by tniessen · Pull Request #55442 · nodejs/node

X Title: sqlite: refactor open options by tniessen · Pull Request #55442 · nodejs/node

Description: Move options that are only relevant for opening the database into a self-contained class. Refs: #54777 (comment)

Open Graph Description: Move options that are only relevant for opening the database into a self-contained class. Refs: #54777 (comment)

X Description: Move options that are only relevant for opening the database into a self-contained class. Refs: #54777 (comment)

Opengraph URL: https://github.com/nodejs/node/pull/55442

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:900b1199-1d23-e9f8-9437-14ec1ae0a5f1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD798:37464F:B402DA:FDB782:696A1DE2
html-safe-noncec327f70e9552698c3d3a0557d567244bd5f26ff764eaeb645138856bf41e1c61
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENzk4OjM3NDY0RjpCNDAyREE6RkRCNzgyOjY5NkExREUyIiwidmlzaXRvcl9pZCI6IjU5Mjc4ODgwNDY2NTkzNDU4OTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac1785896a74fe8a420a07e36073af3006a815112349254f1a6fef5306acf3d6eb
hovercard-subject-tagpull_request:2132066819
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/55442/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c8b579a3f0b2b8d598086dc1e236bcd861e1a96b0b43eb76d78011030df2e158/nodejs/node/pull/55442
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c8b579a3f0b2b8d598086dc1e236bcd861e1a96b0b43eb76d78011030df2e158/nodejs/node/pull/55442
og:image:altMove options that are only relevant for opening the database into a self-contained class. Refs: #54777 (comment)
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametniessen
hostnamegithub.com
expected-hostnamegithub.com
None014f3d193f36b7d393f88ca22d06fbacd370800b40a547c1ea67291e02dc8ea3
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
released515f6f09fa57a93bf90355cb894eb84ca4f458f
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/55442#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F55442
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F55442
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/55442
Reloadhttps://github.com/nodejs/node/pull/55442
Reloadhttps://github.com/nodejs/node/pull/55442
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/55442
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 698 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/55442
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/55442#issue-comment-box
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
tniessen:sqlite-refactor-open-optionshttps://github.com/tniessen/node/tree/sqlite-refactor-open-options
sqlite: refactor open options https://github.com/nodejs/node/pull/55442#top
nodejs-github-bothttps://github.com/nodejs-github-bot
nodejs:mainhttps://github.com/nodejs/node/tree/main
tniessen:sqlite-refactor-open-optionshttps://github.com/tniessen/node/tree/sqlite-refactor-open-options
Conversation 4 https://github.com/nodejs/node/pull/55442
Commits 1 https://github.com/nodejs/node/pull/55442/commits
Checks 0 https://github.com/nodejs/node/pull/55442/checks
Files changed https://github.com/nodejs/node/pull/55442/files
Please reload this pagehttps://github.com/nodejs/node/pull/55442
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Oct 18, 2024https://github.com/nodejs/node/pull/55442#issue-2597050764
#54777 (comment)https://github.com/nodejs/node/pull/54777#discussion_r1745988310
Please reload this pagehttps://github.com/nodejs/node/pull/55442
https://github.com/tniessen
sqlite: refactor open optionshttps://github.com/nodejs/node/pull/55442/commits/dc87f5ce353f96c022ce51de16592faefcf5cb0b
dc87f5chttps://github.com/nodejs/node/pull/55442/commits/dc87f5ce353f96c022ce51de16592faefcf5cb0b
https://github.com/tniessen
tniessenhttps://github.com/tniessen
sqlite https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asqlite
Oct 18, 2024https://github.com/nodejs/node/pull/55442#event-14716617535
https://github.com/tniessen
tniessenhttps://github.com/tniessen
jasnellhttps://github.com/jasnell
October 18, 2024 09:54https://github.com/nodejs/node/pull/55442#event-14716617546
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
Oct 18, 2024https://github.com/nodejs/node/pull/55442#event-14716620644
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Oct 18, 2024https://github.com/nodejs/node/pull/55442#issuecomment-2422239276
Please reload this pagehttps://github.com/nodejs/node/pull/55442
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/55442?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
(ddfef05)https://app.codecov.io/gh/nodejs/node/commit/ddfef05f118e77cdb80a1f5971f076a03d221cb1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
(dc87f5c)https://app.codecov.io/gh/nodejs/node/commit/dc87f5ce353f96c022ce51de16592faefcf5cb0b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/55442?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
src/node_sqlite.cchttps://app.codecov.io/gh/nodejs/node/pull/55442?src=pr&el=tree&filepath=src%2Fnode_sqlite.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfc3FsaXRlLmNj
1 Missing and 1 partial ⚠️ https://app.codecov.io/gh/nodejs/node/pull/55442?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/55442?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
src/node_sqlite.hhttps://app.codecov.io/gh/nodejs/node/pull/55442?src=pr&el=tree&filepath=src%2Fnode_sqlite.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfc3FsaXRlLmg=
src/node_sqlite.cchttps://app.codecov.io/gh/nodejs/node/pull/55442?src=pr&el=tree&filepath=src%2Fnode_sqlite.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfc3FsaXRlLmNj
104 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/55442/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Please reload this pagehttps://github.com/nodejs/node/pull/55442
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Oct 18, 2024 https://github.com/nodejs/node/pull/55442#pullrequestreview-2377857073
View reviewed changes https://github.com/nodejs/node/pull/55442/files/dc87f5ce353f96c022ce51de16592faefcf5cb0b
https://github.com/tniessen
tniessenhttps://github.com/tniessen
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Oct 24, 2024https://github.com/nodejs/node/pull/55442#event-14855966551
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Oct 24, 2024https://github.com/nodejs/node/pull/55442#event-14856029639
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 24, 2024https://github.com/nodejs/node/pull/55442#issuecomment-2435939142
https://ci.nodejs.org/job/node-test-pull-request/63277/https://ci.nodejs.org/job/node-test-pull-request/63277/
Please reload this pagehttps://github.com/nodejs/node/pull/55442
https://github.com/tniessen
tniessenhttps://github.com/tniessen
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Oct 24, 2024https://github.com/nodejs/node/pull/55442#event-14859831288
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue-failed https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-failed
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Oct 24, 2024https://github.com/nodejs/node/pull/55442#event-14859860985
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 24, 2024https://github.com/nodejs/node/pull/55442#issuecomment-2436515762
https://github.com/nodejs/node/actions/runs/11509076184https://github.com/nodejs/node/actions/runs/11509076184
Please reload this pagehttps://github.com/nodejs/node/pull/55442
https://github.com/tniessen
tniessenhttps://github.com/tniessen
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
commit-queue-failed https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-failed
Oct 26, 2024https://github.com/nodejs/node/pull/55442#event-14887847328
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Oct 26, 2024https://github.com/nodejs/node/pull/55442#event-14888264178
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
0668e64https://github.com/nodejs/node/commit/0668e64cea127d8d4fa35d1b49bf11093ecc728f
Oct 26, 2024https://github.com/nodejs/node/pull/55442#event-14888265909
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 26, 2024https://github.com/nodejs/node/pull/55442#issuecomment-2439076470
0668e64https://github.com/nodejs/node/commit/0668e64cea127d8d4fa35d1b49bf11093ecc728f
Please reload this pagehttps://github.com/nodejs/node/pull/55442
RafaelGSShttps://github.com/RafaelGSS
Nov 1, 2024 https://github.com/nodejs/node/pull/55442#ref-commit-88c7f5b
https://github.com/tniessen
https://github.com/RafaelGSS
sqlite: refactor open optionshttps://github.com/nodejs/node/commit/88c7f5b489f5c4869a1d0337265cc174423e24d4
88c7f5bhttps://github.com/nodejs/node/commit/88c7f5b489f5c4869a1d0337265cc174423e24d4
#55442https://github.com/nodejs/node/pull/55442
louwershttps://github.com/louwers
Nov 2, 2024 https://github.com/nodejs/node/pull/55442#ref-commit-b5540df
https://github.com/tniessen
https://github.com/louwers
sqlite: refactor open optionshttps://github.com/louwers/node/commit/b5540df0ac3e37cd57af443afd55f208f5ec1b76
b5540dfhttps://github.com/louwers/node/commit/b5540df0ac3e37cd57af443afd55f208f5ec1b76
nodejs#55442https://github.com/nodejs/node/pull/55442
https://github.com/aduh95
aduh95https://github.com/aduh95
Nov 6, 2024 https://github.com/nodejs/node/pull/55442#ref-pullrequest-2637740329
2024-11-11, Version 23.2.0 (Current) #55741 https://github.com/nodejs/node/pull/55741
tpoisseauhttps://github.com/tpoisseau
Nov 21, 2024 https://github.com/nodejs/node/pull/55442#ref-commit-1d49bb9
https://github.com/tniessen
https://github.com/tpoisseau
sqlite: refactor open optionshttps://github.com/tpoisseau/node/commit/1d49bb964709f8df67c42b532df4ea3010cbe125
1d49bb9https://github.com/tpoisseau/node/commit/1d49bb964709f8df67c42b532df4ea3010cbe125
nodejs#55442https://github.com/nodejs/node/pull/55442
ruyadornohttps://github.com/ruyadorno
Nov 27, 2024 https://github.com/nodejs/node/pull/55442#ref-commit-d51654c
https://github.com/tniessen
https://github.com/ruyadorno
sqlite: refactor open optionshttps://github.com/nodejs/node/commit/d51654c17bd77afa734365d85af365991859e0d7
d51654chttps://github.com/nodejs/node/commit/d51654c17bd77afa734365d85af365991859e0d7
#55442https://github.com/nodejs/node/pull/55442
ruyadornohttps://github.com/ruyadorno
Nov 27, 2024 https://github.com/nodejs/node/pull/55442#ref-commit-80e2939
https://github.com/tniessen
https://github.com/ruyadorno
sqlite: refactor open optionshttps://github.com/nodejs/node/commit/80e2939b236953f6292dbfc0e0d9054a3ce3cbb9
80e2939https://github.com/nodejs/node/commit/80e2939b236953f6292dbfc0e0d9054a3ce3cbb9
#55442https://github.com/nodejs/node/pull/55442
ruyadornohttps://github.com/ruyadorno
Nov 27, 2024 https://github.com/nodejs/node/pull/55442#ref-commit-8c35ad1
https://github.com/tniessen
https://github.com/ruyadorno
sqlite: refactor open optionshttps://github.com/nodejs/node/commit/8c35ad12de4c8918190f1f3d835c9bf6e10eccd2
8c35ad1https://github.com/nodejs/node/commit/8c35ad12de4c8918190f1f3d835c9bf6e10eccd2
#55442https://github.com/nodejs/node/pull/55442
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Nov 27, 2024 https://github.com/nodejs/node/pull/55442#ref-pullrequest-2699543545
2024-12-03, Version 22.12.0 'Jod' (LTS) #56040 https://github.com/nodejs/node/pull/56040
tmeijnhttps://github.com/tmeijn
Dec 5, 2024 https://github.com/nodejs/node/pull/55442#ref-commit-45ce89a
https://github.com/tmeijn
build(deps): update node to v22https://github.com/tmeijn/dotfiles/commit/45ce89aeadd37c6bbc40b837abfa0568f0160482
45ce89ahttps://github.com/tmeijn/dotfiles/commit/45ce89aeadd37c6bbc40b837abfa0568f0160482
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F55442
https://github.com/benjamingr
benjamingr https://github.com/benjamingr
https://github.com/nodejs/node/pull/55442/files/dc87f5ce353f96c022ce51de16592faefcf5cb0b
https://github.com/jasnell
jasnell https://github.com/jasnell
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
sqlite https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asqlite
Please reload this pagehttps://github.com/nodejs/node/pull/55442
https://github.com/tniessen
https://github.com/nodejs-github-bot
https://github.com/benjamingr
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.