René's URL Explorer Experiment


Title: fix: Ensure `Duplex streams` are returned unwrapped in stream operators by KunalKumar-1 · Pull Request #55394 · nodejs/node · GitHub

Open Graph Title: fix: Ensure `Duplex streams` are returned unwrapped in stream operators by KunalKumar-1 · Pull Request #55394 · nodejs/node

X Title: fix: Ensure `Duplex streams` are returned unwrapped in stream operators by KunalKumar-1 · Pull Request #55394 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Updated the implementation of the readable.compose() method to ensure that it correctly returns a Duplex stream when applicable, avoiding unintended conversion to Readable streams. fixes: #55203

X Description: Updated the implementation of the readable.compose() method to ensure that it correctly returns a Duplex stream when applicable, avoiding unintended conversion to Readable streams. fixes: #55203

Opengraph URL: https://github.com/nodejs/node/pull/55394

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f7ee7ecf-0b5a-2ca4-98b2-145d9796d548
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBFE6:53D51:1C04838:284E99F:6A4CE327
html-safe-noncefb4665aad0a931a9839a573ba089e1312e0df0aaacb4dc7665697ded1033c4c1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRkU2OjUzRDUxOjFDMDQ4Mzg6Mjg0RTk5Rjo2QTRDRTMyNyIsInZpc2l0b3JfaWQiOiI2Mzk3MjIwNjc5NTQ4OTg2MTUxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac282c6fa22f864b7ac4f9d7a3b57f7b6d42400b7d610fa0980038dad7d097c267
hovercard-subject-tagpull_request:2125416141
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/55394/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/aa4ff49e2ff40706709ee199ddd34318479923c367b859ead95e4fad1eba2a27/nodejs/node/pull/55394
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/aa4ff49e2ff40706709ee199ddd34318479923c367b859ead95e4fad1eba2a27/nodejs/node/pull/55394
og:image:altUpdated the implementation of the readable.compose() method to ensure that it correctly returns a Duplex stream when applicable, avoiding unintended conversion to Readable streams. fixes: #55203
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameKunalKumar-1
hostnamegithub.com
expected-hostnamegithub.com
None299b43bca6e02ad35197ffeba30d2466846d5fb02ab96fbced5b5e6cec589fb8
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasec5a57f04eeb310f57c73fd6d751d957e2ca27ed2
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/55394#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F55394
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F55394
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/55394
Reloadhttps://github.com/nodejs/node/pull/55394
Reloadhttps://github.com/nodejs/node/pull/55394
Please reload this pagehttps://github.com/nodejs/node/pull/55394
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/55394
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 961 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
KunalKumar-1https://github.com/KunalKumar-1
nodejs:mainhttps://github.com/nodejs/node/tree/main
KunalKumar-1:duplex-stream-handlinghttps://github.com/KunalKumar-1/node/tree/duplex-stream-handling
Conversationhttps://github.com/nodejs/node/pull/55394
Commits3 (3)https://github.com/nodejs/node/pull/55394/commits
Checkshttps://github.com/nodejs/node/pull/55394/checks
Files changedhttps://github.com/nodejs/node/pull/55394/files
fix: Ensure Duplex streams are returned unwrapped in stream operators https://github.com/nodejs/node/pull/55394#top
KunalKumar-1https://github.com/KunalKumar-1
nodejs:mainhttps://github.com/nodejs/node/tree/main
KunalKumar-1:duplex-stream-handlinghttps://github.com/KunalKumar-1/node/tree/duplex-stream-handling
https://github.com/KunalKumar-1
KunalKumar-1https://github.com/KunalKumar-1
Oct 15, 2024https://github.com/nodejs/node/pull/55394#issue-2588941476
Please reload this pagehttps://github.com/nodejs/node/pull/55394
#55203https://github.com/nodejs/node/issues/55203
Please reload this pagehttps://github.com/nodejs/node/pull/55394
fix: Ensure Duplex streams are returned unwrapped in stream operatorshttps://github.com/nodejs/node/pull/55394/commits/fd412e31419828ae70f4898330acdc18dabaf747
fd412e3https://github.com/nodejs/node/pull/55394/commits/fd412e31419828ae70f4898330acdc18dabaf747
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 15, 2024https://github.com/nodejs/node/pull/55394#issuecomment-2414066555
Please reload this pagehttps://github.com/nodejs/node/pull/55394
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Oct 15, 2024https://github.com/nodejs/node/pull/55394#event-14658620530
https://github.com/avivkeller
avivkellerhttps://github.com/avivkeller
Oct 15, 2024https://github.com/nodejs/node/pull/55394#issuecomment-2414484150
Please reload this pagehttps://github.com/nodejs/node/pull/55394
https://github.com/KunalKumar-1
test: added tests for duplex stream functionalityhttps://github.com/nodejs/node/pull/55394/commits/90ac00d50d0c5d12829255f6eded72484068e1d6
90ac00dhttps://github.com/nodejs/node/pull/55394/commits/90ac00d50d0c5d12829255f6eded72484068e1d6
https://github.com/KunalKumar-1
KunalKumar-1https://github.com/KunalKumar-1
force-pushedhttps://github.com/nodejs/node/compare/01ed5136ad167580f7fdab50cd5ab3f96e3fd419..90ac00d50d0c5d12829255f6eded72484068e1d6
01ed513https://github.com/nodejs/node/commit/01ed5136ad167580f7fdab50cd5ab3f96e3fd419
90ac00dhttps://github.com/nodejs/node/commit/90ac00d50d0c5d12829255f6eded72484068e1d6
Compare https://github.com/nodejs/node/compare/01ed5136ad167580f7fdab50cd5ab3f96e3fd419..90ac00d50d0c5d12829255f6eded72484068e1d6
October 15, 2024 18:36https://github.com/nodejs/node/pull/55394#event-14662481229
https://github.com/KunalKumar-1
KunalKumar-1https://github.com/KunalKumar-1
Oct 15, 2024https://github.com/nodejs/node/pull/55394#issuecomment-2414746914
@redyetidevhttps://github.com/redyetidev
Please reload this pagehttps://github.com/nodejs/node/pull/55394
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Oct 15, 2024 https://github.com/nodejs/node/pull/55394#pullrequestreview-2370417222
View reviewed changes https://github.com/nodejs/node/pull/55394/files/4f53c668910b1707719e3b37fbe38a7801fabe13
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/55394#pullrequestreview-2370417222
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/55394
https://github.com/mcollina
mcollinahttps://github.com/mcollina
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Oct 15, 2024https://github.com/nodejs/node/pull/55394#event-14663367864
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Oct 15, 2024https://github.com/nodejs/node/pull/55394#event-14663431674
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Oct 15, 2024https://github.com/nodejs/node/pull/55394#issuecomment-2414889138
https://ci.nodejs.org/job/node-test-pull-request/63127/https://ci.nodejs.org/job/node-test-pull-request/63127/
Please reload this pagehttps://github.com/nodejs/node/pull/55394
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Oct 15, 2024https://github.com/nodejs/node/pull/55394#issuecomment-2415175967
Please reload this pagehttps://github.com/nodejs/node/pull/55394
Codecovhttps://app.codecov.io/gh/nodejs/node/pull/55394?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
(51d8146)https://app.codecov.io/gh/nodejs/node/commit/51d81466efc00417711558a08d0ff4206d8bf174?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
(90ac00d)https://app.codecov.io/gh/nodejs/node/commit/90ac00d50d0c5d12829255f6eded72484068e1d6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/55394?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/stream.jshttps://app.codecov.io/gh/nodejs/node/pull/55394?src=pr&el=tree&filepath=lib%2Fstream.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL3N0cmVhbS5qcw==
2 Missing and 1 partial ⚠️ https://app.codecov.io/gh/nodejs/node/pull/55394?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Files with missing lineshttps://app.codecov.io/gh/nodejs/node/pull/55394?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
lib/stream.jshttps://app.codecov.io/gh/nodejs/node/pull/55394?src=pr&el=tree&filepath=lib%2Fstream.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL3N0cmVhbS5qcw==
32 files with indirect coverage changeshttps://app.codecov.io/gh/nodejs/node/pull/55394/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs
Please reload this pagehttps://github.com/nodejs/node/pull/55394
https://github.com/KunalKumar-1
KunalKumar-1https://github.com/KunalKumar-1
Oct 16, 2024https://github.com/nodejs/node/pull/55394#issuecomment-2415747156
Please reload this pagehttps://github.com/nodejs/node/pull/55394
@mcollinahttps://github.com/mcollina
Please reload this pagehttps://github.com/nodejs/node/pull/55394
https://github.com/ronag
ronaghttps://github.com/ronag
Oct 16, 2024 https://github.com/nodejs/node/pull/55394#pullrequestreview-2371288402
View reviewed changes https://github.com/nodejs/node/pull/55394/files/90ac00d50d0c5d12829255f6eded72484068e1d6
ronaghttps://github.com/ronag
Please reload this pagehttps://github.com/nodejs/node/pull/55394
https://github.com/nodejs/node/pull/55394#pullrequestreview-2371288402
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@mcollinahttps://github.com/mcollina
@lpincahttps://github.com/lpinca
Please reload this pagehttps://github.com/nodejs/node/pull/55394
https://github.com/KunalKumar-1
KunalKumar-1https://github.com/KunalKumar-1
Oct 16, 2024https://github.com/nodejs/node/pull/55394#issuecomment-2415928502
Please reload this pagehttps://github.com/nodejs/node/pull/55394
@ronaghttps://github.com/ronag
Please reload this pagehttps://github.com/nodejs/node/pull/55394
https://github.com/ronag
ronaghttps://github.com/ronag
Oct 16, 2024https://github.com/nodejs/node/pull/55394#issuecomment-2415959795
Please reload this pagehttps://github.com/nodejs/node/pull/55394
Please reload this pagehttps://github.com/nodejs/node/pull/55394
https://github.com/ronag
ronaghttps://github.com/ronag
Oct 16, 2024https://github.com/nodejs/node/pull/55394#issuecomment-2415961883
Please reload this pagehttps://github.com/nodejs/node/pull/55394
https://github.com/KunalKumar-1
KunalKumar-1https://github.com/KunalKumar-1
Oct 16, 2024https://github.com/nodejs/node/pull/55394#issuecomment-2416091454
Please reload this pagehttps://github.com/nodejs/node/pull/55394
https://github.com/ronag
ronaghttps://github.com/ronag
Oct 16, 2024https://github.com/nodejs/node/pull/55394#issuecomment-2416141369
Please reload this pagehttps://github.com/nodejs/node/pull/55394
https://github.com/KunalKumar-1
KunalKumar-1https://github.com/KunalKumar-1
Oct 16, 2024https://github.com/nodejs/node/pull/55394#issuecomment-2416170198
Please reload this pagehttps://github.com/nodejs/node/pull/55394
Please reload this pagehttps://github.com/nodejs/node/pull/55394
https://github.com/KunalKumar-1
KunalKumar-1https://github.com/KunalKumar-1
mcollinahttps://github.com/mcollina
October 16, 2024 11:15https://github.com/nodejs/node/pull/55394#event-14674740044
https://github.com/KunalKumar-1
Merge branch 'nodejs:main' into duplex-stream-handlinghttps://github.com/nodejs/node/pull/55394/commits/4f53c668910b1707719e3b37fbe38a7801fabe13
4f53c66https://github.com/nodejs/node/pull/55394/commits/4f53c668910b1707719e3b37fbe38a7801fabe13
https://github.com/Renegade334
Renegade334https://github.com/Renegade334
Oct 17, 2024https://github.com/nodejs/node/pull/55394#issuecomment-2419996685
Please reload this pagehttps://github.com/nodejs/node/pull/55394
Please reload this pagehttps://github.com/nodejs/node/pull/55394
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F55394
https://github.com/ronag
ronag https://github.com/ronag
https://github.com/nodejs/node/pull/55394/files/90ac00d50d0c5d12829255f6eded72484068e1d6
https://github.com/mcollina
mcollina https://github.com/mcollina
needs-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
stream: readable.compose fails to return a Duplex https://github.com/nodejs/node/issues/55203
Please reload this pagehttps://github.com/nodejs/node/pull/55394
https://github.com/KunalKumar-1
https://github.com/nodejs-github-bot
https://github.com/avivkeller
https://github.com/ronag
https://github.com/Renegade334
https://github.com/mcollina
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.