René's URL Explorer Experiment


Title: Enable linting for benchmarks by Trott · Pull Request #5517 · nodejs/node · GitHub

Open Graph Title: Enable linting for benchmarks by Trott · Pull Request #5517 · nodejs/node

X Title: Enable linting for benchmarks by Trott · Pull Request #5517 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Refactor benchmarks to conform with existing lint rules. (In the process, a few broken benchmarks were fixed, e.g. the one for domains.) Enable linting for benchmarks. /cc @nodejs/benchmarking @mscdex

X Description: Refactor benchmarks to conform with existing lint rules. (In the process, a few broken benchmarks were fixed, e.g. the one for domains.) Enable linting for benchmarks. /cc @nodejs/benchmarking @mscdex

Opengraph URL: https://github.com/nodejs/node/pull/5517

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f6f26ba6-bff4-c7ed-fb7b-55ba9d5df454
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA674:3D7639:D17B3C:12F795A:6A4E4CCC
html-safe-nonceaaf8dd5be1ae412b53dface6a7a28bf7f20ba4730fba3a6e30de021141305029
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNjc0OjNENzYzOTpEMTdCM0M6MTJGNzk1QTo2QTRFNENDQyIsInZpc2l0b3JfaWQiOiI1NDA5NjQ1MzM5ODQ0OTU1MzQwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac3f4a80976cf564a34b841bb052bf94b1001ecc0a48688ad799cf412e9becf6d4
hovercard-subject-tagpull_request:61333111
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/5517/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/cb5432eadf0be56242b8f358b90d3bc4e7644d52beca6e2752e6e1882717fb98/nodejs/node/pull/5517
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/cb5432eadf0be56242b8f358b90d3bc4e7644d52beca6e2752e6e1882717fb98/nodejs/node/pull/5517
og:image:altRefactor benchmarks to conform with existing lint rules. (In the process, a few broken benchmarks were fixed, e.g. the one for domains.) Enable linting for benchmarks. /cc @nodejs/benchmarking @mscdex
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameTrott
hostnamegithub.com
expected-hostnamegithub.com
None030096ee0db095447bfe77409d33bfac127ca7128299c58deef27c52eaa1b1f0
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef344f1eab54fc7dfc02d0d018cda7e158c3db65c
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/5517#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F5517
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F5517
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/5517
Reloadhttps://github.com/nodejs/node/pull/5517
Reloadhttps://github.com/nodejs/node/pull/5517
Please reload this pagehttps://github.com/nodejs/node/pull/5517
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/5517
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 965 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Trotthttps://github.com/Trott
nodejs:masterhttps://github.com/nodejs/node/tree/master
Trott:simplifyhttps://github.com/Trott/io.js/tree/simplify
Conversationhttps://github.com/nodejs/node/pull/5517
Commits2 (2)https://github.com/nodejs/node/pull/5517/commits
Checkshttps://github.com/nodejs/node/pull/5517/checks
Files changedhttps://github.com/nodejs/node/pull/5517/files
Enable linting for benchmarkshttps://github.com/nodejs/node/pull/5517#top
Trotthttps://github.com/Trott
nodejs:masterhttps://github.com/nodejs/node/tree/master
Trott:simplifyhttps://github.com/Trott/io.js/tree/simplify
https://github.com/Trott
Trotthttps://github.com/Trott
Mar 2, 2016https://github.com/nodejs/node/pull/5517#issue-137733358
@mscdexhttps://github.com/mscdex
Please reload this pagehttps://github.com/nodejs/node/pull/5517
https://github.com/Trott
Trotthttps://github.com/Trott
benchmark https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abenchmark
tools https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools
lts-watch-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x
Mar 2, 2016https://github.com/nodejs/node/pull/5517#event-573936817
https://github.com/Trott
Trotthttps://github.com/Trott
Mar 2, 2016https://github.com/nodejs/node/pull/5517#issuecomment-190988567
https://ci.nodejs.org/job/node-test-pull-request/1801/https://ci.nodejs.org/job/node-test-pull-request/1801/
Please reload this pagehttps://github.com/nodejs/node/pull/5517
mscdexhttps://github.com/mscdex
Mar 2, 2016 https://github.com/nodejs/node/pull/5517#discussion-diff-54671226
View reviewed changes https://github.com/nodejs/node/pull/5517/files#diff-d3ecfc06d5f8256be704501b4c88633a1d631fc05b0d59f7afd878c87bbe228e
benchmark/buffers/buffer-indexof.jshttps://github.com/nodejs/node/pull/5517/files#diff-d3ecfc06d5f8256be704501b4c88633a1d631fc05b0d59f7afd878c87bbe228e
mscdexhttps://github.com/mscdex
Mar 2, 2016https://github.com/nodejs/node/pull/5517#discussion_r54671226
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/5517
Trotthttps://github.com/Trott
Mar 2, 2016https://github.com/nodejs/node/pull/5517#discussion_r54676713
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/5517
https://github.com/Trott
Trotthttps://github.com/Trott
Mar 2, 2016https://github.com/nodejs/node/pull/5517#issuecomment-191047353
@mscdexhttps://github.com/mscdex
Please reload this pagehttps://github.com/nodejs/node/pull/5517
https://github.com/mscdex
mscdexhttps://github.com/mscdex
Mar 2, 2016https://github.com/nodejs/node/pull/5517#issuecomment-191050071
Please reload this pagehttps://github.com/nodejs/node/pull/5517
https://github.com/Trott
Trotthttps://github.com/Trott
Mar 2, 2016https://github.com/nodejs/node/pull/5517#issuecomment-191059294
https://ci.nodejs.org/job/node-test-pull-request/1802/https://ci.nodejs.org/job/node-test-pull-request/1802/
Please reload this pagehttps://github.com/nodejs/node/pull/5517
https://github.com/targos
targoshttps://github.com/targos
Mar 2, 2016https://github.com/nodejs/node/pull/5517#issuecomment-191137931
Please reload this pagehttps://github.com/nodejs/node/pull/5517
https://github.com/evanlucas
evanlucashttps://github.com/evanlucas
Mar 2, 2016https://github.com/nodejs/node/pull/5517#issuecomment-191213971
Please reload this pagehttps://github.com/nodejs/node/pull/5517
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Mar 2, 2016https://github.com/nodejs/node/pull/5517#issuecomment-191350780
Please reload this pagehttps://github.com/nodejs/node/pull/5517
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Mar 2, 2016https://github.com/nodejs/node/pull/5517#issuecomment-191350867
Please reload this pagehttps://github.com/nodejs/node/pull/5517
https://github.com/Trott
Trotthttps://github.com/Trott
force-pushedhttps://github.com/nodejs/node/compare/7b98469865d36fd1ae2de86bfafbebca8691fd58..a73f19503aea8eda7edf751c90d99b9a7abd198f
7b98469https://github.com/nodejs/node/commit/7b98469865d36fd1ae2de86bfafbebca8691fd58
a73f195https://github.com/nodejs/node/commit/a73f19503aea8eda7edf751c90d99b9a7abd198f
Compare https://github.com/nodejs/node/compare/7b98469865d36fd1ae2de86bfafbebca8691fd58..a73f19503aea8eda7edf751c90d99b9a7abd198f
March 2, 2016 21:35https://github.com/nodejs/node/pull/5517#event-575341614
Trotthttps://github.com/Trott
March 2, 2016 13:38https://github.com/nodejs/node/pull/5517#commits-pushed-37cc637
https://github.com/Trott
benchmark: fix lint errorshttps://github.com/nodejs/node/pull/5517/commits/37cc6378a78b4ad392087ec6eaaaa4baa1b0188b
37cc637https://github.com/nodejs/node/pull/5517/commits/37cc6378a78b4ad392087ec6eaaaa4baa1b0188b
https://github.com/Trott
tools: enable linting for benchmarkshttps://github.com/nodejs/node/pull/5517/commits/634c9946d28b2971b4c8d28c7ce7516ab5d4fd2c
634c994https://github.com/nodejs/node/pull/5517/commits/634c9946d28b2971b4c8d28c7ce7516ab5d4fd2c
https://github.com/Trott
Trotthttps://github.com/Trott
force-pushedhttps://github.com/nodejs/node/compare/a73f19503aea8eda7edf751c90d99b9a7abd198f..634c9946d28b2971b4c8d28c7ce7516ab5d4fd2c
a73f195https://github.com/nodejs/node/commit/a73f19503aea8eda7edf751c90d99b9a7abd198f
634c994https://github.com/nodejs/node/commit/634c9946d28b2971b4c8d28c7ce7516ab5d4fd2c
Compare https://github.com/nodejs/node/compare/a73f19503aea8eda7edf751c90d99b9a7abd198f..634c9946d28b2971b4c8d28c7ce7516ab5d4fd2c
March 2, 2016 21:38https://github.com/nodejs/node/pull/5517#event-575345914
https://github.com/Trott
Trotthttps://github.com/Trott
Mar 2, 2016https://github.com/nodejs/node/pull/5517#issuecomment-191447526
@jasnellhttps://github.com/jasnell
Please reload this pagehttps://github.com/nodejs/node/pull/5517
jasnellhttps://github.com/jasnell
Mar 3, 2016 https://github.com/nodejs/node/pull/5517#ref-commit-1bedeeb
https://github.com/Trott
https://github.com/jasnell
benchmark: fix lint errorshttps://github.com/nodejs/node/commit/1bedeeb41d0ca8eb6e4d116fb295121b087ed4e1
1bedeebhttps://github.com/nodejs/node/commit/1bedeeb41d0ca8eb6e4d116fb295121b087ed4e1
#5517https://github.com/nodejs/node/pull/5517
jasnellhttps://github.com/jasnell
Mar 3, 2016 https://github.com/nodejs/node/pull/5517#ref-commit-6d22003
https://github.com/Trott
https://github.com/jasnell
tools: enable linting for benchmarkshttps://github.com/nodejs/node/commit/6d22003757c22cd3818feaa07eb8180e5b93580d
6d22003https://github.com/nodejs/node/commit/6d22003757c22cd3818feaa07eb8180e5b93580d
#5517https://github.com/nodejs/node/pull/5517
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Mar 3, 2016https://github.com/nodejs/node/pull/5517#issuecomment-191886411
1bedeebhttps://github.com/nodejs/node/commit/1bedeeb41d0ca8eb6e4d116fb295121b087ed4e1
Please reload this pagehttps://github.com/nodejs/node/pull/5517
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Mar 3, 2016https://github.com/nodejs/node/pull/5517#event-576613612
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Mar 7, 2016 https://github.com/nodejs/node/pull/5517#ref-pullrequest-138334003
v5.8.0 proposal #5559 https://github.com/nodejs/node/pull/5559
Fishrock123https://github.com/Fishrock123
Mar 8, 2016 https://github.com/nodejs/node/pull/5517#ref-commit-65f4ecc
https://github.com/Trott
https://github.com/Fishrock123
benchmark: fix lint errorshttps://github.com/nodejs/node/commit/65f4ecc89f9de4e93aa7ac9f172f85c250abc0ef
65f4ecchttps://github.com/nodejs/node/commit/65f4ecc89f9de4e93aa7ac9f172f85c250abc0ef
#5517https://github.com/nodejs/node/pull/5517
Fishrock123https://github.com/Fishrock123
Mar 8, 2016 https://github.com/nodejs/node/pull/5517#ref-commit-2682b1c
https://github.com/Trott
https://github.com/Fishrock123
tools: enable linting for benchmarkshttps://github.com/nodejs/node/commit/2682b1c518bcca1dc152b48aa5315313b02f03d5
2682b1chttps://github.com/nodejs/node/commit/2682b1c518bcca1dc152b48aa5315313b02f03d5
#5517https://github.com/nodejs/node/pull/5517
Fishrock123https://github.com/Fishrock123
Mar 8, 2016 https://github.com/nodejs/node/pull/5517#ref-commit-b955d02
https://github.com/Trott
https://github.com/Fishrock123
benchmark: fix lint errorshttps://github.com/nodejs/node/commit/b955d022666ed50fcb303b23a41ba193a295bdc6
b955d02https://github.com/nodejs/node/commit/b955d022666ed50fcb303b23a41ba193a295bdc6
#5517https://github.com/nodejs/node/pull/5517
Fishrock123https://github.com/Fishrock123
Mar 8, 2016 https://github.com/nodejs/node/pull/5517#ref-commit-9a3e87e
https://github.com/Trott
https://github.com/Fishrock123
tools: enable linting for benchmarkshttps://github.com/nodejs/node/commit/9a3e87e9a8d9c7ed3937a77afe53c8ce5864cdb2
9a3e87ehttps://github.com/nodejs/node/commit/9a3e87e9a8d9c7ed3937a77afe53c8ce5864cdb2
#5517https://github.com/nodejs/node/pull/5517
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Mar 17, 2016https://github.com/nodejs/node/pull/5517#issuecomment-198034959
@Trotthttps://github.com/Trott
Please reload this pagehttps://github.com/nodejs/node/pull/5517
https://github.com/Trott
Trotthttps://github.com/Trott
Mar 18, 2016 https://github.com/nodejs/node/pull/5517#ref-pullrequest-141739693
benchmark,tools: enable linting for benchmarks #5773 https://github.com/nodejs/node/pull/5773
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
dont-land-on-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x
lts-watch-v4.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x
Mar 21, 2016https://github.com/nodejs/node/pull/5517#event-597439861
https://github.com/Trott
Trotthttps://github.com/Trott
January 13, 2022 22:42https://github.com/nodejs/node/pull/5517#event-5890935182
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F5517
benchmark https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abenchmark
tools https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools
Please reload this pagehttps://github.com/nodejs/node/pull/5517
https://github.com/Trott
https://github.com/mscdex
https://github.com/targos
https://github.com/evanlucas
https://github.com/jasnell
https://github.com/MylesBorins
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.