| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:5ea06a56-c636-bd0f-3686-e47de738170c |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E428:383777:2EBD8F0:407C230:6A4F1257 |
| html-safe-nonce | 9b02700ae6d392e63cc450aac8279a7d932eab1d59bdaedb821e2fe2d61c6ac4 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNDI4OjM4Mzc3NzoyRUJEOEYwOjQwN0MyMzA6NkE0RjEyNTciLCJ2aXNpdG9yX2lkIjoiMzM4MTkyNTY2OTQ4Mjk5MjIxNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 4f1bc247f97cc51591553a0456609a9f10e0c872192698799d2489002a53e3d5 |
| hovercard-subject-tag | pull_request:61277645 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/5505/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/004aa2319ba1924173537154feb59dd2c028770689f05d677736ee24c93b6d24/nodejs/node/pull/5505 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/004aa2319ba1924173537154feb59dd2c028770689f05d677736ee24c93b6d24/nodejs/node/pull/5505 |
| og:image:alt | Pull Request check-list
Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
this change (including linting)?
Is the commit message formatted according to CONTRIBUTING.md?
If th... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | billautomata |
| hostname | github.com |
| expected-hostname | github.com |
| None | b92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b8f23afb982271f1b22258a94aede67a6b77760 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/5505#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F5505 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F5505 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/5505 |
| Reload | https://github.com/nodejs/node/pull/5505 |
| Reload | https://github.com/nodejs/node/pull/5505 |
| Please reload this page | https://github.com/nodejs/node/pull/5505 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/5505 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
966
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| billautomata | https://github.com/billautomata |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| billautomata:patch-1 | https://github.com/billautomata/node/tree/patch-1 |
| Conversation | https://github.com/nodejs/node/pull/5505 |
| Commits3 (3) | https://github.com/nodejs/node/pull/5505/commits |
| Checks | https://github.com/nodejs/node/pull/5505/checks |
| Files changed | https://github.com/nodejs/node/pull/5505/files |
| doc: crypto docs updated to use good defaults for createDiffieHellman | https://github.com/nodejs/node/pull/5505#top |
| billautomata | https://github.com/billautomata |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| billautomata:patch-1 | https://github.com/billautomata/node/tree/patch-1 |
|
| https://github.com/billautomata |
| billautomata | https://github.com/billautomata |
| Mar 1, 2016 | https://github.com/nodejs/node/pull/5505#issue-137637101 |
| CONTRIBUTING.md | https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#step-3-commit |
| Diffie-Hellman | https://en.wikipedia.org/wiki/Diffie%E2%80%93Hellman_key_exchange#Cryptographic_explanation |
| Safe Prime | https://en.wikipedia.org/wiki/Safe_prime |
| standard published groups | http://tools.ietf.org/html/rfc3526 |
| Please reload this page | https://github.com/nodejs/node/pull/5505 |
|
| https://github.com/billautomata |
| crypto docs updated to use good defaults | https://github.com/nodejs/node/pull/5505/commits/2193e707ee6e8eb82c22242c734918fd6049ede4 |
| 2193e70 | https://github.com/nodejs/node/pull/5505/commits/2193e707ee6e8eb82c22242c734918fd6049ede4 |
| https://en.wikipedia.org/wiki/Diffie%E2%80%93Hellman_key_exchange#Cryptographic_explanation | https://en.wikipedia.org/wiki/Diffie%E2%80%93Hellman_key_exchange#Cryptographic_explanation |
| https://en.wikipedia.org/wiki/Safe_prime | https://en.wikipedia.org/wiki/Safe_prime |
| http://tools.ietf.org/html/rfc3526 | http://tools.ietf.org/html/rfc3526 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
crypto
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto |
| Mar 1, 2016 | https://github.com/nodejs/node/pull/5505#event-573381373 |
| mscdex | https://github.com/mscdex |
|
Mar 1, 2016
| https://github.com/nodejs/node/pull/5505#discussion-diff-54602981 |
| View reviewed changes
| https://github.com/nodejs/node/pull/5505/files/2193e707ee6e8eb82c22242c734918fd6049ede4#diff-6883ce94a9e40dc03a6928bf09f1f7b4a3cb458e4510559fd4c6ef608a793d55 |
| doc/api/crypto.markdown | https://github.com/nodejs/node/pull/5505/files#diff-6883ce94a9e40dc03a6928bf09f1f7b4a3cb458e4510559fd4c6ef608a793d55 |
| mscdex | https://github.com/mscdex |
| Mar 1, 2016 | https://github.com/nodejs/node/pull/5505#discussion_r54602981 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/5505 |
| billautomata | https://github.com/billautomata |
| Mar 1, 2016 | https://github.com/nodejs/node/pull/5505#discussion_r54603267 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/5505 |
|
| https://github.com/billautomata |
| removed unnecessary encodings | https://github.com/nodejs/node/pull/5505/commits/f3a94e32788d905ab867f0cfc6d62de64fd45f25 |
| f3a94e3 | https://github.com/nodejs/node/pull/5505/commits/f3a94e32788d905ab867f0cfc6d62de64fd45f25 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| Mar 1, 2016 | https://github.com/nodejs/node/pull/5505#issuecomment-190826782 |
| Please reload this page | https://github.com/nodejs/node/pull/5505 |
| indutny | https://github.com/indutny |
|
Mar 1, 2016
| https://github.com/nodejs/node/pull/5505#discussion-diff-54605949 |
| View reviewed changes
| https://github.com/nodejs/node/pull/5505/files/f3a94e32788d905ab867f0cfc6d62de64fd45f25#diff-6883ce94a9e40dc03a6928bf09f1f7b4a3cb458e4510559fd4c6ef608a793d55 |
| doc/api/crypto.markdown | https://github.com/nodejs/node/pull/5505/files#diff-6883ce94a9e40dc03a6928bf09f1f7b4a3cb458e4510559fd4c6ef608a793d55 |
| indutny | https://github.com/indutny |
| Mar 1, 2016 | https://github.com/nodejs/node/pull/5505#discussion_r54605949 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/5505 |
| https://github.com/indutny |
| indutny | https://github.com/indutny |
| Mar 1, 2016 | https://github.com/nodejs/node/pull/5505#issuecomment-190831725 |
| Please reload this page | https://github.com/nodejs/node/pull/5505 |
|
| https://github.com/billautomata |
| removed newline | https://github.com/nodejs/node/pull/5505/commits/0fb7df73e214101c6f759079b9443474dc0f9ca0 |
| 0fb7df7 | https://github.com/nodejs/node/pull/5505/commits/0fb7df73e214101c6f759079b9443474dc0f9ca0 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
lts-watch-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x |
| Mar 2, 2016 | https://github.com/nodejs/node/pull/5505#event-575034499 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Mar 2, 2016 | https://github.com/nodejs/node/pull/5505#issuecomment-191347646 |
| Please reload this page | https://github.com/nodejs/node/pull/5505 |
| https://github.com/billautomata |
| billautomata | https://github.com/billautomata |
| Mar 10, 2016 | https://github.com/nodejs/node/pull/5505#event-584337166 |
| jasnell | https://github.com/jasnell |
|
Mar 21, 2016
| https://github.com/nodejs/node/pull/5505#ref-commit-e136c17 |
|
| https://github.com/billautomata |
|
| https://github.com/jasnell |
| doc: update crypto docs to use good defaults | https://github.com/nodejs/node/commit/e136c179c17011a0c59009b16e9a4428d564b68f |
| e136c17 | https://github.com/nodejs/node/commit/e136c179c17011a0c59009b16e9a4428d564b68f |
| https://en.wikipedia.org/wiki/Diffie%E2%80%93Hellman_key_exchange#Cryptographic_explanation | https://en.wikipedia.org/wiki/Diffie%E2%80%93Hellman_key_exchange#Cryptographic_explanation |
| https://en.wikipedia.org/wiki/Safe_prime | https://en.wikipedia.org/wiki/Safe_prime |
| http://tools.ietf.org/html/rfc3526 | http://tools.ietf.org/html/rfc3526 |
| #5505 | https://github.com/nodejs/node/pull/5505 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Mar 21, 2016 | https://github.com/nodejs/node/pull/5505#issuecomment-199543124 |
| e136c17 | https://github.com/nodejs/node/commit/e136c179c17011a0c59009b16e9a4428d564b68f |
| Please reload this page | https://github.com/nodejs/node/pull/5505 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Mar 21, 2016 | https://github.com/nodejs/node/pull/5505#event-597960156 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Mar 22, 2016
| https://github.com/nodejs/node/pull/5505#ref-pullrequest-142415910 |
|
v5.9.1 Release Proposal
#5831
| https://github.com/nodejs/node/pull/5831 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Mar 22, 2016
| https://github.com/nodejs/node/pull/5505#ref-commit-d2d0fe9 |
|
| https://github.com/billautomata |
|
| https://github.com/Fishrock123 |
| doc: update crypto docs to use good defaults | https://github.com/nodejs/node/commit/d2d0fe9d3419587ecf7a762cfc86f5395d7f0309 |
| d2d0fe9 | https://github.com/nodejs/node/commit/d2d0fe9d3419587ecf7a762cfc86f5395d7f0309 |
| https://en.wikipedia.org/wiki/Diffie%E2%80%93Hellman_key_exchange#Cryptographic_explanation | https://en.wikipedia.org/wiki/Diffie%E2%80%93Hellman_key_exchange#Cryptographic_explanation |
| https://en.wikipedia.org/wiki/Safe_prime | https://en.wikipedia.org/wiki/Safe_prime |
| http://tools.ietf.org/html/rfc3526 | http://tools.ietf.org/html/rfc3526 |
| #5505 | https://github.com/nodejs/node/pull/5505 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Mar 30, 2016 | https://github.com/nodejs/node/pull/5505#event-608698147 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Mar 30, 2016 | https://github.com/nodejs/node/pull/5505#event-608698192 |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 30, 2016
| https://github.com/nodejs/node/pull/5505#ref-commit-f4ac952 |
|
| https://github.com/billautomata |
| doc: update crypto docs to use good defaults | https://github.com/nodejs/node/commit/f4ac9521501b8cc387b5725cf55d678c5d7de76e |
| f4ac952 | https://github.com/nodejs/node/commit/f4ac9521501b8cc387b5725cf55d678c5d7de76e |
| https://en.wikipedia.org/wiki/Diffie%E2%80%93Hellman_key_exchange#Cryptographic_explanation | https://en.wikipedia.org/wiki/Diffie%E2%80%93Hellman_key_exchange#Cryptographic_explanation |
| https://en.wikipedia.org/wiki/Safe_prime | https://en.wikipedia.org/wiki/Safe_prime |
| http://tools.ietf.org/html/rfc3526 | http://tools.ietf.org/html/rfc3526 |
| #5505 | https://github.com/nodejs/node/pull/5505 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aland-on-v4.x |
|
lts-watch-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x |
| Mar 30, 2016 | https://github.com/nodejs/node/pull/5505#event-608698862 |
| MylesBorins | https://github.com/MylesBorins |
|
Mar 30, 2016
| https://github.com/nodejs/node/pull/5505#ref-commit-3b8fc4f |
|
| https://github.com/billautomata |
| doc: update crypto docs to use good defaults | https://github.com/nodejs/node/commit/3b8fc4fddc9d8121eb6c3cf8d976b64d214f25ee |
| 3b8fc4f | https://github.com/nodejs/node/commit/3b8fc4fddc9d8121eb6c3cf8d976b64d214f25ee |
| https://en.wikipedia.org/wiki/Diffie%E2%80%93Hellman_key_exchange#Cryptographic_explanation | https://en.wikipedia.org/wiki/Diffie%E2%80%93Hellman_key_exchange#Cryptographic_explanation |
| https://en.wikipedia.org/wiki/Safe_prime | https://en.wikipedia.org/wiki/Safe_prime |
| http://tools.ietf.org/html/rfc3526 | http://tools.ietf.org/html/rfc3526 |
| #5505 | https://github.com/nodejs/node/pull/5505 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F5505 |
|
crypto
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto |
| Please reload this page | https://github.com/nodejs/node/pull/5505 |
|
| https://github.com/billautomata |
|
| https://github.com/mscdex |
|
| https://github.com/indutny |
|
| https://github.com/jasnell |
|
| https://github.com/MylesBorins |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |