| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:ef99ac07-809f-4047-81f1-2d397d6a220a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B980:345820:E21F3C:1361CCA:6969F447 |
| html-safe-nonce | c72b64ccc7648f8c0ea317900203446fc01fc8abc19f559513c6f67288a316ff |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOTgwOjM0NTgyMDpFMjFGM0M6MTM2MUNDQTo2OTY5RjQ0NyIsInZpc2l0b3JfaWQiOiI3MDU5MTEwNzU4MDExNDk5NTkxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | dcdc543b08c3a12db3bfa0fc10b644fe3666b106ed462ba4c5ee4cbe5a57e8a6 |
| hovercard-subject-tag | pull_request:61272555 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/5504/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/fdc8fd96f4f9ac881c159629c020ed66f5bdd2cef5118cfff5d9d8eb6e7cdcd8/nodejs/node/pull/5504 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/fdc8fd96f4f9ac881c159629c020ed66f5bdd2cef5118cfff5d9d8eb6e7cdcd8/nodejs/node/pull/5504 |
| og:image:alt | Pull Request check-list
Please make sure to review and check all of these items:
Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
this change (including linting)?
Is the comm... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | indutny |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | bdde15ad1b403e23b08bbd89b53fbe6bdf688cad |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/5504#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F5504 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F5504 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/5504 |
| Reload | https://github.com/nodejs/node/pull/5504 |
| Reload | https://github.com/nodejs/node/pull/5504 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/5504 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
697
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/5504 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/5504#issue-comment-box |
| indutny | https://github.com/indutny |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| indutny:major/remove-binary | https://github.com/indutny/io.js/tree/major/remove-binary |
|
src: remove BINARY encoding
| https://github.com/nodejs/node/pull/5504#top |
| indutny | https://github.com/indutny |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| indutny:major/remove-binary | https://github.com/indutny/io.js/tree/major/remove-binary |
|
Conversation
61
| https://github.com/nodejs/node/pull/5504 |
|
Commits
1
| https://github.com/nodejs/node/pull/5504/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/5504/checks |
|
Files changed
| https://github.com/nodejs/node/pull/5504/files |
| Please reload this page | https://github.com/nodejs/node/pull/5504 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/indutny |
| indutny | https://github.com/indutny |
| Mar 1, 2016 | https://github.com/nodejs/node/pull/5504#issue-137628691 |
| CONTRIBUTING.md | https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#step-3-commit |
| @chrisdickinson | https://github.com/chrisdickinson |
| Please reload this page | https://github.com/nodejs/node/pull/5504 |
|
| https://github.com/indutny |
| src: remove BINARY encoding | https://github.com/nodejs/node/pull/5504/commits/b553cb9beb70991c2587b4fd0967a1abb49cf9f3 |
| b553cb9 | https://github.com/nodejs/node/pull/5504/commits/b553cb9beb70991c2587b4fd0967a1abb49cf9f3 |
| https://github.com/indutny |
| indutny | https://github.com/indutny |
| Mar 1, 2016 | https://github.com/nodejs/node/pull/5504#issuecomment-190808856 |
| https://ci.nodejs.org/job/node-test-pull-request/1789/ | https://ci.nodejs.org/job/node-test-pull-request/1789/ |
| Please reload this page | https://github.com/nodejs/node/pull/5504 |
| https://github.com/indutny |
| indutny | https://github.com/indutny |
|
Mar 1, 2016
| https://github.com/nodejs/node/pull/5504#ref-issue-137422553 |
|
Incorrect HMAC result!
#5499
| https://github.com/nodejs/node/issues/5499 |
| https://github.com/indutny |
| indutny | https://github.com/indutny |
| Mar 1, 2016 | https://github.com/nodejs/node/pull/5504#issuecomment-190809904 |
| Please reload this page | https://github.com/nodejs/node/pull/5504 |
| https://github.com/indutny |
| indutny | https://github.com/indutny |
|
semver-major
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major |
|
tls
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls |
|
crypto
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto |
|
buffer
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer |
|
http
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
net
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anet |
| Mar 1, 2016 | https://github.com/nodejs/node/pull/5504#event-573330074 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Mar 1, 2016 | https://github.com/nodejs/node/pull/5504#issuecomment-190812866 |
| Please reload this page | https://github.com/nodejs/node/pull/5504 |
| https://github.com/indutny |
| indutny | https://github.com/indutny |
| Mar 1, 2016 | https://github.com/nodejs/node/pull/5504#issuecomment-190815407 |
| Please reload this page | https://github.com/nodejs/node/pull/5504 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| Mar 1, 2016 | https://github.com/nodejs/node/pull/5504#issuecomment-190815665 |
| Please reload this page | https://github.com/nodejs/node/pull/5504 |
| https://github.com/indutny |
| indutny | https://github.com/indutny |
| Mar 1, 2016 | https://github.com/nodejs/node/pull/5504#issuecomment-190816594 |
| @mscdex | https://github.com/mscdex |
| Please reload this page | https://github.com/nodejs/node/pull/5504 |
| https://github.com/indutny |
| indutny | https://github.com/indutny |
| Mar 1, 2016 | https://github.com/nodejs/node/pull/5504#issuecomment-190817094 |
| Please reload this page | https://github.com/nodejs/node/pull/5504 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| Mar 1, 2016 | https://github.com/nodejs/node/pull/5504#issuecomment-190817128 |
| @indutny | https://github.com/indutny |
| Please reload this page | https://github.com/nodejs/node/pull/5504 |
| https://github.com/indutny |
| indutny | https://github.com/indutny |
| Mar 1, 2016 | https://github.com/nodejs/node/pull/5504#issuecomment-190817441 |
| @mscdex | https://github.com/mscdex |
| Please reload this page | https://github.com/nodejs/node/pull/5504 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| Mar 1, 2016 | https://github.com/nodejs/node/pull/5504#issuecomment-190817835 |
| @indutny | https://github.com/indutny |
| @mscdex | https://github.com/mscdex |
| Please reload this page | https://github.com/nodejs/node/pull/5504 |
| https://github.com/seishun |
| seishun | https://github.com/seishun |
| Mar 1, 2016 | https://github.com/nodejs/node/pull/5504#issuecomment-190818218 |
| @mscdex | https://github.com/mscdex |
| Please reload this page | https://github.com/nodejs/node/pull/5504 |
| https://github.com/indutny |
| indutny | https://github.com/indutny |
| Mar 1, 2016 | https://github.com/nodejs/node/pull/5504#issuecomment-190818522 |
| @mscdex | https://github.com/mscdex |
| @mscdex | https://github.com/mscdex |
| Please reload this page | https://github.com/nodejs/node/pull/5504 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| Mar 1, 2016 | https://github.com/nodejs/node/pull/5504#issuecomment-190818678 |
| @seishun | https://github.com/seishun |
| Please reload this page | https://github.com/nodejs/node/pull/5504 |
| https://github.com/seishun |
| seishun | https://github.com/seishun |
| Mar 1, 2016 | https://github.com/nodejs/node/pull/5504#issuecomment-190819031 |
| @mscdex | https://github.com/mscdex |
| @indutny | https://github.com/indutny |
| Please reload this page | https://github.com/nodejs/node/pull/5504 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| Mar 1, 2016 | https://github.com/nodejs/node/pull/5504#issuecomment-190820258 |
| @indutny | https://github.com/indutny |
| Please reload this page | https://github.com/nodejs/node/pull/5504 |
| https://github.com/indutny |
| indutny | https://github.com/indutny |
| Mar 1, 2016 | https://github.com/nodejs/node/pull/5504#issuecomment-190829390 |
| Please reload this page | https://github.com/nodejs/node/pull/5504 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| Mar 1, 2016 | https://github.com/nodejs/node/pull/5504#issuecomment-190844313 |
| @indutny | https://github.com/indutny |
| Please reload this page | https://github.com/nodejs/node/pull/5504 |
| https://github.com/indutny |
| indutny | https://github.com/indutny |
| Mar 1, 2016 | https://github.com/nodejs/node/pull/5504#issuecomment-190850732 |
| @mscdex | https://github.com/mscdex |
| Please reload this page | https://github.com/nodejs/node/pull/5504 |
| https://github.com/micnic |
| micnic | https://github.com/micnic |
| Mar 1, 2016 | https://github.com/nodejs/node/pull/5504#issuecomment-190857760 |
| Please reload this page | https://github.com/nodejs/node/pull/5504 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| Mar 1, 2016 | https://github.com/nodejs/node/pull/5504#issuecomment-190866037 |
| @indutny | https://github.com/indutny |
| Please reload this page | https://github.com/nodejs/node/pull/5504 |
| scovetta | https://github.com/scovetta |
|
Apr 2, 2016
| https://github.com/nodejs/node/pull/5504#ref-commit-3c2eb84 |
|
| https://github.com/Trott |
| test: extend timeout in Debug mode | https://github.com/scovetta/node/commit/3c2eb84bcc4b7342bdea972409bb9cc882ffc3a7 |
| 3c2eb84 | https://github.com/scovetta/node/commit/3c2eb84bcc4b7342bdea972409bb9cc882ffc3a7 |
| nodejsGH-5504 | https://github.com/nodejs/node/pull/5504 |
| nodejsGH-5504 | https://github.com/nodejs/node/pull/5504 |
| nodejs#4431 | https://github.com/nodejs/node/pull/4431 |
| https://github.com/vitaliylag |
| vitaliylag | https://github.com/vitaliylag |
| Apr 23, 2016 | https://github.com/nodejs/node/pull/5504#issuecomment-213819664 |
| Please reload this page | https://github.com/nodejs/node/pull/5504 |
| Please reload this page | https://github.com/nodejs/node/pull/5504 |
| https://github.com/trevnorris |
| trevnorris | https://github.com/trevnorris |
| Apr 25, 2016 | https://github.com/nodejs/node/pull/5504#issuecomment-214560226 |
| @vitaliylag | https://github.com/vitaliylag |
| Please reload this page | https://github.com/nodejs/node/pull/5504 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
Jul 3, 2016
| https://github.com/nodejs/node/pull/5504#ref-pullrequest-163556441 |
|
test: listen on and connect to 127.0.0.1
#7524
| https://github.com/nodejs/node/pull/7524 |
| bnoordhuis | https://github.com/bnoordhuis |
|
Jul 4, 2016
| https://github.com/nodejs/node/pull/5504#ref-commit-f47c394 |
|
| https://github.com/bnoordhuis |
| test: listen on and connect to 127.0.0.1 | https://github.com/bnoordhuis/io.js/commit/f47c394d75089dcb6f936fa501f6fe5820e38eab |
| f47c394 | https://github.com/bnoordhuis/io.js/commit/f47c394d75089dcb6f936fa501f6fe5820e38eab |
| nodejs#6611 | https://github.com/nodejs/node/issues/6611 |
| nodejs#7524 | https://github.com/nodejs/node/pull/7524 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Jul 5, 2016
| https://github.com/nodejs/node/pull/5504#ref-commit-c132e9c |
|
| https://github.com/bnoordhuis |
|
| https://github.com/Fishrock123 |
| test: listen on and connect to 127.0.0.1 | https://github.com/nodejs/node/commit/c132e9cc248047a406c80602e7154f95f3beaffa |
| c132e9c | https://github.com/nodejs/node/commit/c132e9cc248047a406c80602e7154f95f3beaffa |
| #6611 | https://github.com/nodejs/node/issues/6611 |
| #7524 | https://github.com/nodejs/node/pull/7524 |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 11, 2016
| https://github.com/nodejs/node/pull/5504#ref-commit-7331fed |
|
| https://github.com/bnoordhuis |
| test: listen on and connect to 127.0.0.1 | https://github.com/nodejs/node/commit/7331feddbc4f8aea3ecc9fda20ecce3a0400a99d |
| 7331fed | https://github.com/nodejs/node/commit/7331feddbc4f8aea3ecc9fda20ecce3a0400a99d |
| #6611 | https://github.com/nodejs/node/issues/6611 |
| #7524 | https://github.com/nodejs/node/pull/7524 |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 12, 2016
| https://github.com/nodejs/node/pull/5504#ref-commit-0e6f4f7 |
|
| https://github.com/bnoordhuis |
|
| https://github.com/MylesBorins |
| test: listen on and connect to 127.0.0.1 | https://github.com/nodejs/node/commit/0e6f4f79e5101f5ff5ef8d078e5cc286d9273c55 |
| 0e6f4f7 | https://github.com/nodejs/node/commit/0e6f4f79e5101f5ff5ef8d078e5cc286d9273c55 |
| #6611 | https://github.com/nodejs/node/issues/6611 |
| #7524 | https://github.com/nodejs/node/pull/7524 |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 12, 2016
| https://github.com/nodejs/node/pull/5504#ref-commit-374862a |
|
| https://github.com/bnoordhuis |
| test: listen on and connect to 127.0.0.1 | https://github.com/nodejs/node/commit/374862a0932af319725cd32c69124188d9e255aa |
| 374862a | https://github.com/nodejs/node/commit/374862a0932af319725cd32c69124188d9e255aa |
| #6611 | https://github.com/nodejs/node/issues/6611 |
| #7524 | https://github.com/nodejs/node/pull/7524 |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 14, 2016
| https://github.com/nodejs/node/pull/5504#ref-commit-cd12cfd |
|
| https://github.com/bnoordhuis |
| test: listen on and connect to 127.0.0.1 | https://github.com/nodejs/node/commit/cd12cfda3ed6cdb040a4d7cb0a0d8041bccd2cd0 |
| cd12cfd | https://github.com/nodejs/node/commit/cd12cfda3ed6cdb040a4d7cb0a0d8041bccd2cd0 |
| #6611 | https://github.com/nodejs/node/issues/6611 |
| #7524 | https://github.com/nodejs/node/pull/7524 |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 14, 2016
| https://github.com/nodejs/node/pull/5504#ref-commit-7d6acef |
|
| https://github.com/bnoordhuis |
| test: listen on and connect to 127.0.0.1 | https://github.com/nodejs/node/commit/7d6acefbcc2829dc6d8b88d4ad3b434002db7802 |
| 7d6acef | https://github.com/nodejs/node/commit/7d6acefbcc2829dc6d8b88d4ad3b434002db7802 |
| #6611 | https://github.com/nodejs/node/issues/6611 |
| #7524 | https://github.com/nodejs/node/pull/7524 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Nov 3, 2016
| https://github.com/nodejs/node/pull/5504#ref-pullrequest-187073599 |
|
test: increase test-net-GH-5504 timeout
#9444
| https://github.com/nodejs/node/pull/9444 |
| Trott | https://github.com/Trott |
|
Nov 4, 2016
| https://github.com/nodejs/node/pull/5504#ref-commit-24af7ca |
|
| https://github.com/Trott |
| test: increate test-net- | https://github.com/Trott/io.js/commit/24af7caf94fc7c8e19c1e7c630acfbae71908c3f |
| nodejsGH-5504 | https://github.com/nodejs/node/pull/5504 |
| timeout | https://github.com/Trott/io.js/commit/24af7caf94fc7c8e19c1e7c630acfbae71908c3f |
| 24af7ca | https://github.com/Trott/io.js/commit/24af7caf94fc7c8e19c1e7c630acfbae71908c3f |
| nodejsGH-5504 | https://github.com/nodejs/node/pull/5504 |
| santigimeno | https://github.com/santigimeno |
|
Nov 6, 2016
| https://github.com/nodejs/node/pull/5504#ref-commit-f8f67d2 |
|
| https://github.com/santigimeno |
| test: fix flaky test-net- | https://github.com/santigimeno/node/commit/f8f67d253eb80ae213f331a3d7c57171053867fd |
| nodejsGH-5504 | https://github.com/nodejs/node/pull/5504 |
| f8f67d2 | https://github.com/santigimeno/node/commit/f8f67d253eb80ae213f331a3d7c57171053867fd |
| nodejs#8930 | https://github.com/nodejs/node/issues/8930 |
| nodejs#9461 | https://github.com/nodejs/node/pull/9461 |
| evanlucas | https://github.com/evanlucas |
|
Nov 7, 2016
| https://github.com/nodejs/node/pull/5504#ref-commit-6eb6816 |
|
| https://github.com/santigimeno |
|
| https://github.com/evanlucas |
| test: fix flaky test-net- | https://github.com/nodejs/node/commit/6eb6816e22f3863bb12563f2b507a40529793db5 |
| GH-5504 | https://github.com/nodejs/node/pull/5504 |
| 6eb6816 | https://github.com/nodejs/node/commit/6eb6816e22f3863bb12563f2b507a40529793db5 |
| #8930 | https://github.com/nodejs/node/issues/8930 |
| #9461 | https://github.com/nodejs/node/pull/9461 |
| https://github.com/evanlucas |
| evanlucas | https://github.com/evanlucas |
|
Nov 7, 2016
| https://github.com/nodejs/node/pull/5504#ref-pullrequest-187029471 |
|
v7.1.0 proposal - 2016-11-08
#9438
| https://github.com/nodejs/node/pull/9438 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 22, 2016
| https://github.com/nodejs/node/pull/5504#ref-commit-093d677 |
|
| https://github.com/santigimeno |
| test: fix flaky test-net- | https://github.com/nodejs/node/commit/093d67725288001a8f8afde30e3aa1ece0c09142 |
| GH-5504 | https://github.com/nodejs/node/pull/5504 |
| 093d677 | https://github.com/nodejs/node/commit/093d67725288001a8f8afde30e3aa1ece0c09142 |
| #8930 | https://github.com/nodejs/node/issues/8930 |
| #9461 | https://github.com/nodejs/node/pull/9461 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 22, 2016
| https://github.com/nodejs/node/pull/5504#ref-pullrequest-190942302 |
|
v6.9.2 proposal
#9735
| https://github.com/nodejs/node/pull/9735 |
| Trott | https://github.com/Trott |
|
May 14, 2017
| https://github.com/nodejs/node/pull/5504#ref-commit-4a3550c |
|
| https://github.com/Trott |
| test: refactor test-net- | https://github.com/Trott/io.js/commit/4a3550c1d3676dc6b783199ec677bae4052a2338 |
| nodejsGH-5504 | https://github.com/nodejs/node/pull/5504 |
| 4a3550c | https://github.com/Trott/io.js/commit/4a3550c1d3676dc6b783199ec677bae4052a2338 |
| Trott | https://github.com/Trott |
|
May 20, 2017
| https://github.com/nodejs/node/pull/5504#ref-commit-5254975 |
|
| https://github.com/Trott |
| test: refactor test-net- | https://github.com/Trott/io.js/commit/525497596a51ef2e6653b930ca525046d27c9fd5 |
| nodejsGH-5504 | https://github.com/nodejs/node/pull/5504 |
| 5254975 | https://github.com/Trott/io.js/commit/525497596a51ef2e6653b930ca525046d27c9fd5 |
| nodejs#13025 | https://github.com/nodejs/node/pull/13025 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
May 28, 2017
| https://github.com/nodejs/node/pull/5504#ref-pullrequest-219383958 |
|
8.0.0 Release Proposal
#12220
| https://github.com/nodejs/node/pull/12220 |
| https://github.com/billinghamj |
| billinghamj | https://github.com/billinghamj |
|
Feb 10, 2018
| https://github.com/nodejs/node/pull/5504#ref-issue-296112494 |
|
Shouldn't this be using Buffer.byteLength?
Bruce17/safe-compare#6
| https://github.com/Bruce17/safe-compare/issues/6 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Oct 21, 2018
| https://github.com/nodejs/node/pull/5504#ref-issue-371744276 |
|
Inspect flaky test-net-bytes-per-incoming-chunk-overhead
#23740
| https://github.com/nodejs/node/issues/23740 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F5504 |
|
buffer
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuffer |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
crypto
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
http
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp |
|
net
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anet |
|
semver-major
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major |
|
tls
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls |
| Please reload this page | https://github.com/nodejs/node/pull/5504 |
|
| https://github.com/indutny |
|
| https://github.com/Fishrock123 |
|
| https://github.com/mscdex |
|
| https://github.com/seishun |
|
| https://github.com/micnic |
|
| https://github.com/vkurchatkin |
|
| https://github.com/trevnorris |
|
| https://github.com/domenic |
|
| https://github.com/ChALkeR |
|
| https://github.com/bnoordhuis |
|
| https://github.com/jasnell |
|
| https://github.com/vitaliylag |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |