| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:23000ecb-0c3a-88c0-24bd-4b91c97cb4d0 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B54A:95B65:DF1A78:130B8EF:6969F441 |
| html-safe-nonce | 2941efcb26442125cae993d3cba4da23ce3772548f64d8fde3152d8558947800 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNTRBOjk1QjY1OkRGMUE3ODoxMzBCOEVGOjY5NjlGNDQxIiwidmlzaXRvcl9pZCI6IjMyNzI4NzkzNTMyMjA0Mjg4NjUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 36a008a12e9d19556910117b4f9d4606d671cfab87fcc88d1e1ce9475e4def09 |
| hovercard-subject-tag | pull_request:2081551360 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/55015/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/b3f72458134a178b3853eac6482f26da38c9c1667d207a3a530bf54a2c678e41/nodejs/node/pull/55015 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b3f72458134a178b3853eac6482f26da38c9c1667d207a3a530bf54a2c678e41/nodejs/node/pull/55015 |
| og:image:alt | Reverts #53063. There are still some filesystem::path references left, since they're added in multiple different PRs. Depending on whether we need them or not, we can remove them.
We're rev... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | anonrig |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | bdde15ad1b403e23b08bbd89b53fbe6bdf688cad |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/55015#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F55015 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F55015 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/55015 |
| Reload | https://github.com/nodejs/node/pull/55015 |
| Reload | https://github.com/nodejs/node/pull/55015 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/55015 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
697
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/55015 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/55015#issue-comment-box |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| anonrig:revert-filesystem-path | https://github.com/anonrig/node/tree/revert-filesystem-path |
|
src: revert filesystem::path changes
| https://github.com/nodejs/node/pull/55015#top |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| nodejs:main | https://github.com/nodejs/node/tree/main |
| anonrig:revert-filesystem-path | https://github.com/anonrig/node/tree/revert-filesystem-path |
|
Conversation
12
| https://github.com/nodejs/node/pull/55015 |
|
Commits
1
| https://github.com/nodejs/node/pull/55015/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/55015/checks |
|
Files changed
| https://github.com/nodejs/node/pull/55015/files |
| Please reload this page | https://github.com/nodejs/node/pull/55015 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
| Sep 19, 2024 | https://github.com/nodejs/node/pull/55015#issue-2536945398 |
| #53063 | https://github.com/nodejs/node/pull/53063 |
| #54991 | https://github.com/nodejs/node/issues/54991 |
| #54476 | https://github.com/nodejs/node/issues/54476 |
| Please reload this page | https://github.com/nodejs/node/pull/55015 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
| joyeecheung | https://github.com/joyeecheung |
| richardlau | https://github.com/richardlau |
| September 19, 2024 17:12 | https://github.com/nodejs/node/pull/55015#event-14327939740 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 19, 2024 | https://github.com/nodejs/node/pull/55015#issuecomment-2361732504 |
| Please reload this page | https://github.com/nodejs/node/pull/55015 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
| Sep 19, 2024 | https://github.com/nodejs/node/pull/55015#event-14327941900 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
| force-pushed | https://github.com/nodejs/node/compare/eea22f79019ae5413067b05d9f77d614d9d7c058..37bd2dcf061659f04a5a558cd75b154cfccbc5b4 |
| eea22f7 | https://github.com/nodejs/node/commit/eea22f79019ae5413067b05d9f77d614d9d7c058 |
| 37bd2dc | https://github.com/nodejs/node/commit/37bd2dcf061659f04a5a558cd75b154cfccbc5b4 |
|
Compare
| https://github.com/nodejs/node/compare/eea22f79019ae5413067b05d9f77d614d9d7c058..37bd2dcf061659f04a5a558cd75b154cfccbc5b4 |
| September 19, 2024 17:17 | https://github.com/nodejs/node/pull/55015#event-14328020347 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
|
Sep 19, 2024
| https://github.com/nodejs/node/pull/55015#pullrequestreview-2316280837 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/55015/files |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
| force-pushed | https://github.com/nodejs/node/compare/be2b0b85ecd15124ec637e577f6b5956d84d50d7..b0e83d9bf48c3b7bafac6d6401a3bb22865fc088 |
| be2b0b8 | https://github.com/nodejs/node/commit/be2b0b85ecd15124ec637e577f6b5956d84d50d7 |
| b0e83d9 | https://github.com/nodejs/node/commit/b0e83d9bf48c3b7bafac6d6401a3bb22865fc088 |
|
Compare
| https://github.com/nodejs/node/compare/be2b0b85ecd15124ec637e577f6b5956d84d50d7..b0e83d9bf48c3b7bafac6d6401a3bb22865fc088 |
| September 19, 2024 17:21 | https://github.com/nodejs/node/pull/55015#event-14328088493 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
| Sep 19, 2024 | https://github.com/nodejs/node/pull/55015#issuecomment-2361777632 |
| @joyeecheung | https://github.com/joyeecheung |
| Please reload this page | https://github.com/nodejs/node/pull/55015 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
|
Sep 19, 2024
| https://github.com/nodejs/node/pull/55015#pullrequestreview-2316289725 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/55015/files |
| src/permission/fs_permission.cc | https://github.com/nodejs/node/pull/55015/files#diff-16e5137c62185f95ea21a79e2558004ded41ddbd1f9b5f7b78c9f9aa7ec86b47 |
| anonrig | https://github.com/anonrig |
| Sep 19, 2024 | https://github.com/nodejs/node/pull/55015#discussion_r1767318266 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @joyeecheung | https://github.com/joyeecheung |
| Please reload this page | https://github.com/nodejs/node/pull/55015 |
| joyeecheung | https://github.com/joyeecheung |
| Sep 20, 2024 | https://github.com/nodejs/node/pull/55015#discussion_r1768256928 |
| Please reload this page | https://github.com/nodejs/node/pull/55015 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/55015 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
| force-pushed | https://github.com/nodejs/node/compare/b0e83d9bf48c3b7bafac6d6401a3bb22865fc088..67ddaa9abd974172c91f880515c9a244f3ec4626 |
| b0e83d9 | https://github.com/nodejs/node/commit/b0e83d9bf48c3b7bafac6d6401a3bb22865fc088 |
| 67ddaa9 | https://github.com/nodejs/node/commit/67ddaa9abd974172c91f880515c9a244f3ec4626 |
|
Compare
| https://github.com/nodejs/node/compare/b0e83d9bf48c3b7bafac6d6401a3bb22865fc088..67ddaa9abd974172c91f880515c9a244f3ec4626 |
| September 19, 2024 17:23 | https://github.com/nodejs/node/pull/55015#event-14328110454 |
| https://github.com/avivkeller |
| avivkeller | https://github.com/avivkeller |
|
fs
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs |
|
revert
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arevert |
| Sep 19, 2024 | https://github.com/nodejs/node/pull/55015#event-14328190020 |
| https://github.com/avivkeller |
| avivkeller | https://github.com/avivkeller |
| Sep 19, 2024 | https://github.com/nodejs/node/pull/55015#issuecomment-2361793763 |
| Please reload this page | https://github.com/nodejs/node/pull/55015 |
|
| https://github.com/anonrig |
| src: revert filesystem::path changes | https://github.com/nodejs/node/pull/55015/commits/ba26f0b80fea4ef70b752576a4718138295d6221 |
| ba26f0b | https://github.com/nodejs/node/pull/55015/commits/ba26f0b80fea4ef70b752576a4718138295d6221 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
| force-pushed | https://github.com/nodejs/node/compare/67ddaa9abd974172c91f880515c9a244f3ec4626..ba26f0b80fea4ef70b752576a4718138295d6221 |
| 67ddaa9 | https://github.com/nodejs/node/commit/67ddaa9abd974172c91f880515c9a244f3ec4626 |
| ba26f0b | https://github.com/nodejs/node/commit/ba26f0b80fea4ef70b752576a4718138295d6221 |
|
Compare
| https://github.com/nodejs/node/compare/67ddaa9abd974172c91f880515c9a244f3ec4626..ba26f0b80fea4ef70b752576a4718138295d6221 |
| September 19, 2024 17:36 | https://github.com/nodejs/node/pull/55015#event-14328251984 |
| https://github.com/apps/codecov |
| codecov | https://github.com/apps/codecov |
| Sep 19, 2024 | https://github.com/nodejs/node/pull/55015#issuecomment-2361954622 |
| Please reload this page | https://github.com/nodejs/node/pull/55015 |
| Codecov | https://app.codecov.io/gh/nodejs/node/pull/55015?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| (291d90a) | https://app.codecov.io/gh/nodejs/node/commit/291d90acbc746d39d2cece18715ce428c4eb6858?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| (ba26f0b) | https://app.codecov.io/gh/nodejs/node/commit/ba26f0b80fea4ef70b752576a4718138295d6221?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| Files with missing lines | https://app.codecov.io/gh/nodejs/node/pull/55015?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| src/env.cc | https://app.codecov.io/gh/nodejs/node/pull/55015?src=pr&el=tree&filepath=src%2Fenv.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL2Vudi5jYw== |
| 1 Missing ⚠️ | https://app.codecov.io/gh/nodejs/node/pull/55015?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| src/node_modules.cc | https://app.codecov.io/gh/nodejs/node/pull/55015?src=pr&el=tree&filepath=src%2Fnode_modules.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfbW9kdWxlcy5jYw== |
| 1 Missing ⚠️ | https://app.codecov.io/gh/nodejs/node/pull/55015?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| Files with missing lines | https://app.codecov.io/gh/nodejs/node/pull/55015?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| src/compile_cache.cc | https://app.codecov.io/gh/nodejs/node/pull/55015?src=pr&el=tree&filepath=src%2Fcompile_cache.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL2NvbXBpbGVfY2FjaGUuY2M= |
| src/compile_cache.h | https://app.codecov.io/gh/nodejs/node/pull/55015?src=pr&el=tree&filepath=src%2Fcompile_cache.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL2NvbXBpbGVfY2FjaGUuaA== |
| src/inspector_profiler.cc | https://app.codecov.io/gh/nodejs/node/pull/55015?src=pr&el=tree&filepath=src%2Finspector_profiler.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL2luc3BlY3Rvcl9wcm9maWxlci5jYw== |
| src/node_file.cc | https://app.codecov.io/gh/nodejs/node/pull/55015?src=pr&el=tree&filepath=src%2Fnode_file.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfZmlsZS5jYw== |
| src/node_report.cc | https://app.codecov.io/gh/nodejs/node/pull/55015?src=pr&el=tree&filepath=src%2Fnode_report.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL25vZGVfcmVwb3J0LmNj |
| src/path.cc | https://app.codecov.io/gh/nodejs/node/pull/55015?src=pr&el=tree&filepath=src%2Fpath.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL3BhdGguY2M= |
| src/permission/fs_permission.cc | https://app.codecov.io/gh/nodejs/node/pull/55015?src=pr&el=tree&filepath=src%2Fpermission%2Ffs_permission.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL3Blcm1pc3Npb24vZnNfcGVybWlzc2lvbi5jYw== |
| src/permission/fs_permission.h | https://app.codecov.io/gh/nodejs/node/pull/55015?src=pr&el=tree&filepath=src%2Fpermission%2Ffs_permission.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL3Blcm1pc3Npb24vZnNfcGVybWlzc2lvbi5o |
| src/util.h | https://app.codecov.io/gh/nodejs/node/pull/55015?src=pr&el=tree&filepath=src%2Futil.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL3V0aWwuaA== |
| src/env.cc | https://app.codecov.io/gh/nodejs/node/pull/55015?src=pr&el=tree&filepath=src%2Fenv.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-c3JjL2Vudi5jYw== |
| 1 more | https://app.codecov.io/gh/nodejs/node/pull/55015?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| 29 files with indirect coverage changes | https://app.codecov.io/gh/nodejs/node/pull/55015/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs |
| Please reload this page | https://github.com/nodejs/node/pull/55015 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 19, 2024 | https://github.com/nodejs/node/pull/55015#issuecomment-2361965420 |
| https://ci.nodejs.org/job/node-test-pull-request/62569/ | https://ci.nodejs.org/job/node-test-pull-request/62569/ |
| Please reload this page | https://github.com/nodejs/node/pull/55015 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 20, 2024 | https://github.com/nodejs/node/pull/55015#issuecomment-2362535228 |
| https://ci.nodejs.org/job/node-test-pull-request/62582/ | https://ci.nodejs.org/job/node-test-pull-request/62582/ |
| Please reload this page | https://github.com/nodejs/node/pull/55015 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Sep 20, 2024
| https://github.com/nodejs/node/pull/55015#pullrequestreview-2317687726 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/55015/files/ba26f0b80fea4ef70b752576a4718138295d6221 |
| joyeecheung | https://github.com/joyeecheung |
| https://github.com/nodejs/node/pull/55015#pullrequestreview-2317687726 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/55015 |
| src/compile_cache.cc | https://github.com/nodejs/node/pull/55015/files/ba26f0b80fea4ef70b752576a4718138295d6221#diff-774bfbe806c939d2ad318fe5ebbdaf1a7c05ebfa38f240771fd81e0d937bd73f |
| joyeecheung | https://github.com/joyeecheung |
| Sep 20, 2024 | https://github.com/nodejs/node/pull/55015#discussion_r1768250980 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/55015 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
| Sep 20, 2024 | https://github.com/nodejs/node/pull/55015#issuecomment-2363239756 |
| Please reload this page | https://github.com/nodejs/node/pull/55015 |
| #54476 | https://github.com/nodejs/node/issues/54476 |
| #53614 | https://github.com/nodejs/node/pull/53614 |
| #54653 | https://github.com/nodejs/node/pull/54653 |
| Please reload this page | https://github.com/nodejs/node/pull/55015 |
| https://github.com/anonrig |
| anonrig | https://github.com/anonrig |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Sep 21, 2024 | https://github.com/nodejs/node/pull/55015#event-14349979988 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Sep 21, 2024 | https://github.com/nodejs/node/pull/55015#event-14350135902 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| 5a96671 | https://github.com/nodejs/node/commit/5a966714c1b78069f1b6e871ae1f7fb73ed25794 |
| Sep 21, 2024 | https://github.com/nodejs/node/pull/55015#event-14350136008 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 21, 2024 | https://github.com/nodejs/node/pull/55015#issuecomment-2365259753 |
| 5a96671 | https://github.com/nodejs/node/commit/5a966714c1b78069f1b6e871ae1f7fb73ed25794 |
| Please reload this page | https://github.com/nodejs/node/pull/55015 |
| targos | https://github.com/targos |
|
Oct 4, 2024
| https://github.com/nodejs/node/pull/55015#ref-commit-9ae80e1 |
|
| https://github.com/anonrig |
|
| https://github.com/targos |
| src: revert filesystem::path changes | https://github.com/nodejs/node/commit/9ae80e1e4d9e7fdc33217e7316dd519b4adce05b |
| 9ae80e1 | https://github.com/nodejs/node/commit/9ae80e1e4d9e7fdc33217e7316dd519b4adce05b |
| #55015 | https://github.com/nodejs/node/pull/55015 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Oct 9, 2024
| https://github.com/nodejs/node/pull/55015#ref-pullrequest-2577076550 |
|
V22.10.0 proposal
#55343
| https://github.com/nodejs/node/pull/55343 |
| louwers | https://github.com/louwers |
|
Nov 2, 2024
| https://github.com/nodejs/node/pull/55015#ref-commit-733eec9 |
|
| https://github.com/anonrig |
|
| https://github.com/louwers |
| src: revert filesystem::path changes | https://github.com/louwers/node/commit/733eec9075811ae8c8085f46dcadd9d27aaaf2f7 |
| 733eec9 | https://github.com/louwers/node/commit/733eec9075811ae8c8085f46dcadd9d27aaaf2f7 |
| nodejs#55015 | https://github.com/nodejs/node/pull/55015 |
| https://github.com/marco-ippolito |
| marco-ippolito | https://github.com/marco-ippolito |
|
dont-land-on-v20.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v20.x |
| Nov 16, 2024 | https://github.com/nodejs/node/pull/55015#event-15321010493 |
| tpoisseau | https://github.com/tpoisseau |
|
Nov 21, 2024
| https://github.com/nodejs/node/pull/55015#ref-commit-0200cd7 |
|
| https://github.com/anonrig |
|
| https://github.com/tpoisseau |
| src: revert filesystem::path changes | https://github.com/tpoisseau/node/commit/0200cd7b51058da4b11e0f79c2ec67f837ad28e7 |
| 0200cd7 | https://github.com/tpoisseau/node/commit/0200cd7b51058da4b11e0f79c2ec67f837ad28e7 |
| nodejs#55015 | https://github.com/nodejs/node/pull/55015 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Nov 29, 2024
| https://github.com/nodejs/node/pull/55015#ref-issue-2701300828 |
|
fs.rmSync('速') crash without throw
#56049
| https://github.com/nodejs/node/issues/56049 |
| codebytere | https://github.com/codebytere |
|
Jan 22, 2025
| https://github.com/nodejs/node/pull/55015#ref-commit-c7552ad |
|
| https://github.com/codebytere |
| src: revert filesystem::path changes | https://github.com/electron/electron/commit/c7552adc5092f506d4e782c85eda28f4b11e73d9 |
| c7552ad | https://github.com/electron/electron/commit/c7552adc5092f506d4e782c85eda28f4b11e73d9 |
| nodejs/node#55015 | https://github.com/nodejs/node/pull/55015 |
| samuelmaddock | https://github.com/samuelmaddock |
|
Jan 22, 2025
| https://github.com/nodejs/node/pull/55015#ref-commit-863faea |
|
| https://github.com/apps/electron-roller |
|
| https://github.com/codebytere |
| chore: bump node to v22.11.0 (main) ( | https://github.com/electron/electron/commit/863faea542e82d18e1ec475fec04c32afa2b4f95 |
| #44530 | https://github.com/electron/electron/pull/44530 |
| ) | https://github.com/electron/electron/commit/863faea542e82d18e1ec475fec04c32afa2b4f95 |
| 863faea | https://github.com/electron/electron/commit/863faea542e82d18e1ec475fec04c32afa2b4f95 |
| nodejs/node#54911 | https://github.com/nodejs/node/pull/54911 |
| nodejs/node#54159 | https://github.com/nodejs/node/pull/54159 |
| nodejs/node#54461 | https://github.com/nodejs/node/pull/54461 |
| nodejs/node#55003 | https://github.com/nodejs/node/pull/55003 |
| nodejs/node#55155 | https://github.com/nodejs/node/pull/55155 |
| nodejs/node#54159 | https://github.com/nodejs/node/pull/54159 |
| nodejs/node#54408 | https://github.com/nodejs/node/pull/54408 |
| nodejs/node#55121 | https://github.com/nodejs/node/pull/55121 |
| nodejs/node#55015 | https://github.com/nodejs/node/pull/55015 |
| soobinrho | https://github.com/soobinrho |
|
Jan 22, 2025
| https://github.com/nodejs/node/pull/55015#ref-commit-8c4d83f |
|
| https://github.com/apps/electron-roller |
|
| https://github.com/codebytere |
|
| https://github.com/soobinrho |
| chore: bump node to v22.11.0 (main) ( | https://github.com/soobinrho/electron/commit/8c4d83f762881168ebb7570ab5470fe3b26a3d10 |
| electron#44530 | https://github.com/electron/electron/pull/44530 |
| ) | https://github.com/soobinrho/electron/commit/8c4d83f762881168ebb7570ab5470fe3b26a3d10 |
| 8c4d83f | https://github.com/soobinrho/electron/commit/8c4d83f762881168ebb7570ab5470fe3b26a3d10 |
| nodejs/node#54911 | https://github.com/nodejs/node/pull/54911 |
| nodejs/node#54159 | https://github.com/nodejs/node/pull/54159 |
| nodejs/node#54461 | https://github.com/nodejs/node/pull/54461 |
| nodejs/node#55003 | https://github.com/nodejs/node/pull/55003 |
| nodejs/node#55155 | https://github.com/nodejs/node/pull/55155 |
| nodejs/node#54159 | https://github.com/nodejs/node/pull/54159 |
| nodejs/node#54408 | https://github.com/nodejs/node/pull/54408 |
| nodejs/node#55121 | https://github.com/nodejs/node/pull/55121 |
| nodejs/node#55015 | https://github.com/nodejs/node/pull/55015 |
| codebytere | https://github.com/codebytere |
|
Feb 3, 2025
| https://github.com/nodejs/node/pull/55015#ref-commit-eb130b0 |
|
| https://github.com/codebytere |
| src: revert filesystem::path changes | https://github.com/electron/electron/commit/eb130b0f37fe28f0a8b9bce998452dc085ceb3ef |
| eb130b0 | https://github.com/electron/electron/commit/eb130b0f37fe28f0a8b9bce998452dc085ceb3ef |
| nodejs/node#55015 | https://github.com/nodejs/node/pull/55015 |
| codebytere | https://github.com/codebytere |
|
Feb 10, 2025
| https://github.com/nodejs/node/pull/55015#ref-commit-c178633 |
|
| https://github.com/codebytere |
| src: revert filesystem::path changes | https://github.com/electron/electron/commit/c1786333664a626fe56759597831c351631d50d1 |
| c178633 | https://github.com/electron/electron/commit/c1786333664a626fe56759597831c351631d50d1 |
| nodejs/node#55015 | https://github.com/nodejs/node/pull/55015 |
| codebytere | https://github.com/codebytere |
|
Feb 10, 2025
| https://github.com/nodejs/node/pull/55015#ref-commit-2aceefd |
|
| https://github.com/codebytere |
| src: revert filesystem::path changes | https://github.com/electron/electron/commit/2aceefd3a88fd9317d311b56b0f784e19d975b5f |
| 2aceefd | https://github.com/electron/electron/commit/2aceefd3a88fd9317d311b56b0f784e19d975b5f |
| nodejs/node#55015 | https://github.com/nodejs/node/pull/55015 |
| codebytere | https://github.com/codebytere |
|
Feb 14, 2025
| https://github.com/nodejs/node/pull/55015#ref-commit-9c2550b |
|
| https://github.com/codebytere |
| src: revert filesystem::path changes | https://github.com/electron/electron/commit/9c2550bcdbf8ad9d5ae75b1687b925a9eb8ba809 |
| 9c2550b | https://github.com/electron/electron/commit/9c2550bcdbf8ad9d5ae75b1687b925a9eb8ba809 |
| nodejs/node#55015 | https://github.com/nodejs/node/pull/55015 |
| codebytere | https://github.com/codebytere |
|
Feb 14, 2025
| https://github.com/nodejs/node/pull/55015#ref-commit-bc163a5 |
|
| https://github.com/apps/electron-roller |
|
| https://github.com/codebytere |
| chore: bump node to v22.13.1 (35-x-y) ( | https://github.com/electron/electron/commit/bc163a5ea892b0982b319966c3e79430f3d39a2c |
| #45216 | https://github.com/electron/electron/pull/45216 |
| ) | https://github.com/electron/electron/commit/bc163a5ea892b0982b319966c3e79430f3d39a2c |
| bc163a5 | https://github.com/electron/electron/commit/bc163a5ea892b0982b319966c3e79430f3d39a2c |
| nodejs/node#54911 | https://github.com/nodejs/node/pull/54911 |
| nodejs/node#54159 | https://github.com/nodejs/node/pull/54159 |
| nodejs/node#54461 | https://github.com/nodejs/node/pull/54461 |
| nodejs/node#55003 | https://github.com/nodejs/node/pull/55003 |
| nodejs/node#55155 | https://github.com/nodejs/node/pull/55155 |
| nodejs/node#54159 | https://github.com/nodejs/node/pull/54159 |
| nodejs/node#54408 | https://github.com/nodejs/node/pull/54408 |
| nodejs/node#55121 | https://github.com/nodejs/node/pull/55121 |
| nodejs/node#55015 | https://github.com/nodejs/node/pull/55015 |
| nodejs/node#55529 | https://github.com/nodejs/node/pull/55529 |
| nodejs/node#55798 | https://github.com/nodejs/node/pull/55798 |
| nodejs/node#55530 | https://github.com/nodejs/node/pull/55530 |
| nodejs/node#55679 | https://github.com/nodejs/node/pull/55679 |
| nodejs/node#56133 | https://github.com/nodejs/node/pull/56133 |
| nodejs/node#55425 | https://github.com/nodejs/node/pull/55425 |
| nodejs/node#55928 | https://github.com/nodejs/node/pull/55928 |
| nodejs/node#55629 | https://github.com/nodejs/node/pull/55629 |
| nodejs/node#56196 | https://github.com/nodejs/node/pull/56196 |
| nodejs/node#55491 | https://github.com/nodejs/node/pull/55491 |
| libuv/libuv#4486 | https://github.com/libuv/libuv/pull/4486 |
| nodejs/node#55114 | https://github.com/nodejs/node/pull/55114 |
| nodejs/node#55401 | https://github.com/nodejs/node/pull/55401 |
| nodejs/node#54384 | https://github.com/nodejs/node/pull/54384 |
| c-ares/c-ares#869 | https://github.com/c-ares/c-ares/pull/869 |
| nodejs/node#55559 | https://github.com/nodejs/node/pull/55559 |
| nodejs/node#55591 | https://github.com/nodejs/node/pull/55591 |
| nodejs/node#56196 | https://github.com/nodejs/node/pull/56196 |
| nodejs/node#56041 | https://github.com/nodejs/node/pull/56041 |
| nodejs/node#55714 | https://github.com/nodejs/node/pull/55714 |
| nodejs/node#55114 | https://github.com/nodejs/node/pull/55114 |
| https://github.com/YEONDG |
| YEONDG | https://github.com/YEONDG |
|
Jul 25, 2025
| https://github.com/nodejs/node/pull/55015#ref-issue-3262562599 |
|
Node.js fails to run when folder path contains Korean characters
#59208
| https://github.com/nodejs/node/issues/59208 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F55015 |
|
| https://github.com/joyeecheung |
|
joyeecheung
| https://github.com/joyeecheung |
|
| https://github.com/nodejs/node/pull/55015/files/ba26f0b80fea4ef70b752576a4718138295d6221 |
|
| https://github.com/benjamingr |
|
benjamingr
| https://github.com/benjamingr |
|
| https://github.com/nodejs/node/pull/55015/files/37bd2dcf061659f04a5a558cd75b154cfccbc5b4 |
|
| https://github.com/richardlau |
|
richardlau
| https://github.com/richardlau |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
dont-land-on-v20.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v20.x |
|
fs
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
|
needs-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aneeds-ci |
|
revert
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arevert |
|
v22.3.0 Cannot start if the Folder or Script File Name is Unicode.
| https://github.com/nodejs/node/issues/54991 |
|
v22.6.0 fs.cpSync crash
| https://github.com/nodejs/node/issues/54476 |
| Please reload this page | https://github.com/nodejs/node/pull/55015 |
|
| https://github.com/anonrig |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/avivkeller |
|
| https://github.com/joyeecheung |
|
| https://github.com/benjamingr |
|
| https://github.com/marco-ippolito |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |